Mercury Li
be2f1e9812
Fix compilation warnings: upgrade kotlinx-datetime 0.7.1, migrate deprecated APIs
...
- Upgrade kotlinx-datetime 0.6.1 → 0.7.1 and migrate to kotlin.time.Instant/Clock
- Migrate TabRow → SecondaryTabRow with TabIndicatorScope API
- Fix LocalDateTime constructors (monthNumber → month, dayOfMonth → day)
- Remove deprecated KoinAndroidContext wrapper, add KOIN_DEFAULT_MODULE KSP arg
- Convert SystemTrayNotifier expression body with return to block body
- Add @param: annotation target prefix for @Dispatcher and @ApplicationScope
- Add @ConsistentCopyVisibility to UserNewsResource data class
- Fix JVM compilation: use correct uiToolingPreview dep, move lifecycle-runtime-compose to commonMain
3 weeks ago
Mercury Li
e31481fd0b
Merge upstream android/nowinandroid pre-Navigation3 changes (up to d438a007)
3 weeks ago
Simon Marquis
17162dab60
graphUpdate
6 months ago
Simon Marquis
1c61be7b7b
Update color mapping
...
| Type | Plugin ID | Color |
|-------------|------------------------------------|------------------------|
| Application | `nowinandroid.android.application` | `#CAFFBF` PastelGreen |
| Feature | `nowinandroid.android.feature` | `#FFD6A5` PastelOrange |
| Library | `nowinandroid.android.library` | `#9BF6FF` PastelBlue |
| Test | `nowinandroid.android.test` | `#A0C4FF` PastelMauve |
| JVM | `nowinandroid.jvm.library` | `#BDB2FF` PastelPurple |
| Unknown | `?` | `#FFADAD` PastelRed |
6 months ago
Simon Marquis
e8dc43b58b
graphUpdate
6 months ago
Simon Marquis
e079e68815
Delete old graphs
6 months ago
lihenggui
0c691b9676
Merge remote-tracking branch 'upstream/main'
1 year ago
lihenggui
44c4566028
Remove unused dependencies and conventions
1 year ago
lihenggui
be3f330f24
Remove annotations in TopicViewModel
1 year ago
lihenggui
78915028d3
Use koin in testing module
1 year ago
lihenggui
08e237d001
Update dependencies
2 years ago
lihenggui
32918f929b
Merge remote-tracking branch 'upstream/main'
2 years ago
Simon Marquis
d56e06e676
Merge Android & JVM plugins into a single `HiltConventionPlugin`
2 years ago
lihenggui
a383a5f35a
Merge remote-tracking branch 'upstream/main' into compose_multiplatform
2 years ago
Simon Marquis
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
2 years ago
Alex Vanyo
78c77737c0
Merge pull request #1275 from Jaehwa-Noh/rename-function
...
Rename function to setNewsResourceBookmarked
2 years ago
Don Turner
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
2 years ago
lihenggui
277bfb744d
Import correct dependencies for data and testing module
2 years ago
lihenggui
94b14e7279
spotlessApply
2 years ago
lihenggui
1aa6375d26
Fix compilation errors in tests in the designsystem module
2 years ago
Jaehwa Noh
ee4320723f
Fix typo.
...
Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f
2 years ago
Jaehwa Noh
ed91723e2f
Fix #1270
...
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
2 years ago
lihenggui
0dce05406c
WIP: Make :core:designsystem as the multiplatform module
2 years ago
lihenggui
6c89a82e30
Merge branch 'main' of https://github.com/android/nowinandroid into compose_multiplatform
2 years ago
Don Turner
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
2 years ago
Alex Vanyo
e3c7018124
Extract ScreenshotHelper to separate testing module
...
Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af
2 years ago
Tomáš Mlynarič
f31fdb3ec2
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Id49a580012629163ec4a3663d95ab71b98910220
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
# gradle/libs.versions.toml
2 years ago
lihenggui
2f412db367
Use object to provide implementations
2 years ago
lihenggui
460060389e
Merge remote-tracking branch 'upstream/main' into compose_multiplatform
2 years ago
lihenggui
c5521ce89b
Make :core:common as a multiplatform library
2 years ago
Tomáš Mlynarič
ea1573fcc1
Use kotlinx.datetime.Timezone instead of java ZoneId
...
Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628
2 years ago
Simon Marquis
b687328567
Replace comments with proper `@TestOnly` annotations
2 years ago
Simon Marquis
a83f6691c4
Fix addNewsResources issue
2 years ago
Simon Marquis
5a1258232f
Fix `emptyResultIsReturned_withNotMatchingQuery` unit test
...
`searchResultUiState` transitively relied on `getSearchContentsCount` updates and on `userDataRepository` to emit something.
2 years ago
Tomáš Mlynarič
0b3ece1bb9
Fix spotless
...
Change-Id: I6583fa9ed7c1563f6164653be9bbaf7904ec0215
2 years ago
Tomáš Mlynarič
cb00d2c8cb
Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers
...
This way, we can save ~1ms per composed item on screen.
Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d
2 years ago
Don Turner
707117a4f2
Merge branch 'main' into kotlinify
2 years ago
Don Turner
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
2 years ago
Simon Marquis
be9dc533e3
Replace `Enum.values()` with `Enum.entries`
...
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
2 years ago
Don Turner
9d41ffa318
Merge branch 'main' into kotlinify
2 years ago
lihenggui
f8f932705a
Remove violations: discouraged-comment-location
2 years ago
lihenggui
fb5bd225be
Spotless
2 years ago
Simon Marquis
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
2 years ago
Simon Marquis
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
2 years ago
Mario Manhique
b2c1c11218
Update MainDispatcherRule.kt
...
Updated MainDispatcherRule parameter accessibility to private because its only needs to be accessible inside that class.
2 years ago
Don Turner
a381d13199
Merge pull request #958 from McGalanes/main
...
Use typesafe project accessors
2 years ago
Melwin Magalhaes
6247712064
Add convention plugins to version catalogs
2 years ago
Melwin Magalhaes
b1266dc05a
Use typesafe project accessors for project modules
2 years ago
Simon Marquis
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
3 years ago
Jose Alcérreca
151f877bbe
Adds screenshot tests to :core:designsystem ( #931 )
...
* WIP: Adds screenshot tests to :core:designsystem
Change-Id: I0672845feba4064652dd8d60f07047b87864e121
* 🤖 Updates screenshots
* Creates tests for more components and cleans up
Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22
* WIP: More cleanup and more combinations of themes
Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523
* Added the rest of the screenshot tests for designsystem
Change-Id: Ic427db5491910781c038882055524e3f3dbed194
* Some more cleanup
Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180
* Spotless
Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6
* 🤖 Updates screenshots
* ScreenshotHelper cleanup
Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0
3 years ago