d8b735f80e
Revert "Improve accessibility to ForYou topics ( #1309 )" ( #1732 )
...
This reverts commit 48544194f4
2 years ago
48544194f4
Improve accessibility to ForYou topics ( #1309 )
...
* Clear semantics.
Change-Id: I69a48798f6be8433e877c38166bd73cd776d71ac
* Merge the descendants semantics.
Change-Id: Ifbe91bb694b393e6780f93732a7d38f5ee355680
* Add string for icon description.
Change-Id: Ibf35c651aeacfbe317794ed898f0fb0e8bc1ec15
* Change icon description.
Change-Id: I9359bf8c9272b247669ae58fd79e5f79466ec0a9
* Change state of icon check logic.
Change-Id: I3e5e89fc1c469c3f3c4744d18f697f68d070996b
* Merge only text.
Change-Id: I36eefc6dd9f56f7a1f63003f0f95f6755ae16def
* Add stateDescription.
Change-Id: Id4d32e49374dbdb6e666048937e37060cbd4b454
* Add toggleableState.
Change-Id: I9f836e2463bf800786d11f9e0997a7d570ff90b0
* Set clearAndSetSemantics at Row.
Change-Id: Ic25b9ca11bbcc40c8ff24172669b07ea9b7642a9
* Set stateDescription "Following" and "Not Following".
Change-Id: Ib82ac94b05a5d373ac10787aac5241fb4f03c7b2
* Find topic by onNodeWithContentDescription.
Change-Id: I2423e3846c02169f6bf1fc30d9b4034b5f79efb3
* Find topic by onNodeWithContentDescription.
Change-Id: Iefc97fd9e52227f51f7d40f8c10cb4878cde90c0
2 years ago
89795c98b5
Fix spotless
2 years ago
5994d8c6fd
Add TopicScreen as a sub destination in the ForYou section. Fixes #1463
2 years ago
f0434e52a4
Spotless Apply
2 years ago
46e15f21dc
Fix duplicate composition trace markers in composable
2 years ago
8d57134663
Fix spotless
...
Change-Id: Ib093c206809a470b7f6135933bd2a72046865684
2 years ago
4b3f5370b9
Clean up deep link handling
...
Change-Id: I9d589cfe5c20a6b55708b99f5d79b10271af8ab4
2 years ago
95bdc0f533
Rename ForYouRoute composable to ForYouScreen
...
Change-Id: I47456f19f2b41cafe44ba7636cad6d1fea782a33
2 years ago
da8f32a2ea
Rename Destinations to Routes
...
Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7
2 years ago
aba2b2c154
Remove different deeplink destination, add route for nested nav host
...
Change-Id: Idb9586752d815449243d6d529e9b655c45e395ad
2 years ago
4a84cf2bf4
Add specific type for deeplinks
...
Change-Id: I63c0abb16cbf540ef72dfb945518a48113bdbf75
2 years ago
f67f4d1a83
Update ForYou destination to match current deeplink pattern
...
Change-Id: Ia5ab36f2d75d8d061e63c0cac5262503bc93a638
2 years ago
7ec21d9d2f
Fix issue where selected topic in list was not showing as selected. Minor tidy ups.
...
Change-Id: Icfa79eac6f7327c365f79fd7d15dfa1f8c77184d
2 years ago
924391cd22
Fix spotless
...
Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428
2 years ago
89163b5ea1
Migrate remainder of app to type-safe navigation
...
Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b
2 years ago
ee4320723f
Fix typo.
...
Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f
2 years ago
ed91723e2f
Fix #1270
...
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
2 years ago
db5e2b649e
Remove unnecessary Boxes
...
Change-Id: Ia404cde7f6b555234bef4b27058fabd4471ea3c6
2 years ago
2271d01da5
Fix spotless
...
Change-Id: I8d19c437fc6e2e2198af5ac871c3f7813d280923
2 years ago
b1d867f827
Replace BoxWithConstraints with Box (fixes linter error)
...
Change-Id: Iea0401e28ae0e884511800652fde0f1896642aa0
2 years ago
f64f1c0aa2
Remove legacy benchmark build type ( #1207 )
...
* Remove legacy benchmark build type
Now that we have the baseline profile gradle plugin,
there is no need for a benchmark build type.
The plugin does the setup and configuration and runs against the
correct app flavor.
* Remove explicit benchmark build type from benchmark module
* Remove stale build task exclusions
* Fix tracing import location
FYI @mlykotom
3 years ago
d9aaec0699
Use androidx.tracing everywhere
...
Change-Id: I847827efc08f5cbc00f0c809ad992c267f826e50
3 years ago
707117a4f2
Merge branch 'main' into kotlinify
3 years ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
3 years ago
65f0d5b2d9
Update feature/foryou/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/foryou/navigation/ForYouNavigation.kt
3 years ago
9d41ffa318
Merge branch 'main' into kotlinify
3 years ago
2a2d8ed88d
Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE
3 years ago
32e1ec0447
Remove violations: property-naming
3 years ago
f8f932705a
Remove violations: discouraged-comment-location
3 years ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
3 years ago
03d2455f41
Use lazy vertical staggered grid in feed to maximize space utilization
...
Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926
3 years ago
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
3 years ago
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
3 years ago
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
3 years ago
4e6cda1965
Renamed toggle function signature with boolean parameters
...
Change-Id: I0d6c0ed4d4c0ee4bd387e5645fc558970f5f202b
3 years ago
153b34fd50
Merge pull request #850 from qamarelsafadi/loading-progress-for-image
...
Fix #849 : Loading progress for image
3 years ago
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
3 years ago
2db3e0c804
Merge branch 'android:main' into loading-progress-for-image
3 years ago
8901e5932a
Merge pull request #872 from SimonMarquis/data-objects
...
Convert 'sealed' sub-object to 'data object'
3 years ago
8aa0457ca9
Merge branch 'android:main' into loading-progress-for-image
3 years ago
03610d229a
Update feedItemsSize calculation
...
Change-Id: I2bf6a2fa0e210cef1318707d948a49d2ef010452
3 years ago
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
3 years ago
b7799f0475
Convert 'sealed' sub-object to 'data object'
3 years ago
f1a2993adc
feat: remove add placeholder todo
3 years ago
e13e84c155
Replace usages of 'displacement' to 'moved' in parameter names
...
Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a
3 years ago
eeb4973265
PR feedback
...
Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f
3 years ago
cb1d50e65e
Even better names
...
Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65
3 years ago
3aec705048
Add padding to scrollbars
3 years ago
31b4841cb2
Add scrollbars to app
3 years ago
Ben Weiss
Jaehwa Noh
Don Turner
yongsuk44
Tomáš Mlynarič
Don Turner
Simon Marquis
lihenggui
dahunsi
Simon Marquis
Roy Matero
Adetunji Dahunsi
Qamar A. Safadi
qamarelsafadi
TJ Dahunsi