Alex Vanyo
369cd33b7a
Add accompanist/testharness
...
Adds a usage of accompanist/testharnness to force a given DpSize for its content, overriding the density if necessary to ensure that the size is achieved. This allows testing UI at arbitrary sizes on arbitrary emulators, lessening the need for using multiple emulators at different sizes (and filtering tests) when Android-specific window size has been hoisted appropriately.
The initial test using it is a test for checking whether or not the navigation bar or navigation rail is being shown, and these tests can run on any emulator.
Change-Id: I315384e5eafac23a3cd6d3818d9828f6d3c1acfc
2 years ago
Tomáš Mlynarič
b425f9560d
Merge pull request #458 from android/tm/fix-benchmarks
...
Fix benchmarks
2 years ago
mlykotom
7db33aa041
Refactor naming according to convention
...
Change-Id: Id74e2495d5909e4978247e0d7edfb5621b2064ff
2 years ago
mlykotom
867cc549cd
Update BLP
2 years ago
Masood Fallahpoor
22b8f782eb
Make functions 'shouldUseDarkTheme' and 'shouldUseDarkTheme' private
2 years ago
mlykotom
eea70382d6
Fix code style
2 years ago
mlykotom
7ebc718ca0
Enable R8
2 years ago
mlykotom
6c1f8394d9
Fix flavors change
2 years ago
Milosz Moczkowski
fe32e90cdd
Merge pull request #412 from SimonMarquis/patch-2
...
Remove test dependency from `implementation` configuration, fixes #411
2 years ago
Milosz Moczkowski
06dac236fe
Merge pull request #420 from SimonMarquis/patch/kotlin-test
...
Migrate from JUnit assertions to Kotlin's test framework
2 years ago
Don Turner
df6207122d
Merge pull request #326 from MaximillianLeonov/redundant-label-on-activity
...
Remove redundant label on activity
2 years ago
Don Turner
c7859d3c3c
Merge pull request #324 from MaximillianLeonov/unused-color-resources
...
Remove redundant unused color resources
2 years ago
Simon Marquis
90dc300783
Migrate from JUnit assertions to Kotlin's test framework
...
Fixes #419
2 years ago
Simon Marquis
18e58678e3
Merge branch 'android:main' into patch-2
2 years ago
Simon Marquis
e050c22c88
Remove test dependency from `implementation` configuration, fixes #411
2 years ago
Don Turner
d616bf3a42
New version to trigger new build on server
...
Change-Id: I19e606f29c4d7449c09184282ba1e646ead52517
2 years ago
Don Turner
de403be3c4
Update app version
2 years ago
Don Turner
a9aa3eafab
Add data from the last 10 episodes
2 years ago
Ben Weiss
0171971dc7
Merge pull request #316 from android/bw/gradleCleanup
...
Update Baseline Profile generation
2 years ago
Ben Weiss
3ab6002531
New baseline profile
...
Change-Id: I8a20ab2f44b198afaf57f26d1bee20054ed1ce6d
2 years ago
Yura Laguta
de893cbad7
Resolves #206 , enables predictive back navigation support
2 years ago
Don Turner
505187482b
Add workaround for top app bar overlapping nav rail
2 years ago
Don Turner
1c6c812b76
Update app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
2 years ago
Don Turner
dbff140b64
Fix minor issues
2 years ago
Don Turner
e5183e21e0
Resolve conflict with navigation changes from main
2 years ago
Don Turner
76daa393b1
Address review feedback from Manu
2 years ago
Don Turner
0d5dd944ea
Fix getter for settings dialog state
2 years ago
Don Turner
828242dbad
Remove Scaffold from top level screens
2 years ago
Don Turner
f59da72383
Add comment about splashScreen.setKeepOnScreenCondition
2 years ago
Don Turner
5e4100fafc
Add MainActivity view model
2 years ago
Don Turner
c3f7870412
Fix spotless issues
2 years ago
Don Turner
56c0645816
Add tests
2 years ago
Don Turner
d42881e5d4
Add UI architecture for Settings dialog
2 years ago
Don Turner
8c30ab9f80
Add settings module, refactor top bar
2 years ago
Don Turner
b7500ea09b
Fix typo
2 years ago
Don Turner
add486a0ab
Fix spotless issues
2 years ago
Alex Vanyo
7e3faad699
Add data logic for theme switcher
...
Change-Id: Ifffadb897de4f6e08f7115103f99c156a7098b70
2 years ago
Manuel Vivo
a0b22d8ed2
Updates Navigation approach with new guidance ( #347 )
2 years ago
Ben Weiss
7e6cb46436
Merge pull request #328 from android/bw/moreJankstats
...
Add more jank tracking
2 years ago
Ben Weiss
ee2e3db928
Add more jank tracking
2 years ago
Wojtek Kaliciński
dcc23829d4
Migrate packages to namespaces in build files
...
Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5
2 years ago
Ben Weiss
348e2cc6f4
Shorten navigation trace, fixes #271
...
Change-Id: I4b33800a538b13996fc68b48854be56251a9db2c
2 years ago
Maximillian Leonov
f16b698ba6
Remove redundant label on activity
2 years ago
Maximillian Leonov
73a9960cbd
Remove redundant unused color resources
2 years ago
Don Turner
6351a89545
Merge pull request #310 from android/documentation/dep_graphs
...
Add dependency graphs to every module
2 years ago
Adetunji Dahunsi
c4debb74e7
Give feedback when syncing on ForYouScreen
...
Change-Id: I10a646e8a17f81d96351e69d36f0cb6ccf28e05c
2 years ago
Milosz Moczkowski
06e60063b5
Add dependency graphs to every module
...
Change-Id: I629fef818f7521c13bb3069a3ff9ed9bc42e57f3
2 years ago
Alex Vanyo
9be6e846d9
Apply spotless
...
Change-Id: I49eeb1984cb3e978a9cee5c1e4d53e856a10bb4e
2 years ago
Alex Vanyo
738210166a
Refine backgrounds and navigation colors
...
Change-Id: I9fd863cc608f21078ab78c39c2c3d227aedbac7c
2 years ago
Alex Vanyo
8c11769622
Update to material3 1.0.0-beta03 wih built-in insets support
...
Change-Id: I4d07f89d4faa6e3417468ad78acf3fbb161f0797
2 years ago
Wojtek Kaliciński
4683918cc7
Move spotless to init script
...
Also adds automatic git hooks installation
Change-Id: I18debbee43af27db7b95a4202f824fa87e186713
2 years ago
Wojtek Kaliciński
d0cff2b11c
Build cleanup
...
* Move Hilt setup to convention plugin
* Disable Hilt on modules where it's not needed
* Enable non-transitive R classes
* Fix `configuration` blocks called in wrong scope
* Move imperative Flavors code from build.gradle
* Disable unnecessary build features globally
* Disable configure-on-demand as it's not encouraged
* Don't use internal AGP packages in plugins
Change-Id: I1bee3e3fd0103054637b979a350f9fd2312ae8ba
2 years ago
Alex Vanyo
d6555cbaa5
Merge pull request #269 from android/av/compose-tracing
...
Update Kotlin, Compose and add in the new runtime-tracing artifact
2 years ago
Alex Vanyo
a60687ae73
Update Kotlin, Compose and add runtime-tracing
...
Change-Id: I1697541a70a47281424fa51dfe5cab78bf89a1f6
2 years ago
madroid
c35699280e
Move 'feature-' module to feature subfolder
2 years ago
madroid
3bd81154b5
Move 'core-' module to core subfolder
2 years ago
Jolanda Verhoef
a37c06db10
Merge pull request #231 from android/jv/app-icon
...
Update app icon using Image Asset Studio
2 years ago
Jolanda Verhoef
bcdc906f3a
Add round icon again for API 25.
2 years ago
Jolanda Verhoef
f00cae012f
Add monochrome to v26 app icon, remove round icon (as per documentation: You may also define an icon drawable resource using the android:roundIcon attribute—but only if you require a different icon asset for circular masks, for example in a case where your branding relies on a circular shape.)
2 years ago
Alex Vanyo
73cd535695
Fix dark mode system icons
...
Change-Id: I8af3435d2b83ebbd55b8adaa3f2066fbe2d22fa5
2 years ago
Jolanda Verhoef
f851141b0d
Add v33 launcher icon with support for adaptive icons
2 years ago
Jolanda Verhoef
152d571847
Update app icon using Image Asset Studio
...
Change-Id: I9eb8281abbb59da0b653dbe6c36786c90d330556
2 years ago
Alex Vanyo
e0687e9aae
Merge pull request #217 from android/av/splash-screen
...
Removes non-Compose Material library and adds splash screen
2 years ago
Alex Vanyo
200aede1c7
Rename NightAdjusted.Splash to NightAdjusted.Theme.Splash
...
Change-Id: I2493c664945d3cfbe1c52397133fdc955265ac56
2 years ago
Ben Weiss
8587ae8ee6
Merge pull request #219 from android/bw/metricsUpdate
...
Update JankStats to 1.0.0-alpha03
2 years ago
Ben Weiss
6dc17126da
Update JankStats to 1.0.0-alpha03
...
Accomodating API changes along the way.
2 years ago
Alex Vanyo
063965c9cd
Add splashscreen integration
...
Change-Id: I1fbc5b7e663497ae52759afb7bcd6169c5987ce6
2 years ago
Alex Vanyo
4523129fd4
Remove non-Compose material
...
Change-Id: I62a639b6c12e7d523c3dc5ad0766f180120d9e92
2 years ago
Jolanda Verhoef
40cf1b8171
[NiA] Implement LazyVerticalGrid for Feed
...
Change-Id: I0fd51bdd4c64a3d9ceaba05244d384bb9b463315
2 years ago
Jolanda Verhoef
37ad3e6299
Merge remote-tracking branch 'github/main' into jul22automerger
...
Change-Id: Ic54190a9d825ae9649d34a4e2bd9c83855511b71
2 years ago
Manuel Vivo
ea07e97a07
Add more KDocs and nav args encoding
2 years ago
Manuel Vivo
872a7a6523
Make the state holder stable
2 years ago
Manuel Vivo
0eee3620b8
Add state holder for NiaApp composable
2 years ago
Don Turner
34411e3f70
Merge remote-tracking branch 'github/main'
...
* github/main: (21 commits)
Add stacktrace for test command
Add TODO comment with bug
Update Compose compiler to 1.2.0, Kotlin to 1.7.0
Consistent tags & named parameter usage
Address review comments
Remove redundant dependency
Fix spotless
Move JankStats metric gathering further down
Add ForYou TopicSelection scrolling state
Add ForYou feed scrolling state
Add JankMetricDisposableEffect
Add AuthorsCarousel scrolling state
Add JankMetricEffect
Remove InterestItem state
Use DisposableEffect + rememberMetricsStateHolder for Interests tab selection
Use rememberMetricsStateHolder for navigation
Add rememberMetricsStateHolder composable
Introduce view extension to track jank
Inject JankStats with Hilt
Add jankStats and rudamentary jank logging
...
Change-Id: I1ff0fb3ccb7d6082c17c6e69f5d9ea9cabe1d733
2 years ago
Jolanda Verhoef
c4110e33c6
[NiA] Add Saved functionality
...
Change-Id: I38320a16999d063a023bbe9d329a275af4e78b1e
2 years ago
Ben Weiss
efb76d4941
Merge branch 'main' into bw/initialMetrics
2 years ago
Ben Weiss
9f929944d0
Address review comments
...
* Introduce gradle plugin for firebase perf
* Create TrackScrollJank composable to mask tracking code
2 years ago
Ben Weiss
c3ca38d31d
Remove redundant dependency
2 years ago
Ben Weiss
6509b6ac9d
Merge branch 'main' into bw/initialMetrics
2 years ago
Tomáš Mlynarič
a4e7488888
Update baseline profile
...
Contains CUJs:
- scrolling for you feed
- scrolling interests topics
- scrolling interests people
Change-Id: Iad124aafae9858b2922dcfa49302fe1f8aacae48
2 years ago
Tomáš Mlynarič
b2569c1576
Add testTag to access composables from UiAutomator
...
Change-Id: I5125cae0778151b11868b72f74f74f979774625c
2 years ago
Tomáš Mlynarič
2407a1d4b4
Fix debuggable build types
...
Change-Id: Ie3ecf462cac81bd462c48ad161521b18836325b9
2 years ago
Jolanda Verhoef
90480286c9
Merge pull request #68 from RivanParmar/main
...
Fix Navigation Bar in landscape mode.
2 years ago
Nick Rout
d05b573f52
Improve design system usage and add lint checks
...
Change-Id: I05f9400a9410e31bdf1534e458d560fe793b809f
2 years ago
Rivan
334a6d07b3
Fix SpotlessApply.
2 years ago
Ben Weiss
fa16a25ac8
Merge branch 'main' into bw/initialMetrics
2 years ago
Rivan Parmar
09e0aed124
Merge branch 'android:main' into main
2 years ago
Renovate Bot
22c5668133
Update dependency org.objenesis:objenesis to v3
2 years ago
Jolanda Verhoef
2f35893b2e
Merge remote-tracking branch 'github/main'
...
Change-Id: I8706d94ba2850646218fc982719c99991d93f34c
2 years ago
Ben Weiss
42878c5e86
Move JankStats metric gathering further down
...
This isn't the thing a developer should be focusing on when first
opening the file. So moving it further down in the composable.
2 years ago
Ben Weiss
da79a98876
Update baseline profile and generation logic ( #61 )
2 years ago
Ben Weiss
e949749073
Merge branch 'bw/initialMetrics' of github.com:android/nowinandroid into bw/initialMetrics
2 years ago
Rivan
747416ad84
Fix Navigation Bar in landscape mode.
3 years ago
Rivan
5032136784
Fix Navigation Bar in landscape mode.
3 years ago
Don Turner
eb1973052d
Add demo and prod product flavors. Remove staging variant.
...
Change-Id: I7d251d477ef1ee770096b9971099e0bf59cfa6ea
3 years ago
Alex Vanyo
b602abc263
Merge pull request #56 from sud007/fix/nia-naming-convention
...
Fix Bug #41 | Nia Naming conventions
3 years ago
Tomáš Mlynarič
bc7270d6c4
Add JankMetricDisposableEffect
...
Change-Id: Idcab0faa2e9b4cc9986064f45217cab101843697
3 years ago
Tomáš Mlynarič
a076a50010
Use rememberMetricsStateHolder for navigation
...
Change-Id: I3b038a9bbc6eed9b21343aa0fd75c044049386a4
3 years ago
kbuilder
58fd7dcec0
Merge branch 'github/main'
3 years ago
Sudhanshu
ea1114a337
Fix Bug #41
...
Fix bug #41 Made Naming Convention symmetrical. as 'Nia' instead of 'NiA' as that sounds more subtle and easy to follow in camel-case notation based Naming
3 years ago
Simon Marquis
7813757393
Remove ClearRippleTheme CompositionLocal from NavigationBar
...
Fixes #36
3 years ago
Ben Weiss
a37c932898
Introduce view extension to track jank
3 years ago
Ben Weiss
895ec4c337
Inject JankStats with Hilt
3 years ago
Ben Weiss
4f57975657
Add jankStats and rudamentary jank logging
3 years ago
Ben Weiss
103398682a
Add tracing library and start using it
...
Currently tracing sync and main navigation.
3 years ago
kbuilder
3a43928ef1
Merge branch 'github/main'
3 years ago
Jolanda Verhoef
f74103c804
Merge pull request #44 from serbelga/fix_themed_app_icon_round
...
Fix themed app icon launcher roundIcon
3 years ago
Sergio Belda
9f10b5c4c6
Add cutout version of ic_launcher_foreground for drawable-v24 in app module in order to distinguish it from the nia-app-catalog version
3 years ago
Sergio Belda
72278b8cef
Add monochrome attribute to ic_launcher_round.xml in :app and :app-nia-catalog
3 years ago
Simona Stojanovic
1475e3e8f9
Fix nested navigation graphs
...
Change-Id: I2c3ad0a0f6c132230b821d3621389913cf37247c
3 years ago
Ben Weiss
0651d9dde6
Update benchmarking & baseline profiles
...
Uses newest versions from I/O release
Also updates baseline profile to match latest changes
Change-Id: I83c709338ea37d2187d1e8437f5b5d8e98a42f22
3 years ago
Simona Stojanovic
febbd26261
Refactor navigation
...
Change-Id: I3501446e73976f3872592038501fcef8c8324f74
3 years ago
Ben Weiss
52b771a8b5
Update baseline profile
...
Change-Id: I6b69df704e14ba9568494d773690a1121226273e
3 years ago
Don Turner
9bb7f9d8a7
Add staging build variant, move staging URL out of source control
...
Change-Id: I9388f8d2adc4800749fc7e5e79c2d165938401c4
3 years ago
Adetunji Dahunsi
d945a007c6
Add AuthorScreen and corresponding components
...
Change-Id: Iee5e8bd0932d1b68770aaa1e23fa660451109601
3 years ago
Simona Stojanovic
dc4af7e6f7
Rename following to interests
...
Change-Id: Iabcb8b495717e0cb3a993ecc0e09e3338fe5140f
3 years ago
Jolanda Verhoef
ce0142b98a
Add gradient background to For You Screen
...
Change-Id: I6a85ee82a78b1897020f1737503611bd100764a1
3 years ago
Alex Vanyo
cce9402b04
Add multi-column support for cards on the for you feed
...
Fixes: 228074722
Change-Id: Id077b4dd93452b5f9399f94161c9b66594436975
3 years ago
Alex Vanyo
203c8e1ceb
Configure spotless for kts and xml files
...
Fixes: 230874524
Change-Id: I147b9f16d5424b3459435e3c5422867b40c480b7
3 years ago
Simona Stojanovic
7968a70398
Rename core-domain to core-data
...
Change-Id: Ief2eef982c9ebe4be729bee1d2f59e2ab8b1f911
3 years ago
Alex Vanyo
f84320e9a9
Fix large screen insets handling
...
Bug: 228374243
Change-Id: I2a7af72e60450be3280872b46bd84eb1079b533d
3 years ago
Adetunji Dahunsi
643b230187
Converted model ids from ints to strings
...
Change-Id: Iad07926e04113bcd2c6d9e06e5e2a4e802a79b80
3 years ago
Alex Vanyo
b677cc4508
Convert all build files to kts
...
Change-Id: I26bf730ee51f62cbd604c02b628c1f277cfceb72
3 years ago
Alex Vanyo
7ac15771b3
Update to Kotlin 1.6.20 and using material3-window-size-class
...
Change-Id: I30bc9f729ab91f007de530af3a12b281430ac1cb
3 years ago
Alex Vanyo
bcf05f5502
Remove material non-3 components
...
Bug: 228974929
Change-Id: Ie74189bd6ce1a4a2ece36962e0ad1627ac9c71dd
3 years ago
Manuel Vivo
3558a6931e
Add People to interests screen
...
Screenshot: https://screenshot.googleplex.com/3XqkTwJQwgfoPsT
Change-Id: Iac7dc06c84523b4db8d05f538b74a08741d2c347
3 years ago
Alex Vanyo
ca73f5598f
Setup convention plugins base
...
Change-Id: I66ea3a5c95ca9d87a1f0da39b6ba72faffc320ed
3 years ago
Jose Alcérreca
553d152844
Adds topic screen
...
Bug: 213876743
Tests: Local + UI tests + Navigation test
Change-Id: I6c521695d6b777084a6255c6d62623a4def83063
3 years ago
Ran Nachmany
9ebea8ad29
Improving For You onboaring [ http://b/223204846 ]
...
Test: updated tests that were failing in firebase testlab due to the UI change.
Change-Id: If892a7a81eecc69bf71f41d75c11af363903f962
3 years ago
Don Turner
ab7b25ef6a
Add new fields to Topic and display SVG icon.
...
This CL makes the following changes to the Topic model:
Renamed description -> shortDescription
Added longDescription, url and imageUrl (this is the URL of the icon)
This makes the model of Topic in the app match the model in the back end.
The icon (an SVG file) for each topic is displayed in the Topic list UI.
Change-Id: Ibbb35c8be879ae4d6e45b69fa0eafa88f3537052
3 years ago
Adetunji Dahunsi
2b2bd496e0
Added launcher icons
...
Change-Id: I2c7fbfd36d91866956d7787e547affe1b90f4fbc
3 years ago
Adetunji Dahunsi
ccb822286f
Integrate WorkManager (WIP)
...
Change-Id: Iedf81220336911ab3ed6ea4ca71b10f07e645bc9
3 years ago
Don Turner
57f478b7c1
Remove episodes and saved destinations
...
Bug: 223215076
Change-Id: If71b9190c145f9fc298f33fe2145a87886419d68
3 years ago
Ben Weiss
5b54858642
Add baseline profile
...
Create proguard-rules.pro, disabling obfuscation.
The BaselineProfileGenerator needs to run on an AOSP emulator.
Classes in StartupBenchmark should run on a physical device to produce
reliable data.
The baseline-prof.txt file should be re-generated for each release.
Change-Id: Iaceb4e5c6d2f927dc545454a44dea43951dfaf6d
3 years ago
Ran Nachmany
668d6cc91c
Merge "Adding device class breakopints ( http://b/216019537 )" into main
3 years ago
Caren Chang
89f54c23d6
Add Internet permission
...
Change-Id: I3b7e042a6fac971597f554049895dbc1cc38fba7
3 years ago
Ran Nachmany
ea9fbad058
Adding device class breakopints ( http://b/216019537 )
...
Adding NavRail for MEDIUM / EXPANDED classes (http://b/216019759 )
Change-Id: I19a8888de558e1466d186a48f2ea293bb1b8ba4b
3 years ago
Alex Vanyo
506c98cc90
Add test dispatchers
...
This adds a test implementation of dispatchers with an injected TestDispatcher.
The normal IO dispatcher is automatically swapped out via a TestInstallsIn in core-testing.
This update also updates DataStore to use an injected dispatcher, which allows removing the waitUntil in the navigation tests because we can eagerly read from disk with runTest.
Change-Id: I82abb8c8a57c2beed5ef37bf1e252acf379278cd
3 years ago
Alex Vanyo
fd545f7fad
Fix test dependencies
...
https://twitter.com/alex_vanyo/status/1494409399216992268
Change-Id: If8325a16c6ccd8e42af1e35abad8eebfc8371afe
3 years ago
Simona Stojanovic
1411b1576b
Modularise the app
...
Change-Id: I63791eaf27d08a837598d774df53c96bb01b5864
3 years ago
Jolanda Verhoef
1b06dc97ea
Fixing UI tests
...
Change-Id: Iaa0ce3ae92e0c736aef5809c1e471c9cbff695a9
3 years ago
Simona Stojanovic
53248e6dac
Merge "Add Following - Topics feature base" into main
3 years ago
Caren Chang
4f3776406c
Merge "NewsResourceCard: Display Title, Bookmark Icon and Description" into main
3 years ago
Simona Stojanovic
d355a70292
Add Following - Topics feature base
...
Acceptance criteria: https://b.corp.google.com/issues/213886281
Change-Id: I129fb3d076b831aa00c16533090cb03b2bdebdd7
3 years ago
Adetunji Dahunsi
e089012a8d
Replace module interfaces with objects
...
Change-Id: Ieab7533120e7b8d5a770963e37b9db405e229630
3 years ago
TJ Dahunsi
8b1852cf5e
Merge "Add DAOs for Room and provisions for their Hilt injections" into main
3 years ago
Caren Chang
8d8e72667b
NewsResourceCard: Display Title, Bookmark Icon and Description
...
Screenshot of change: https://screenshot.googleplex.com/957TAnWp96uX8Ea
Bug: 216019530
Change-Id: I58fd1b4fda06b0fb8cc5df2ba5baf7e8ddcd5a1d
3 years ago
Adetunji Dahunsi
cbcb24c08f
Add DAOs for Room and provisions for their Hilt injections
...
Change-Id: Ia14c225cc1632ded38abffc201b673a6a60f4451
3 years ago
Alex Vanyo
a36c0da93a
Replace accompanist/insets
...
Replaces the insets support from accompanist with the in-progress support from Compose itself.
This is a pretty simple change on the usage side, since we only used it in one place.
Change-Id: I05ce768d13fcdeb6471012dde774636526cf35f3
3 years ago
Adetunji Dahunsi
9f11f6ae8b
Update copyright accross all files
...
Change-Id: I3d30bf58ded466f936772958bebcd7b7817ad809
3 years ago