66cc98f845
Merge branch 'github/main'
4 years ago
b5b7e9134c
Merge pull request #21 from SimonMarquis/fix/empty-author-item-image
...
Replace empty `AuthorItem`'s picture with `Icons.Filled.Person`
4 years ago
1ac5459817
Merge branch 'github/main'
4 years ago
e3579d0feb
Merge pull request #42 from madroidmaq/rename-ui-state
...
Rename UI State sealed interface class with UiState postfix
4 years ago
77eba29689
Merge branch 'github/main'
4 years ago
1b899adcfb
run spotlessApply task
4 years ago
8d2b44ddf9
Fix ktlint: max line length (100) in ForYouScreenTest.kt
4 years ago
7e310198e9
remove colors
4 years ago
532d846a47
used NiaFilledButton instead of Button
4 years ago
7e39c0a90f
revert a import line
4 years ago
44111bb11f
fix done button color in the darkmode and lightmode
4 years ago
1cb6d616f6
Fix ktlint: max line length (100)
4 years ago
6419f52263
Replace Filled.Android with Filled.Person icon in InterestsIcon
4 years ago
2287204b64
rename ForYouInterestsSelectionState -> ForYouInterestsSelectionUiState, ForYouFeedState -> ForYouFeedUiState
4 years ago
89c63f243a
Add common build convention for feature modules
...
Change-Id: I24d54343de2835fff4f7a8dfc598b9a1864ffec7
4 years ago
4049c54afc
Replace empty `AuthorItem`'s picture with `Icons.Filled.Person`
...
Duplicated from `NewsResourceAuthors`.
Fixes #20
4 years ago
5ca7b6c607
Refactor navigation
...
Change-Id: I3501446e73976f3872592038501fcef8c8324f74
4 years ago
0381fcbbd8
Fix onboarding topic name cropped at bottom
...
Bug: 231310262
Change-Id: I8eee6b871c8f36765591d01e9d971b5d8a6f4387
4 years ago
7a5af75105
Update for you top app bar
...
Change-Id: I95c8082198e1d1068e9ef674b005d7999e1b4542
4 years ago
47699aec9a
UI polish for "For You" Onboarding Screen [ http://b/228070817 ]
...
1. Fixed - Primary container surrounding check mark is too large - refer to Figma for padding values
2.Fixed - Done" button color should be black.
3. Fixed - Margin between bottom of ""done"" button and top of card should be increased.
4. Fixed - Elements within card container should have 16px of padding. Corners should be rounded to 24px
5. Fixed: Headline font should be Euclid and needs to be reduced in size. Refer to type styles in Figma for full specs.
6. Not Fixed (see b/227246491)- Missing save icon
7. Fixed: Date font should be Roboto mono.
8. Not Fixed: Missing ""unread"" indicator dot.
9. Not Fixed: Missing source URL or category tag
8. Fixed: Body copy in card should be Roboto (refer to type styles in Figma for full specs)
Change-Id: I76252bd40037f7f7a987c8d45681b9b6b6243823
4 years ago
ad57a93b64
Add gradient background to For You Screen
...
Change-Id: I6a85ee82a78b1897020f1737503611bd100764a1
4 years ago
7c52414724
Add multi-column support for cards on the for you feed
...
Fixes: 228074722
Change-Id: Id077b4dd93452b5f9399f94161c9b66594436975
4 years ago
b73b6a4e3c
Add bio to AuthorEntity
...
Change-Id: Idea9873e2a3107a03f6d30e888e27ba78466ca69
4 years ago
19abcd5589
Fix ic_icon_placeholder.xml formatting
...
Change-Id: I0cdfb8bbb353b47715461b14f257c9b49b3b7ffe
4 years ago
9144645f4b
Add news resource cards to topics screen
...
Change-Id: Iaab014904460988296ea93cc2088c8da93ed17f1
4 years ago
19ff76656f
Add topic icon on topic chips
...
Bug: 228070748
Change-Id: I736f4029bed84cf1d5552c5afa7ba07896e86602
4 years ago
403afba03f
Configure spotless for kts and xml files
...
Fixes: 230874524
Change-Id: I147b9f16d5424b3459435e3c5422867b40c480b7
4 years ago
a1032ff557
Rename core-domain to core-data
...
Change-Id: Ief2eef982c9ebe4be729bee1d2f59e2ab8b1f911
4 years ago
9b4d26a93d
Add loading indicator while for you data is loading
...
Updates the for you view model to support displaying a loading
state when data hasn't loaded yet.
This is a somewhat involved CL, because there are multiple ways
in which data could be loading: We could have topics, but
the feed itself could be loading after we selected a new set
of topics.
Change-Id: I8662140c7132b195f85e69fee8e18745829ae975
4 years ago
384c7eb9c2
Add dependency for Compose Previews to render
...
Bug: 228869437
Change-Id: I44a1457916e87f22dda077f4fc34d630b54f6869
4 years ago
47107e86be
Fix large screen insets handling
...
Bug: 228374243
Change-Id: I2a7af72e60450be3280872b46bd84eb1079b533d
4 years ago
68d146a7c7
Converted model ids from ints to strings
...
Change-Id: Iad07926e04113bcd2c6d9e06e5e2a4e802a79b80
4 years ago
395b6ad2ad
Add TopAppBar to the For You screen
...
Change-Id: I66730ebfcd65d16304c87ba64a66e8f5b03291c4
4 years ago
1911b6b4b8
Convert all build files to kts
...
Change-Id: I26bf730ee51f62cbd604c02b628c1f277cfceb72
4 years ago
988807a83d
Add initial loading wheel animation
...
Change-Id: Iaf4f80c34914022d79c7e089799fc6dd5554a532
4 years ago
675ca1e88a
Update to lifecycle 2.5.0-beta01
...
Change-Id: I9537006378e64a64da8053559bb16ab046e21246
4 years ago
e420cf7b50
Revert "Add TopAppBar to the "For You screen""
...
This reverts commit 3e664f1b724a620ad606cda0d4758240d80073ab.
Reason for revert: This change doesn't pass one of the tests
Change-Id: I9ffacbe4eaf1080323a7c9073dfe426a8f43345c
4 years ago
6f162376ad
Add TopAppBar to the "For You screen"
...
Change-Id: I0bb1a5038d697adebad4e662755baaba72ded529
4 years ago
04d368bb58
Allow saving authors and topics only
...
Bug: 229012243
Change-Id: I4c8bc77002d39b8f97c925ea811d307e2cbe93db
4 years ago
8d4ab06983
Add People carousel
...
Screenshot: https://screenshot.googleplex.com/9K6C4NZMfMzCABE.png
Change-Id: I32b0240910df6a953c8843895f3b7e22d5adc5de
4 years ago
4dceebab73
Setup convention plugins base
...
Change-Id: I66ea3a5c95ca9d87a1f0da39b6ba72faffc320ed
4 years ago
b10b5b2dc6
Fixes UI tests
...
Change-Id: I8dd8eae9e79f111bb1ae4df2738fc0de4be25ea8
4 years ago
f6575e947b
Card UI: Add rounded corners
...
Bug: 228067197
Change-Id: I7af4eb64680f39616c2e37f092f62da960d3189d
4 years ago
e577b1f15a
Refine For You screen
...
Bugs: 228374446, 228374358, 228373944
Change-Id: I237cc511b09acd4c8e794f1950fadadf23656152
4 years ago
b6eae2907c
Reset in-progress topic selection upon saving
...
Previously, the in-progress topic selection wasn't reset upon saving. This meant that clearing out the selected topics (from the topics tab) would bring back the topic selection that was last used.
Bug: 228050946
Change-Id: I3d52baf6396b41e2116f38c89a79b419c90c63b5
4 years ago
36c4e3dcf9
Update lifecycle to alpha06
...
Change-Id: I39958aa440e0ecd5bdae43179d8ac8501f87720e
4 years ago
71cef7951b
Improving For You onboaring [ http://b/223204846 ]
...
Test: updated tests that were failing in firebase testlab due to the UI change.
Change-Id: If892a7a81eecc69bf71f41d75c11af363903f962
4 years ago
184097bf13
Add new fields to Topic and display SVG icon.
...
This CL makes the following changes to the Topic model:
Renamed description -> shortDescription
Added longDescription, url and imageUrl (this is the URL of the icon)
This makes the model of Topic in the app match the model in the back end.
The icon (an SVG file) for each topic is displayed in the Topic list UI.
Change-Id: Ibbb35c8be879ae4d6e45b69fa0eafa88f3537052
4 years ago
442cf6dc8f
Use androidx SavedStateHandle.saveable
...
Change-Id: Ifdae07c5b3731c4d67f348a01652cf3aec00b234
4 years ago
c949413c0a
Open NewsResource URL when Card is tapped
...
Bug: 226603463
Change-Id: Ia9d15e9fd85ae1076c7744bf96ad39fd0d5f2e66
4 years ago
kbuilder
Jolanda Verhoef
Saeed Noshadi
madroid
Simon Marquis
Simona Stojanovic
Caren Chang
Alex Vanyo
shed
Adetunji Dahunsi
Milosz Moczkowski
Manuel Vivo
Jose Alcérreca
Don Turner
