370 Commits (dd516a7e1280a8df27fee20b3c6d58cd71d005aa)

Author	SHA1	Message	Date
Don Turner	ce9e82622d	Fix broken reference to string resources ... Change-Id: Ide4cb90abc2ae7ca78488909a37df685c2e71ec6	7 months ago
Don Turner	5084fca4dd	Fix InterestScreenTest resources ... Change-Id: Ib6aa372a1ab3b13b5c69c1d3feec2c31e5dca3ce	7 months ago
Don Turner	a4c52e6485	Remove the search module's dependency on other feature modules ... Change-Id: I17df9948fed04ddc7ba507b437d39536b8b180bb	7 months ago
Don Turner	3e4aad3210	Merge pull request #1257 from android/dt/add-module-graphs ... Update module dependency graphs and add script to create them	7 months ago
Don Turner	a5025390af	Add title to READMEs to describe the dependency graph ... Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528	7 months ago
Jaehwa Noh	fc4f7930a6	Merge branch 'android:main' into rename-function	7 months ago
Jaehwa Noh	ee4320723f	Fix typo. ... Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f	7 months ago
Jaehwa Noh	ed91723e2f	Fix #1270 ... Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c	7 months ago
Don Turner	547cb191d2	Merge pull request #1256 from lnbs97/main ... Fix typo in TopicViewModel.kt	7 months ago
Tomáš Mlynarič	aa15e65a77	Fix search flickering ... Change-Id: I6d17f5703186dbebcba4f931ab9692d4ab1e9f79	7 months ago
Jonathan Koren	19f6f9e09a	2 pane support in Interests screen (#1234) ... * Add dependency on material3 adaptive Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6 * Add InterestsListDetailScreen composable Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971 * Store selectedTopicId in InterestsViewModel Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce * Pass detail pane composable down Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293 * Navigate to initial topic if provided Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b * Lift LDPS up to app module Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85 * Fix some navigation behavior Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b * Navigate to initial topic if provided Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed * Remove dependency in interests feature module Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f * Hide back arrow when the topics list is visible Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8 * Update interests tests Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd * Highlight selected topic when displaying 2 panes Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415 * update dependency baselines Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00 * run spotless apply Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8 * Convert isListPaneHidden to isListPaneVisible Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657 * Set semantics for selected state Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca * Use scaffold roles when determining visibility Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648 * Update multipleBackStackInterests test Change-Id: I1e372f7989817151a6765205291b13b561187fa8	7 months ago
lnbs97	96d210dc35	fix typo in TopicViewModel.kt	7 months ago
Don Turner	80a82de945	Update module dependency graphs and add script to create them ... Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31	7 months ago
Don Turner	171fa88ac0	Merge pull request #1248 from yongsuk44/main ... Apply Composable Parameter Ordering Guidelines	7 months ago
kim-yongsuk	3fa75a037a	Apply Composable Parameter Ordering Guidelines ... Change-Id: Id456e91b5ce8bd5807c40df67c3deac008c61670	7 months ago
Alex Vanyo	e3c7018124	Extract ScreenshotHelper to separate testing module ... Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af	7 months ago
Don Turner	db5e2b649e	Remove unnecessary Boxes ... Change-Id: Ia404cde7f6b555234bef4b27058fabd4471ea3c6	7 months ago
dturner	27fd4e544a	🤖 Updates screenshots	7 months ago
dturner	02d4fea615	🤖 Updates screenshots	7 months ago
dturner	81a5c0a3a7	🤖 Updates screenshots	7 months ago
Don Turner	76d59b3da8	Merge branch 'main' into update-compose-bom	7 months ago
Don Turner	1d2029aa2c	Merge pull request #1040 from SimonMarquis/fix-unit-test ... Fix `emptyResultIsReturned_withNotMatchingQuery` unit test	7 months ago
dturner	9e645356f6	🤖 Updates screenshots	7 months ago
Don Turner	2271d01da5	Fix spotless ... Change-Id: I8d19c437fc6e2e2198af5ac871c3f7813d280923	7 months ago
Don Turner	b1d867f827	Replace BoxWithConstraints with Box (fixes linter error) ... Change-Id: Iea0401e28ae0e884511800652fde0f1896642aa0	7 months ago
dturner	6b2b01ed82	🤖 Updates screenshots	8 months ago
Don Turner	522efac8c0	Update Compose BOM to 2024.02.00. Fixes #1218 ... Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b	8 months ago
Don Turner	69f4287ab5	Merge branch 'main' into lifecycle2.7.0 ... * main: Bump protobuf from 3.24.4 to 3.25.2 (#1214) Remove legacy benchmark build type (#1207) Use androidx.tracing everywhere Revert fast initialization of Coil Add comment for Retrofit async OkHttp Optimize OkHttp initialization for Retrofit Add braces Inline initialization Don't use runBlocking if async init completed Launch loader directly without additional coroutine scope Fix comment Improve lazy loading for Coil + OkHttp Restores screenshot tests in foryou (#1199) Fix name and message of dependency guard actions (#1196) Change-Id: Ifcbfcfba4b7d8c24599e207b4a05dfea6125fde7	8 months ago
Don Turner	2ad48843f6	Fix formatting ... Change-Id: I674d32bc0f1921c431717dbf0f41a74f632322b3	8 months ago
Ben Weiss	f64f1c0aa2	Remove legacy benchmark build type (#1207) ... * Remove legacy benchmark build type Now that we have the baseline profile gradle plugin, there is no need for a benchmark build type. The plugin does the setup and configuration and runs against the correct app flavor. * Remove explicit benchmark build type from benchmark module * Remove stale build task exclusions * Fix tracing import location FYI @mlykotom	8 months ago
Don Turner	254b464259	Update Lifecycle to 2.7.0. Use new LifecycleEventEffect. ... Change-Id: I71e7aa521f22499fd3f3e9f3ac7c81658f3abc3a	8 months ago
Tomáš Mlynarič	d9aaec0699	Use androidx.tracing everywhere ... Change-Id: I847827efc08f5cbc00f0c809ad992c267f826e50	8 months ago
Jose Alcérreca	3ff5d48f37	Restores screenshot tests in foryou (#1199)	8 months ago
Simon Marquis	5a1258232f	Fix `emptyResultIsReturned_withNotMatchingQuery` unit test ... `searchResultUiState` transitively relied on `getSearchContentsCount` updates and on `userDataRepository` to emit something.	8 months ago
Don Turner	707117a4f2	Merge branch 'main' into kotlinify	9 months ago
Don Turner	0f0511748e	Merge pull request #1088 from SimonMarquis/cleanup-dependencies ... Reduce overall build complexity	9 months ago
Simon Marquis	b043d8db86	Replace workaround on SettingsViewModel now that a fix has been deployed ... The issue has been addressed in `androidx.compose.ui:ui:1.5.0`.	9 months ago
Don Turner	89d39a7242	Merge pull request #767 from SimonMarquis/resource-prefix ... Enforce `resourcePrefix` on Android library modules	9 months ago
Simon Marquis	cd62fd5e01	Update feature/search/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/search/navigation/SearchNavigation.kt	9 months ago
Simon Marquis	b7a628ece5	Update feature/interests/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/interests/navigation/InterestsNavigation.kt	9 months ago
Simon Marquis	6cd5958665	Update feature/bookmarks/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/bookmarks/navigation/BookmarksNavigation.kt	9 months ago
Simon Marquis	65f0d5b2d9	Update feature/foryou/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/foryou/navigation/ForYouNavigation.kt	9 months ago
Don Turner	9d41ffa318	Merge branch 'main' into kotlinify	10 months ago
Simon Marquis	b6d82e24df	Merge branch 'main' into kotlinify	10 months ago
lihenggui	2a2d8ed88d	Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE	10 months ago
lihenggui	32e1ec0447	Remove violations: property-naming	10 months ago
lihenggui	f8f932705a	Remove violations: discouraged-comment-location	10 months ago
lihenggui	fb5bd225be	Spotless	10 months ago
Simon Marquis	f27a2e176e	Reduce overall build complexity ... - Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`	10 months ago
Simon Marquis	caa482bc71	Kotlinify codebase ... - Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)	10 months ago
Simon Marquis	988002e692	Update Robolectric 4.11.1 ... - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11 - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1 > Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below. Removing explicit API 33 Robolectric configuration.	10 months ago
Miłosz Moczkowski	9c89e98e5b	Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold" ... This reverts commit 335a7ec68c, reversing changes made to aa8ce0e1f6.	11 months ago
Miłosz Moczkowski	816a7b60c1	Replace manual navigation component switching with new NavigationSuiteScaffold ... Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723	11 months ago
kimdowoo	129099e219	refactor/Convert object to data object in sealed interface	11 months ago
Adetunji Dahunsi	0287af8d9a	Merge pull request #947 from android/tj/staggered-grid-feed ... Use lazy vertical staggered grid in feed to maximize space utilization	1 year ago
Don Turner	a381d13199	Merge pull request #958 from McGalanes/main ... Use typesafe project accessors	1 year ago
Melwin Magalhaes	6247712064	Add convention plugins to version catalogs	1 year ago
Melwin Magalhaes	b1266dc05a	Use typesafe project accessors for project modules	1 year ago
tunjid	b2498c763f	🤖 Updates screenshots	1 year ago
dahunsi	03d2455f41	Use lazy vertical staggered grid in feed to maximize space utilization ... Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926	1 year ago
Simon Marquis	b2cd980170	Merge remote-tracking branch 'origin/main' into resource-prefix	1 year ago
Simon Marquis	ebfe01affd	Enforce `resourcePrefix` on Android library modules ... ``` :ui-test-hilt-manifest -> ui_test_hilt_manifest_ :core:analytics -> core_analytics_ :core:common -> core_common_ :core:data -> core_data_ :core:data-test -> core_data_test_ :core:database -> core_database_ :core:datastore -> core_datastore_ :core:datastore-test -> core_datastore_test_ :core:designsystem -> core_designsystem_ :core:domain -> core_domain_ :core:network -> core_network_ :core:notifications -> core_notifications_ :core:testing -> core_testing_ :core:ui -> core_ui_ :feature:bookmarks -> feature_bookmarks_ :feature:foryou -> feature_foryou_ :feature:interests -> feature_interests_ :feature:search -> feature_search_ :feature:settings -> feature_settings_ :feature:topic -> feature_topic_ :sync:sync-test -> sync_test_ :sync:work -> sync_work_ ```	1 year ago
Simon Marquis	a33dafccad	Migrate from `java` to `kotlin` sourceSet directory	1 year ago
Roy Matero	298f3ce4db	Merge branch 'android:main' into main	1 year ago
Jose Alcérreca	5b79869324	Adds dark screenshot tests and fixes background colors in ForYou (#918) ... * Adds dark screenshot tests and fixes background colors in ForYou * 🤖 Updates screenshots	1 year ago
Roy Matero	4e6cda1965	Renamed toggle function signature with boolean parameters ... Change-Id: I0d6c0ed4d4c0ee4bd387e5645fc558970f5f202b	1 year ago
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876) ... * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	1 year ago
Adetunji Dahunsi	4716c7f841	Merge pull request #913 from hoangchungk53qx1/main ... Refactor Search Feature	1 year ago
hoangchungk53qx1	66eafdc38b	format modification for screen search	1 year ago
Milosz Moczkowski	b6459d41ee	Merge pull request #834 from takahirom/takahirom/rename-topicBody/2023-07-13 ... Rename LazyListScope.TopicBody LazyListScope.topicBody	1 year ago
Milosz Moczkowski	374808c284	Merge pull request #847 from SilviaGarciaBouza/wrong_color_in_dark_mode ... Added TextStyle color for ClickableText	1 year ago
hoangchungk53qx1	70498dd6e3	separate function logEvent for search triggered	1 year ago
hoangchungk53qx1	9cb20db93a	separate function logEvent for search triggered	1 year ago
hoangchungk53qx1	c52c4b88cd	replace object with data object in search feature, simple format code for the reader	1 year ago
hoangchungk53qx1	cd30ecf359	replace object with data object in search feature, simple format code for the reader	1 year ago
Milosz Moczkowski	89a1294c63	Merge branch 'main' into takahirom/rename-topicBody/2023-07-13	1 year ago
Simon Marquis	daa2228132	Restore original `type` labels	1 year ago
Simon Marquis	0377fd8712	Replace `NewsResourceType` enum with simpler String type ... See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901	1 year ago
Adetunji Dahunsi	153b34fd50	Merge pull request #850 from qamarelsafadi/loading-progress-for-image ... Fix #849: Loading progress for image	1 year ago
Don Turner	492697ce6b	Merge pull request #873 from SimonMarquis/misc-warnings ... Fix miscellaneous warnings	1 year ago
Qamar A. Safadi	2db3e0c804	Merge branch 'android:main' into loading-progress-for-image	1 year ago
Don Turner	8901e5932a	Merge pull request #872 from SimonMarquis/data-objects ... Convert 'sealed' sub-object to 'data object'	1 year ago
Don Turner	0e13207a40	Merge pull request #874 from SimonMarquis/string-decoder ... Replace StringDecoder injection with simpler API	1 year ago
Qamar A. Safadi	5abc69fb49	Merge branch 'android:main' into loading-progress-for-image	1 year ago
Simon Marquis	0418997f5a	Extract `UTF-8` character encoding	1 year ago
Don Turner	4d0efef3b4	Merge pull request #879 from tatsuyafujisaki/rename-constants ... Rename constants	1 year ago
Qamar A. Safadi	8aa0457ca9	Merge branch 'android:main' into loading-progress-for-image	1 year ago
Adetunji Dahunsi	0a20cb729b	Merge pull request #877 from android/tj/scrollbars ... Update feedItemsSize calculation	1 year ago
Tatsuya Fujisaki	4eeb045287	Rename constants	1 year ago
Adetunji Dahunsi	ec53d03854	Merge pull request #722 from android/tj/scrollbars ... Add scrollbars to app	1 year ago
dahunsi	03610d229a	Update feedItemsSize calculation ... Change-Id: I2bf6a2fa0e210cef1318707d948a49d2ef010452	1 year ago
Simon Marquis	e8449112b4	Replace StringDecoder injection with simpler API ... The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String. For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`). Unit tests would fail because Uri is not mocked (since we are not using Robolectric). Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc. FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded". The solution to this problem was to simply use regular Java APIs: - `URLDecoder.decode(urlEncodedTopicId, "UTF-8")` - `URLEncoder.encode(topicId, "UTF-8")`	1 year ago
Simon Marquis	4bdc9705af	Fix miscellaneous warnings ... - Remove unused namespace declaration - Collapse empty manifest tags - Remove redundant qualifier name - Remove redundant suppression	1 year ago
Simon Marquis	b7799f0475	Convert 'sealed' sub-object to 'data object'	1 year ago
Qamar A. Safadi	9f3103c212	Merge branch 'android:main' into loading-progress-for-image	1 year ago
Simon Marquis	995d7b643f	Add missing full stop in `search_not_ready` string	1 year ago
qamarelsafadi	f1a2993adc	feat: remove add placeholder todo	1 year ago
TJ Dahunsi	e13e84c155	Replace usages of 'displacement' to 'moved' in parameter names ... Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a	1 year ago
TJ Dahunsi	eeb4973265	PR feedback ... Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f	1 year ago
TJ Dahunsi	bdf3ee3cb0	PR feedback ... Change-Id: Ie22aa3c7fdf4c8ca8d8118837cfd279de8c6d80b	1 year ago