Simon Marquis
9aba5cc0fe
Cleanup unused string resources
2 years ago
Simon Marquis
b453386327
Ellipsis string can be replaced with ellipsis character
...
Lint: Replace `...` with ellipsis character `…`
2 years ago
Simon Marquis
97a55c9dd5
Merge `AndroidCIWithGmd.yaml` into `Build.yaml`
...
Add dependency on the `build` job, and add the same timeout of 55 minutes.
Closes #761
2 years ago
Simon Marquis
c882dbd507
Testing... To be removed!
2 years ago
Simon Marquis
04ddc86298
Enable `checkDependencies` and run lint tasks on project roots
2 years ago
Simon Marquis
62db986836
Add lint plugin to the `:lint` module
2 years ago
Simon Marquis
ec7b7ac668
Call `github/codeql-action/upload-sarif` with the root folder as argument
...
It does not support path globbing.
2 years ago
Simon Marquis
8ea9a8fa51
Android Lint improvements
...
- Create `LintConventionPlugin` to configure Lint on all compatible modules: Android applications, Android libraries and JVM modules.
- Run `lintProdRelease` in CI instead of the default `lintDemoDebug` which is less important compared to production code.
- Rearrange CI steps to make it more clear that Lint should is an additional step after build (build -> test -> lint).
- Enable SARIF support and upload results to GitHub's CodeQL to get inline feedback on PRs.
If we really need better perfs, we could restore `lint.checkDependencies = true` on the `:app` module and only execute `:app:lintProdRelease`.
But in practice, this does not change the total build time on this project.
2 years ago
Simon Marquis
502f9ed110
Remove `ExperimentalCoroutinesApi` and `FlowPreview` opt-in
...
```
> Task :core:model:compileKotlin
w: Opt-in requirement marker kotlinx.coroutines.ExperimentalCoroutinesApi is unresolved. Please make sure it's present in the module dependencies
w: Opt-in requirement marker kotlinx.coroutines.FlowPreview is unresolved. Please make sure it's present in the module dependencies
```
2 years ago
Simon Marquis
8c8c7611ce
Update KotlinX Serialization to version 1.5.1
...
https://github.com/Kotlin/kotlinx.serialization/releases/tag/v1.5.1
> ### Bugfixes
> - KeyValueSerializer: Fix missing call to endStructure() (#2272 )
> - ObjectSerializer: Respect sequential decoding (#2273 )
> - Fix value class encoding in various corner cases (#2242 )
> - Fix incorrect json decoding iterator's .hasNext() behavior on array-wrapped inputs (#2268 )
> - Fix memory leak caused by invalid KTypeWrapper's equals method (#2274 )
> - Fixed NoSuchMethodError when parsing a JSON stream on Java 8 (#2219 )
> - Fix MissingFieldException duplication (#2213 )
2 years ago
Simon Marquis
8f41a6b3ab
Cleanup proguard configuration
...
- Remove custom KotlinX Serialization config as it's already provided, see https://github.com/Kotlin/kotlinx.serialization#android .
- Delete empty config files.
2 years ago
Simon Marquis
1c8c881e0e
fixup
2 years ago
Simon Marquis
a49f732442
Mention core-designsystem module in the modularization journey docs
...
Closes #189
2 years ago
Automerger
23d8ebfee3
Merge branch 'github/main'
2 years ago
Ale Stamato
0c8457099d
Merge pull request #733 from android/stamato/clicks-notification-dialog
...
Grant `permission.POST_NOTIFICATIONS` in Macrobenchmark tests
2 years ago
Automerger
5fc7f1b4e0
Merge branch 'github/main'
2 years ago
Tomáš Mlynarič
f577fb06cc
Add project path subfolder
...
Change-Id: I1b680a37ecbd80b894b0d1b649633936cbe41328
2 years ago
Tomáš Mlynarič
d549ca6c7a
Apply suggestions from code review
...
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
2 years ago
Adetunji Dahunsi
f914254414
Merge pull request #749 from android/tj/reactive-only-dao
...
Ensure DAO exposes only reactive types
2 years ago
Automerger
1825d2745b
Merge branch 'github/main'
2 years ago
Milosz Moczkowski
d3e7ab92e9
Merge pull request #751 from android/st/document-compiler-metrics-command
...
Added Compose compiler metrics generation command to README.md
2 years ago
Automerger
5d93ff559b
Merge branch 'github/main'
2 years ago
Don Turner
29394467f1
Merge pull request #750 from android/tidy/scopes
...
Add general application scope, use IO dispatcher for DataStore
2 years ago
Tomáš Mlynarič
ca8b22e798
Update README
...
Change-Id: I36e98760b254be00d591d8d719dcbc57a8dd8d62
2 years ago
Tomáš Mlynarič
9f6a94dee2
Change folder for compose-reports
...
Change-Id: I7757f13c36c60991586224707f91f8ac8c0beae8
2 years ago
Automerger
d0acdca9db
Merge branch 'github/main'
2 years ago
Alex Vanyo
d4d471f1c9
Merge pull request #747 from SimonMarquis/patch-4
...
Remove benchmark androidTest task exclusion
2 years ago
Don Turner
d319264ef0
Provide Default dispatcher for instrumented tests
...
Change-Id: I488a9b9d9d3864ce9496614ab35332ec19d06bcc
2 years ago
Alejandra Stamato
96c7ada651
Added Compose compiler metrics generation command to README.md
2 years ago
Alejandra Stamato
c64cf13b4e
Added Compose compiler metrics generation command to README.md
2 years ago
Alejandra Stamato
49c8ce700e
Fixing ScrollForYouFeedBenchmark
...
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
2 years ago
Don Turner
b245334a18
Updating TestDataStoreModule to use ApplicationScope
2 years ago
TJ Dahunsi
dcc36b0228
Fix tests
...
Change-Id: Ie6b62071d2023e3a7ffe1553ab606e3f6b386a5e
2 years ago
Don Turner
4cdb5963a0
Add top level application scope, use IO dispatcher for DataStore
...
Change-Id: I1512b1665587c73abd5e8a78aa9abd3eed24ab79
2 years ago
TJ Dahunsi
cd6ad7d575
Ensure DAO exposes only reactive types
...
Change-Id: I8992ccf6525cd4c5ea9503d532b500e4d310b7fb
2 years ago
Automerger
ed4d30f5cd
Merge branch 'github/main'
2 years ago
Vixb
01e5a68a8d
Replace NiaTopLevelNavigation with TopLevelDestination based on #186 ( #723 )
...
* Replace NiaTopLevelNavigation with TopLevelDestination based on #186
* Update ModularizationLearningJourney.md
2 years ago
Simon Marquis
823c4db201
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
...
Continues the work initiated in #738 .
Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.
2 years ago
Simon Marquis
ae50f3d332
Remove benchmark androidTest task exclusion
...
Task `:benchmark:connectedDemoBenchmarkAndroidTest` is not part of the `connectedDemoDebugAndroidTest` task graph and can therefore safely be removed.
2 years ago
Automerger
98d36450ff
Merge branch 'github/main'
2 years ago
Don Turner
a03307e14d
Merge pull request #738 from SimonMarquis/patch-5
...
Grant `POST_NOTIFICATIONS` permission in instrumented tests
2 years ago
Don Turner
f87e769b7d
Merge pull request #681 from SimonMarquis/di/coroutine-scope
...
Add Application-wide `CoroutineScope` in the DI graph
2 years ago
Simon Marquis
cefac16445
Manually accept Android licenses instead of relying on third party action
2 years ago
Automerger
61baaf6d59
Merge branch 'github/main'
2 years ago
Don Turner
b91773d053
Merge pull request #736 from SimonMarquis/patch-3
...
chore(deps): update android-gradleplugin to v8.0.1
2 years ago
Don Turner
fa2ae96625
Merge pull request #737 from SimonMarquis/patch-4
...
Update `BookmarksGrid` horizontal spacing to fix #732
2 years ago
Don Turner
0158bff856
Merge pull request #739 from SimonMarquis/patch-6
...
Update benchmarks module minSdk to 28
2 years ago
Don Turner
5b5707831c
Merge pull request #695 from SimonMarquis/ci/androidTest-GMD
...
Improve `androidTest` step of `AndroidCIWithGmd` worflow by pre-packaging apps before spawning the emulator
2 years ago
Don Turner
ec2471c842
Merge pull request #710 from SimonMarquis/SimonMarquis-patch-1
...
Add missing steps in `AndroidCIWithGmd.yaml`
2 years ago
Simon Marquis
a93cce92f7
Update ForYouScreenTest.kt
2 years ago