nowinandroid

Commit Graph

Author	SHA1	Message	Date
Simon Marquis	d56e06e676	Merge Android & JVM plugins into a single `HiltConventionPlugin`	6 months ago
Simon Marquis	3dbca86a37	Merge remote-tracking branch 'origin/main' into jvm-alt	6 months ago
Don Turner	a5025390af	Add title to READMEs to describe the dependency graph Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528	9 months ago
Don Turner	80a82de945	Update module dependency graphs and add script to create them Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31	10 months ago
Don Turner	522efac8c0	Update Compose BOM to 2024.02.00. Fixes #1218 Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b	10 months ago
Simon Marquis	e629d5e4bf	Merge branch 'main' into jvm-alt	11 months ago
Simon Marquis	61c7d71870	Migrate `:core:common` to pure JVM module The notification icons are now stored in `:core:notifications`. This forces `:sync:work` to depend on it. Another solution could be to provide the resource id through Hilt, but it would require more changes.	1 year ago
Don Turner	707117a4f2	Merge branch 'main' into kotlinify	1 year ago
Don Turner	0f0511748e	Merge pull request #1088 from SimonMarquis/cleanup-dependencies Reduce overall build complexity	1 year ago
Don Turner	89d39a7242	Merge pull request #767 from SimonMarquis/resource-prefix Enforce `resourcePrefix` on Android library modules	1 year ago
Simon Marquis	f27a2e176e	Reduce overall build complexity - Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`	1 year ago
Simon Marquis	caa482bc71	Kotlinify codebase - Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)	1 year ago
Don Turner	a381d13199	Merge pull request #958 from McGalanes/main Use typesafe project accessors	1 year ago
Melwin Magalhaes	6247712064	Add convention plugins to version catalogs	1 year ago
Melwin Magalhaes	b1266dc05a	Use typesafe project accessors for project modules	1 year ago
Simon Marquis	b2cd980170	Merge remote-tracking branch 'origin/main' into resource-prefix	1 year ago
Simon Marquis	ebfe01affd	Enforce `resourcePrefix` on Android library modules ``` :ui-test-hilt-manifest -> ui_test_hilt_manifest_ :core:analytics -> core_analytics_ :core:common -> core_common_ :core:data -> core_data_ :core:data-test -> core_data_test_ :core:database -> core_database_ :core:datastore -> core_datastore_ :core:datastore-test -> core_datastore_test_ :core:designsystem -> core_designsystem_ :core:domain -> core_domain_ :core:network -> core_network_ :core:notifications -> core_notifications_ :core:testing -> core_testing_ :core:ui -> core_ui_ :feature:bookmarks -> feature_bookmarks_ :feature:foryou -> feature_foryou_ :feature:interests -> feature_interests_ :feature:search -> feature_search_ :feature:settings -> feature_settings_ :feature:topic -> feature_topic_ :sync:sync-test -> sync_test_ :sync:work -> sync_work_ ```	1 year ago
Simon Marquis	a33dafccad	Migrate from `java` to `kotlin` sourceSet directory	1 year ago
Don Turner	492697ce6b	Merge pull request #873 from SimonMarquis/misc-warnings Fix miscellaneous warnings	1 year ago
Don Turner	8901e5932a	Merge pull request #872 from SimonMarquis/data-objects Convert 'sealed' sub-object to 'data object'	1 year ago
Simon Marquis	e8449112b4	Replace StringDecoder injection with simpler API The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String. For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`). Unit tests would fail because Uri is not mocked (since we are not using Robolectric). Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc. FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded". The solution to this problem was to simply use regular Java APIs: - `URLDecoder.decode(urlEncodedTopicId, "UTF-8")` - `URLEncoder.encode(topicId, "UTF-8")`	1 year ago
Simon Marquis	4bdc9705af	Fix miscellaneous warnings - Remove unused namespace declaration - Collapse empty manifest tags - Remove redundant qualifier name - Remove redundant suppression	1 year ago
Simon Marquis	b7799f0475	Convert 'sealed' sub-object to 'data object'	1 year ago
Don Turner	4cdb5963a0	Add top level application scope, use IO dispatcher for DataStore Change-Id: I1512b1665587c73abd5e8a78aa9abd3eed24ab79	2 years ago
Simon Marquis	5a43b4b74e	Run Spotless	2 years ago
Simon Marquis	aa701064a2	Add Application-wide `CoroutineScope` in the DI graph Following the work of #607.	2 years ago
James Rose	bd450099fb	Replace GetUserNewsResourcesUseCase with UserNewsResourceRepository This moves the responsibility for joining the UserData and the NewsResources to UserNewsResourceRepository. This way, the work can be done once and shared with all consumers in a SharedFlow, rather than having each consumer perform the join itself by invoking the UseCase.	2 years ago
Márton Braun	819dd494ad	Run Spotless to add trailing commas (and apply other rule updates) Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209	2 years ago
Simon Marquis	90dc300783	Migrate from JUnit assertions to Kotlin's test framework Fixes #419	2 years ago
Manuel Vivo	a0b22d8ed2	Updates Navigation approach with new guidance (#347 )	2 years ago
Wojtek Kaliciński	dcc23829d4	Migrate packages to namespaces in build files Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5	2 years ago
Milosz Moczkowski	06e60063b5	Add dependency graphs to every module Change-Id: I629fef818f7521c13bb3069a3ff9ed9bc42e57f3	2 years ago
Wojtek Kaliciński	4683918cc7	Move spotless to init script Also adds automatic git hooks installation Change-Id: I18debbee43af27db7b95a4202f824fa87e186713	2 years ago
Wojtek Kaliciński	d0cff2b11c	Build cleanup * Move Hilt setup to convention plugin * Disable Hilt on modules where it's not needed * Enable non-transitive R classes * Fix `configuration` blocks called in wrong scope * Move imperative Flavors code from build.gradle * Disable unnecessary build features globally * Disable configure-on-demand as it's not encouraged * Don't use internal AGP packages in plugins Change-Id: I1bee3e3fd0103054637b979a350f9fd2312ae8ba	2 years ago
madroid	3bd81154b5	Move 'core-' module to core subfolder	2 years ago

35 Commits (d66cc776a7a85b8951212ea9c1efb63e015fc79c)