f03c06163e
Add NavigationSuiteScaffold
...
Change-Id: I36710d880bff381ed86c61632f2ab91902727775
1 year ago
74fead944a
Merge branch 'main' into replace-testharness
1 year ago
bfcea73e3c
Adds screenshot tests for snackbar ( #1343 )
...
* Adds screenshot tests for snackbar
Change-Id: I81566e3301fb17e3f31cbc408e6cc3325eab5a12
* Small tweaks, RFR
Change-Id: Ia16db6e6f5bec2714081b5ceaeeba36b2ee26105
* 🤖 Updates screenshots
* Update NiaApp.kt
Adds modifier to NiaApp
1 year ago
7a9355482b
Remove forgotten Trace.endSection()
...
Change-Id: Ib6f7678f5f1c4b0f93f1736b6453c649d6f7dc97
1 year ago
5b1ba07f99
Offload connectivity monitor to a background thread
...
Change-Id: I9a2ef7766ae6abc6d8a7c86a4b49ef3c795e446c
1 year ago
6a5041d746
🤖 Updates screenshots
1 year ago
369c271b50
Merge branch 'main' into replace-testharness
1 year ago
34540c4d01
Lower visibility of some dependencies
1 year ago
29e5551589
Merge pull request #1284 from sanao1006/remove-GetSearchContentsCountUseCase
...
Directly call SearchContentsRepository interface in SearchViewModel
1 year ago
3eef22be71
Merge pull request #1314 from squart300kg/main
...
clean up di module in core.database package
1 year ago
0639b375f1
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
1 year ago
66c5335e0f
Merge pull request #1306 from yongsuk44/feat/weak-warning
...
Cleaned up unnecessary '@opt-in' annotations and removed empty constructors
1 year ago
4fc5e67d30
Merge pull request #1291 from Jaehwa-Noh/rename
...
Rename Fake to Demo
1 year ago
c336537a43
clean up di module in core.database package
1 year ago
5dcf769031
Remove empty primary constructors
1 year ago
8e9b39fa31
Remove unnecessary opt-in annotations
1 year ago
77da15f57d
Change name Fake to Demo.
...
Change-Id: Ife321dd95238227bfdfc1f13f6832472bd699b6f
1 year ago
bcdc1a322e
Delete unused `combine` extension in `SyncUtilities.kt`
2 years ago
c04ffa8bf8
Change lint ignore name in lint.xml.
...
Change-Id: I3b1e19dedd238ec96bd8debee5fcbcc91bc25094
2 years ago
2e039d3f0d
Revert "Move main to demo."
...
This reverts commit a5be299e3d
2 years ago
6f468d66fd
Move main to demo.
...
Change-Id: I48bb3c26ef02d6302cb7caabcaa17d5b4659031a
2 years ago
d8f2ef1def
Remove VisibleForTesting.
...
Change-Id: Icd7005ec38495a1a4bc6f1594f70a2c1228538ab
2 years ago
c975be2f07
Rename fake to demo.
...
Change-Id: I5b1d7963e623832a766900aa74ef1085aac0cacc
2 years ago
09c8b46855
Merge branch 'main' into remove-GetSearchContentsCountUseCase
2 years ago
5a38b9465a
Merge pull request #1271 from android/dt/remove-feature-dep
...
Remove the search module's dependency on other feature modules
2 years ago
37e776771d
[Refactor]: Directly call SearchContentsRepository interface in SearchViewModel
...
- Remove GetSearchContentsCountUseCase.
- Remove GetSearchContentsCountUseCase from SearchViewModel.
- Remove GetSearchContentsCountUseCase from SearchViewModelTest.
Fixes #1283
2 years ago
055ed3cc5c
Merge pull request #1275 from Jaehwa-Noh/rename-function
...
Rename function to setNewsResourceBookmarked
2 years ago
6da850d28a
Remove the search module's dependency on other feature modules
...
Change-Id: I17df9948fed04ddc7ba507b437d39536b8b180bb
2 years ago
315c284be2
Merge pull request #1257 from android/dt/add-module-graphs
...
Update module dependency graphs and add script to create them
2 years ago
7415ae3b46
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
2 years ago
114ab5a713
Fix typo.
...
Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f
2 years ago
8f46eb84ae
Fix #1270
...
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
2 years ago
37422cc12d
Add graph for screenshot testing module, minor update to script
...
Change-Id: I611f73d59790bde240756e8016aa721a1783335f
2 years ago
d49cc4e5bb
Add @After to guarantee DB was closed. ( #1240 )
...
* Add @After to guarantee DB was closed.
Change-Id: Ic29b7d12125853c71ddaef1a997ec123bb2dfc8b
* Fix spotless
- style
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
---------
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
2 years ago
2004c9abca
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
2 years ago
7196156718
Merge branch 'main' into replace-testharness
...
* main: (37 commits)
Disable animations of instrumented tests (#1167 )
Bump gradle/wrapper-validation-action from 1 to 2
Remove unused release variable. Fixes #1231
Apply Composable Parameter Ordering Guidelines
Remove kotlinx-coroutines-guava dependency from :sync:work
Add explicit guava-android dependency for :sync:work
Extract ScreenshotHelper to separate testing module
Update AGP to 8.3.0
Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert.
🤖 Updates baselines for Dependency Guard
Bump the kotlin-ksp-compose group with 6 updates
🤖 Updates baselines for Dependency Guard
Bump hilt from 2.50 to 2.51
Bump com.google.truth:truth from 1.1.5 to 1.4.2
Move java to kotlin folder.
Remove disk usage testing
Figuring out what is using 66Gb in the runner
Dpm
Improve converting to kotlin timezone
Use trySend multiple times
...
Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a
2 years ago
6db4f519b2
Merge pull request #1182 from SimonMarquis/api-compose-ui-tooling
...
Move `androidx.compose.ui:ui-tooling` dependency to convention plugin
2 years ago
951bd07490
Merge pull request #1144 from SimonMarquis/move-fakes-to-data-test-module
...
Move `:core:data` fake repositories to `:core:data-test`
2 years ago
f7646a5a2e
Merge pull request #1248 from yongsuk44/main
...
Apply Composable Parameter Ordering Guidelines
2 years ago
5dc1dd790b
Merge pull request #1247 from Jaehwa-Noh/remove-unused-function
...
Remove Insert function
2 years ago
314f8a6e7b
Apply Composable Parameter Ordering Guidelines
...
Change-Id: Id456e91b5ce8bd5807c40df67c3deac008c61670
2 years ago
a4c0842d73
Extract ScreenshotHelper to separate testing module
...
Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af
2 years ago
1ff2722d2e
Remove Insert function
...
- Insert is only used in test.
- Upsert do same thing as Insert.
Change-Id: Ib5f8e693e71c895b83e43f6b51cebdc698bf744b
2 years ago
8f89ca6cbb
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Id49a580012629163ec4a3663d95ab71b98910220
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
# gradle/libs.versions.toml
2 years ago
ec8786e168
🤖 Updates screenshots
2 years ago
137a8a78a6
Replace Accompanist TestHarness with DeviceConfigurationOverride
...
Change-Id: I6742d5e221f86a019f44d3e623609bf76d2a3a2a
2 years ago
e1d10d5a54
Update Compose BOM to 2024.02.00. Fixes #1218
...
Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b
2 years ago
d61affe324
Merge remote-tracking branch 'origin/main' into move-android-instrumented-test
2 years ago
1634aff29f
Merge remote-tracking branch 'origin/main' into jvm-alt
2 years ago
554f50ac8a
Merge remote-tracking branch 'origin/main' into move-fakes-to-data-test-module
2 years ago
b3ff8aa940
🤖 Updates screenshots
2 years ago
1e14339924
Fix individual UI components
...
Change-Id: I7dec3672b9efc3524371811743b06efc1e113a36
2 years ago
5c83771326
🤖 Updates screenshots
2 years ago
a04a43d5cf
Fix spotless (really should enable the commit hook to do this)
...
Change-Id: I68cb9bd989a809e5db1bca3157c2c978ad8c8906
2 years ago
502edda0b7
Fix text styles and spacing now that includeFontPadding is false
...
Change-Id: I6894836a7cd3a6139511a5d1ac0a96702a265186
2 years ago
1c9c47fda4
🤖 Updates screenshots
2 years ago
d07783be5d
Revert fontSize change
...
Change-Id: I4011205f8a07c418653ee463d7355fe1e4ff6f44
2 years ago
811bdf801b
Fix spotless (again)
...
Change-Id: If6b292af514df435d7bd233bd634657904c67d6b
2 years ago
e04cb4e00d
Merge branch 'main' into update-compose-bom
2 years ago
3ab68c72ea
Merge pull request #1040 from SimonMarquis/fix-unit-test
...
Fix `emptyResultIsReturned_withNotMatchingQuery` unit test
2 years ago
9fc80d8611
Remove includeFontPadding, default behaviour is fine
...
Change-Id: I334c5a488c1e2a2b49670a97b16385a7df1791c8
2 years ago
7737a83eb9
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt
2 years ago
77bb7f95d1
🤖 Updates screenshots
2 years ago
82b15d38f1
Switch default padding to true since this was actually false by default since Compose 1.6.0-alpha01
...
Change-Id: Ifd291b247f848cea43e084cc0fb99917e47e26eb
2 years ago
e750cdda90
Switch off default font padding to avoid changing UI
...
Change-Id: Ida974df8fd4b1aba6f9525ef5335a6cbe02ddb18
2 years ago
954afd6810
Fix ShortText icon
...
Change-Id: I8b243ef88c1cc8be83f5fbeaee6a2576c453a062
2 years ago
4a1015287d
🤖 Updates screenshots
2 years ago
f5ccb99e8a
Update Compose BOM to 2024.02.00. Fixes #1218
...
Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b
2 years ago
226ef1ac25
Add comment for Retrofit async OkHttp
...
Change-Id: Ic7a6887b76caf26f00b58b0753271d426b67e75b
2 years ago
f4dc167da2
Optimize OkHttp initialization for Retrofit
...
Change-Id: I347f1080ab5adf774a0cdd3c659cbf25c4820f9a
2 years ago
41b576d294
Improve lazy loading for Coil + OkHttp
...
This way, we can load Coil's backend on a background thread and not block the MainThread with it.
Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames.
Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62
2 years ago
8e959e9803
Improve converting to kotlin timezone
...
Change-Id: I2af929c341cb274ae6b93bb8dffe696de6ed1c63
2 years ago
77d4f5f57f
Use trySend multiple times
...
Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032
2 years ago
37af179716
Move `:core:data` fake repositories to `:core:data-test`
...
Now that these fake implementations are no longer used in the production source code (only in tests), we can safely extract them out of this module.
Hopefully, we'll later be able to use Kotlin testFixtures for that.
References:
- #709
- #875
2 years ago
e3a0f119c3
Merge branch 'main' into jvm-alt
2 years ago
251b1bbc2c
Use androidx.tracing everywhere
...
Change-Id: I9a77c4434d271e2e23700823f9f513aa61d177f8
2 years ago
e208bd0bfd
Use kotlinx.datetime.Timezone instead of java ZoneId
...
Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628
2 years ago
7a5df77bc3
Replace comments with proper `@TestOnly` annotations
2 years ago
17b006ed43
Fix addNewsResources issue
2 years ago
e4917b1332
Fix `emptyResultIsReturned_withNotMatchingQuery` unit test
...
`searchResultUiState` transitively relied on `getSearchContentsCount` updates and on `userDataRepository` to emit something.
2 years ago
6c7a136de2
More readable zoneId creation
...
Change-Id: I912dc021554e4886a5d09e63799aa5c81e8fd16a
2 years ago
e19d435317
Rename LocalTimeZone -> LocalZoneId + collects with lifecycle
...
Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3
2 years ago
64a325ae6c
Conflate TimeZoneMonitor emissions
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
2 years ago
fa16457b5e
Fix spotless
...
Change-Id: I6583fa9ed7c1563f6164653be9bbaf7904ec0215
2 years ago
c432f74054
Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers
...
This way, we can save ~1ms per composed item on screen.
Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d
2 years ago
c307446e69
Move `androidx.compose.ui:ui-tooling` dependency to convention plugin
2 years ago
ecd7b035c7
Merge pull request #785 from SimonMarquis/optimize-avd
...
Optimize AVD to fix long vector paths Lint warning
2 years ago
c3bb7ce4b5
Merge branch 'main' into firebase-ktx
2 years ago
ae55eb8e1a
Optimize AVD to fix long vector paths Lint warning
...
... with SVGOM, but you'll have to check on Android Studio the AVD diff.
https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html
2 years ago
35caa8547c
Merge branch 'main' into move-android-instrumented-test
2 years ago
de331fafb5
Apply suggestions from code review
2 years ago
987b534f1c
Migrate `:core:common` to pure JVM module
...
The notification icons are now stored in `:core:notifications`.
This forces `:sync:work` to depend on it.
Another solution could be to provide the resource id through Hilt, but it would require more changes.
2 years ago
62a0f1c84e
Prep work for JVM alternatives to modules/plugins
2 years ago
4843216871
Merge branch 'main' into kotlinify
2 years ago
305f049429
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
2 years ago
6cd965d70c
Replace `Enum.values()` with `Enum.entries`
...
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
2 years ago
137944ab9a
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
2 years ago
dad6f3dcdc
Update core/designsystem/src/main/kotlin/com/google/samples/apps/nowinandroid/core/designsystem/component/scrollbar/ScrollbarExt.kt
...
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
2 years ago
e4991aff96
Merge branch 'main' into kotlinify
2 years ago
2e663d3572
Merge branch 'main' into kotlinify
2 years ago
d7727f1cac
Ignore function naming check when annotated with @Test
2 years ago
97ecd911c5
Suppress ktlint:standard:function-naming in ResultKtTest
2 years ago
9dac5b80c3
Move @Suppress("ktlint:standard:max-line-length") to function scope
2 years ago
5aa9122f08
Remove violations: property-naming
2 years ago
402ca7d782
Remove violations: discouraged-comment-location
2 years ago
5e965962c5
Spotless
2 years ago
171e2e83f5
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
2 years ago
7bdf942a47
Merge branch 'main' into firebase-ktx
2 years ago
907be7d667
Update thumbTrackSizePercent calculation for readability
...
Change-Id: I7ef067a950b4b5911b8c2e6a8c1f72c3e95d938d
2 years ago
cc6677872d
Update thumb movement range by thumb size, in app scrollbars
...
Change-Id: I4438debd5037965a837758e0c78b110ab8197da5
2 years ago
20002b25ed
Merge pull request #1067 from android/ben/itemstate
...
Remove redundant mutable state in NewsFeed
2 years ago
58567379dc
Fix typo in app scrollbars
...
Change-Id: Ie72f1410fa8e5a68a520321c34d4fad251016486
2 years ago
1d65b7b702
Remove redundant mutable state
2 years ago
41a7a697da
Apply spotless
2 years ago
a7c7b520a4
Use custom Modifier.Node instead of background
2 years ago
6a95579954
Move state into a state holder and remove redundant Box
2 years ago
a142660048
Move scrollbar changes out of composition
2 years ago
4c8e0319ee
spotless
2 years ago
6d93ce5ead
Firebase: Migrate to using the Kotlin extensions (KTX) APIs in the main modules
...
https://firebase.google.com/docs/android/kotlin-migration
Requirements: Firebase BoM 32.5.0, but let's update to the latest 32.6.0.
And remove warnings:
- `'logEvent(String, ParametersBuilder.() -> Unit): Unit' is deprecated. Migrate to use the KTX API from the main module: https://firebase.google.com/docs/android/kotlin-migration .`
- `'param(String, String): Unit' is deprecated. Migrate to use the KTX API from the main module: https://firebase.google.com/docs/android/kotlin-migration .`
2 years ago
6a3a5ea692
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
2 years ago
8d0b893459
Update Robolectric 4.11.1
...
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1
> Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below.
Removing explicit API 33 Robolectric configuration.
2 years ago
142a37cd94
Move Android instrumented test `ThemeTest` to unit test
2 years ago
20129f083b
Update to Hilt 2.48.1 and use the KSP version
...
* Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin.
* `@Binds` function cannot be an extension function.
* Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.
2 years ago
137a5de28c
remove ktx import from FirebaseAnalyticsHelper.kt
2 years ago
9d43ecfdb9
Update MainDispatcherRule.kt
...
Updated MainDispatcherRule parameter accessibility to private because its only needs to be accessible inside that class.
2 years ago
bbcabea220
Fix formatting issues
...
Change-Id: Ia90a4aad72db737455b70de9b4583689d6a0e5d6
2 years ago
9abc0cc2d4
upgrade to Firebase BoM 32.5.0 and drop Firebase KTX
2 years ago
53d8bef434
Merge pull request #972 from tjmtic/now-update-888
...
Update primitive mutable states to mutableState API where applicable
2 years ago
45b11a0571
fixed for PR 985
2 years ago
0d31a62bbd
Merge remote-tracking branch 'upstream/main' into now-update-888
2 years ago
c85e361ef9
Fix compiler warning: Remove single lambda parameter declaration
2 years ago
27dd4e66ad
Merge pull request #947 from android/tj/staggered-grid-feed
...
Use lazy vertical staggered grid in feed to maximize space utilization
2 years ago
190189b7e4
Update compose-runtime version; Update primitive mutable states to mutableState API where applicable
2 years ago
3d85cd06d0
Merge pull request #958 from McGalanes/main
...
Use typesafe project accessors
2 years ago
97933b1686
Merge pull request #959 from McGalanes/convention-plugins-toml
...
Add convention plugins to version catalogs
2 years ago
0ccd6d2f29
Fix spotless
...
Change-Id: Ia931fc5662af50a6045a51783d72cb5b68e2486a
2 years ago
401b42388a
Address PR feedback
...
Change-Id: I50b49d3e216535e384b64849f915b37f6e2acbbc
2 years ago
6628ddfdaf
Merge pull request #912 from lihenggui/main
...
Upgrade Gradle to v8.3
2 years ago
a147118fdd
Fit typo in SystemTrayNotifier.kt
2 years ago
f470be2860
Add convention plugins to version catalogs
2 years ago
d089ccd9d7
Use typesafe project accessors for project modules
2 years ago
738fbc190d
Use animateItemPlacement() on feed
...
Change-Id: Id120a6e84e0641679fa54ebf0e34bb04165aa419
2 years ago
9c8f1256a0
Fix spotless
...
Change-Id: I7ee8bc84beb38d00983aa7b0da3f3073e1249992
2 years ago
768c484090
Use lazy vertical staggered grid in feed to maximize space utilization
...
Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926
2 years ago
79bb3b9edf
Merge remote-tracking branch 'origin/main' into resource-prefix
2 years ago
415e35c35e
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
2 years ago
2bbb982b3a
Migrate from `java` to `kotlin` sourceSet directory
2 years ago
ff9f38198f
Adds screenshot tests to :core:designsystem ( #931 )
...
* WIP: Adds screenshot tests to :core:designsystem
Change-Id: I0672845feba4064652dd8d60f07047b87864e121
* 🤖 Updates screenshots
* Creates tests for more components and cleans up
Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22
* WIP: More cleanup and more combinations of themes
Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523
* Added the rest of the screenshot tests for designsystem
Change-Id: Ic427db5491910781c038882055524e3f3dbed194
* Some more cleanup
Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180
* Spotless
Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6
* 🤖 Updates screenshots
* ScreenshotHelper cleanup
Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0
2 years ago
a2c0450965
Merge pull request #925 from SimonMarquis/remove-dispatcher
...
Remove unnecessary dispatcher switch in `DefaultRecentSearchRepository`
2 years ago
7f5a8619fe
Remove unnecessary dispatcher switch in `DefaultRecentSearchRepository`
...
As mentioned in the following discussion: https://github.com/android/nowinandroid/discussions/818
Room already takes care of switching dispatchers if the DAO method is correctly annotated with the `suspend` modifier.
2 years ago
Alex Vanyo
Don Turner
Jose Alcérreca
Tomáš Mlynarič
Simon Marquis
sangyoon
yongsuk44
Jaehwa Noh
sanao1006
Don Turner
kim-yongsuk
lihenggui
Yuya
Ben Trengrove
dahunsi
Ben Trengrove
Daniel Santiago
rosariopf
Mario Manhique
Adetunji Dahunsi
Jonathan Koren
TM
Minseong Kim
Melwin Magalhaes
Simon Marquis