Don Turner
2646c43f1c
Spotless
3 years ago
Don Turner
49e47685bd
Fix merge conflicts
3 years ago
magicalmeghan
f4c2a2b138
Added third draft of tests
3 years ago
magicalmeghan
1c8bfea3d8
Added second draft of tests
3 years ago
magicalmeghan
7776ccce6c
Added second draft of tests
3 years ago
Alex Vanyo
4eda902d63
Merge pull request #491 from android/av/fix-background-composable
...
Updated background composable for gradient
3 years ago
Chris Sinco
857806e294
Spacing polish based on design spec
3 years ago
Don Turner
24b4f5bf23
Merge pull request #504 from android/dt/fix-build-warnings
...
Fix build warnings
3 years ago
Don Turner
222da07c0d
Refactor NiaGradientBackground to accept GradientColors
...
Change-Id: I55840b22e123490097710570bf11554554df90f9
3 years ago
Don Turner
d2035096c6
Merge pull request #493 from andhiratobing/main
...
Set visibility modifier of composable preview to private
3 years ago
Don Turner
a9ee4d1c47
Fix build warnings
3 years ago
magicalmeghan
802d984300
Added first draft of tests
3 years ago
magicalmeghan
cb28fa3409
Renamed SaveableNewsResource to UserNewsResource
3 years ago
Don Turner
ed2df9c379
Fix unit and UI tests. Apply spotless.
...
Change-Id: Iab75852a27a44309d349f84e65226911ab59fcd5
3 years ago
magicalmeghan
a25ad9c017
Renamed SaveableNewsResource to UserNewsResource
3 years ago
magicalmeghan
664a827d55
Renamed SaveableNewsResource to UserNewsResource
3 years ago
Nick Rout
a7d2b134c5
Merge pull request #492 from ricknout/main
...
Fix issues with NiaTheme gradients and backgrounds
3 years ago
ratobing
dd96befa17
Set visibility modifier of composable preview to private
3 years ago
Nick Rout
70a321cfa5
Fix issues with NiaTheme gradients and backgrounds
3 years ago
Nick Rout
13ef87dc5a
Merge pull request #485 from ricknout/main
...
Update :core-designsystem module based on Figma file
3 years ago
Nick Rout
6e0ab61410
Address design system PR feedback
3 years ago
Nick Rout
4f862d79a8
Fix ThemeTest
3 years ago
Nick Rout
59f95072e5
Fix ThemeTest
3 years ago
Nick Rout
fba50729cb
Fix spotless issues
3 years ago
Nick Rout
adb302520f
Fix spotless issues
3 years ago
Nick Rout
37611fae12
Update :core-designsystem module based on Figma file
3 years ago
Caren
597bd97439
Merge pull request #476 from android/caren/resource_type
...
Display resource type for each news resource
3 years ago
Caren
919801245a
Rename NewsResourceDataAndType -> NewsResourceMetaData
...
Change-Id: Ide67bb9adf740d9cf0bba58f369688f91e0eb85f
3 years ago
Caren
6adb6b72ce
Fix tests
...
Change-Id: Ie1e2408ea523e6ddc0941fe261fce7f2502e3416
3 years ago
Caren
74a8da0448
Merge pull request #465 from android/caren/custom_chrome_tab
...
Use Chrome Custom tab for opening articles
3 years ago
Caren
61110b9aa3
run spotless
...
Change-Id: Ieb751d960ade646dfe35ed7d2ca039e3b8f38ba7
3 years ago
Caren
8831e49e27
Add test and add string template in strings.xml for RTL purposes
...
Change-Id: I1bce9ac7534f376a9626cac2c50e1bcc7620cf61
3 years ago
Caren
00a75bc3fe
Rename NewsResourceDateAndNewsType -> NewsResourceDateAndType
...
Change-Id: I535c62f3317d6ada882a08235c0c4465d9963201
3 years ago
Caren
234d451021
Display resource type for each news resource
...
Change-Id: Ib33ffd0e9b87ec91d2ee4316a4e3dbf70bb5cfc9
3 years ago
mlykotom
b13096140c
Add niaTopAppBar testTag
...
Change-Id: I02a207675e106137fe005140965c96f1b50f98ce
3 years ago
mlykotom
77d45811c3
LoadingWheel testTag for every loading wheel
...
Change-Id: I7728e1717925abdfb607e93f3d48226910d42c0d
3 years ago
Caren
3c7ab45da4
Add ColorInt annotation
...
Change-Id: If6ea8e4c3a09c6de932797ddcb64bbfff1e52ede
3 years ago
Jolanda Verhoef
a09612ec80
Remove author concept from app
...
Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793
3 years ago
Caren
d419b3f5f7
Run spotless
...
Change-Id: I1deee3c9b38d352afca0f646366598e32710ffca
3 years ago
Caren
227fb0b1b6
Implement custom chrome tabs in NewsResourceCardList as well
...
Change-Id: Ie5851666117a7c756b3d9ad02d6e17be0d3ba904
3 years ago
Caren
6116f679a5
Use Chrome Custom tab for opening articles
...
Change-Id: I0024038f918a18d3c3e803587a7e1c159bfb9169
3 years ago
Márton Braun
8e5fc3e03e
Remove `Stream` suffixes
...
Change-Id: I45decae965d7e35289d3fa31fc58b8c463fbead1
3 years ago
Marek Rzeźniczek
c3bc7f1545
Migrate core:domain namespace to build.gradle file
3 years ago
Milosz Moczkowski
b55f3e2f9e
Merge pull request #441 from android/refactor/remote_fake_data_source
...
Remove FakeDataSource
3 years ago
Mohsen Rzna
34b41d84fc
New empty bookmarks handling ( #443 )
...
* Added the png file for error state
This should be removed later - couldn't convert the design to vector from svg - there is a problem with the `<mask` tag.
* Added two new strings based on the Figma file
* Redesign and reimplementation for the empty BookmarksScreen along with two clarifying comments.
* Removed the png file and replaced it with vector
* Code refactor after code reviewing
Made contentDescription null, removed extra spaces and renaming for the Composable function as suggested.
* Moved the modifier after Text
* Added a space after the curly bracket to pass the Spotless check
* Spotless apply
* Simplify logic in Bookmarks screen
* Change order of composables in BookmarksScreen and add previews
* Refactor after code review
Removed the space before `if`, and changed the padding from 5 to 8dp.
Co-authored-by: Jolanda Verhoef <JolandaVerhoef@users.noreply.github.com>
3 years ago
Simon Marquis
7797faee25
Configure `isReturnDefaultValues` for `:core:datastore`
3 years ago
Simon Marquis
8a720477dc
Configure `isReturnDefaultValues` to fix #448
3 years ago
Don Turner
b0e01316c7
Fix comment
3 years ago
Adetunji Dahunsi
145b0782db
Check active network for connectivity state each time network changes
...
Change-Id: I5d3eb0251f62a57a5767911167067d35aeec8e6a
3 years ago
Miłosz Moczkowski
f906e6b42c
Spotless apply
...
Change-Id: Iaf82b44487f001417265ad97acfe6eea8dd6a78f
3 years ago
Miłosz Moczkowski
1c1ded4296
Replace networkJson and FakeAssetManager with FakeNiaDataSource in all repositories
...
Change-Id: Ibeb9fd09bd862000794f41edcddd2cea434a9bb1
3 years ago
Miłosz Moczkowski
5cbdbeead6
Remove FakeDataSource
...
Change-Id: I5e1486feeade67f0f7276458187694e684310ad3
3 years ago
Milosz Moczkowski
8435ed4b77
Merge pull request #179 from Abhimanyu14/niaicons
...
Icons alignment to use NiaIcons
3 years ago
Simon Marquis
4b7d0e26b4
Refactor `:core:network` DI
...
- Delete unused `NetworkModule` from benchmark sourceSet (contains unknowns references)
- Extract common bindings into a single `NetworkModule`
- Expose "flavored" bindings through `FlavoredNetworkModule`s
3 years ago
Simon Marquis
1d63cb4d40
Add missing binding in NetworkModule
3 years ago
Simon Marquis
be30d2869c
Merge remote-tracking branch 'fork/main' into patch/assets-as-json-files
3 years ago
Milosz Moczkowski
6437c77ecd
Merge pull request #431 from SaeedNoshadi89/show-all-news-authors
...
Show all authors in the news card
3 years ago
Saeed Noshadi
4152160b27
replace StringBuilder with joinToString
3 years ago
Saeed Noshadi
16ce94962e
remove unused import
3 years ago
Saeed Noshadi
9902e8ce26
show all authors in the news card
3 years ago
Abhimanyu14
5e4963a48d
Icons alignment to use NiaIcons
3 years ago
Simon Marquis
61bfb85b64
Fix spotless issues
3 years ago
Simon Marquis
7213994b97
Remove duplicated link
3 years ago
Simon Marquis
845e62aca5
Fix lint crash
3 years ago
Simon Marquis
67ebe8de38
Fix spotless issues
3 years ago
Simon Marquis
90a8c6f048
Migrate hard-coded JSON data into JSON assets files
...
JSON minification is no longer necessary since assets files are already gzipped during APK/AAB packaging.
Fixes #391
3 years ago
Simon Marquis
a09ea875b8
Migrate from JUnit assertions to Kotlin's test framework
...
Fixes #419
3 years ago
Don Turner
5b28826e18
Merge branch 'main' into fix/typos
3 years ago
Don Turner
89a18de1e4
Make updateShouldHideOnboardingIfNecessary private
...
Change-Id: I7917b025d258a07604e98950396ec3e119e2d9a7
3 years ago
Simon Marquis
bcc4712cfd
Fix typos
3 years ago
Don Turner
f81c7222e2
Rename hasDismissedOnboarding to shouldHideOnboarding
...
Change-Id: I8a6b35f7216f9944652d8da346e7458614311e08
3 years ago
Don Turner
be88f4f03d
Refactor onboarding to save interests to user data
...
Change-Id: I97772a8b65e1e94a95187ebb7c514104af2d3a08
3 years ago
Don Turner
7413e22377
Add data from the last 10 episodes
3 years ago
Milosz Moczkowski
45d4eabac8
Merge pull request #297 from android/av/remove-dolphin-preview-todos
...
Remove Preview TODOs for Dolphin
3 years ago
Don Turner
b55b4fab9c
Merge pull request #356 from android/jv/compose-bom
...
Update to new Compose release
3 years ago
Jolanda Verhoef
58a3721575
Update to new Compose release
3 years ago
Don Turner
391bc1e900
Fix minor issues
3 years ago
Don Turner
c3bcdd75e0
Address review feedback from Manu
3 years ago
Don Turner
4654e67c23
Added null branches for reading user data from datastore
3 years ago
Don Turner
8cb5216d8e
Add settings module, refactor top bar
3 years ago
Don Turner
f1e15d6b83
Fix spotless issues
3 years ago
Alex Vanyo
e596e76714
Add data logic for theme switcher
...
Change-Id: Ifffadb897de4f6e08f7115103f99c156a7098b70
3 years ago
Manuel Vivo
38670449ee
Updates Navigation approach with new guidance ( #347 )
3 years ago
Automerger
c8976ca191
Merge branch 'github/main'
3 years ago
Ben Weiss
b6204656b8
Merge pull request #328 from android/bw/moreJankstats
...
Add more jank tracking
3 years ago
Ben Weiss
5315d2d957
Add more jank tracking
3 years ago
Don Turner
2468f1bc11
Merge branch 'main' into av/remove-dolphin-preview-todos
3 years ago
Automerger
33e66c2443
Merge branch 'github/main'
3 years ago
Don Turner
b078e3019b
Merge "Add domain layer. See go/nia-domain-layer for details." into main
3 years ago
Don Turner
e223be6ac1
Add domain layer. See go/nia-domain-layer for details.
...
Change-Id: I3f4684005e81fb9c4163bf59c7026dcff6e88dc4
3 years ago
Don Turner
383e2e4ce0
Merge pull request #332 from android/kotlin-1720
...
Update Kotlin to 1.7.20
3 years ago
Wojtek Kaliciński
222f65e9e8
Migrate packages to namespaces in build files
...
Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5
3 years ago
Márton Braun
5090834ef5
Update Kotlin to 1.7.20
...
Change-Id: Ib3ce03b0a1d78e90424f8431f039511c04446a62
3 years ago
Adetunji Dahunsi
d54dabe76b
Merge pull request #311 from yveskalume/main
...
Use @Upsert from Room instead of a custom helper
3 years ago
YvesKalume
05fb700c13
fix failling tests
...
Change-Id: I88b6d80dfb473010f8742890d9f6b17ed153ecc5
3 years ago
Don Turner
9cf5efee98
Merge pull request #310 from android/documentation/dep_graphs
...
Add dependency graphs to every module
3 years ago
YvesKalume
5659033a1c
update : remove unused upsert method.
...
Change-Id: I737c7c0078512594a719fe3966cdd99ead39331f
3 years ago
Adetunji Dahunsi
a31da1785f
Merge pull request #304 from android/tj/sync-ui
...
Offline-first UX improvements
3 years ago
YvesKalume
0390d65f03
update : Use @Upsert from Room instead of a custom helper
...
Change-Id: I21194fda29976e069d5cfc1e083cf48d3dd149fe
3 years ago
Adetunji Dahunsi
c1316a2f23
Give feedback when syncing on ForYouScreen
...
Change-Id: I10a646e8a17f81d96351e69d36f0cb6ccf28e05c
3 years ago
Milosz Moczkowski
2d60785879
Add dependency graphs to every module
...
Change-Id: I629fef818f7521c13bb3069a3ff9ed9bc42e57f3
3 years ago
Márton Braun
558b979d08
Merge pull request #307 from android/update-kotlinx-serialization-optin
...
Opt in to experimental kotlinx.serialization API locally
3 years ago
Márton Braun
e1e195564d
Opt in to experimental kotlinx.serialization API locally
...
Change-Id: Ibc88151f5a8b7a3a82e2c0043839c1cb9e016bcf
3 years ago
Alex Vanyo
0630159e2e
Refine backgrounds and navigation colors
...
Change-Id: I9fd863cc608f21078ab78c39c2c3d227aedbac7c
3 years ago
Alex Vanyo
cdbcf54ba0
Update to material3 1.0.0-beta03 wih built-in insets support
...
Change-Id: I4d07f89d4faa6e3417468ad78acf3fbb161f0797
3 years ago
Milosz Moczkowski
f2c64a1f68
Merge pull request #299 from android/refactor/remove_episodes
...
Remove episodes related code
3 years ago
Automerger
8f3e7f037b
Merge branch 'github/main'
3 years ago
Caren
93630216d7
Merge pull request #288 from android/caren/remove_search
...
Remove Search from top app bar
3 years ago
Automerger
d9c4236d40
Merge branch 'github/main'
3 years ago
Caren
96bd63944a
Merge pull request #272 from android/caren/fix_toggle_buttons
...
Fix toggle buttons interaction when using TalkBack
3 years ago
Milosz Moczkowski
a4553d4cfb
Spotless improvements
3 years ago
Milosz Moczkowski
d7062977d3
Spotless improvements
3 years ago
Milosz Moczkowski
ab8053f087
Remove episodes related code
3 years ago
Automerger
99a14e8e73
Merge branch 'github/main'
3 years ago
Alex Vanyo
556ffce88b
Remove Preview TODOs for Dolphin
...
Change-Id: I35219c7dd6a902c43cd310dcaf8d0e2c2dbdec45
3 years ago
Don Turner
96ed6735be
Merge pull request #294 from dturner/proto-list-to-map
...
Change user data fields to use maps instead of lists.
3 years ago
Don Turner
750c43fb05
Change user data fields to use maps instead of lists.
3 years ago
Takeshi Hagikura
ee27ea6f87
Fix the lint warnings
3 years ago
Takeshi Hagikura
821001cfcc
Introduce Multipreview annotation to simplify the preview configurations
...
- Bump the AGP version to 7.3.0
- Introduce Multipreview annotation class that represents device
previews and theme previews
Fixes #282
3 years ago
Caren Chang
664510c652
Fix toggle buttons interaction when using TalkBack
3 years ago
Caren Chang
470cccb7db
Remove Search from top app bar
3 years ago
Wojtek Kaliciński
79de18507a
Move spotless to init script
...
Also adds automatic git hooks installation
Change-Id: I18debbee43af27db7b95a4202f824fa87e186713
3 years ago
Wojtek Kaliciński
70ff3831a2
Build cleanup
...
* Move Hilt setup to convention plugin
* Disable Hilt on modules where it's not needed
* Enable non-transitive R classes
* Fix `configuration` blocks called in wrong scope
* Move imperative Flavors code from build.gradle
* Disable unnecessary build features globally
* Disable configure-on-demand as it's not encouraged
* Don't use internal AGP packages in plugins
Change-Id: I1bee3e3fd0103054637b979a350f9fd2312ae8ba
3 years ago
madroid
40efeed4ed
Move 'core-' module to core subfolder
3 years ago