596a036dcc
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
2 years ago
9adac89946
Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
2 years ago
9abe814915
Merge branch 'android:main' into loading-progress-for-image
2 years ago
eecf95eaf7
fix formatting
2 years ago
b291ac5f38
feat: replacing SubcomposeAsyncImage as its not recommended to use with lazyLayout
2 years ago
54ad808e74
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
2 years ago
28c9412cc9
Convert 'sealed' sub-object to 'data object'
2 years ago
64365f818a
feat: make painter in one line
2 years ago
86c51d369c
Merge branch 'android:main' into loading-progress-for-image
2 years ago
a132e331bc
Typo fix for topics
...
tocpis -> topics
2 years ago
ef7141d361
fix: review notes
2 years ago
13fe767fb9
feat: fix format issue
2 years ago
3e04a65ca4
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
2 years ago
51c007c51c
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
2 years ago
acc5942978
Merge remote-tracking branch 'origin/main'
2 years ago
e33036f039
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
2 years ago
39244db2d8
Allow localised date format
2 years ago
43c087d7aa
Add named arguments
...
Change-Id: Ic91ae4fc04bf8eb92c3e5845c7e984475526ec91
2 years ago
f5a5811506
Add contentType to news feed
...
Before
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5
frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
After
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2
frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef
2 years ago
da09e124a7
Refactor icons
2 years ago
31dd5ecf59
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
2 years ago
8645c1bbff
added comment to document what happens on tapping news resource card.
2 years ago
c65cbc6c2a
added back launchCustomChromeTab()
2 years ago
4e658ac537
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
...
1. removed the unused onItemClick parameter
2. removed now redundant variables it used
3. removed its description from the comments.
2 years ago
61db05b707
Implement search feature ( #685 )
...
Implement search feature
- Add a feature module named "search"
- Add a SearchScreen that is navigated by tapping the search icon at the top left corner
- Add a data layer that takes care of populating the *Fts tables and querying them by a search query
- Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen
The SearchScreen has following features:
- The user is able to type the search query in the TextField
- The search result is displayed as the user types
- When the search result is clicked, it navigates to:
- The InterestsScreen when a topic is clicked
- Chrome custom tab with the URL of the clicked news resource
- When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches
- Latest recent searches are displayed in the SearchScreen
2 years ago
bb973872c7
Merge branch 'main' into jr/track-viewed
2 years ago
2ffe3af41c
Merge pull request #575 from takagimeow/fix/provide-true-to-local-inspection-mode
...
Provide true to LocalInspectionMode
2 years ago
dd3c6827d2
Merge pull request #600 from takagimeow/cleanup-unused-args
...
Remove newsResourceTitle from AnalyticsHelper.logNewsResourceOpened method
2 years ago
c6c600dd82
Merge pull request #624 from SimonMarquis/gradle-sort
...
Sort and group Gradle dependencies
2 years ago
577fdc790c
Fix trailing commas based on spotless check
3 years ago
738325af29
Merge branch 'main' into ui-polish
3 years ago
317f47c3cf
Incorporate code review changes: Move UserNewsResourceRepository to data
...
module; move UserNewsResource to model module. Implement unread dot for
bookmarked articles. Keep the flows cold in UserNewsResourceRepository.
3 years ago
3d7b71963c
Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
3 years ago
b1286ca188
Display unread state on the news feed and bottom nav bar
...
When a news resource is unread, display a dot on its card in the news
feed. When the For You section has unread resources, display a dot on
its icon in the navigation bar.
Update the read status when a resource is opened.
3 years ago
b8fc2c9302
Add viewed status for news resources to data layer
3 years ago
a1dae8c858
remove newsResourceTitle
3 years ago
30759e68db
Merge branch 'main' of github.com:takagimeow/nowinandroid into fix/provide-true-to-local-inspection-mode
...
Conflicts:
core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt
3 years ago
3d6ca9b7d8
Merge remote-tracking branch 'github/main' into feb9automerger
...
* github/main:
Bump version to 4
Remove unused DropdownMenu component
Route topic chip tap events up to NiaNavHost
Apply suggestions from code review
Migrate custom room configuration into a convention plugin
Update docs/ArchitectureLearningJourney.md - User action follow topic
Update docs/ArchitectureLearningJourney.md - Writing data
Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea
3 years ago
2f5de17634
Route topic chip tap events up to NiaNavHost
...
Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7
3 years ago
a1bd4beadb
Add Firebase analytics. See go/nia-firebase-services.
...
Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689
3 years ago
0cd5abe77b
Provide true to LocalInspectionMode
3 years ago
7b11622c5d
Replace global variables with PreviewParameterProvider
3 years ago
56ecffbadd
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
3 years ago
5ef7084baa
Refactor Topics news feed, tidy a few other bits up
...
Change-Id: Id4c9d1bce484137b363ec4cd21a45ca9863a2e7f
3 years ago
286196a43d
fixed string issue for testTopicsChipColorBackground_matchesFollowedState test
3 years ago
103a497415
Merge remote-tracking branch 'github/mm/chipcolor' into mm/chipcolor
3 years ago
00fe2292ad
removed hardcoded strings
3 years ago
44c01135b9
fix spotless, tidy test data
...
Change-Id: I4ceb7b85e5a8dd4d4f20088b2594c6b4030299bb
3 years ago
45144528a3
Updated NewsResourceCardTest
3 years ago
c629c72f69
Move construction of UserNewsResource into separate function
...
Change-Id: I7c1f6427cd7d95c2016349fec301b88455b33cf2
3 years ago
2646c43f1c
Spotless
3 years ago
49e47685bd
Fix merge conflicts
3 years ago
f4c2a2b138
Added third draft of tests
3 years ago
7776ccce6c
Added second draft of tests
3 years ago
857806e294
Spacing polish based on design spec
3 years ago
24b4f5bf23
Merge pull request #504 from android/dt/fix-build-warnings
...
Fix build warnings
3 years ago
a9ee4d1c47
Fix build warnings
3 years ago
802d984300
Added first draft of tests
3 years ago
cb28fa3409
Renamed SaveableNewsResource to UserNewsResource
3 years ago
ed2df9c379
Fix unit and UI tests. Apply spotless.
...
Change-Id: Iab75852a27a44309d349f84e65226911ab59fcd5
3 years ago
a25ad9c017
Renamed SaveableNewsResource to UserNewsResource
3 years ago
664a827d55
Renamed SaveableNewsResource to UserNewsResource
3 years ago
dd96befa17
Set visibility modifier of composable preview to private
3 years ago
13ef87dc5a
Merge pull request #485 from ricknout/main
...
Update :core-designsystem module based on Figma file
3 years ago
37611fae12
Update :core-designsystem module based on Figma file
3 years ago
597bd97439
Merge pull request #476 from android/caren/resource_type
...
Display resource type for each news resource
3 years ago
919801245a
Rename NewsResourceDataAndType -> NewsResourceMetaData
...
Change-Id: Ide67bb9adf740d9cf0bba58f369688f91e0eb85f
3 years ago
6adb6b72ce
Fix tests
...
Change-Id: Ie1e2408ea523e6ddc0941fe261fce7f2502e3416
3 years ago
74a8da0448
Merge pull request #465 from android/caren/custom_chrome_tab
...
Use Chrome Custom tab for opening articles
3 years ago
61110b9aa3
run spotless
...
Change-Id: Ieb751d960ade646dfe35ed7d2ca039e3b8f38ba7
3 years ago
8831e49e27
Add test and add string template in strings.xml for RTL purposes
...
Change-Id: I1bce9ac7534f376a9626cac2c50e1bcc7620cf61
3 years ago
00a75bc3fe
Rename NewsResourceDateAndNewsType -> NewsResourceDateAndType
...
Change-Id: I535c62f3317d6ada882a08235c0c4465d9963201
3 years ago
234d451021
Display resource type for each news resource
...
Change-Id: Ib33ffd0e9b87ec91d2ee4316a4e3dbf70bb5cfc9
3 years ago
3c7ab45da4
Add ColorInt annotation
...
Change-Id: If6ea8e4c3a09c6de932797ddcb64bbfff1e52ede
3 years ago
a09612ec80
Remove author concept from app
...
Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793
3 years ago
d419b3f5f7
Run spotless
...
Change-Id: I1deee3c9b38d352afca0f646366598e32710ffca
3 years ago
227fb0b1b6
Implement custom chrome tabs in NewsResourceCardList as well
...
Change-Id: Ie5851666117a7c756b3d9ad02d6e17be0d3ba904
3 years ago
6116f679a5
Use Chrome Custom tab for opening articles
...
Change-Id: I0024038f918a18d3c3e803587a7e1c159bfb9169
3 years ago
4152160b27
replace StringBuilder with joinToString
3 years ago
16ce94962e
remove unused import
3 years ago
9902e8ce26
show all authors in the news card
3 years ago
bcc4712cfd
Fix typos
3 years ago
45d4eabac8
Merge pull request #297 from android/av/remove-dolphin-preview-todos
...
Remove Preview TODOs for Dolphin
3 years ago
c8976ca191
Merge branch 'github/main'
3 years ago
b6204656b8
Merge pull request #328 from android/bw/moreJankstats
...
Add more jank tracking
3 years ago
5315d2d957
Add more jank tracking
3 years ago
2468f1bc11
Merge branch 'main' into av/remove-dolphin-preview-todos
3 years ago
b078e3019b
Merge "Add domain layer. See go/nia-domain-layer for details." into main
3 years ago
e223be6ac1
Add domain layer. See go/nia-domain-layer for details.
...
Change-Id: I3f4684005e81fb9c4163bf59c7026dcff6e88dc4
3 years ago
222f65e9e8
Migrate packages to namespaces in build files
...
Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5
3 years ago
9cf5efee98
Merge pull request #310 from android/documentation/dep_graphs
...
Add dependency graphs to every module
3 years ago
c1316a2f23
Give feedback when syncing on ForYouScreen
...
Change-Id: I10a646e8a17f81d96351e69d36f0cb6ccf28e05c
3 years ago
2d60785879
Add dependency graphs to every module
...
Change-Id: I629fef818f7521c13bb3069a3ff9ed9bc42e57f3
3 years ago
f2c64a1f68
Merge pull request #299 from android/refactor/remove_episodes
...
Remove episodes related code
3 years ago
ab8053f087
Remove episodes related code
3 years ago
99a14e8e73
Merge branch 'github/main'
3 years ago
556ffce88b
Remove Preview TODOs for Dolphin
...
Change-Id: I35219c7dd6a902c43cd310dcaf8d0e2c2dbdec45
3 years ago
ee27ea6f87
Fix the lint warnings
3 years ago
821001cfcc
Introduce Multipreview annotation to simplify the preview configurations
...
- Bump the AGP version to 7.3.0
- Introduce Multipreview annotation class that represents device
previews and theme previews
Fixes #282
3 years ago
79de18507a
Move spotless to init script
...
Also adds automatic git hooks installation
Change-Id: I18debbee43af27db7b95a4202f824fa87e186713
3 years ago
Don Turner
qamarelsafadi
Qamar A. Safadi
Simon Marquis
prosixe
ahmedmadhoun1
Tomáš Mlynarič
Miłosz Moczkowski
gururani-abhishek
Takeshi Hagikura
James Rose
Chris Sinco
Keisuke Takagi
Don Turner
Márton Braun
magicalmeghan
ratobing
Nick Rout
Caren
Caren
Jolanda Verhoef
Saeed Noshadi
Automerger
Ben Weiss
Ben Weiss
Wojtek Kaliciński
Adetunji Dahunsi
Alex Vanyo