Qamar A. Safadi
1574ad250c
Merge branch 'android:main' into loading-progress-for-image
2 years ago
AlirezaJoon
60775d6bf8
fix: add label to animations for fixing lint issue
2 years ago
Qamar A. Safadi
72e515d512
Merge branch 'android:main' into loading-progress-for-image
2 years ago
Simon Marquis
54ad808e74
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
2 years ago
qamarelsafadi
a913c85c4d
feat: move the placeholder default value to the method
2 years ago
qamarelsafadi
58a42a6c85
feat: remove check if placeholder null and put a default placeholder if its not passed.
2 years ago
qamarelsafadi
6bc6fe1551
fix: modifier to Modifier
2 years ago
qamarelsafadi
8166ec18cb
feat: fix format issue
2 years ago
qamarelsafadi
3e04a65ca4
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
2 years ago
qamarelsafadi
51c007c51c
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
2 years ago
Qamar Safadi
e33036f039
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
2 years ago
TJ Dahunsi
451c2e9b74
Interact with scrollbar only if drag direction matches scrollbar orientation
...
Change-Id: I8fb5a64098ea83458d25fd2b7363a6b5dd3fef2f
2 years ago
TJ Dahunsi
3e7aa961c5
Replace usages of 'displacement' to 'moved' in parameter names
...
Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a
2 years ago
TJ Dahunsi
f77f6c134d
PR feedback
...
Change-Id: I6e9f4a2ba53e81d32d07e229eb848541801eca18
2 years ago
TJ Dahunsi
7a889b64a6
PR feedback
...
Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f
2 years ago
TJ Dahunsi
843826a68f
Check if first item size == 0
...
Change-Id: I41acffad84d9db1cf407f77b04530643933f98bf
2 years ago
TJ Dahunsi
208e03709b
Even better names
...
Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65
2 years ago
TJ Dahunsi
a97dec9633
Fix spotless
2 years ago
TJ Dahunsi
81c6076153
Added clarifying comments to code and used better variable names
2 years ago
TJ Dahunsi
b27c1b3d0d
Default scrollbars to dormant
2 years ago
TJ Dahunsi
ef85588d40
Extract scrollbar values to constants
2 years ago
TJ Dahunsi
acf0526226
Add hoverable to scrollbar
2 years ago
TJ Dahunsi
66a4e78105
Add scrollbars to app
2 years ago
Simon Marquis
e125658335
Merge branch 'main' into lint/sarif
2 years ago
Miłosz Moczkowski
da09e124a7
Refactor icons
2 years ago
Miłosz Moczkowski
31dd5ecf59
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
2 years ago
Simon Marquis
d562d566a8
Android Lint improvements
...
- Create `LintConventionPlugin` to configure Lint on all compatible modules: Android applications, Android libraries and JVM modules.
- Run `lintProdRelease` in CI instead of the default `lintDemoDebug` which is less important compared to production code.
- Rearrange CI steps to make it more clear that Lint should is an additional step after build (build -> test -> lint).
- Enable SARIF support and upload results to GitHub's CodeQL to get inline feedback on PRs.
If we really need better perfs, we could restore `lint.checkDependencies = true` on the `:app` module and only execute `:app:lintProdRelease`.
But in practice, this does not change the total build time on this project.
2 years ago
Simon Marquis
3d7b71963c
Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
3 years ago
Márton Braun
39c76443b1
Remove unused DropdownMenu component
...
Change-Id: I7ee7e8f1995667c7e54459f4333594c4605cc5a9
3 years ago
Márton Braun
2f5de17634
Route topic chip tap events up to NiaNavHost
...
Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7
3 years ago
Márton Braun
56ecffbadd
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
3 years ago
Angie Sasmita
463d7ac6e8
Merge pull request #542 from android/as/dynamic-color-option
...
Add dynamic color option in settings for API >=32
3 years ago
mlykotom
61c044a712
Merge branch 'main' into tm/fix-benchmarks-no-people
...
Change-Id: I94ca19fad5527c11a2f0f28cc43a23ab22f419a7
3 years ago
Angie Sasmita
2159f12d3f
Small fix for naming and boolean logic
...
Change-Id: I3dd291bdd581494574c557329bf23f5ed07af0bb
3 years ago
Angie Sasmita
2430c8c25b
Fix Spotless issue manually
...
Change-Id: Icd560e6ceaaeee0a6f502fe49b3403ab07f926ef
3 years ago
Angie Sasmita
c97e7980c8
Add dynamic color option in settings for API >=32
...
Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6
3 years ago
Alex Vanyo
4eda902d63
Merge pull request #491 from android/av/fix-background-composable
...
Updated background composable for gradient
3 years ago
Don Turner
222da07c0d
Refactor NiaGradientBackground to accept GradientColors
...
Change-Id: I55840b22e123490097710570bf11554554df90f9
3 years ago
Don Turner
d2035096c6
Merge pull request #493 from andhiratobing/main
...
Set visibility modifier of composable preview to private
3 years ago
ratobing
dd96befa17
Set visibility modifier of composable preview to private
3 years ago
Nick Rout
70a321cfa5
Fix issues with NiaTheme gradients and backgrounds
3 years ago
Nick Rout
6e0ab61410
Address design system PR feedback
3 years ago
Nick Rout
4f862d79a8
Fix ThemeTest
3 years ago
Nick Rout
59f95072e5
Fix ThemeTest
3 years ago
Nick Rout
fba50729cb
Fix spotless issues
3 years ago
Nick Rout
adb302520f
Fix spotless issues
3 years ago
Nick Rout
37611fae12
Update :core-designsystem module based on Figma file
3 years ago
mlykotom
b13096140c
Add niaTopAppBar testTag
...
Change-Id: I02a207675e106137fe005140965c96f1b50f98ce
3 years ago
mlykotom
77d45811c3
LoadingWheel testTag for every loading wheel
...
Change-Id: I7728e1717925abdfb607e93f3d48226910d42c0d
3 years ago
Mohsen Rzna
34b41d84fc
New empty bookmarks handling ( #443 )
...
* Added the png file for error state
This should be removed later - couldn't convert the design to vector from svg - there is a problem with the `<mask` tag.
* Added two new strings based on the Figma file
* Redesign and reimplementation for the empty BookmarksScreen along with two clarifying comments.
* Removed the png file and replaced it with vector
* Code refactor after code reviewing
Made contentDescription null, removed extra spaces and renaming for the Composable function as suggested.
* Moved the modifier after Text
* Added a space after the curly bracket to pass the Spotless check
* Spotless apply
* Simplify logic in Bookmarks screen
* Change order of composables in BookmarksScreen and add previews
* Refactor after code review
Removed the space before `if`, and changed the padding from 5 to 8dp.
Co-authored-by: Jolanda Verhoef <JolandaVerhoef@users.noreply.github.com>
3 years ago
Milosz Moczkowski
8435ed4b77
Merge pull request #179 from Abhimanyu14/niaicons
...
Icons alignment to use NiaIcons
3 years ago
Abhimanyu14
5e4963a48d
Icons alignment to use NiaIcons
3 years ago
Simon Marquis
a09ea875b8
Migrate from JUnit assertions to Kotlin's test framework
...
Fixes #419
3 years ago
Milosz Moczkowski
45d4eabac8
Merge pull request #297 from android/av/remove-dolphin-preview-todos
...
Remove Preview TODOs for Dolphin
3 years ago
Don Turner
c3bcdd75e0
Address review feedback from Manu
3 years ago
Don Turner
8cb5216d8e
Add settings module, refactor top bar
3 years ago
Alex Vanyo
e596e76714
Add data logic for theme switcher
...
Change-Id: Ifffadb897de4f6e08f7115103f99c156a7098b70
3 years ago
Don Turner
2468f1bc11
Merge branch 'main' into av/remove-dolphin-preview-todos
3 years ago
Wojtek Kaliciński
222f65e9e8
Migrate packages to namespaces in build files
...
Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5
3 years ago
Don Turner
9cf5efee98
Merge pull request #310 from android/documentation/dep_graphs
...
Add dependency graphs to every module
3 years ago
Adetunji Dahunsi
c1316a2f23
Give feedback when syncing on ForYouScreen
...
Change-Id: I10a646e8a17f81d96351e69d36f0cb6ccf28e05c
3 years ago
Milosz Moczkowski
2d60785879
Add dependency graphs to every module
...
Change-Id: I629fef818f7521c13bb3069a3ff9ed9bc42e57f3
3 years ago
Alex Vanyo
0630159e2e
Refine backgrounds and navigation colors
...
Change-Id: I9fd863cc608f21078ab78c39c2c3d227aedbac7c
3 years ago
Alex Vanyo
cdbcf54ba0
Update to material3 1.0.0-beta03 wih built-in insets support
...
Change-Id: I4d07f89d4faa6e3417468ad78acf3fbb161f0797
3 years ago
Automerger
8f3e7f037b
Merge branch 'github/main'
3 years ago
Caren
93630216d7
Merge pull request #288 from android/caren/remove_search
...
Remove Search from top app bar
3 years ago
Automerger
d9c4236d40
Merge branch 'github/main'
3 years ago
Caren
96bd63944a
Merge pull request #272 from android/caren/fix_toggle_buttons
...
Fix toggle buttons interaction when using TalkBack
3 years ago
Automerger
99a14e8e73
Merge branch 'github/main'
3 years ago
Alex Vanyo
556ffce88b
Remove Preview TODOs for Dolphin
...
Change-Id: I35219c7dd6a902c43cd310dcaf8d0e2c2dbdec45
3 years ago
Takeshi Hagikura
821001cfcc
Introduce Multipreview annotation to simplify the preview configurations
...
- Bump the AGP version to 7.3.0
- Introduce Multipreview annotation class that represents device
previews and theme previews
Fixes #282
3 years ago
Caren Chang
664510c652
Fix toggle buttons interaction when using TalkBack
3 years ago
Caren Chang
470cccb7db
Remove Search from top app bar
3 years ago
Wojtek Kaliciński
79de18507a
Move spotless to init script
...
Also adds automatic git hooks installation
Change-Id: I18debbee43af27db7b95a4202f824fa87e186713
3 years ago
madroid
40efeed4ed
Move 'core-' module to core subfolder
3 years ago