603 Commits (d5a23098bcb51a76c3ead93679dfda41d2cf79bd)

Author	SHA1	Message	Date
dependabot[bot]	f584f3baf8	🤖 Updates baselines for Dependency Guard	1 year ago
Simon Marquis	d6402a9c09	Merge remote-tracking branch 'origin/main' into fix/1161-2	1 year ago
Don Turner	64c4a25eb3	Fix tests, fix spotless ... Change-Id: I55e779abe4ee49dc93916d9e1184ed81e1b2bbd0	1 year ago
Don Turner	cc50d7420a	Remove different deeplink destination, add route for nested nav host ... Change-Id: Idb9586752d815449243d6d529e9b655c45e395ad	1 year ago
Don Turner	299a352aa4	Update to adaptive alpha12, fix merge issues ... Change-Id: I99703db37712abb46b844beb73bb14ddd5283165	1 year ago
Don Turner	3bcb5f9910	Merge pull request #1406 from SimonMarquis/patch-1 ... Remove duplicated AndroidX Work testing dependency	1 year ago
Don Turner	070ad5f319	Merge pull request #1300 from android/dependabot/gradle/protobuf-4.26.0 ... Bump protobuf from 3.25.2 to 4.26.0	1 year ago
Don Turner	dfe4a23f73	Merge pull request #1127 from android/dependabot/gradle/androidx.activity-activity-compose-1.8.2 ... Bump androidx.activity:activity-compose from 1.8.0 to 1.8.2	1 year ago
Don Turner	226e893aff	Merge branch 'main' into dt/nav-safe-args (AnimatedPane broken) ... * main: Save nested nav key in instance state 🤖 Updates baselines for Dependency Guard Recreate nested nav to work with AnimatedPane Remove forgotten Trace.endSection() Offload connectivity monitor to a background thread Change-Id: I4002a07484a4d633c57406aedabf9f5d813a8592	1 year ago
Don Turner	ae5f002a1c	Add specific type for deeplinks ... Change-Id: I63c0abb16cbf540ef72dfb945518a48113bdbf75	1 year ago
Don Turner	a41edeac21	Remove autoVerify from intent filter ... Change-Id: Ia7460a618b2ddf8a25debce92308573bc18368a8	1 year ago
Don Turner	046ab2ace9	Use version catalog reference to serialization plugin ... Change-Id: Ia197b2403e8250720387123d8c5d5d9ad809a036	1 year ago
Don Turner	1a45eabcb1	Update ForYou destination to match current deeplink pattern ... Change-Id: Ia5ab36f2d75d8d061e63c0cac5262503bc93a638	1 year ago
Don Turner	ef235cae1f	Fix issue where selected topic in list was not showing as selected. Minor tidy ups. ... Change-Id: Icfa79eac6f7327c365f79fd7d15dfa1f8c77184d	1 year ago
Alex Vanyo	f03c06163e	Add NavigationSuiteScaffold ... Change-Id: I36710d880bff381ed86c61632f2ab91902727775	1 year ago
Alex Vanyo	c046c0cf5c	Fix state loss with workaround ... Change-Id: I96025bd8b2f4f59019df95d1391b832249e7dc91	1 year ago
Alex Vanyo	80676d55ff	Save nested nav key in instance state ... Change-Id: If1155bfbe080eb4df3c59faaec0fb4cd4da3821d	1 year ago
alexvanyo	60d42b2646	🤖 Updates baselines for Dependency Guard	1 year ago
Alex Vanyo	d146e0128a	Recreate nested nav to work with AnimatedPane ... Change-Id: I6b526331b7fc62b968ac39e91753a8a1e5343023	1 year ago
Don Turner	578c7f58a7	Use navigation argument topicId as default value to InterestListDetailScreen ... Change-Id: I659f729191bce00683b1621c360c8f36f00595f9	1 year ago
Don Turner	6a4dd757e9	Change startDestination from KClass to default instance ... Change-Id: Ia5bb0abd366653aff5cf5a772ac11a837e96b9b1	1 year ago
dturner	2cc0dab95f	🤖 Updates screenshots	1 year ago
dturner	48746ac52f	🤖 Updates baselines for Dependency Guard	1 year ago
Don Turner	c4aa2024f0	Fix spotless ... Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428	1 year ago
Don Turner	727015573d	Merge branch 'main' into dt/nav-safe-args	1 year ago
Don Turner	4cee9776cb	Add deeplink action to enable testing from terminal ... Change-Id: Ia112f87c7f1bb7fa9ebe08b82d26e00b4ad17d05	1 year ago
Don Turner	a78e127c1d	Remove Interests2PaneViewModel as it was overkill for holding a single string value ... Change-Id: I4767578028b55c2bc7b1763bdeef87345b9fbf06	1 year ago
Don Turner	2b40962f3d	Migrate remainder of app to type-safe navigation ... Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b	1 year ago
Don Turner	977151ae19	Update to alpha08, use toRoute to obtain destination inside VM ... Change-Id: I72f617c594b5e0ae272cf94d2d7288446153420a	1 year ago
Don Turner	9260ad6c84	Migrate Interests nested NavHost to safe args ... Change-Id: I4f3c310be693ecbcbc8b99c4e573d7fc6e9a2f74	1 year ago
Don Turner	c7a1486457	Merge pull request #1383 from android/av/navigation-2.7.7 ... Update to navigation 2.7.7	1 year ago
Alex Vanyo	c5d0f25360	Add workaround for state loss bug ... Change-Id: I7ac4495c8e3ada419358688c61214c33c0d4040e	1 year ago
Simon Marquis	be5bf1f8d5	Update build.gradle.kts	1 year ago
Jose Alcérreca	be2dd57af2	Fixes flakiness in app's screenshot tests (#1395) ... * Disables WM init in app's screenshot tests Change-Id: Ib0994e744f49b53f58c0eebd52f80c0eba67bbed * Spotless Change-Id: Ic0212889354481433ce45ec4292ae7be9bd24b2e * [CI] Uploads roborazzi reports if they fail Change-Id: I5a25a7e156d3fcb72a396d3b503e62068a20b417 * Uses unused test module and enables LocalInspection Change-Id: Iac36347dc3d702248d7515a74823e0bc0cbf2a2b * Fixes timezone in snackbar screenshot tests Change-Id: Ic517e8822218abeaddd3f8d2740b03e651d72d31 * Fixes conflict Change-Id: Ia42fb78781d2469a608183594fc25c7c69f7e76c * 🤖 Updates screenshots	1 year ago
Jose Alcérreca	815c471d24	Revert "Configure baseline profiles in the baselineProfile lambda" (#1398) ... This reverts commit 7980c1d0df.	1 year ago
Ben Weiss	32bdaad690	Configure baseline profiles in the baselineProfile lambda (#1060) ... * Configure baseline profiles in the baselineProfile lambda * This is the correct and easiest way to set up baseline profiles correctly. * See b/313428246 for more context. * Handle empty topics during baseline profile generation * Revert to API 33 GMD and fail empty screen tests * Rename withChildren to noChildren for better legibility * Remove unused log tags * Update benchmark and metrics versions * 🤖 Updates baselines for Dependency Guard --------- Co-authored-by: Tomáš Mlynarič <mlykotom@google.com> Co-authored-by: Jaehwa Noh <shwoghk14@gmail.com>	1 year ago
Alex Vanyo	98927133dd	Update to navigation 2.7.7 ... Change-Id: Iaceea1fc216c899f7fac58e7f5eeaea4e1c10dbb	1 year ago
Don Turner	83676800f0	Replace TestHarness with DeviceConfigurationOverride after merging main ... Change-Id: Ie49b67981929fd3932ce3da68571a6305cf67aef	1 year ago
Don Turner	74fead944a	Merge branch 'main' into replace-testharness	1 year ago
Sergey Pinkevich	0d3b5fe359	Merge branch 'dependabot/gradle/androidx.activity-activity-compose-1.8.2' of https://github.com/android/nowinandroid into dependabot/gradle/androidx.activity-activity-compose-1.8.2	1 year ago
Alex Vanyo	a471572fb4	Update badging ... Change-Id: If6b1327554bc855baa86fd47519ca56e015b9d14	1 year ago
Alex Vanyo	45768621f5	Update to material3-adaptive alpha10 ... Change-Id: I810c36323a35c445c22dd3876c52df0360a5cb48	1 year ago
Alex Vanyo	f28c598f76	Update usage of material3 adaptive to be edge-to-edge ... Change-Id: I481c79db77bbdd657182f5355200f63e2355f40d	1 year ago
Jose Alcérreca	bfcea73e3c	Adds screenshot tests for snackbar (#1343) ... * Adds screenshot tests for snackbar Change-Id: I81566e3301fb17e3f31cbc408e6cc3325eab5a12 * Small tweaks, RFR Change-Id: Ia16db6e6f5bec2714081b5ceaeeba36b2ee26105 * 🤖 Updates screenshots * Update NiaApp.kt Adds modifier to NiaApp	1 year ago
Tomáš Mlynarič	5b5f04a075	Fix format ... Change-Id: I54c9a794cbb84ffba4378ccc901ceb603de4642c	1 year ago
Tomáš Mlynarič	075382e3aa	Fix default value ... Change-Id: I6b77e1c23ad91c1c97f31a705161d444be7913c0	1 year ago
Tomáš Mlynarič	fa68c59069	Optimized handling of dark/light mode ... - Activity handles uiMode config change to prevent re-creating the whole activity - Wrap uiState logic into its classes - Optimize startup to prevent recomposing twice on startup - Optimize startup to call enableEdgeToEdge only once or when change occurs Change-Id: I6f7a48b3b6ce9b55db4ab2ec1770583028e9bc50	1 year ago
Tomáš Mlynarič	f6f5bf04f6	Add niaEdgeToEdge trace tag ... Change-Id: I8012c8b4544abc9488f96f6f01822fb15bb0775a	1 year ago
Don Turner	01cf2cfcd2	Fix spotless ... Change-Id: I98a9b9fa1de5cc0bb3a3caa7d795053fd784b238	1 year ago
Don Turner	369c271b50	Merge branch 'main' into replace-testharness	1 year ago
Don Turner	2bdcbeb95b	Remove workaround for https://issuetracker.google.com/327149166 ... Change-Id: I335f9f5da1ff3f2574acca8e3fcb27b949a07c7a	1 year ago
Jaehwa Noh	b101838f85	Change getByName to named ... - reference by [APIs to avoid](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#apis_to_avoid) Change-Id: Idf1ce9cf372b8f5da2f0da95fcf53454ffb3388f	2 years ago
Jose Alcérreca	7d39d7394e	Sets up jacoco coverage with a combined report and a GHA (#1303) ... * Uses jacoco coverage reporting in AGP	2 years ago
Simon Marquis	0639b375f1	Cleanup dependencies ... This is a followup cleanup of #1163 that was partially addressed by #1140. - Remove unused `projects.core.testing` dependencies (or replace with direct dependencies). - Introduce `androidx.compose.ui.test` bundle. - Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.	2 years ago
Don Turner	66c5335e0f	Merge pull request #1306 from yongsuk44/feat/weak-warning ... Cleaned up unnecessary '@opt-in' annotations and removed empty constructors	2 years ago
yongsuk44	8e9b39fa31	Remove unnecessary opt-in annotations	2 years ago
dependabot[bot]	2b3bfaee09	🤖 Updates baselines for Dependency Guard	2 years ago
dependabot[bot]	4471ce4f1a	🤖 Updates baselines for Dependency Guard	2 years ago
Jonathan Koren	bca4e40a28	Topic detail pane placeholder (#1280) ... * Topic detail pane placeholder Change-Id: I92b84493a5406240285c0759b30aa10d29871f09 * Add modifier parameter Change-Id: Ie363be83b44f26291030c04c1513cecb851a6899	2 years ago
Don Turner	c95b90fbe7	Make path to module graph image dynamic. Fixes #1286 ... Change-Id: I595a841ef7b06cccc959ca96d18824f4fad4c261	2 years ago
Don Turner	315c284be2	Merge pull request #1257 from android/dt/add-module-graphs ... Update module dependency graphs and add script to create them	2 years ago
Don Turner	7415ae3b46	Add title to READMEs to describe the dependency graph ... Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528	2 years ago
SergeyPinkevich	dedb199f77	🤖 Updates baselines for Dependency Guard	2 years ago
alexvanyo	d4efe8540b	🤖 Updates baselines for Dependency Guard	2 years ago
Alex Vanyo	3e4d9c1c5e	Update material3-adaptive to 1.0.0-alpha08 ... Change-Id: Ic218c6b061b5cea4e56b544073541421862bc1d0	2 years ago
Don Turner	c921578e6b	Merge pull request #1217 from android/dependabot/gradle/org.jetbrains.kotlinx-kotlinx-serialization-json-1.6.3 ... Bump org.jetbrains.kotlinx:kotlinx-serialization-json from 1.6.0 to 1.6.3	2 years ago
Don Turner	9c05d83c36	Merge pull request #1258 from Jaehwa-Noh/rename-test-function ... Rename test function, and delete explicit type argument	2 years ago
Don Turner	dbbb8afa60	Merge pull request #1263 from android/dependabot/gradle/kotlinxCoroutines-1.8.0 ... Bump kotlinxCoroutines from 1.7.3 to 1.8.0	2 years ago
Don Turner	f843f1b23a	Merge pull request #1264 from android/dependabot/gradle/androidx.hilt-hilt-navigation-compose-1.2.0 ... Bump androidx.hilt:hilt-navigation-compose from 1.0.0 to 1.2.0	2 years ago
Don Turner	8636dd240f	Merge pull request #1266 from android/dependabot/gradle/androidx.browser-browser-1.8.0 ... Bump androidx.browser:browser from 1.6.0 to 1.8.0	2 years ago
mlykotom	07fc490ab5	🤖 Updates baselines for Dependency Guard	2 years ago
dependabot[bot]	7ca27abec7	🤖 Updates baselines for Dependency Guard	2 years ago
dependabot[bot]	c00f9de9ff	🤖 Updates baselines for Dependency Guard	2 years ago
dependabot[bot]	6d91566aaf	🤖 Updates baselines for Dependency Guard	2 years ago
Jaehwa Noh	19efc6c3ad	Merge branch 'android:main' into rename-test-function	2 years ago
Jaehwa Noh	3b11bcf725	Remove explicit type argument. ... Change-Id: Id02756d780309af6638698de856b563d9e775cc3	2 years ago
Jaehwa Noh	2eb0318513	Rename test function name ... - Given-when-then format. Change-Id: I3305c5a7cc5a0f41be31292534a086034f642404	2 years ago
Jonathan Koren	c750a3c4c1	2 pane support in Interests screen (#1234) ... * Add dependency on material3 adaptive Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6 * Add InterestsListDetailScreen composable Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971 * Store selectedTopicId in InterestsViewModel Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce * Pass detail pane composable down Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293 * Navigate to initial topic if provided Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b * Lift LDPS up to app module Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85 * Fix some navigation behavior Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b * Navigate to initial topic if provided Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed * Remove dependency in interests feature module Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f * Hide back arrow when the topics list is visible Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8 * Update interests tests Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd * Highlight selected topic when displaying 2 panes Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415 * update dependency baselines Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00 * run spotless apply Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8 * Convert isListPaneHidden to isListPaneVisible Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657 * Set semantics for selected state Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca * Use scaffold roles when determining visibility Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648 * Update multipleBackStackInterests test Change-Id: I1e372f7989817151a6765205291b13b561187fa8	2 years ago
Don Turner	2004c9abca	Update module dependency graphs and add script to create them ... Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31	2 years ago
Don Turner	7196156718	Merge branch 'main' into replace-testharness ... * main: (37 commits) Disable animations of instrumented tests (#1167) Bump gradle/wrapper-validation-action from 1 to 2 Remove unused release variable. Fixes #1231 Apply Composable Parameter Ordering Guidelines Remove kotlinx-coroutines-guava dependency from :sync:work Add explicit guava-android dependency for :sync:work Extract ScreenshotHelper to separate testing module Update AGP to 8.3.0 Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert. 🤖 Updates baselines for Dependency Guard Bump the kotlin-ksp-compose group with 6 updates 🤖 Updates baselines for Dependency Guard Bump hilt from 2.50 to 2.51 Bump com.google.truth:truth from 1.1.5 to 1.4.2 Move java to kotlin folder. Remove disk usage testing Figuring out what is using 66Gb in the runner Dpm Improve converting to kotlin timezone Use trySend multiple times ... Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a	2 years ago
Don Turner	18376f5f3d	Update app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt ... Co-authored-by: Alex Vanyo <vanyo@google.com>	2 years ago
Don Turner	140ad2086a	Merge branch 'main' into dependabot/gradle/org.jetbrains.kotlinx-kotlinx-serialization-json-1.6.3	2 years ago
Don Turner	35c703ec4f	Merge pull request #1239 from Jaehwa-Noh/java-to-kotlin ... Move java to kotlin folder.	2 years ago
Don Turner	2837c64a12	Merge pull request #1249 from android/dt/fix-1231 ... Remove unused release variable. Fixes #1231	2 years ago
Don Turner	15ebc0ce59	Remove unused release variable. Fixes #1231 ... Change-Id: I8c03d3d2e1aee85a22d1a03b97e3bec4069e0fcb	2 years ago
Alex Vanyo	a4c0842d73	Extract ScreenshotHelper to separate testing module ... Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af	2 years ago
Don Turner	609018f211	Merge pull request #1244 from android/dependabot/gradle/hilt-2.51 ... Bump hilt from 2.50 to 2.51	2 years ago
Jaehwa Noh	e2809d7871	Merge branch 'android:main' into java-to-kotlin	2 years ago
Tomáš Mlynarič	8f89ca6cbb	Merge branch 'main' into mlykotom/tz-perf-improvement ... Change-Id: Id49a580012629163ec4a3663d95ab71b98910220 # Conflicts: # app/dependencies/prodReleaseRuntimeClasspath.txt # app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt # gradle/libs.versions.toml	2 years ago
dependabot[bot]	9fa36b1f63	🤖 Updates baselines for Dependency Guard	2 years ago
Jaehwa Noh	5c3c9dcd14	Move java to kotlin folder. ... Change-Id: Iaf4723dea6169fbf3f9a8d3bf8779179ac56ab86	2 years ago
dturner	890307b056	🤖 Updates screenshots	2 years ago
Don Turner	20d57b1105	Workaround for new ForcedSize behaviour, bump ui-test version ... Change-Id: Ibf93c1b65250e6527e34bc90602c1b1001b2df46	2 years ago
Don Turner	e2dd43f635	Bump to ui-test:1.7.0-alpha03, add parameter name ... Change-Id: Ib1bbe4ad0d823c632d387587aa55c5eeb39e4b8d	2 years ago
dturner	ec8786e168	🤖 Updates screenshots	2 years ago
Don Turner	137a8a78a6	Replace Accompanist TestHarness with DeviceConfigurationOverride ... Change-Id: I6742d5e221f86a019f44d3e623609bf76d2a3a2a	2 years ago
dturner	b3ff8aa940	🤖 Updates screenshots	2 years ago
dturner	5c83771326	🤖 Updates screenshots	2 years ago
Don Turner	793bb6568e	Wrap NiaApp with NiaTheme for app screenshot tests ... Change-Id: I8e298da139b19721b90ae778e7ab184f600d0bd7	2 years ago
Tomáš Mlynarič	7737a83eb9	Merge branch 'main' into mlykotom/tz-perf-improvement ... Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c # Conflicts: # app/dependencies/prodReleaseRuntimeClasspath.txt # build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt	2 years ago
dturner	4a1015287d	🤖 Updates screenshots	2 years ago
dturner	6958a5ddcb	🤖 Updates baselines for Dependency Guard	2 years ago
dturner	541262b6bb	🤖 Updates baselines for Dependency Guard	2 years ago
dependabot[bot]	0aeb7d1001	🤖 Updates baselines for Dependency Guard	2 years ago
dependabot[bot]	267c97cb6e	Bump protobuf from 3.24.4 to 3.25.2 (#1214) ... * Bump protobuf from 3.24.4 to 3.25.2 Bumps `protobuf` from 3.24.4 to 3.25.2. Updates `com.google.protobuf:protobuf-kotlin-lite` from 3.24.4 to 3.25.2 Updates `com.google.protobuf:protoc` from 3.24.4 to 3.25.2 - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl) - [Commits](https://github.com/protocolbuffers/protobuf/compare/v3.24.4...v3.25.2) --- updated-dependencies: - dependency-name: com.google.protobuf:protobuf-kotlin-lite dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: com.google.protobuf:protoc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * 🤖 Updates baselines for Dependency Guard --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>	2 years ago
Ben Weiss	ef9f7d67a5	Remove legacy benchmark build type (#1207) ... * Remove legacy benchmark build type Now that we have the baseline profile gradle plugin, there is no need for a benchmark build type. The plugin does the setup and configuration and runs against the correct app flavor. * Remove explicit benchmark build type from benchmark module * Remove stale build task exclusions * Fix tracing import location FYI @mlykotom	2 years ago
Tomáš Mlynarič	74175c1d1c	Revert fast initialization of Coil ... As discussed in https://github.com/coil-kt/coil/issues/2097 the problem is caused by regitering system services, which will be fixed in 2.6.0 Change-Id: I9085309780508137f10b25ff82deed3c62e5d159	2 years ago
Tomáš Mlynarič	efc6775053	Add braces ... Change-Id: I859babab7278137a4a2e49e5a085c65632888dd0	2 years ago
Tomáš Mlynarič	b208b8bfcd	Inline initialization ... Change-Id: I0a77eb6457cac27c1a4d604c8efdcbbdce95bc48	2 years ago
Tomáš Mlynarič	d8c538e0ed	Don't use runBlocking if async init completed ... Change-Id: I641187ce277f434c6fca49a11b3cfccd50ecf5da	2 years ago
Tomáš Mlynarič	be4dcedc63	Launch loader directly without additional coroutine scope ... Change-Id: Icbbdbcbcac1a6275857ebe998509f1e09109db7a	2 years ago
Tomáš Mlynarič	27dcfe26c9	Fix comment ... Co-authored-by: Yuri Schimke <yuri@schimke.ee>	2 years ago
Tomáš Mlynarič	41b576d294	Improve lazy loading for Coil + OkHttp ... This way, we can load Coil's backend on a background thread and not block the MainThread with it. Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames. Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62	2 years ago
Tomáš Mlynarič	77d4f5f57f	Use trySend multiple times ... Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032	2 years ago
Tomáš Mlynarič	5f994ec7cd	Update dependency guard baseline ... Change-Id: I2557753f1eb4c6845aca6473a6aba5b7e758ebbf	2 years ago
Tomáš Mlynarič	8f5c475aab	Rename currentTimezone variable ... Change-Id: I92630f6851b0253294a8d3ec2e5b3cbe7db74b4d	2 years ago
Tomáš Mlynarič	bb8981f01c	Merge branch 'main' into mlykotom/tz-perf-improvement ... Change-Id: Ie83fb57676934ca3bdda59a986eb1a01a7c97424	2 years ago
Tomáš Mlynarič	e208bd0bfd	Use kotlinx.datetime.Timezone instead of java ZoneId ... Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628	2 years ago
Jonathan Koren	230cc95e5f	Run dependencyGuard task during CI (#1064) ... * Run dependencyGuard task during CI Run the `dependencyGuard` task during CI, which will fail if there are detected changes. Change-Id: If5f2b18a4c765bd38a3353df2adaaa91cf1739c3 * Add actions to update dependency guard baselines * Update baselines * Better glob for update baselines action	2 years ago
Tomáš Mlynarič	e19d435317	Rename LocalTimeZone -> LocalZoneId + collects with lifecycle ... Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3	2 years ago
Tomáš Mlynarič	c432f74054	Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers ... This way, we can save ~1ms per composed item on screen. Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d	2 years ago
Tomáš Mlynarič	40c72de60a	Add Composition Tracing ... Change-Id: I3ad60930de2fab71a700a0c2df3f0a1f566cafd8	2 years ago
Don Turner	c83ea9d24e	Merge pull request #951 from SimonMarquis/issue-945 ... Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`	2 years ago
Don Turner	ecd7b035c7	Merge pull request #785 from SimonMarquis/optimize-avd ... Optimize AVD to fix long vector paths Lint warning	2 years ago
Simon Marquis	1494f77683	Fix badging after merge	2 years ago
Simon Marquis	c3bb7ce4b5	Merge branch 'main' into firebase-ktx	2 years ago
SimonMarquis	4858b8355a	🤖 Updates screenshots	2 years ago
Simon Marquis	ae55eb8e1a	Optimize AVD to fix long vector paths Lint warning ... ... with SVGOM, but you'll have to check on Android Studio the AVD diff. https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html	2 years ago
Don Turner	4843216871	Merge branch 'main' into kotlinify	2 years ago
Don Turner	305f049429	Merge pull request #1088 from SimonMarquis/cleanup-dependencies ... Reduce overall build complexity	2 years ago
Don Turner	b34d365c05	Update dependency guard classpaths ... Change-Id: I5f729bce92ec1cc9f71e34e42cbe38765966fc31	2 years ago
Simon Marquis	81b15d046e	Merge branch 'main' into issue-945	2 years ago
Simon Marquis	6cd965d70c	Replace `Enum.values()` with `Enum.entries` ... 'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9	2 years ago
Don Turner	1d92f90ab0	Merge pull request #956 from KDW03/add_saved_test ... Add Test for Saved Top Level Destination	2 years ago
Don Turner	137944ab9a	Merge pull request #767 from SimonMarquis/resource-prefix ... Enforce `resourcePrefix` on Android library modules	2 years ago
Don Turner	e4991aff96	Merge branch 'main' into kotlinify	2 years ago
Don Turner	8d29d9bf57	Merge pull request #1094 from lihenggui/main ... Upgrade Spotless and Ktlint and remove code convention violations	2 years ago
Don Turner	00823a51ac	Merge pull request #1103 from android/add_icon_comment ... Add comment explaining why the launcher icon colors differ per build	2 years ago
Simon Marquis	2e663d3572	Merge branch 'main' into kotlinify	2 years ago
Don Turner	5a49b51008	Moving comments to _after_ first XML element ... Change-Id: Id4271a67ffcfbd712a2dd1f363970fcd31ee5ac0	2 years ago
lihenggui	b3d68b92d3	Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE	2 years ago
Don Turner	c8163a7328	Fix spotless ... Change-Id: I5dea4fec5b391e8cb7794af13e99978fcb622fbb	2 years ago
Don Turner	76e3c1d97c	Revert "Move app screenshot tests to match dependencies declaration"	2 years ago
Don Turner	235585c8c4	Add comment explaining why the launcher icon colors differ per build variant ... Change-Id: I30126402370162ccbe53e177652583e4472f2030	2 years ago
Simon Marquis	14c90400be	Move app screenshot tests to match dependencies declaration ... Fixes #990	2 years ago
lihenggui	5aa9122f08	Remove violations: property-naming	2 years ago
lihenggui	5e965962c5	Spotless	2 years ago
Simon Marquis	7068e3d055	Fix badging, which is not "stable" when it comes to ordering	2 years ago
Simon Marquis	57dacf18d5	dependencyGuardBaseline	2 years ago
Simon Marquis	171e2e83f5	Reduce overall build complexity ... - Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`	2 years ago
Simon Marquis	7bdf942a47	Merge branch 'main' into firebase-ktx	2 years ago
Simon Marquis	c83a5edadf	updateProdReleaseBadging ... See https://github.com/android/nowinandroid/pull/1006 for these new permissions and "Ad Services" property.	2 years ago
Jonathan Koren	b95c52c264	Add dependencyGuard to AndroidApplicationConventionPlugin ... Change-Id: Ib695ca18512d0ccde4c67e101f09ebbff8897912	2 years ago
Jonathan Koren	014e2a22f1	Only record prodReleaseRuntimeClasspath configuration ... Change-Id: I129fc4839ac2b4d5624c91cd25b47efba8847f44	2 years ago
Jonathan Koren	b64075b3b2	Add dependency guard plugin	2 years ago
Simon Marquis	6a3a5ea692	Kotlinify codebase ... - Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)	2 years ago
Simon Marquis	8d0b893459	Update Robolectric 4.11.1 ... - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11 - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1 > Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below. Removing explicit API 33 Robolectric configuration.	2 years ago
Miłosz Moczkowski	ad98844d64	Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold" ... This reverts commit 335a7ec68c, reversing changes made to aa8ce0e1f6.	2 years ago
mmoczkowski	ed702d195a	🤖 Updates screenshots	2 years ago
Miłosz Moczkowski	e03e5561ef	Replace manual navigation component switching with new NavigationSuiteScaffold ... Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723	2 years ago
Ben Weiss	ca62bb6c49	Add automated baseline profile generation (#880) ... Baseline profile generation is disabled for the PR level Build task. Release tasks require a fresh baseline profile. A new profile is generated using the baseline profile Gradle plugin. * Prepare for usage of dex layout optimizations which can be actively used once NiA switches to AGP 8.2+. * Add GMD config to release build * Switch to macos-latest * Update names for StartupBenchmark tests to better reflect states * Stable release and recent GMD device * Reduce flakiness by adding wait to benchmark * More convenient waiting for objects * Rename junit dependency to androidx-junit * Only run baseline profile benchmarks during GH workflow * Enable automatic BP generation for only release builds * Disable BP generation from Build workflow * Specify modules and skip benchmarking Build workflow Bug: b/299334172	2 years ago
Don Turner	5f26b9c8a5	Merge pull request #933 from danysantiago/main ... Update to Hilt 2.48 and use the KSP version	2 years ago
Daniel Santiago	20129f083b	Update to Hilt 2.48.1 and use the KSP version ... * Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin. * `@Binds` function cannot be an extension function. * Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.	2 years ago
Jose Alcérreca	4faf8f0d8d	[CI] Better caching and fewer jobs run ... * [CI] Runs build in macos to generate a cache for androidTest runs * Build projects before running emulator * Fixes flaky coroutines test * Moves spotless up in local tests job * Enables config cache by setting problems to warn. Fixes #1022	2 years ago
rosariopf	0081d14105	remove ACCESS_ADSERVICES permissions	2 years ago
Don Turner	368e8b7348	Add updated badging for prodRelease variant ... Change-Id: Ibe71c285708ffec85520a0c7852600f361ed1646	2 years ago
Alex Vanyo	f4d115c0f9	Add automatic checks for badging ... Change-Id: Ic8fca86d7aa84675fa91fb1aa99abcc6e19d663e	2 years ago
TM	ecb7528a2c	Inline color values for app icons	2 years ago
TM	1e0e1140ff	Removed Comments	2 years ago
TM	cd87a5ad70	Use colors from design palette in build variant icons	2 years ago
TM	8c7055f8ce	Create different icons for each build variant ... Added color values for DEBUG and BENCHMARK build variants.	2 years ago
Jose Alcérreca	85b7549b44	NiaAppScreenSizesScreenshotTests.kt: Fixes screenshot test showing wrong width (#986) ... * FIxes screenshot test * 🤖 Updates screenshots	2 years ago
Adetunji Dahunsi	27dd4e66ad	Merge pull request #947 from android/tj/staggered-grid-feed ... Use lazy vertical staggered grid in feed to maximize space utilization	2 years ago
Don Turner	3d85cd06d0	Merge pull request #958 from McGalanes/main ... Use typesafe project accessors	2 years ago
Melwin Magalhaes	f470be2860	Add convention plugins to version catalogs	2 years ago
Melwin Magalhaes	d089ccd9d7	Use typesafe project accessors for project modules	2 years ago
tunjid	5009105592	🤖 Updates screenshots	2 years ago
Simon Marquis	79bb3b9edf	Merge remote-tracking branch 'origin/main' into resource-prefix	2 years ago
Simon Marquis	5df3f0b665	Merge remote-tracking branch 'origin/main' into issue-945	2 years ago
kimdowoo	ed9299de65	Add Test for Saved Top Level Destination	2 years ago
Don Turner	129c46d9b3	Merge pull request #779 from SimonMarquis/java-to-kotlin-sourceset ... Migrate from `java` to `kotlin` sourceSet directory	2 years ago
Simon Marquis	415e35c35e	Enforce `resourcePrefix` on Android library modules ... ``` :ui-test-hilt-manifest -> ui_test_hilt_manifest_ :core:analytics -> core_analytics_ :core:common -> core_common_ :core:data -> core_data_ :core:data-test -> core_data_test_ :core:database -> core_database_ :core:datastore -> core_datastore_ :core:datastore-test -> core_datastore_test_ :core:designsystem -> core_designsystem_ :core:domain -> core_domain_ :core:network -> core_network_ :core:notifications -> core_notifications_ :core:testing -> core_testing_ :core:ui -> core_ui_ :feature:bookmarks -> feature_bookmarks_ :feature:foryou -> feature_foryou_ :feature:interests -> feature_interests_ :feature:search -> feature_search_ :feature:settings -> feature_settings_ :feature:topic -> feature_topic_ :sync:sync-test -> sync_test_ :sync:work -> sync_work_ ```	2 years ago
Simon Marquis	2bbb982b3a	Migrate from `java` to `kotlin` sourceSet directory	2 years ago
Simon Marquis	1c36712c6b	Fix wrong configuration name, leaking `work-testing` to runtime classpath ... Typo introduced recently when Roborazzi was added to the project: 886158d3cb (diff-8cff73265af19c059547b76aca8882cbaa3209291406f52df1dafbbc78e80c46)	2 years ago
Simon Marquis	23f14116f6	Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication` ... - Prevent logging multiple times (because of `onResume()` callback) - Remove unnecessary io dispatcher: `ListenableFuture<T>.await()` is already main-safe and prevent acquiring io slot. - Merge comments into a single javadoc comment on the `ProfileVerifierLogger` type. - Add proper javadoc format with markdown specific blocks. - Update logs & tag to be more uniform. Closes #945	2 years ago
Jose Alcérreca	ff9f38198f	Adds screenshot tests to :core:designsystem (#931) ... * WIP: Adds screenshot tests to :core:designsystem Change-Id: I0672845feba4064652dd8d60f07047b87864e121 * 🤖 Updates screenshots * Creates tests for more components and cleans up Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22 * WIP: More cleanup and more combinations of themes Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523 * Added the rest of the screenshot tests for designsystem Change-Id: Ic427db5491910781c038882055524e3f3dbed194 * Some more cleanup Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180 * Spotless Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6 * 🤖 Updates screenshots * ScreenshotHelper cleanup Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0	2 years ago
Milosz Moczkowski	d32d871f4b	Merge pull request #868 from SimonMarquis/patch-4 ... Handle topic clicks from all destinations	2 years ago
Jose Alcérreca	9748be62c5	Adds Screenshot testing with Roborazzi (#876) ... * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	2 years ago
Don Turner	c9ab7de4f5	Merge pull request #806 from SimonMarquis/objenesis ... Remove forced resolution strategy	2 years ago
Simon Marquis	28c9412cc9	Convert 'sealed' sub-object to 'data object'	2 years ago
Alex Vanyo	0a606296e1	Merge pull request #817 from android/av/enable-edge-to-edge ... Switch to new Activity.enableEdgeToEdge	2 years ago
Simon Marquis	b0b13d07bc	Replace NiaNetworkDataSource with TopicsRepository ... to be closer to the actual source of data used by the instrumented app.	2 years ago
Simon Marquis	812c558bc3	Select last topic by name instead of a random one	2 years ago
Simon Marquis	c7a5a5865b	Handle topic clicks from all destinations ... Closes #865	2 years ago
Alex Vanyo	65007350ab	Switch to new Activity.enableEdgeToEdge ... Change-Id: I9bbb7b2d116099524525619714ef18448e707c4f	2 years ago
Simon Marquis	09441774f5	Update NavigationTest.kt	2 years ago
Simon Marquis	4f7874874d	Update NavigationTest.kt	2 years ago
Simon Marquis	86d3031d94	Remove hardcoded topic names in `NavigationTest.kt`	2 years ago
Don Turner	8d90c4ec40	Fix for Retrofit R8 issue, bump version to 0.1.2 ... Change-Id: Ia90d693731c95248211b12b1ce2e9dfab0ecf34c	2 years ago
Márton Braun	1bef42844f	Merge pull request #752 from SimonMarquis/kotlin-1.9.0 ... Kotlin 1.9.0	2 years ago