Alex Vanyo
a9083d7bc6
Merge pull request #772 from SimonMarquis/patch-5
...
Update to latest stable AGP 8.0.2
3 years ago
Milosz Moczkowski
376a715a0c
Merge pull request #777 from android/bugfix/bookmarks_wrong_bg
...
Bookmarks screen has wrong background
3 years ago
Maximillian Leonov
bea3661f81
Merge branch 'main' into feature-settings
...
# Conflicts:
# feature/settings/src/main/java/com/google/samples/apps/nowinandroid/feature/settings/SettingsDialog.kt
3 years ago
Maximillian Leonov
7dadf033c1
Add comment for ColumnScope usage
3 years ago
Miłosz Moczkowski
7b30720b25
Remove nested scaffold from the bookmarks screen
...
Change-Id: Ie8b6f160d341156a6f9c02c0ca7f530095fb2950
3 years ago
Milosz Moczkowski
caaa82b909
Merge pull request #773 from android/refactor/simplify-icons
...
Simplify icons
3 years ago
Miłosz Moczkowski
479a2f00b0
Refactor icons
3 years ago
Milosz Moczkowski
1345764649
Merge pull request #770 from android/refactor/remove_unused_statements
...
Remove unused statements
3 years ago
Simon Marquis
fecab96e4c
Keep track of matching `Network`s inside `NetworkCallback`
...
This will ensure the connectivity state remains synchronized with the `ConnectivityManager`.
Fixes #714
3 years ago
Simon Marquis
14ce53562f
Update to latest stable AGP 8.0.2
3 years ago
Milosz Moczkowski
bdcd41e14e
Merge pull request #766 from android/refactor/remove_redundant_suppresions
...
Remove redundant suppressions
3 years ago
Milosz Moczkowski
9c77c45578
Merge pull request #765 from android/refactor/notification-dot-modifier
...
Notification dot improvements
3 years ago
Miłosz Moczkowski
83fa8c887f
Spotless apply
...
Change-Id: I80457acc6a49fe9755240a3d52ff96a8fdfd6b92
3 years ago
Miłosz Moczkowski
99094199bc
Remove redundant suppressions
...
Change-Id: Iae08b6f284cf7a387922fdec34c8a0aa0da809ef
3 years ago
Milosz Moczkowski
fb41a0118c
Merge pull request #758 from SimonMarquis/patch-5
...
Remove `ExperimentalCoroutinesApi` and `FlowPreview` opt-in
3 years ago
Miłosz Moczkowski
5bf66739bd
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
3 years ago
Miłosz Moczkowski
ded8b109b9
Refactor custom notificationDot modifier
...
Change-Id: Ife24492a495b111f111a8bd16f21b7ebd469e5aa
3 years ago
Milosz Moczkowski
2bf3018898
Merge pull request #763 from SimonMarquis/cleanup/unused-resources
...
Cleanup unused string resources
3 years ago
Milosz Moczkowski
eec9289be9
Merge pull request #764 from SimonMarquis/lint/ellipsis
...
Ellipsis string can be replaced with ellipsis character
3 years ago
Simon Marquis
9aba5cc0fe
Cleanup unused string resources
3 years ago
Simon Marquis
b453386327
Ellipsis string can be replaced with ellipsis character
...
Lint: Replace `...` with ellipsis character `…`
3 years ago
Simon Marquis
97a55c9dd5
Merge `AndroidCIWithGmd.yaml` into `Build.yaml`
...
Add dependency on the `build` job, and add the same timeout of 55 minutes.
Closes #761
3 years ago
Simon Marquis
c882dbd507
Testing... To be removed!
3 years ago
Simon Marquis
04ddc86298
Enable `checkDependencies` and run lint tasks on project roots
3 years ago
Simon Marquis
62db986836
Add lint plugin to the `:lint` module
3 years ago
Simon Marquis
ec7b7ac668
Call `github/codeql-action/upload-sarif` with the root folder as argument
...
It does not support path globbing.
3 years ago
Simon Marquis
8ea9a8fa51
Android Lint improvements
...
- Create `LintConventionPlugin` to configure Lint on all compatible modules: Android applications, Android libraries and JVM modules.
- Run `lintProdRelease` in CI instead of the default `lintDemoDebug` which is less important compared to production code.
- Rearrange CI steps to make it more clear that Lint should is an additional step after build (build -> test -> lint).
- Enable SARIF support and upload results to GitHub's CodeQL to get inline feedback on PRs.
If we really need better perfs, we could restore `lint.checkDependencies = true` on the `:app` module and only execute `:app:lintProdRelease`.
But in practice, this does not change the total build time on this project.
3 years ago
Simon Marquis
502f9ed110
Remove `ExperimentalCoroutinesApi` and `FlowPreview` opt-in
...
```
> Task :core:model:compileKotlin
w: Opt-in requirement marker kotlinx.coroutines.ExperimentalCoroutinesApi is unresolved. Please make sure it's present in the module dependencies
w: Opt-in requirement marker kotlinx.coroutines.FlowPreview is unresolved. Please make sure it's present in the module dependencies
```
3 years ago
Simon Marquis
8c8c7611ce
Update KotlinX Serialization to version 1.5.1
...
https://github.com/Kotlin/kotlinx.serialization/releases/tag/v1.5.1
> ### Bugfixes
> - KeyValueSerializer: Fix missing call to endStructure() (#2272 )
> - ObjectSerializer: Respect sequential decoding (#2273 )
> - Fix value class encoding in various corner cases (#2242 )
> - Fix incorrect json decoding iterator's .hasNext() behavior on array-wrapped inputs (#2268 )
> - Fix memory leak caused by invalid KTypeWrapper's equals method (#2274 )
> - Fixed NoSuchMethodError when parsing a JSON stream on Java 8 (#2219 )
> - Fix MissingFieldException duplication (#2213 )
3 years ago
Simon Marquis
8f41a6b3ab
Cleanup proguard configuration
...
- Remove custom KotlinX Serialization config as it's already provided, see https://github.com/Kotlin/kotlinx.serialization#android .
- Delete empty config files.
3 years ago
Simon Marquis
1c8c881e0e
fixup
3 years ago
Simon Marquis
a49f732442
Mention core-designsystem module in the modularization journey docs
...
Closes #189
3 years ago
Ale Stamato
0c8457099d
Merge pull request #733 from android/stamato/clicks-notification-dialog
...
Grant `permission.POST_NOTIFICATIONS` in Macrobenchmark tests
3 years ago
Adetunji Dahunsi
f914254414
Merge pull request #749 from android/tj/reactive-only-dao
...
Ensure DAO exposes only reactive types
3 years ago
Milosz Moczkowski
d3e7ab92e9
Merge pull request #751 from android/st/document-compiler-metrics-command
...
Added Compose compiler metrics generation command to README.md
3 years ago
Don Turner
29394467f1
Merge pull request #750 from android/tidy/scopes
...
Add general application scope, use IO dispatcher for DataStore
3 years ago
Alex Vanyo
d4d471f1c9
Merge pull request #747 from SimonMarquis/patch-4
...
Remove benchmark androidTest task exclusion
3 years ago
Don Turner
d319264ef0
Provide Default dispatcher for instrumented tests
...
Change-Id: I488a9b9d9d3864ce9496614ab35332ec19d06bcc
3 years ago
Alejandra Stamato
96c7ada651
Added Compose compiler metrics generation command to README.md
3 years ago
Alejandra Stamato
c64cf13b4e
Added Compose compiler metrics generation command to README.md
3 years ago
Alejandra Stamato
49c8ce700e
Fixing ScrollForYouFeedBenchmark
...
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
3 years ago
Don Turner
b245334a18
Updating TestDataStoreModule to use ApplicationScope
3 years ago
TJ Dahunsi
dcc36b0228
Fix tests
...
Change-Id: Ie6b62071d2023e3a7ffe1553ab606e3f6b386a5e
3 years ago
Don Turner
4cdb5963a0
Add top level application scope, use IO dispatcher for DataStore
...
Change-Id: I1512b1665587c73abd5e8a78aa9abd3eed24ab79
3 years ago
TJ Dahunsi
cd6ad7d575
Ensure DAO exposes only reactive types
...
Change-Id: I8992ccf6525cd4c5ea9503d532b500e4d310b7fb
3 years ago
Vixb
01e5a68a8d
Replace NiaTopLevelNavigation with TopLevelDestination based on #186 ( #723 )
...
* Replace NiaTopLevelNavigation with TopLevelDestination based on #186
* Update ModularizationLearningJourney.md
3 years ago
Simon Marquis
823c4db201
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
...
Continues the work initiated in #738 .
Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.
3 years ago
Simon Marquis
ae50f3d332
Remove benchmark androidTest task exclusion
...
Task `:benchmark:connectedDemoBenchmarkAndroidTest` is not part of the `connectedDemoDebugAndroidTest` task graph and can therefore safely be removed.
3 years ago
Don Turner
a03307e14d
Merge pull request #738 from SimonMarquis/patch-5
...
Grant `POST_NOTIFICATIONS` permission in instrumented tests
3 years ago
Don Turner
f87e769b7d
Merge pull request #681 from SimonMarquis/di/coroutine-scope
...
Add Application-wide `CoroutineScope` in the DI graph
3 years ago