Jolanda Verhoef
61a51f6701
Merge pull request #124 from camina-apps/removeCancel
...
remove explicit cancel calls in tests
3 years ago
Jolanda Verhoef
03c11df958
Merge remote-tracking branch 'goog/main' into jun9merge2
...
Change-Id: Ie5d6e5d0f88c9b2c6beeeaf0598f32487d86b82c
3 years ago
Jolanda Verhoef
2acae8f709
Merge pull request #127 from android/jun9merge
...
Internal > Public merge June 9th
3 years ago
Jolanda Verhoef
45dd9d0ed6
Fix broken test in Firebase Test Lab
...
Change-Id: Ia8246d4bc531fb3c52f4cdd77b0262b086849320
3 years ago
Jolanda Verhoef
d29a851b6b
Add Previews for Feature screens ( #72 )
...
* Add Previews for Feature screens
Change-Id: I02ce60230d327d879046ba84b894d951af76bbba
* Remove Scaffolds from previews
Change-Id: I0773e9016a1628c5ad95a139e28b192a8bce6dc0
3 years ago
Jolanda Verhoef
2f35893b2e
Merge remote-tracking branch 'github/main'
...
Change-Id: I8706d94ba2850646218fc982719c99991d93f34c
3 years ago
Carmen Geelhaar
4290884be5
remove explicit cancel calls
...
Change-Id: I38c85a9f0e29da0de805956a994b4ec4f8d1a684
3 years ago
Mohammad Ershad Nasri
e7ee1e11f8
Use checked parameter instead of !isSelected ( #50 )
...
* Use checked parameter instead of !isSelected
* Update AGP and gradle versions
* Revert "Update AGP and gradle versions"
This reverts commit c0fd351c82
.
* Remove the indentation changes
3 years ago
Simon Marquis
0edac18b10
Move `AuthorsCarousel`'s padding into `AuthorItem` ( #19 )
...
* Move `AuthorsCarousel`'s padding into `AuthorItem`
Fixes #18
* Restore the expected layout dimensions
* Add unbounded ripple effect on `AuthorItem`
* Remove unnecessary contentAlignment
* Set LazyRow contentPadding horizontal and vertical
* Add missing import after merge
3 years ago
kbuilder
8d706d7062
Merge branch 'github/main'
3 years ago
Jolanda Verhoef
b46f94a089
Merge pull request #21 from SimonMarquis/fix/empty-author-item-image
...
Replace empty `AuthorItem`'s picture with `Icons.Filled.Person`
3 years ago
kbuilder
18ff08dd0d
Merge branch 'github/main'
3 years ago
Jolanda Verhoef
c6397715d3
Merge pull request #42 from madroidmaq/rename-ui-state
...
Rename UI State sealed interface class with UiState postfix
3 years ago
kbuilder
91b9f12074
Merge branch 'github/main'
3 years ago
Saeed Noshadi
829d4daf27
run spotlessApply task
3 years ago
madroid
c4d85d07df
Fix ktlint: max line length (100) in ForYouScreenTest.kt
3 years ago
Saeed Noshadi
f55ad14a3d
remove colors
3 years ago
Saeed Noshadi
ecd52300c2
used NiaFilledButton instead of Button
3 years ago
Saeed Noshadi
9998658210
revert a import line
3 years ago
Saeed Noshadi
06072be56c
fix done button color in the darkmode and lightmode
3 years ago
madroid
084b9b607a
Fix ktlint: max line length (100)
3 years ago
Simon Marquis
1959ee53d2
Replace Filled.Android with Filled.Person icon in InterestsIcon
3 years ago
madroid
25b26bdf13
rename ForYouInterestsSelectionState -> ForYouInterestsSelectionUiState, ForYouFeedState -> ForYouFeedUiState
3 years ago
Simona Stojanovic
7cf8693923
Add common build convention for feature modules
...
Change-Id: I24d54343de2835fff4f7a8dfc598b9a1864ffec7
3 years ago
Simon Marquis
e5b2b22b03
Replace empty `AuthorItem`'s picture with `Icons.Filled.Person`
...
Duplicated from `NewsResourceAuthors`.
Fixes #20
3 years ago
Simona Stojanovic
febbd26261
Refactor navigation
...
Change-Id: I3501446e73976f3872592038501fcef8c8324f74
3 years ago
Caren Chang
b81ba74a14
Fix onboarding topic name cropped at bottom
...
Bug: 231310262
Change-Id: I8eee6b871c8f36765591d01e9d971b5d8a6f4387
3 years ago
Alex Vanyo
25f2e39c62
Update for you top app bar
...
Change-Id: I95c8082198e1d1068e9ef674b005d7999e1b4542
3 years ago
shed
a3eccce0ec
UI polish for "For You" Onboarding Screen [ http://b/228070817 ]
...
1. Fixed - Primary container surrounding check mark is too large - refer to Figma for padding values
2.Fixed - Done" button color should be black.
3. Fixed - Margin between bottom of ""done"" button and top of card should be increased.
4. Fixed - Elements within card container should have 16px of padding. Corners should be rounded to 24px
5. Fixed: Headline font should be Euclid and needs to be reduced in size. Refer to type styles in Figma for full specs.
6. Not Fixed (see b/227246491)- Missing save icon
7. Fixed: Date font should be Roboto mono.
8. Not Fixed: Missing ""unread"" indicator dot.
9. Not Fixed: Missing source URL or category tag
8. Fixed: Body copy in card should be Roboto (refer to type styles in Figma for full specs)
Change-Id: I76252bd40037f7f7a987c8d45681b9b6b6243823
3 years ago
Jolanda Verhoef
ce0142b98a
Add gradient background to For You Screen
...
Change-Id: I6a85ee82a78b1897020f1737503611bd100764a1
3 years ago
Alex Vanyo
cce9402b04
Add multi-column support for cards on the for you feed
...
Fixes: 228074722
Change-Id: Id077b4dd93452b5f9399f94161c9b66594436975
3 years ago
Adetunji Dahunsi
9ffa4d0a20
Add bio to AuthorEntity
...
Change-Id: Idea9873e2a3107a03f6d30e888e27ba78466ca69
3 years ago
Caren Chang
9b7d6344e4
Fix ic_icon_placeholder.xml formatting
...
Change-Id: I0cdfb8bbb353b47715461b14f257c9b49b3b7ffe
3 years ago
Adetunji Dahunsi
4d72950f94
Add news resource cards to topics screen
...
Change-Id: Iaab014904460988296ea93cc2088c8da93ed17f1
3 years ago
Caren Chang
635abb4dc2
Add topic icon on topic chips
...
Bug: 228070748
Change-Id: I736f4029bed84cf1d5552c5afa7ba07896e86602
3 years ago
Alex Vanyo
203c8e1ceb
Configure spotless for kts and xml files
...
Fixes: 230874524
Change-Id: I147b9f16d5424b3459435e3c5422867b40c480b7
3 years ago
Simona Stojanovic
7968a70398
Rename core-domain to core-data
...
Change-Id: Ief2eef982c9ebe4be729bee1d2f59e2ab8b1f911
3 years ago
Alex Vanyo
a5f679063d
Add loading indicator while for you data is loading
...
Updates the for you view model to support displaying a loading
state when data hasn't loaded yet.
This is a somewhat involved CL, because there are multiple ways
in which data could be loading: We could have topics, but
the feed itself could be loading after we selected a new set
of topics.
Change-Id: I8662140c7132b195f85e69fee8e18745829ae975
3 years ago
Caren Chang
2e4c763db5
Add dependency for Compose Previews to render
...
Bug: 228869437
Change-Id: I44a1457916e87f22dda077f4fc34d630b54f6869
3 years ago
Alex Vanyo
f84320e9a9
Fix large screen insets handling
...
Bug: 228374243
Change-Id: I2a7af72e60450be3280872b46bd84eb1079b533d
3 years ago
Adetunji Dahunsi
643b230187
Converted model ids from ints to strings
...
Change-Id: Iad07926e04113bcd2c6d9e06e5e2a4e802a79b80
3 years ago
Milosz Moczkowski
0dfc2f4fa7
Add TopAppBar to the For You screen
...
Change-Id: I66730ebfcd65d16304c87ba64a66e8f5b03291c4
3 years ago
Alex Vanyo
b677cc4508
Convert all build files to kts
...
Change-Id: I26bf730ee51f62cbd604c02b628c1f277cfceb72
3 years ago
Simona Stojanovic
2145f6a7cd
Add initial loading wheel animation
...
Change-Id: Iaf4f80c34914022d79c7e089799fc6dd5554a532
3 years ago
Alex Vanyo
f9d8d45ecb
Update to lifecycle 2.5.0-beta01
...
Change-Id: I9537006378e64a64da8053559bb16ab046e21246
3 years ago
Miłosz Moczkowski
707c9d04e7
Revert "Add TopAppBar to the "For You screen""
...
This reverts commit 3e664f1b724a620ad606cda0d4758240d80073ab.
Reason for revert: This change doesn't pass one of the tests
Change-Id: I9ffacbe4eaf1080323a7c9073dfe426a8f43345c
3 years ago
Milosz Moczkowski
fb0ed61ac8
Add TopAppBar to the "For You screen"
...
Change-Id: I0bb1a5038d697adebad4e662755baaba72ded529
3 years ago
Alex Vanyo
356d00531a
Allow saving authors and topics only
...
Bug: 229012243
Change-Id: I4c8bc77002d39b8f97c925ea811d307e2cbe93db
3 years ago
Manuel Vivo
de2f07d1a4
Add People carousel
...
Screenshot: https://screenshot.googleplex.com/9K6C4NZMfMzCABE.png
Change-Id: I32b0240910df6a953c8843895f3b7e22d5adc5de
3 years ago
Alex Vanyo
ca73f5598f
Setup convention plugins base
...
Change-Id: I66ea3a5c95ca9d87a1f0da39b6ba72faffc320ed
3 years ago