ee4320723f
Fix typo.
...
Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f
2 years ago
ed91723e2f
Fix #1270
...
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
2 years ago
db5e2b649e
Remove unnecessary Boxes
...
Change-Id: Ia404cde7f6b555234bef4b27058fabd4471ea3c6
2 years ago
2271d01da5
Fix spotless
...
Change-Id: I8d19c437fc6e2e2198af5ac871c3f7813d280923
2 years ago
b1d867f827
Replace BoxWithConstraints with Box (fixes linter error)
...
Change-Id: Iea0401e28ae0e884511800652fde0f1896642aa0
2 years ago
f64f1c0aa2
Remove legacy benchmark build type ( #1207 )
...
* Remove legacy benchmark build type
Now that we have the baseline profile gradle plugin,
there is no need for a benchmark build type.
The plugin does the setup and configuration and runs against the
correct app flavor.
* Remove explicit benchmark build type from benchmark module
* Remove stale build task exclusions
* Fix tracing import location
FYI @mlykotom
2 years ago
d9aaec0699
Use androidx.tracing everywhere
...
Change-Id: I847827efc08f5cbc00f0c809ad992c267f826e50
2 years ago
707117a4f2
Merge branch 'main' into kotlinify
2 years ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
2 years ago
65f0d5b2d9
Update feature/foryou/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/foryou/navigation/ForYouNavigation.kt
2 years ago
9d41ffa318
Merge branch 'main' into kotlinify
2 years ago
2a2d8ed88d
Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE
2 years ago
32e1ec0447
Remove violations: property-naming
2 years ago
f8f932705a
Remove violations: discouraged-comment-location
2 years ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
2 years ago
03d2455f41
Use lazy vertical staggered grid in feed to maximize space utilization
...
Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926
3 years ago
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
3 years ago
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
3 years ago
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
3 years ago
4e6cda1965
Renamed toggle function signature with boolean parameters
...
Change-Id: I0d6c0ed4d4c0ee4bd387e5645fc558970f5f202b
3 years ago
153b34fd50
Merge pull request #850 from qamarelsafadi/loading-progress-for-image
...
Fix #849 : Loading progress for image
3 years ago
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
3 years ago
2db3e0c804
Merge branch 'android:main' into loading-progress-for-image
3 years ago
8901e5932a
Merge pull request #872 from SimonMarquis/data-objects
...
Convert 'sealed' sub-object to 'data object'
3 years ago
8aa0457ca9
Merge branch 'android:main' into loading-progress-for-image
3 years ago
03610d229a
Update feedItemsSize calculation
...
Change-Id: I2bf6a2fa0e210cef1318707d948a49d2ef010452
3 years ago
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
3 years ago
b7799f0475
Convert 'sealed' sub-object to 'data object'
3 years ago
f1a2993adc
feat: remove add placeholder todo
3 years ago
e13e84c155
Replace usages of 'displacement' to 'moved' in parameter names
...
Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a
3 years ago
eeb4973265
PR feedback
...
Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f
3 years ago
cb1d50e65e
Even better names
...
Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65
3 years ago
3aec705048
Add padding to scrollbars
3 years ago
31b4841cb2
Add scrollbars to app
3 years ago
4af86580eb
Move analytics tracking of news deep link to an extension method
...
Change-Id: Id3d1a30d86634b9176067696db5ecfd4d02854a5
3 years ago
c4686cfa54
Track when deep link notifications are opened
...
Change-Id: I223b1c8fbca36f9b7f2a35d9cb2fa901d6f5be91
3 years ago
19ffb53150
Don't use lambda contentType for a single item
...
Change-Id: I0588c031428d523707463c5f0f0b6c586ea5e2c3
3 years ago
4a8a43551a
Add contentType to news feed
...
Before
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5
frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
After
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2
frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef
3 years ago
512930c239
Fix inline comment as suggested in PR
3 years ago
87c27f6b82
Apply suggested changes to inline comment
3 years ago
dd70bbd589
Fix ForYouScreen Compose Previews
...
Permissions should only be called in an Activity context, which is a layoutlib limitation. We need to avoid launching the permission request when in LocalInspectionMode, otherwise we'll have render errors on the ForYouScreen previews.
3 years ago
9aba5cc0fe
Cleanup unused string resources
3 years ago
5d51cdcd28
Fix navigation tests
3 years ago
ef97cb941c
Route notification deep link through for you screen
3 years ago
2499c0a0bd
Notify users when news are updated
3 years ago
050db2cb72
Merge branch 'main' into jr/track-viewed
3 years ago
3b7e7e3c02
Use ReportDrawnWhen
...
Change-Id: I77b4db63f72f43c6c826e66358f7672792ef137d
3 years ago
08956492c8
Backend triggered sync
...
Change-Id: I53c43b136ebb755f6258b1e815301dddb3b536a3
3 years ago
93c01ad184
Fix trailing commas based on spotless check
3 years ago
049750dd51
Merge branch 'main' into ui-polish
3 years ago
Jaehwa Noh
Don Turner
Ben Weiss
Tomáš Mlynarič
Don Turner
Simon Marquis
lihenggui
dahunsi
Simon Marquis
Roy Matero
Adetunji Dahunsi
Qamar A. Safadi
qamarelsafadi
TJ Dahunsi
Amaury Medeiros
James Rose
Chris Sinco