Don Turner
a4c52e6485
Remove the search module's dependency on other feature modules
...
Change-Id: I17df9948fed04ddc7ba507b437d39536b8b180bb
10 months ago
Tomáš Mlynarič
f31fdb3ec2
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Id49a580012629163ec4a3663d95ab71b98910220
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
# gradle/libs.versions.toml
11 months ago
Don Turner
68c15a891c
Fix text styles and spacing now that includeFontPadding is false
...
Change-Id: I6894836a7cd3a6139511a5d1ac0a96702a265186
11 months ago
Tomáš Mlynarič
ea1573fcc1
Use kotlinx.datetime.Timezone instead of java ZoneId
...
Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628
12 months ago
Tomáš Mlynarič
44ae059a2b
Rename LocalTimeZone -> LocalZoneId + collects with lifecycle
...
Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3
12 months ago
Tomáš Mlynarič
cb00d2c8cb
Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers
...
This way, we can save ~1ms per composed item on screen.
Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d
12 months ago
Don Turner
707117a4f2
Merge branch 'main' into kotlinify
1 year ago
Don Turner
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
1 year ago
Don Turner
9d41ffa318
Merge branch 'main' into kotlinify
1 year ago
Simon Marquis
b6d82e24df
Merge branch 'main' into kotlinify
1 year ago
lihenggui
f8f932705a
Remove violations: discouraged-comment-location
1 year ago
lihenggui
fb5bd225be
Spotless
1 year ago
Ben Trengrove
3142ecb495
Remove redundant mutable state
1 year ago
Simon Marquis
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
1 year ago
dahunsi
77451779cd
Use animateItemPlacement() on feed
...
Change-Id: Id120a6e84e0641679fa54ebf0e34bb04165aa419
1 year ago
dahunsi
03d2455f41
Use lazy vertical staggered grid in feed to maximize space utilization
...
Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926
1 year ago
Simon Marquis
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
1 year ago
Simon Marquis
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
1 year ago
Simon Marquis
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
1 year ago
Jose Alcérreca
6c0d6ad82e
Fixes icons size in onboarding and restores LocalInspection for images ( #909 )
...
* Fixes icons size in onboarding and restores LocalInspection for images
1 year ago
Simon Marquis
0ced769999
Widen `isNotEmpty` with `isNotBlank` to potentially catch blank values
1 year ago
Simon Marquis
4a5ec5bd82
Update `var` with fake default value to the more "correct" `lateinit var`
1 year ago
Simon Marquis
f1bc6f1226
Restore `Unknown` type as empty `String`
1 year ago
Simon Marquis
c831dc673c
Fix broken text
1 year ago
Simon Marquis
daa2228132
Restore original `type` labels
1 year ago
Simon Marquis
480d8e7d7c
Fix missing removal
1 year ago
Simon Marquis
0377fd8712
Replace `NewsResourceType` enum with simpler String type
...
See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901
1 year ago
Adetunji Dahunsi
153b34fd50
Merge pull request #850 from qamarelsafadi/loading-progress-for-image
...
Fix #849 : Loading progress for image
1 year ago
Don Turner
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
1 year ago
qamarelsafadi
308f51f87d
Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
1 year ago
Qamar A. Safadi
2db3e0c804
Merge branch 'android:main' into loading-progress-for-image
1 year ago
qamarelsafadi
5d7e33d905
fix formatting
1 year ago
qamarelsafadi
f203e9a218
feat: replacing SubcomposeAsyncImage as its not recommended to use with lazyLayout
1 year ago
Simon Marquis
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
1 year ago
Simon Marquis
b7799f0475
Convert 'sealed' sub-object to 'data object'
1 year ago
qamarelsafadi
5bbcc904e9
feat: make painter in one line
1 year ago
Qamar A. Safadi
9f3103c212
Merge branch 'android:main' into loading-progress-for-image
1 year ago
prosixe
c779b4e8ca
Typo fix for topics
...
tocpis -> topics
1 year ago
qamarelsafadi
57025e7587
fix: review notes
1 year ago
qamarelsafadi
8a197800c5
feat: fix format issue
1 year ago
qamarelsafadi
7a05f7db96
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
2 years ago
qamarelsafadi
3284eb68a3
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
2 years ago
qamarelsafadi
42b16bf7be
Merge remote-tracking branch 'origin/main'
2 years ago
Qamar Safadi
ee8b70003d
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
2 years ago
ahmedmadhoun1
3114b2eeaa
Allow localised date format
2 years ago
Tomáš Mlynarič
8e1e994bb1
Add named arguments
...
Change-Id: Ic91ae4fc04bf8eb92c3e5845c7e984475526ec91
2 years ago
Tomáš Mlynarič
4a8a43551a
Add contentType to news feed
...
Before
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5
frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
After
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2
frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef
2 years ago
Miłosz Moczkowski
479a2f00b0
Refactor icons
2 years ago
Miłosz Moczkowski
5bf66739bd
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
2 years ago
gururani-abhishek
f6bdba08d9
added comment to document what happens on tapping news resource card.
2 years ago