363 Commits (c3ac3290c6dd0d137d7ee4d6c714de4e86885860)

Author	SHA1	Message	Date
Don Turner	da8f32a2ea	Rename Destinations to Routes ... Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7	7 months ago
Don Turner	8a15a61a50	Merge pull request #1419 from android/av/fix-state-loss-with-workaround ... Fix state loss with workaround	7 months ago
Don Turner	488b97a071	Update app/src/main/kotlin/com/google/samples/apps/nowinandroid/ui/NiaApp.kt	7 months ago
alexvanyo	8f2beaf889	🤖 Updates screenshots	7 months ago
Don Turner	be752e779d	Fix tests, fix spotless ... Change-Id: I55e779abe4ee49dc93916d9e1184ed81e1b2bbd0	8 months ago
Don Turner	aba2b2c154	Remove different deeplink destination, add route for nested nav host ... Change-Id: Idb9586752d815449243d6d529e9b655c45e395ad	8 months ago
Don Turner	68152e5056	Update to adaptive alpha12, fix merge issues ... Change-Id: I99703db37712abb46b844beb73bb14ddd5283165	8 months ago
Don Turner	f711e69cd2	Merge branch 'main' into dt/nav-safe-args (AnimatedPane broken) ... * main: Save nested nav key in instance state 🤖 Updates baselines for Dependency Guard Recreate nested nav to work with AnimatedPane Remove forgotten Trace.endSection() Offload connectivity monitor to a background thread Change-Id: I4002a07484a4d633c57406aedabf9f5d813a8592	8 months ago
Don Turner	4a84cf2bf4	Add specific type for deeplinks ... Change-Id: I63c0abb16cbf540ef72dfb945518a48113bdbf75	8 months ago
Don Turner	173ac6711a	Remove autoVerify from intent filter ... Change-Id: Ia7460a618b2ddf8a25debce92308573bc18368a8	8 months ago
Don Turner	f67f4d1a83	Update ForYou destination to match current deeplink pattern ... Change-Id: Ia5ab36f2d75d8d061e63c0cac5262503bc93a638	8 months ago
Don Turner	7ec21d9d2f	Fix issue where selected topic in list was not showing as selected. Minor tidy ups. ... Change-Id: Icfa79eac6f7327c365f79fd7d15dfa1f8c77184d	8 months ago
Alex Vanyo	3fb6df7c33	Add NavigationSuiteScaffold ... Change-Id: I36710d880bff381ed86c61632f2ab91902727775	8 months ago
Alex Vanyo	a324fcc8d3	Fix state loss with workaround ... Change-Id: I96025bd8b2f4f59019df95d1391b832249e7dc91	8 months ago
Alex Vanyo	c2fc34c761	Save nested nav key in instance state ... Change-Id: If1155bfbe080eb4df3c59faaec0fb4cd4da3821d	8 months ago
Alex Vanyo	1c0508a678	Recreate nested nav to work with AnimatedPane ... Change-Id: I6b526331b7fc62b968ac39e91753a8a1e5343023	8 months ago
Don Turner	2264451bb8	Use navigation argument topicId as default value to InterestListDetailScreen ... Change-Id: I659f729191bce00683b1621c360c8f36f00595f9	8 months ago
Don Turner	116e961f1b	Change startDestination from KClass to default instance ... Change-Id: Ia5bb0abd366653aff5cf5a772ac11a837e96b9b1	8 months ago
dturner	8cc0fc00e6	🤖 Updates screenshots	8 months ago
Don Turner	924391cd22	Fix spotless ... Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428	8 months ago
Don Turner	2d45b84031	Merge branch 'main' into dt/nav-safe-args	8 months ago
Don Turner	29e08ea1a0	Add deeplink action to enable testing from terminal ... Change-Id: Ia112f87c7f1bb7fa9ebe08b82d26e00b4ad17d05	8 months ago
Don Turner	9779074997	Remove Interests2PaneViewModel as it was overkill for holding a single string value ... Change-Id: I4767578028b55c2bc7b1763bdeef87345b9fbf06	8 months ago
Don Turner	89163b5ea1	Migrate remainder of app to type-safe navigation ... Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b	8 months ago
Don Turner	490997281a	Update to alpha08, use toRoute to obtain destination inside VM ... Change-Id: I72f617c594b5e0ae272cf94d2d7288446153420a	8 months ago
Don Turner	d96bcf8ffe	Migrate Interests nested NavHost to safe args ... Change-Id: I4f3c310be693ecbcbc8b99c4e573d7fc6e9a2f74	8 months ago
Don Turner	afad1b9ac7	Merge pull request #1383 from android/av/navigation-2.7.7 ... Update to navigation 2.7.7	8 months ago
Alex Vanyo	068cee0278	Add workaround for state loss bug ... Change-Id: I7ac4495c8e3ada419358688c61214c33c0d4040e	8 months ago
Jose Alcérreca	ead3f49f7b	Fixes flakiness in app's screenshot tests (#1395) ... * Disables WM init in app's screenshot tests Change-Id: Ib0994e744f49b53f58c0eebd52f80c0eba67bbed * Spotless Change-Id: Ic0212889354481433ce45ec4292ae7be9bd24b2e * [CI] Uploads roborazzi reports if they fail Change-Id: I5a25a7e156d3fcb72a396d3b503e62068a20b417 * Uses unused test module and enables LocalInspection Change-Id: Iac36347dc3d702248d7515a74823e0bc0cbf2a2b * Fixes timezone in snackbar screenshot tests Change-Id: Ic517e8822218abeaddd3f8d2740b03e651d72d31 * Fixes conflict Change-Id: Ia42fb78781d2469a608183594fc25c7c69f7e76c * 🤖 Updates screenshots	8 months ago
Jose Alcérreca	1da560f582	Revert "Configure baseline profiles in the baselineProfile lambda" (#1398) ... This reverts commit 7980c1d0df.	8 months ago
Ben Weiss	7980c1d0df	Configure baseline profiles in the baselineProfile lambda (#1060) ... * Configure baseline profiles in the baselineProfile lambda * This is the correct and easiest way to set up baseline profiles correctly. * See b/313428246 for more context. * Handle empty topics during baseline profile generation * Revert to API 33 GMD and fail empty screen tests * Rename withChildren to noChildren for better legibility * Remove unused log tags * Update benchmark and metrics versions * 🤖 Updates baselines for Dependency Guard --------- Co-authored-by: Tomáš Mlynarič <mlykotom@google.com> Co-authored-by: Jaehwa Noh <shwoghk14@gmail.com>	8 months ago
Don Turner	c7d5cb4012	Replace TestHarness with DeviceConfigurationOverride after merging main ... Change-Id: Ie49b67981929fd3932ce3da68571a6305cf67aef	9 months ago
Don Turner	61cce4bf19	Merge branch 'main' into replace-testharness	9 months ago
Alex Vanyo	9b4c22cb2d	Update to material3-adaptive alpha10 ... Change-Id: I810c36323a35c445c22dd3876c52df0360a5cb48	9 months ago
Alex Vanyo	0be0bc191f	Update usage of material3 adaptive to be edge-to-edge ... Change-Id: I481c79db77bbdd657182f5355200f63e2355f40d	9 months ago
Jose Alcérreca	16f45c0b1a	Adds screenshot tests for snackbar (#1343) ... * Adds screenshot tests for snackbar Change-Id: I81566e3301fb17e3f31cbc408e6cc3325eab5a12 * Small tweaks, RFR Change-Id: Ia16db6e6f5bec2714081b5ceaeeba36b2ee26105 * 🤖 Updates screenshots * Update NiaApp.kt Adds modifier to NiaApp	9 months ago
Don Turner	739dc00987	Fix spotless ... Change-Id: I98a9b9fa1de5cc0bb3a3caa7d795053fd784b238	9 months ago
Don Turner	fc2146c970	Merge branch 'main' into replace-testharness	9 months ago
Don Turner	655aebccdc	Remove workaround for https://issuetracker.google.com/327149166 ... Change-Id: I335f9f5da1ff3f2574acca8e3fcb27b949a07c7a	9 months ago
yongsuk44	e2a4706470	Remove unnecessary opt-in annotations	9 months ago
Jonathan Koren	dac1a9e446	Topic detail pane placeholder (#1280) ... * Topic detail pane placeholder Change-Id: I92b84493a5406240285c0759b30aa10d29871f09 * Add modifier parameter Change-Id: Ie363be83b44f26291030c04c1513cecb851a6899	10 months ago
Alex Vanyo	cc02c30b8e	Update material3-adaptive to 1.0.0-alpha08 ... Change-Id: Ic218c6b061b5cea4e56b544073541421862bc1d0	10 months ago
Jaehwa Noh	d67b1a2504	Merge branch 'android:main' into rename-test-function	10 months ago
Jaehwa Noh	e017b84a12	Remove explicit type argument. ... Change-Id: Id02756d780309af6638698de856b563d9e775cc3	10 months ago
Jaehwa Noh	8cfd42453c	Rename test function name ... - Given-when-then format. Change-Id: I3305c5a7cc5a0f41be31292534a086034f642404	10 months ago
Jonathan Koren	19f6f9e09a	2 pane support in Interests screen (#1234) ... * Add dependency on material3 adaptive Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6 * Add InterestsListDetailScreen composable Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971 * Store selectedTopicId in InterestsViewModel Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce * Pass detail pane composable down Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293 * Navigate to initial topic if provided Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b * Lift LDPS up to app module Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85 * Fix some navigation behavior Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b * Navigate to initial topic if provided Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed * Remove dependency in interests feature module Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f * Hide back arrow when the topics list is visible Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8 * Update interests tests Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd * Highlight selected topic when displaying 2 panes Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415 * update dependency baselines Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00 * run spotless apply Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8 * Convert isListPaneHidden to isListPaneVisible Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657 * Set semantics for selected state Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca * Use scaffold roles when determining visibility Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648 * Update multipleBackStackInterests test Change-Id: I1e372f7989817151a6765205291b13b561187fa8	10 months ago
Don Turner	2d610b0775	Merge branch 'main' into replace-testharness ... * main: (37 commits) Disable animations of instrumented tests (#1167) Bump gradle/wrapper-validation-action from 1 to 2 Remove unused release variable. Fixes #1231 Apply Composable Parameter Ordering Guidelines Remove kotlinx-coroutines-guava dependency from :sync:work Add explicit guava-android dependency for :sync:work Extract ScreenshotHelper to separate testing module Update AGP to 8.3.0 Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert. 🤖 Updates baselines for Dependency Guard Bump the kotlin-ksp-compose group with 6 updates 🤖 Updates baselines for Dependency Guard Bump hilt from 2.50 to 2.51 Bump com.google.truth:truth from 1.1.5 to 1.4.2 Move java to kotlin folder. Remove disk usage testing Figuring out what is using 66Gb in the runner Dpm Improve converting to kotlin timezone Use trySend multiple times ... Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a	10 months ago
Don Turner	7737368c0e	Update app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt ... Co-authored-by: Alex Vanyo <vanyo@google.com>	10 months ago
Jaehwa Noh	1ca0085423	Merge branch 'android:main' into java-to-kotlin	10 months ago
Tomáš Mlynarič	f31fdb3ec2	Merge branch 'main' into mlykotom/tz-perf-improvement ... Change-Id: Id49a580012629163ec4a3663d95ab71b98910220 # Conflicts: # app/dependencies/prodReleaseRuntimeClasspath.txt # app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt # gradle/libs.versions.toml	10 months ago
Jaehwa Noh	9b488bf70a	Move java to kotlin folder. ... Change-Id: Iaf4723dea6169fbf3f9a8d3bf8779179ac56ab86	10 months ago
dturner	43b2240bdd	🤖 Updates screenshots	10 months ago
Don Turner	73d0b70f21	Workaround for new ForcedSize behaviour, bump ui-test version ... Change-Id: Ibf93c1b65250e6527e34bc90602c1b1001b2df46	10 months ago
Don Turner	fa811ab85f	Bump to ui-test:1.7.0-alpha03, add parameter name ... Change-Id: Ib1bbe4ad0d823c632d387587aa55c5eeb39e4b8d	10 months ago
dturner	50d5583fe1	🤖 Updates screenshots	10 months ago
Don Turner	d6357be8c4	Replace Accompanist TestHarness with DeviceConfigurationOverride ... Change-Id: I6742d5e221f86a019f44d3e623609bf76d2a3a2a	10 months ago
dturner	27fd4e544a	🤖 Updates screenshots	10 months ago
dturner	02d4fea615	🤖 Updates screenshots	10 months ago
Don Turner	a507ff6d8e	Wrap NiaApp with NiaTheme for app screenshot tests ... Change-Id: I8e298da139b19721b90ae778e7ab184f600d0bd7	10 months ago
Tomáš Mlynarič	75a3295381	Merge branch 'main' into mlykotom/tz-perf-improvement ... Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c # Conflicts: # app/dependencies/prodReleaseRuntimeClasspath.txt # build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt	10 months ago
dturner	6b2b01ed82	🤖 Updates screenshots	10 months ago
Tomáš Mlynarič	58483b6166	Revert fast initialization of Coil ... As discussed in https://github.com/coil-kt/coil/issues/2097 the problem is caused by regitering system services, which will be fixed in 2.6.0 Change-Id: I9085309780508137f10b25ff82deed3c62e5d159	11 months ago
Tomáš Mlynarič	f3e89bad4a	Add braces ... Change-Id: I859babab7278137a4a2e49e5a085c65632888dd0	11 months ago
Tomáš Mlynarič	d1211f15e7	Inline initialization ... Change-Id: I0a77eb6457cac27c1a4d604c8efdcbbdce95bc48	11 months ago
Tomáš Mlynarič	e853748cf7	Don't use runBlocking if async init completed ... Change-Id: I641187ce277f434c6fca49a11b3cfccd50ecf5da	11 months ago
Tomáš Mlynarič	7c33946ce1	Launch loader directly without additional coroutine scope ... Change-Id: Icbbdbcbcac1a6275857ebe998509f1e09109db7a	11 months ago
Tomáš Mlynarič	8e3903e90c	Fix comment ... Co-authored-by: Yuri Schimke <yuri@schimke.ee>	11 months ago
Tomáš Mlynarič	5f0612102d	Improve lazy loading for Coil + OkHttp ... This way, we can load Coil's backend on a background thread and not block the MainThread with it. Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames. Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62	11 months ago
Tomáš Mlynarič	12a3a6edde	Use trySend multiple times ... Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032	11 months ago
Tomáš Mlynarič	f8e797fd26	Rename currentTimezone variable ... Change-Id: I92630f6851b0253294a8d3ec2e5b3cbe7db74b4d	11 months ago
Tomáš Mlynarič	ea1573fcc1	Use kotlinx.datetime.Timezone instead of java ZoneId ... Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628	11 months ago
Tomáš Mlynarič	44ae059a2b	Rename LocalTimeZone -> LocalZoneId + collects with lifecycle ... Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3	11 months ago
Tomáš Mlynarič	cb00d2c8cb	Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers ... This way, we can save ~1ms per composed item on screen. Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d	11 months ago
Don Turner	f5b3ae56dc	Merge pull request #951 from SimonMarquis/issue-945 ... Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`	1 year ago
Don Turner	691bf2aad6	Merge pull request #785 from SimonMarquis/optimize-avd ... Optimize AVD to fix long vector paths Lint warning	1 year ago
SimonMarquis	afdfd8acc5	🤖 Updates screenshots	1 year ago
Simon Marquis	377d3bef0c	Optimize AVD to fix long vector paths Lint warning ... ... with SVGOM, but you'll have to check on Android Studio the AVD diff. https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html	1 year ago
Don Turner	707117a4f2	Merge branch 'main' into kotlinify	1 year ago
Simon Marquis	0699efc592	Merge branch 'main' into issue-945	1 year ago
Simon Marquis	be9dc533e3	Replace `Enum.values()` with `Enum.entries` ... 'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9	1 year ago
Don Turner	a5c030f740	Merge pull request #956 from KDW03/add_saved_test ... Add Test for Saved Top Level Destination	1 year ago
Don Turner	89d39a7242	Merge pull request #767 from SimonMarquis/resource-prefix ... Enforce `resourcePrefix` on Android library modules	1 year ago
Don Turner	9d41ffa318	Merge branch 'main' into kotlinify	1 year ago
Don Turner	ad15f0137e	Merge pull request #1094 from lihenggui/main ... Upgrade Spotless and Ktlint and remove code convention violations	1 year ago
Don Turner	8d5ef578c6	Merge pull request #1103 from android/add_icon_comment ... Add comment explaining why the launcher icon colors differ per build	1 year ago
Simon Marquis	b6d82e24df	Merge branch 'main' into kotlinify	1 year ago
Don Turner	b801a7deea	Moving comments to _after_ first XML element ... Change-Id: Id4271a67ffcfbd712a2dd1f363970fcd31ee5ac0	1 year ago
lihenggui	2a2d8ed88d	Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE	1 year ago
Don Turner	d018e57f52	Fix spotless ... Change-Id: I5dea4fec5b391e8cb7794af13e99978fcb622fbb	1 year ago
Don Turner	e6b5560f07	Revert "Move app screenshot tests to match dependencies declaration"	1 year ago
Don Turner	28bb3f1b2f	Add comment explaining why the launcher icon colors differ per build variant ... Change-Id: I30126402370162ccbe53e177652583e4472f2030	1 year ago
Simon Marquis	83764082ff	Move app screenshot tests to match dependencies declaration ... Fixes #990	1 year ago
lihenggui	32e1ec0447	Remove violations: property-naming	1 year ago
lihenggui	fb5bd225be	Spotless	1 year ago
Simon Marquis	caa482bc71	Kotlinify codebase ... - Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)	1 year ago
Simon Marquis	988002e692	Update Robolectric 4.11.1 ... - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11 - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1 > Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below. Removing explicit API 33 Robolectric configuration.	1 year ago
Miłosz Moczkowski	9c89e98e5b	Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold" ... This reverts commit 335a7ec68c, reversing changes made to aa8ce0e1f6.	1 year ago
mmoczkowski	f365e8b782	🤖 Updates screenshots	1 year ago
Miłosz Moczkowski	816a7b60c1	Replace manual navigation component switching with new NavigationSuiteScaffold ... Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723	1 year ago
Jose Alcérreca	3f22248cb7	[CI] Better caching and fewer jobs run ... * [CI] Runs build in macos to generate a cache for androidTest runs * Build projects before running emulator * Fixes flaky coroutines test * Moves spotless up in local tests job * Enables config cache by setting problems to warn. Fixes #1022	1 year ago