448 Commits (c396352d83f9bbf1d86dae3c52c89fb66a9bcd05)

Author	SHA1	Message	Date
Don Turner	3868371ec8	Switch default padding to true since this was actually false by default since Compose 1.6.0-alpha01 ... Change-Id: Ifd291b247f848cea43e084cc0fb99917e47e26eb	10 months ago
Don Turner	c773fd7d0a	Switch off default font padding to avoid changing UI ... Change-Id: Ida974df8fd4b1aba6f9525ef5335a6cbe02ddb18	10 months ago
Don Turner	3b1ee87194	Fix ShortText icon ... Change-Id: I8b243ef88c1cc8be83f5fbeaee6a2576c453a062	10 months ago
dturner	6b2b01ed82	🤖 Updates screenshots	10 months ago
Don Turner	522efac8c0	Update Compose BOM to 2024.02.00. Fixes #1218 ... Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b	10 months ago
Tomáš Mlynarič	4cdc2ad345	Add comment for Retrofit async OkHttp ... Change-Id: Ic7a6887b76caf26f00b58b0753271d426b67e75b	11 months ago
Tomáš Mlynarič	d110d92b87	Optimize OkHttp initialization for Retrofit ... Change-Id: I347f1080ab5adf774a0cdd3c659cbf25c4820f9a	11 months ago
Tomáš Mlynarič	5f0612102d	Improve lazy loading for Coil + OkHttp ... This way, we can load Coil's backend on a background thread and not block the MainThread with it. Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames. Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62	11 months ago
Tomáš Mlynarič	9daedc9690	Improve converting to kotlin timezone ... Change-Id: I2af929c341cb274ae6b93bb8dffe696de6ed1c63	11 months ago
Tomáš Mlynarič	12a3a6edde	Use trySend multiple times ... Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032	11 months ago
Simon Marquis	3d339e1658	Move `:core:data` fake repositories to `:core:data-test` ... Now that these fake implementations are no longer used in the production source code (only in tests), we can safely extract them out of this module. Hopefully, we'll later be able to use Kotlin testFixtures for that. References: - #709 - #875	11 months ago
Tomáš Mlynarič	6ec3b3c7a2	Use androidx.tracing everywhere ... Change-Id: I9a77c4434d271e2e23700823f9f513aa61d177f8	11 months ago
Tomáš Mlynarič	ea1573fcc1	Use kotlinx.datetime.Timezone instead of java ZoneId ... Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628	11 months ago
Simon Marquis	b687328567	Replace comments with proper `@TestOnly` annotations	11 months ago
Simon Marquis	a83f6691c4	Fix addNewsResources issue	11 months ago
Simon Marquis	5a1258232f	Fix `emptyResultIsReturned_withNotMatchingQuery` unit test ... `searchResultUiState` transitively relied on `getSearchContentsCount` updates and on `userDataRepository` to emit something.	11 months ago
Tomáš Mlynarič	a16d5f726c	More readable zoneId creation ... Change-Id: I912dc021554e4886a5d09e63799aa5c81e8fd16a	11 months ago
Tomáš Mlynarič	44ae059a2b	Rename LocalTimeZone -> LocalZoneId + collects with lifecycle ... Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3	11 months ago
Tomáš Mlynarič	1e925ed99f	Conflate TimeZoneMonitor emissions ... Co-authored-by: Alex Vanyo <vanyo@google.com>	11 months ago
Tomáš Mlynarič	0b3ece1bb9	Fix spotless ... Change-Id: I6583fa9ed7c1563f6164653be9bbaf7904ec0215	11 months ago
Tomáš Mlynarič	cb00d2c8cb	Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers ... This way, we can save ~1ms per composed item on screen. Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d	11 months ago
Simon Marquis	d932cde110	Move `androidx.compose.ui:ui-tooling` dependency to convention plugin	11 months ago
Don Turner	691bf2aad6	Merge pull request #785 from SimonMarquis/optimize-avd ... Optimize AVD to fix long vector paths Lint warning	1 year ago
Simon Marquis	377d3bef0c	Optimize AVD to fix long vector paths Lint warning ... ... with SVGOM, but you'll have to check on Android Studio the AVD diff. https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html	1 year ago
Don Turner	707117a4f2	Merge branch 'main' into kotlinify	1 year ago
Don Turner	0f0511748e	Merge pull request #1088 from SimonMarquis/cleanup-dependencies ... Reduce overall build complexity	1 year ago
Simon Marquis	be9dc533e3	Replace `Enum.values()` with `Enum.entries` ... 'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9	1 year ago
Don Turner	89d39a7242	Merge pull request #767 from SimonMarquis/resource-prefix ... Enforce `resourcePrefix` on Android library modules	1 year ago
Simon Marquis	bdb10a6870	Update core/designsystem/src/main/kotlin/com/google/samples/apps/nowinandroid/core/designsystem/component/scrollbar/ScrollbarExt.kt ... Co-authored-by: Don Turner <dturner@users.noreply.github.com>	1 year ago
Don Turner	9d41ffa318	Merge branch 'main' into kotlinify	1 year ago
Simon Marquis	b6d82e24df	Merge branch 'main' into kotlinify	1 year ago
lihenggui	56fbe13b5a	Ignore function naming check when annotated with @Test	1 year ago
lihenggui	485440b550	Suppress ktlint:standard:function-naming in ResultKtTest	1 year ago
lihenggui	d671126f9e	Move @Suppress("ktlint:standard:max-line-length") to function scope	1 year ago
lihenggui	32e1ec0447	Remove violations: property-naming	1 year ago
lihenggui	f8f932705a	Remove violations: discouraged-comment-location	1 year ago
lihenggui	fb5bd225be	Spotless	1 year ago
Simon Marquis	f27a2e176e	Reduce overall build complexity ... - Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`	1 year ago
Yuya	e8f4537e7c	Update thumbTrackSizePercent calculation for readability ... Change-Id: I7ef067a950b4b5911b8c2e6a8c1f72c3e95d938d	1 year ago
Yuya	07d9877331	Update thumb movement range by thumb size, in app scrollbars ... Change-Id: I4438debd5037965a837758e0c78b110ab8197da5	1 year ago
Ben Trengrove	e62d70bf5a	Merge pull request #1067 from android/ben/itemstate ... Remove redundant mutable state in NewsFeed	1 year ago
dahunsi	e334a727c3	Fix typo in app scrollbars ... Change-Id: Ie72f1410fa8e5a68a520321c34d4fad251016486	1 year ago
Ben Trengrove	3142ecb495	Remove redundant mutable state	1 year ago
Ben Trengrove	22df321b9e	Apply spotless	1 year ago
Ben Trengrove	72da8e2e56	Use custom Modifier.Node instead of background	1 year ago
Ben Trengrove	d8880e98f0	Move state into a state holder and remove redundant Box	1 year ago
Ben Trengrove	01928d7df5	Move scrollbar changes out of composition	1 year ago
Simon Marquis	caa482bc71	Kotlinify codebase ... - Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)	1 year ago
Simon Marquis	988002e692	Update Robolectric 4.11.1 ... - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11 - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1 > Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below. Removing explicit API 33 Robolectric configuration.	1 year ago
Daniel Santiago	c908f989c8	Update to Hilt 2.48.1 and use the KSP version ... * Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin. * `@Binds` function cannot be an extension function. * Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.	1 year ago
Mario Manhique	b2c1c11218	Update MainDispatcherRule.kt ... Updated MainDispatcherRule parameter accessibility to private because its only needs to be accessible inside that class.	1 year ago
Adetunji Dahunsi	78573b8efc	Merge pull request #972 from tjmtic/now-update-888 ... Update primitive mutable states to mutableState API where applicable	1 year ago
Jonathan Koren	5482d81fdc	fixed for PR 985	1 year ago
TM	2b84fafcf7	Merge remote-tracking branch 'upstream/main' into now-update-888	1 year ago
Simon Marquis	245723b5b2	Fix compiler warning: Remove single lambda parameter declaration	1 year ago
Adetunji Dahunsi	0287af8d9a	Merge pull request #947 from android/tj/staggered-grid-feed ... Use lazy vertical staggered grid in feed to maximize space utilization	1 year ago
TM	7fc67c2915	Update compose-runtime version; Update primitive mutable states to mutableState API where applicable	1 year ago
Don Turner	a381d13199	Merge pull request #958 from McGalanes/main ... Use typesafe project accessors	1 year ago
Don Turner	301661ce86	Merge pull request #959 from McGalanes/convention-plugins-toml ... Add convention plugins to version catalogs	1 year ago
dahunsi	1d0435832d	Fix spotless ... Change-Id: Ia931fc5662af50a6045a51783d72cb5b68e2486a	1 year ago
dahunsi	beaa85739d	Address PR feedback ... Change-Id: I50b49d3e216535e384b64849f915b37f6e2acbbc	1 year ago
Don Turner	6e96d30519	Merge pull request #912 from lihenggui/main ... Upgrade Gradle to v8.3	1 year ago
Minseong Kim	5612396290	Fit typo in SystemTrayNotifier.kt	1 year ago
Melwin Magalhaes	6247712064	Add convention plugins to version catalogs	1 year ago
Melwin Magalhaes	b1266dc05a	Use typesafe project accessors for project modules	1 year ago
dahunsi	77451779cd	Use animateItemPlacement() on feed ... Change-Id: Id120a6e84e0641679fa54ebf0e34bb04165aa419	1 year ago
dahunsi	8b759ae569	Fix spotless ... Change-Id: I7ee8bc84beb38d00983aa7b0da3f3073e1249992	1 year ago
dahunsi	03d2455f41	Use lazy vertical staggered grid in feed to maximize space utilization ... Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926	1 year ago
Simon Marquis	b2cd980170	Merge remote-tracking branch 'origin/main' into resource-prefix	1 year ago
Simon Marquis	ebfe01affd	Enforce `resourcePrefix` on Android library modules ... ``` :ui-test-hilt-manifest -> ui_test_hilt_manifest_ :core:analytics -> core_analytics_ :core:common -> core_common_ :core:data -> core_data_ :core:data-test -> core_data_test_ :core:database -> core_database_ :core:datastore -> core_datastore_ :core:datastore-test -> core_datastore_test_ :core:designsystem -> core_designsystem_ :core:domain -> core_domain_ :core:network -> core_network_ :core:notifications -> core_notifications_ :core:testing -> core_testing_ :core:ui -> core_ui_ :feature:bookmarks -> feature_bookmarks_ :feature:foryou -> feature_foryou_ :feature:interests -> feature_interests_ :feature:search -> feature_search_ :feature:settings -> feature_settings_ :feature:topic -> feature_topic_ :sync:sync-test -> sync_test_ :sync:work -> sync_work_ ```	1 year ago
Simon Marquis	a33dafccad	Migrate from `java` to `kotlin` sourceSet directory	1 year ago
Jose Alcérreca	151f877bbe	Adds screenshot tests to :core:designsystem (#931) ... * WIP: Adds screenshot tests to :core:designsystem Change-Id: I0672845feba4064652dd8d60f07047b87864e121 * 🤖 Updates screenshots * Creates tests for more components and cleans up Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22 * WIP: More cleanup and more combinations of themes Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523 * Added the rest of the screenshot tests for designsystem Change-Id: Ic427db5491910781c038882055524e3f3dbed194 * Some more cleanup Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180 * Spotless Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6 * 🤖 Updates screenshots * ScreenshotHelper cleanup Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0	1 year ago
Don Turner	d0909a9c8f	Merge pull request #925 from SimonMarquis/remove-dispatcher ... Remove unnecessary dispatcher switch in `DefaultRecentSearchRepository`	1 year ago
Simon Marquis	0ddcf0b4ab	Remove unnecessary dispatcher switch in `DefaultRecentSearchRepository` ... As mentioned in the following discussion: https://github.com/android/nowinandroid/discussions/818 Room already takes care of switching dispatchers if the DAO method is correctly annotated with the `suspend` modifier.	1 year ago
Roy Matero	298f3ce4db	Merge branch 'android:main' into main	1 year ago
Simon Marquis	c98e6236d5	Replace identical `InstantSerializer` with KotlinX datetime default serializer	1 year ago
Jose Alcérreca	5b79869324	Adds dark screenshot tests and fixes background colors in ForYou (#918) ... * Adds dark screenshot tests and fixes background colors in ForYou * 🤖 Updates screenshots	1 year ago
Roy Matero	4e6cda1965	Renamed toggle function signature with boolean parameters ... Change-Id: I0d6c0ed4d4c0ee4bd387e5645fc558970f5f202b	1 year ago
Milosz Moczkowski	c57fb78fa7	Merge pull request #759 from SimonMarquis/lint/sarif ... Android Lint improvements	1 year ago
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876) ... * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	1 year ago
lihenggui	fcc49d141d	Upgrade Gradle to v8.3	1 year ago
Milosz Moczkowski	928833fe5d	Merge pull request #889 from RivanParmar/main ... Rename SearchResult.kt.kt to SearchResult.kt	1 year ago
Jose Alcérreca	6c0d6ad82e	Fixes icons size in onboarding and restores LocalInspection for images (#909) ... * Fixes icons size in onboarding and restores LocalInspection for images	1 year ago
Simon Marquis	0ced769999	Widen `isNotEmpty` with `isNotBlank` to potentially catch blank values	1 year ago
Simon Marquis	4a5ec5bd82	Update `var` with fake default value to the more "correct" `lateinit var`	1 year ago
Simon Marquis	f1bc6f1226	Restore `Unknown` type as empty `String`	1 year ago
Simon Marquis	c831dc673c	Fix broken text	1 year ago
Simon Marquis	daa2228132	Restore original `type` labels	1 year ago
Simon Marquis	480d8e7d7c	Fix missing removal	1 year ago
Simon Marquis	553b01fcb6	spotlessApply	1 year ago
Simon Marquis	0377fd8712	Replace `NewsResourceType` enum with simpler String type ... See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901	1 year ago
Adetunji Dahunsi	153b34fd50	Merge pull request #850 from qamarelsafadi/loading-progress-for-image ... Fix #849: Loading progress for image	1 year ago
RivanParmar	9e1d46e28c	Rename SearchResult.kt.kt to SearchResult.kt	1 year ago
Don Turner	492697ce6b	Merge pull request #873 from SimonMarquis/misc-warnings ... Fix miscellaneous warnings	1 year ago
qamarelsafadi	308f51f87d	Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image	1 year ago
Qamar A. Safadi	2db3e0c804	Merge branch 'android:main' into loading-progress-for-image	1 year ago
qamarelsafadi	5d7e33d905	fix formatting	1 year ago
Don Turner	8901e5932a	Merge pull request #872 from SimonMarquis/data-objects ... Convert 'sealed' sub-object to 'data object'	1 year ago
Don Turner	0e13207a40	Merge pull request #874 from SimonMarquis/string-decoder ... Replace StringDecoder injection with simpler API	1 year ago
qamarelsafadi	f203e9a218	feat: replacing SubcomposeAsyncImage as its not recommended to use with lazyLayout	1 year ago