78e3725f9f
Sets up jacoco coverage with a combined report and a GHA ( #1303 )
...
* Uses jacoco coverage reporting in AGP
8 months ago
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
8 months ago
bd89507f10
Merge pull request #1306 from yongsuk44/feat/weak-warning
...
Cleaned up unnecessary '@opt-in' annotations and removed empty constructors
8 months ago
e2a4706470
Remove unnecessary opt-in annotations
8 months ago
c4b669a138
🤖 Updates baselines for Dependency Guard
8 months ago
7d2026f180
🤖 Updates baselines for Dependency Guard
8 months ago
dac1a9e446
Topic detail pane placeholder ( #1280 )
...
* Topic detail pane placeholder
Change-Id: I92b84493a5406240285c0759b30aa10d29871f09
* Add modifier parameter
Change-Id: Ie363be83b44f26291030c04c1513cecb851a6899
8 months ago
70dcd5119d
Make path to module graph image dynamic. Fixes #1286
...
Change-Id: I595a841ef7b06cccc959ca96d18824f4fad4c261
8 months ago
3e4aad3210
Merge pull request #1257 from android/dt/add-module-graphs
...
Update module dependency graphs and add script to create them
8 months ago
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
8 months ago
06f08a58dd
🤖 Updates baselines for Dependency Guard
8 months ago
a6f223301e
🤖 Updates baselines for Dependency Guard
8 months ago
cc02c30b8e
Update material3-adaptive to 1.0.0-alpha08
...
Change-Id: Ic218c6b061b5cea4e56b544073541421862bc1d0
8 months ago
0c9f0dd48c
Merge pull request #1217 from android/dependabot/gradle/org.jetbrains.kotlinx-kotlinx-serialization-json-1.6.3
...
Bump org.jetbrains.kotlinx:kotlinx-serialization-json from 1.6.0 to 1.6.3
8 months ago
e9565a567e
Merge pull request #1258 from Jaehwa-Noh/rename-test-function
...
Rename test function, and delete explicit type argument
8 months ago
74d1d91c28
Merge pull request #1263 from android/dependabot/gradle/kotlinxCoroutines-1.8.0
...
Bump kotlinxCoroutines from 1.7.3 to 1.8.0
8 months ago
91af060e77
Merge pull request #1264 from android/dependabot/gradle/androidx.hilt-hilt-navigation-compose-1.2.0
...
Bump androidx.hilt:hilt-navigation-compose from 1.0.0 to 1.2.0
8 months ago
1fde4f5753
Merge pull request #1266 from android/dependabot/gradle/androidx.browser-browser-1.8.0
...
Bump androidx.browser:browser from 1.6.0 to 1.8.0
8 months ago
a7a7736426
🤖 Updates baselines for Dependency Guard
8 months ago
5448786c4d
🤖 Updates baselines for Dependency Guard
8 months ago
72f968ff2c
🤖 Updates baselines for Dependency Guard
8 months ago
6e5548a837
🤖 Updates baselines for Dependency Guard
8 months ago
d67b1a2504
Merge branch 'android:main' into rename-test-function
9 months ago
e017b84a12
Remove explicit type argument.
...
Change-Id: Id02756d780309af6638698de856b563d9e775cc3
9 months ago
8cfd42453c
Rename test function name
...
- Given-when-then format.
Change-Id: I3305c5a7cc5a0f41be31292534a086034f642404
9 months ago
19f6f9e09a
2 pane support in Interests screen ( #1234 )
...
* Add dependency on material3 adaptive
Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6
* Add InterestsListDetailScreen composable
Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971
* Store selectedTopicId in InterestsViewModel
Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce
* Pass detail pane composable down
Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293
* Navigate to initial topic if provided
Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b
* Lift LDPS up to app module
Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85
* Fix some navigation behavior
Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b
* Navigate to initial topic if provided
Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed
* Remove dependency in interests feature module
Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f
* Hide back arrow when the topics list is visible
Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8
* Update interests tests
Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd
* Highlight selected topic when displaying 2 panes
Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415
* update dependency baselines
Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00
* run spotless apply
Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8
* Convert isListPaneHidden to isListPaneVisible
Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657
* Set semantics for selected state
Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca
* Use scaffold roles when determining visibility
Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648
* Update multipleBackStackInterests test
Change-Id: I1e372f7989817151a6765205291b13b561187fa8
9 months ago
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
9 months ago
2d610b0775
Merge branch 'main' into replace-testharness
...
* main: (37 commits)
Disable animations of instrumented tests (#1167 )
Bump gradle/wrapper-validation-action from 1 to 2
Remove unused release variable. Fixes #1231
Apply Composable Parameter Ordering Guidelines
Remove kotlinx-coroutines-guava dependency from :sync:work
Add explicit guava-android dependency for :sync:work
Extract ScreenshotHelper to separate testing module
Update AGP to 8.3.0
Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert.
🤖 Updates baselines for Dependency Guard
Bump the kotlin-ksp-compose group with 6 updates
🤖 Updates baselines for Dependency Guard
Bump hilt from 2.50 to 2.51
Bump com.google.truth:truth from 1.1.5 to 1.4.2
Move java to kotlin folder.
Remove disk usage testing
Figuring out what is using 66Gb in the runner
Dpm
Improve converting to kotlin timezone
Use trySend multiple times
...
Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a
9 months ago
7737368c0e
Update app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
9 months ago
14b60b3a59
Merge branch 'main' into dependabot/gradle/org.jetbrains.kotlinx-kotlinx-serialization-json-1.6.3
9 months ago
8a3c34994d
Merge pull request #1239 from Jaehwa-Noh/java-to-kotlin
...
Move java to kotlin folder.
9 months ago
747c9275bc
Merge pull request #1249 from android/dt/fix-1231
...
Remove unused release variable. Fixes #1231
9 months ago
77cbdb62a4
Remove unused release variable. Fixes #1231
...
Change-Id: I8c03d3d2e1aee85a22d1a03b97e3bec4069e0fcb
9 months ago
e3c7018124
Extract ScreenshotHelper to separate testing module
...
Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af
9 months ago
d768c796d4
Merge pull request #1244 from android/dependabot/gradle/hilt-2.51
...
Bump hilt from 2.50 to 2.51
9 months ago
1ca0085423
Merge branch 'android:main' into java-to-kotlin
9 months ago
f31fdb3ec2
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Id49a580012629163ec4a3663d95ab71b98910220
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
# gradle/libs.versions.toml
9 months ago
b2b9f12915
🤖 Updates baselines for Dependency Guard
9 months ago
9b488bf70a
Move java to kotlin folder.
...
Change-Id: Iaf4723dea6169fbf3f9a8d3bf8779179ac56ab86
9 months ago
43b2240bdd
🤖 Updates screenshots
9 months ago
73d0b70f21
Workaround for new ForcedSize behaviour, bump ui-test version
...
Change-Id: Ibf93c1b65250e6527e34bc90602c1b1001b2df46
9 months ago
fa811ab85f
Bump to ui-test:1.7.0-alpha03, add parameter name
...
Change-Id: Ib1bbe4ad0d823c632d387587aa55c5eeb39e4b8d
9 months ago
50d5583fe1
🤖 Updates screenshots
9 months ago
d6357be8c4
Replace Accompanist TestHarness with DeviceConfigurationOverride
...
Change-Id: I6742d5e221f86a019f44d3e623609bf76d2a3a2a
9 months ago
27fd4e544a
🤖 Updates screenshots
9 months ago
02d4fea615
🤖 Updates screenshots
9 months ago
a507ff6d8e
Wrap NiaApp with NiaTheme for app screenshot tests
...
Change-Id: I8e298da139b19721b90ae778e7ab184f600d0bd7
9 months ago
75a3295381
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt
9 months ago
6b2b01ed82
🤖 Updates screenshots
9 months ago
076a2af757
🤖 Updates baselines for Dependency Guard
9 months ago
08d8f1393a
🤖 Updates baselines for Dependency Guard
9 months ago
0c0adddf42
🤖 Updates baselines for Dependency Guard
9 months ago
6add4d68e3
Bump protobuf from 3.24.4 to 3.25.2 ( #1214 )
...
* Bump protobuf from 3.24.4 to 3.25.2
Bumps `protobuf` from 3.24.4 to 3.25.2.
Updates `com.google.protobuf:protobuf-kotlin-lite` from 3.24.4 to 3.25.2
Updates `com.google.protobuf:protoc` from 3.24.4 to 3.25.2
- [Release notes](https://github.com/protocolbuffers/protobuf/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl )
- [Commits](https://github.com/protocolbuffers/protobuf/compare/v3.24.4...v3.25.2 )
---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-kotlin-lite
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.protobuf:protoc
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* 🤖 Updates baselines for Dependency Guard
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
9 months ago
f64f1c0aa2
Remove legacy benchmark build type ( #1207 )
...
* Remove legacy benchmark build type
Now that we have the baseline profile gradle plugin,
there is no need for a benchmark build type.
The plugin does the setup and configuration and runs against the
correct app flavor.
* Remove explicit benchmark build type from benchmark module
* Remove stale build task exclusions
* Fix tracing import location
FYI @mlykotom
9 months ago
58483b6166
Revert fast initialization of Coil
...
As discussed in https://github.com/coil-kt/coil/issues/2097 the problem is caused by regitering system services, which will be fixed in 2.6.0
Change-Id: I9085309780508137f10b25ff82deed3c62e5d159
10 months ago
f3e89bad4a
Add braces
...
Change-Id: I859babab7278137a4a2e49e5a085c65632888dd0
10 months ago
d1211f15e7
Inline initialization
...
Change-Id: I0a77eb6457cac27c1a4d604c8efdcbbdce95bc48
10 months ago
e853748cf7
Don't use runBlocking if async init completed
...
Change-Id: I641187ce277f434c6fca49a11b3cfccd50ecf5da
10 months ago
7c33946ce1
Launch loader directly without additional coroutine scope
...
Change-Id: Icbbdbcbcac1a6275857ebe998509f1e09109db7a
10 months ago
8e3903e90c
Fix comment
...
Co-authored-by: Yuri Schimke <yuri@schimke.ee>
10 months ago
5f0612102d
Improve lazy loading for Coil + OkHttp
...
This way, we can load Coil's backend on a background thread and not block the MainThread with it.
Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames.
Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62
10 months ago
12a3a6edde
Use trySend multiple times
...
Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032
10 months ago
08bfc54832
Update dependency guard baseline
...
Change-Id: I2557753f1eb4c6845aca6473a6aba5b7e758ebbf
10 months ago
f8e797fd26
Rename currentTimezone variable
...
Change-Id: I92630f6851b0253294a8d3ec2e5b3cbe7db74b4d
10 months ago
98e9e80639
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Ie83fb57676934ca3bdda59a986eb1a01a7c97424
10 months ago
ea1573fcc1
Use kotlinx.datetime.Timezone instead of java ZoneId
...
Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628
10 months ago
c1d6c88bb0
Run dependencyGuard task during CI ( #1064 )
...
* Run dependencyGuard task during CI
Run the `dependencyGuard` task during CI, which will fail if there are
detected changes.
Change-Id: If5f2b18a4c765bd38a3353df2adaaa91cf1739c3
* Add actions to update dependency guard baselines
* Update baselines
* Better glob for update baselines action
10 months ago
44ae059a2b
Rename LocalTimeZone -> LocalZoneId + collects with lifecycle
...
Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3
10 months ago
cb00d2c8cb
Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers
...
This way, we can save ~1ms per composed item on screen.
Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d
10 months ago
395b9853df
Add Composition Tracing
...
Change-Id: I3ad60930de2fab71a700a0c2df3f0a1f566cafd8
10 months ago
f5b3ae56dc
Merge pull request #951 from SimonMarquis/issue-945
...
Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`
11 months ago
691bf2aad6
Merge pull request #785 from SimonMarquis/optimize-avd
...
Optimize AVD to fix long vector paths Lint warning
11 months ago
afdfd8acc5
🤖 Updates screenshots
11 months ago
377d3bef0c
Optimize AVD to fix long vector paths Lint warning
...
... with SVGOM, but you'll have to check on Android Studio the AVD diff.
https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html
11 months ago
707117a4f2
Merge branch 'main' into kotlinify
11 months ago
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
11 months ago
046831df36
Update dependency guard classpaths
...
Change-Id: I5f729bce92ec1cc9f71e34e42cbe38765966fc31
11 months ago
0699efc592
Merge branch 'main' into issue-945
11 months ago
be9dc533e3
Replace `Enum.values()` with `Enum.entries`
...
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
11 months ago
a5c030f740
Merge pull request #956 from KDW03/add_saved_test
...
Add Test for Saved Top Level Destination
11 months ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
11 months ago
9d41ffa318
Merge branch 'main' into kotlinify
11 months ago
ad15f0137e
Merge pull request #1094 from lihenggui/main
...
Upgrade Spotless and Ktlint and remove code convention violations
11 months ago
8d5ef578c6
Merge pull request #1103 from android/add_icon_comment
...
Add comment explaining why the launcher icon colors differ per build
11 months ago
b6d82e24df
Merge branch 'main' into kotlinify
11 months ago
b801a7deea
Moving comments to _after_ first XML element
...
Change-Id: Id4271a67ffcfbd712a2dd1f363970fcd31ee5ac0
11 months ago
2a2d8ed88d
Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE
11 months ago
d018e57f52
Fix spotless
...
Change-Id: I5dea4fec5b391e8cb7794af13e99978fcb622fbb
11 months ago
e6b5560f07
Revert "Move app screenshot tests to match dependencies declaration"
11 months ago
28bb3f1b2f
Add comment explaining why the launcher icon colors differ per build variant
...
Change-Id: I30126402370162ccbe53e177652583e4472f2030
11 months ago
83764082ff
Move app screenshot tests to match dependencies declaration
...
Fixes #990
11 months ago
32e1ec0447
Remove violations: property-naming
11 months ago
fb5bd225be
Spotless
11 months ago
2b739c0ffe
Fix badging, which is not "stable" when it comes to ordering
12 months ago
65a8b0d3b5
dependencyGuardBaseline
12 months ago
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
12 months ago
392eaa3e61
Add dependencyGuard to AndroidApplicationConventionPlugin
...
Change-Id: Ib695ca18512d0ccde4c67e101f09ebbff8897912
12 months ago
d15a203c59
Only record prodReleaseRuntimeClasspath configuration
...
Change-Id: I129fc4839ac2b4d5624c91cd25b47efba8847f44
12 months ago
d5d5e3561f
Add dependency guard plugin
12 months ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
1 year ago
Jose Alcérreca
Simon Marquis
Don Turner
yongsuk44
dependabot[bot]
Jonathan Koren
Don Turner
SergeyPinkevich
alexvanyo
Alex Vanyo
mlykotom
Jaehwa Noh
Tomáš Mlynarič
dependabot[bot]
Ben Weiss
SimonMarquis
lihenggui