Don Turner
b9a80fc038
Refactor navigation routes to NavKeys
...
This commit refactors the navigation implementation by renaming all `...Route` classes to `...NavKey`. This change provides more descriptive and consistent naming for navigation keys across the codebase.
Key changes include:
* Renamed `BookmarksRoute` to `BookmarksNavKey`
* Renamed `ForYouRoute` to `ForYouNavKey`
* Renamed `InterestsRoute` to `InterestsNavKey`
* Renamed `TopicRoute` to `TopicNavKey`
* Renamed `SearchRoute` to `SearchNavKey`
* Updated all associated feature modules, tests, and UI components to use the new `NavKey` names.
* Removed obsolete test utilities and mock providers related to the old navigation setup.
* Deleted outdated dependency graph images and their corresponding `README.md` files from feature modules.
2 months ago
Don Turner
bd484ebb3c
Title bar is now hidden on non top-level keys.
2 months ago
Don Turner
af504d2331
More NavigationState refactoring. Fix compilation errors.
2 months ago
Don Turner
f6824858c4
Refactor NavigationState and make tests pass
2 months ago
Don Turner
386d1a0a16
WIP remove DI 2
2 months ago
Don Turner
c9bba49957
WIP remove DI
2 months ago
Don Turner
adcc3871be
Refactor navigation state management
...
This commit refactors the navigation state management by renaming `NiaNavigatorState` to `NavigationState` to make it more generic.
Specific changes include:
- Renamed `NiaNavigatorState` to `NavigationState`.
- Renamed `NiaNavigatorProvider` to `NavigationStateProvider`.
- Updated all usages of the renamed classes, including `NiaNavigator`, `NiaBackStackViewModel`, and various tests.
- Replaced the `getEntries()` extension function with `toEntries()`.
- Added numerous TODOs to identify areas for future improvement, such as removing dependencies on `SavedStateHandle` for navigation state, simplifying event handling in ViewModels, and documenting the new navigation components.
2 months ago
Clara Fok
dc29a5eb62
run spotless
3 months ago
Clara Fok
b91a965ae2
Refactored NiaNavigator
...
Made NiaNavigator a stateless class only responsibly for navigating and pop (modifying backStack).
Navigation state now lives in a new class called NiaNavigatorState.
The state of this class is saved and restored by ViewModel.
3 months ago
Clara Fok
e373828f5f
Update feature ViewModels and tests
3 months ago
Clara Fok
4a8eaba408
Refactor Interests to ListDetailScene
3 months ago
Clara Fok
c9e38b329a
Refactor app to navigation3
3 months ago
Clara Fok
d30083005e
Refactor feature modules to navigation3
3 months ago
Clara Fok
af3ca67f64
Add NiaBackStack and BackStack providers
...
Bump agp versions and add navigation 3 dependency
3 months ago
Clara Fok
068d8cc93c
Split feature modules into api and impl modules
...
Source code is still left in api module. impl module is empty at this point.
3 months ago
Mayokun Yusuf
dd17e11538
Fix punctuation and alignment for English text in RTL locales by forcing LTR text direction and left alignment globally in typography"
5 months ago
Jaehwa Noh
9b33232fc7
Fix spotless.
...
Change-Id: I741418a1e44fd9e3488513bdb33995490738679d
8 months ago
Jaehwa Noh
84dbcb678a
Exclude the ime window inset at the snack bar.
...
Change-Id: I14a43609090176604e42caf2862bcb4ba291fe89
8 months ago
Alex Vanyo
476baff45f
Merge pull request #1855 from SimonMarquis/deprecated-centerAlignedTopAppBarColors
...
Replace deprecated `centerAlignedTopAppBarColors` with `topAppBarColors`
10 months ago
Ben Weiss
425ddf6a69
Remove death penalty from strict mode violations ( #1857 )
...
The app was still crashing in non-debug after strict mode was enabled. Less restrictive, now only logging violations
Closes #1853
Closes #1809
11 months ago
Simon Marquis
fe4ebce324
Replace deprecated `centerAlignedTopAppBarColors` with `topAppBarColors`
...
from a recent material3 update: https://developer.android.com/jetpack/androidx/releases/compose-material3#1.4.0-alpha06
11 months ago
Alex Vanyo
fc418fc7a5
Rename highlightSelectedTopic to shouldHighlightSelectedTopic
...
Change-Id: I5869404bc66d878030faf1ae2d5b95cc27ce67b4
11 months ago
Alex Vanyo
77c0d6c500
Rename to topicRoute
...
Change-Id: I44696efe11f8d660bb7c9dc41ade6927ce15798b
11 months ago
alexvanyo
af98b39223
🤖 Updates screenshots
11 months ago
Alex Vanyo
e25b3634ca
Add predictive back and pane expansion back handling
...
Change-Id: I8e881bb2cf549303be8612732bfb7df7555096aa
11 months ago
Alex Vanyo
800e3d55c9
Assisted inject approach
...
Change-Id: I5fba15921520bc83b13601fa82ae71457d875805
11 months ago
alexvanyo
ed8745cef5
🤖 Updates screenshots
11 months ago
Alex Vanyo
f3cf2379a3
Update to material3-adaptive 1.1
...
Change-Id: I4b3b68face17149ab87135df28baa41cd5bacb0f
11 months ago
Jaehwa-Noh
46b37a3e7f
🤖 Updates screenshots
1 year ago
Jaehwa Noh
01e428bba4
Remove old screenshots.
...
Change-Id: Ib1181a3f9f6cf364794766b70b990f8616edd118
1 year ago
Jaehwa Noh
aa18b8b711
Merge branch 'android-remote-main' into fix-snackbar
...
Change-Id: If0f12500cb55daae98fd7ee0951d3d3384d26b0e
# Conflicts:
# app/src/testDemo/screenshots/insets_snackbar_compact_medium.png
# app/src/testDemo/screenshots/insets_snackbar_expanded_expanded.png
# app/src/testDemo/screenshots/insets_snackbar_medium_medium.png
1 year ago
Don Turner
904e6fccee
Merge pull request #1730 from seve-andre/force-dark-opt-out
...
Opt out of Force Dark mode
1 year ago
Don Turner
d15c739812
Merge pull request #1625 from blue928sky/move-nia-app-state-test
...
Move Android instrumented test NiaAppStateTest to unit test
1 year ago
Andrea Severi
38dcac5340
remove API 29 themes.xml
1 year ago
Andrea Severi
67646f3fd5
replace version code with api level
1 year ago
Tomáš Mlynarič
917e12c50e
Merge pull request #1369 from android/mlykotom/optimize-startup
...
Optimize startup by preventing whole screen recomposing twice
1 year ago
Don Turner
4277366b7c
Merge pull request #1729 from takahirom/takahirom/update-sdk-35/2024-12-11
...
Update SDK 35 with Theme Fixing
1 year ago
Tomáš Mlynarič
b2c71025b5
Merge branch 'main' into mlykotom/optimize-startup
...
Change-Id: If8e49d8c5e3873657aef3592c2202839f70e7be9
# Conflicts:
# app/src/main/kotlin/com/google/samples/apps/nowinandroid/MainActivity.kt
1 year ago
Ben Weiss
d8b735f80e
Revert "Improve accessibility to ForYou topics ( #1309 )" ( #1732 )
...
This reverts commit 48544194f4 .
1 year ago
takahirom
5e73c76acd
🤖 Updates screenshots
1 year ago
Don Turner
013424896c
Merge pull request #1050 from android/bw/threadPolicy
...
Enable the thread police 👮 for debug builds
1 year ago
Jaehwa Noh
48544194f4
Improve accessibility to ForYou topics ( #1309 )
...
* Clear semantics.
Change-Id: I69a48798f6be8433e877c38166bd73cd776d71ac
* Merge the descendants semantics.
Change-Id: Ifbe91bb694b393e6780f93732a7d38f5ee355680
* Add string for icon description.
Change-Id: Ibf35c651aeacfbe317794ed898f0fb0e8bc1ec15
* Change icon description.
Change-Id: I9359bf8c9272b247669ae58fd79e5f79466ec0a9
* Change state of icon check logic.
Change-Id: I3e5e89fc1c469c3f3c4744d18f697f68d070996b
* Merge only text.
Change-Id: I36eefc6dd9f56f7a1f63003f0f95f6755ae16def
* Add stateDescription.
Change-Id: Id4d32e49374dbdb6e666048937e37060cbd4b454
* Add toggleableState.
Change-Id: I9f836e2463bf800786d11f9e0997a7d570ff90b0
* Set clearAndSetSemantics at Row.
Change-Id: Ic25b9ca11bbcc40c8ff24172669b07ea9b7642a9
* Set stateDescription "Following" and "Not Following".
Change-Id: Ib82ac94b05a5d373ac10787aac5241fb4f03c7b2
* Find topic by onNodeWithContentDescription.
Change-Id: I2423e3846c02169f6bf1fc30d9b4034b5f79efb3
* Find topic by onNodeWithContentDescription.
Change-Id: Iefc97fd9e52227f51f7d40f8c10cb4878cde90c0
1 year ago
Ben Weiss
27a05c416e
Extract strict mode policy into function
...
Change-Id: If170b2b05859ebfca7bc91ccc790be5b43a1b772
1 year ago
Ben Weiss
225f05e697
Update app/src/main/kotlin/com/google/samples/apps/nowinandroid/NiaApplication.kt
...
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
1 year ago
Andrea Severi
1927b6d9bd
fix xml spotless check
1 year ago
Don Turner
462440e990
Merge pull request #1695 from gibachan/remove-redundant-annotations
...
Remove redundant annotations
1 year ago
Ben Weiss
e8035622b3
Enable the thread police 👮 for debug builds
...
* App will now crash if someone does funky stuff on the main thread.
Change-Id: I9026c100705f2fec6963a1d888b40906186f9d28
1 year ago
Andrea Severi
95ab14601f
opt out of forced dark mode
1 year ago
Tram Bui
827d3d66e2
incorporate safe fallback destination to null destination UI flickering
1 year ago
Ben Weiss
729681b79a
Revert "Bump protobuf from 4.26.1 to 4.28.2 ( #1630 )"
...
This reverts commit 82b6352da1 .
1 year ago