321 Commits (b989d3a243d09e40fadaba1264ea20d7df89e362)

Author	SHA1	Message	Date
Simon Marquis	c98e6236d5	Replace identical `InstantSerializer` with KotlinX datetime default serializer	1 year ago
Jose Alcérreca	5b79869324	Adds dark screenshot tests and fixes background colors in ForYou (#918) ... * Adds dark screenshot tests and fixes background colors in ForYou * 🤖 Updates screenshots	1 year ago
Milosz Moczkowski	c57fb78fa7	Merge pull request #759 from SimonMarquis/lint/sarif ... Android Lint improvements	1 year ago
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876) ... * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	1 year ago
Milosz Moczkowski	928833fe5d	Merge pull request #889 from RivanParmar/main ... Rename SearchResult.kt.kt to SearchResult.kt	1 year ago
Jose Alcérreca	6c0d6ad82e	Fixes icons size in onboarding and restores LocalInspection for images (#909) ... * Fixes icons size in onboarding and restores LocalInspection for images	1 year ago
Simon Marquis	0ced769999	Widen `isNotEmpty` with `isNotBlank` to potentially catch blank values	1 year ago
Simon Marquis	4a5ec5bd82	Update `var` with fake default value to the more "correct" `lateinit var`	1 year ago
Simon Marquis	f1bc6f1226	Restore `Unknown` type as empty `String`	1 year ago
Simon Marquis	c831dc673c	Fix broken text	1 year ago
Simon Marquis	daa2228132	Restore original `type` labels	1 year ago
Simon Marquis	480d8e7d7c	Fix missing removal	1 year ago
Simon Marquis	553b01fcb6	spotlessApply	1 year ago
Simon Marquis	0377fd8712	Replace `NewsResourceType` enum with simpler String type ... See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901	1 year ago
Adetunji Dahunsi	153b34fd50	Merge pull request #850 from qamarelsafadi/loading-progress-for-image ... Fix #849: Loading progress for image	1 year ago
RivanParmar	9e1d46e28c	Rename SearchResult.kt.kt to SearchResult.kt	1 year ago
Don Turner	492697ce6b	Merge pull request #873 from SimonMarquis/misc-warnings ... Fix miscellaneous warnings	1 year ago
qamarelsafadi	308f51f87d	Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image	1 year ago
Qamar A. Safadi	2db3e0c804	Merge branch 'android:main' into loading-progress-for-image	1 year ago
qamarelsafadi	5d7e33d905	fix formatting	1 year ago
Don Turner	8901e5932a	Merge pull request #872 from SimonMarquis/data-objects ... Convert 'sealed' sub-object to 'data object'	1 year ago
Don Turner	0e13207a40	Merge pull request #874 from SimonMarquis/string-decoder ... Replace StringDecoder injection with simpler API	1 year ago
qamarelsafadi	f203e9a218	feat: replacing SubcomposeAsyncImage as its not recommended to use with lazyLayout	1 year ago
Qamar A. Safadi	5abc69fb49	Merge branch 'android:main' into loading-progress-for-image	1 year ago
Don Turner	4d0efef3b4	Merge pull request #879 from tatsuyafujisaki/rename-constants ... Rename constants	1 year ago
AlirezaJoon	a23ffab602	fix: add label to animations for fixing lint issue	1 year ago
Qamar A. Safadi	8aa0457ca9	Merge branch 'android:main' into loading-progress-for-image	1 year ago
Tatsuya Fujisaki	4eeb045287	Rename constants	1 year ago
Adetunji Dahunsi	ec53d03854	Merge pull request #722 from android/tj/scrollbars ... Add scrollbars to app	1 year ago
Simon Marquis	e8449112b4	Replace StringDecoder injection with simpler API ... The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String. For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`). Unit tests would fail because Uri is not mocked (since we are not using Robolectric). Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc. FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded". The solution to this problem was to simply use regular Java APIs: - `URLDecoder.decode(urlEncodedTopicId, "UTF-8")` - `URLEncoder.encode(topicId, "UTF-8")`	1 year ago
Simon Marquis	4bdc9705af	Fix miscellaneous warnings ... - Remove unused namespace declaration - Collapse empty manifest tags - Remove redundant qualifier name - Remove redundant suppression	1 year ago
Simon Marquis	b7799f0475	Convert 'sealed' sub-object to 'data object'	1 year ago
qamarelsafadi	5bbcc904e9	feat: make painter in one line	1 year ago
qamarelsafadi	3595d8dcb5	feat: move the placeholder default value to the method	1 year ago
Qamar A. Safadi	9f3103c212	Merge branch 'android:main' into loading-progress-for-image	1 year ago
prosixe	c779b4e8ca	Typo fix for topics ... tocpis -> topics	1 year ago
qamarelsafadi	e276212574	feat: remove check if placeholder null and put a default placeholder if its not passed.	1 year ago
qamarelsafadi	9c1ec17a39	fix: modifier to Modifier	1 year ago
qamarelsafadi	57025e7587	fix: review notes	1 year ago
qamarelsafadi	8a197800c5	feat: fix format issue	1 year ago
qamarelsafadi	f4859e0bcd	Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image	1 year ago
Qamar A. Safadi	06e91fd623	Merge branch 'android:main' into loading-progress-for-image	1 year ago
qamarelsafadi	a294adb6b9	feat: fix format issue	1 year ago
Adetunji Dahunsi	48041fcaa4	Merge pull request #835 from blackbracken/avoid_retrieving_unnecessary_entity ... Call getNewsResourceIds instead of getNewsResources	1 year ago
qamarelsafadi	7a05f7db96	feat: Show loading progress for Image Component as a solve for ... //TODO b/228077205,	1 year ago
qamarelsafadi	3284eb68a3	feat: Show loading progress for Image Component as a solve for ... //TODO b/228077205,	1 year ago
qamarelsafadi	42b16bf7be	Merge remote-tracking branch 'origin/main'	1 year ago
Qamar Safadi	ee8b70003d	feat: Show loading progress for Image Component as a solve for ... //TODO b/228077205,	1 year ago
TJ Dahunsi	9babb50c58	Interact with scrollbar only if drag direction matches scrollbar orientation ... Change-Id: I8fb5a64098ea83458d25fd2b7363a6b5dd3fef2f	1 year ago
TJ Dahunsi	e13e84c155	Replace usages of 'displacement' to 'moved' in parameter names ... Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a	1 year ago