af504d2331
More NavigationState refactoring. Fix compilation errors.
2 months ago
f6824858c4
Refactor NavigationState and make tests pass
2 months ago
386d1a0a16
WIP remove DI 2
2 months ago
c9bba49957
WIP remove DI
2 months ago
adcc3871be
Refactor navigation state management
...
This commit refactors the navigation state management by renaming `NiaNavigatorState` to `NavigationState` to make it more generic.
Specific changes include:
- Renamed `NiaNavigatorState` to `NavigationState`.
- Renamed `NiaNavigatorProvider` to `NavigationStateProvider`.
- Updated all usages of the renamed classes, including `NiaNavigator`, `NiaBackStackViewModel`, and various tests.
- Replaced the `getEntries()` extension function with `toEntries()`.
- Added numerous TODOs to identify areas for future improvement, such as removing dependencies on `SavedStateHandle` for navigation state, simplifying event handling in ViewModels, and documenting the new navigation components.
2 months ago
dc29a5eb62
run spotless
2 months ago
b91a965ae2
Refactored NiaNavigator
...
Made NiaNavigator a stateless class only responsibly for navigating and pop (modifying backStack).
Navigation state now lives in a new class called NiaNavigatorState.
The state of this class is saved and restored by ViewModel.
2 months ago
a878b170dc
Update dependencyGuardBaseline
2 months ago
e373828f5f
Update feature ViewModels and tests
2 months ago
4a8eaba408
Refactor Interests to ListDetailScene
2 months ago
d30083005e
Refactor feature modules to navigation3
2 months ago
068d8cc93c
Split feature modules into api and impl modules
...
Source code is still left in api module. impl module is empty at this point.
2 months ago
17162dab60
graphUpdate
4 months ago
1c61be7b7b
Update color mapping
...
| Type | Plugin ID | Color |
|-------------|------------------------------------|------------------------|
| Application | `nowinandroid.android.application` | `#CAFFBF` PastelGreen |
| Feature | `nowinandroid.android.feature` | `#FFD6A5` PastelOrange |
| Library | `nowinandroid.android.library` | `#9BF6FF` PastelBlue |
| Test | `nowinandroid.android.test` | `#A0C4FF` PastelMauve |
| JVM | `nowinandroid.jvm.library` | `#BDB2FF` PastelPurple |
| Unknown | `?` | `#FFADAD` PastelRed |
4 months ago
e8dc43b58b
graphUpdate
5 months ago
e079e68815
Delete old graphs
5 months ago
fc418fc7a5
Rename highlightSelectedTopic to shouldHighlightSelectedTopic
...
Change-Id: I5869404bc66d878030faf1ae2d5b95cc27ce67b4
10 months ago
f3cf2379a3
Update to material3-adaptive 1.1
...
Change-Id: I4b3b68face17149ab87135df28baa41cd5bacb0f
11 months ago
6f40606c54
InterstsViewModelTest fix spotless Issue
1 year ago
26dd4424f6
remove blank lines for resolve spotless error
1 year ago
0356b873e9
change collectJob to backgroundScope coroutine
1 year ago
bee8c88681
Update feature/interests/src/test/kotlin/com/google/samples/apps/nowinandroid/interests/InterestsViewModelTest.kt
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
1 year ago
4ff5b1fa26
Fix failing InterestsListDetailScreenTest
...
Change-Id: Ib6e47d9a9cced4c967756f95a5c98587628bd2cb
1 year ago
00efda54e8
Merge branch 'main' into dt/nav-safe-args
...
* main: (58 commits)
Instrumented tests for InterestsListDetailScreen (#1518 )
Remove Firebase AD_SERVICE_CONFIG property
updateProdReleaseBadging
Merge Android & JVM plugins into a single `HiltConventionPlugin`
Update dependency guard
🤖 Updates baselines for Dependency Guard
Update to Lifecycle 2.8.3
Add android.adservices.AD_SERVICES_CONFIG to badges
Apply suggestions from code review
Update app/src/main/AndroidManifest.xml
generateModuleGraphs
dependencyGuardBaseline
updateProdReleaseBadging
Fix spotless.
Change set to `=` operator
Cleanup unused reference in `libs.versions.toml`
Regenerate SVG graphs
Update comment wording
Use stdin to avoid repeating the output file name
Replace bash commands with proper svgo cli
...
Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5
1 year ago
fc58680c06
Remove string-based argument name from navigation code
...
Change-Id: I7c880cc73374e053ea0d41df00a4bda95ed4b551
2 years ago
ec71b2a07e
Add Robolectric to allow ViewModel tests to pass
...
Change-Id: I782fab167103edbdaa1d95839b4fbc6e659fef4e
2 years ago
da8f32a2ea
Rename Destinations to Routes
...
Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7
2 years ago
8fc2e15e73
Update to navigation 2.8.0-beta01
...
Change-Id: I2f01dc19e37b9fe890ad861909f57198cc5262d4
2 years ago
be752e779d
Fix tests, fix spotless
...
Change-Id: I55e779abe4ee49dc93916d9e1184ed81e1b2bbd0
2 years ago
7ec21d9d2f
Fix issue where selected topic in list was not showing as selected. Minor tidy ups.
...
Change-Id: Icfa79eac6f7327c365f79fd7d15dfa1f8c77184d
2 years ago
924391cd22
Fix spotless
...
Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428
2 years ago
89163b5ea1
Migrate remainder of app to type-safe navigation
...
Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b
2 years ago
490997281a
Update to alpha08, use toRoute to obtain destination inside VM
...
Change-Id: I72f617c594b5e0ae272cf94d2d7288446153420a
2 years ago
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
2 years ago
5084fca4dd
Fix InterestScreenTest resources
...
Change-Id: Ib6aa372a1ab3b13b5c69c1d3feec2c31e5dca3ce
2 years ago
a4c52e6485
Remove the search module's dependency on other feature modules
...
Change-Id: I17df9948fed04ddc7ba507b437d39536b8b180bb
2 years ago
3e4aad3210
Merge pull request #1257 from android/dt/add-module-graphs
...
Update module dependency graphs and add script to create them
2 years ago
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
2 years ago
19f6f9e09a
2 pane support in Interests screen ( #1234 )
...
* Add dependency on material3 adaptive
Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6
* Add InterestsListDetailScreen composable
Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971
* Store selectedTopicId in InterestsViewModel
Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce
* Pass detail pane composable down
Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293
* Navigate to initial topic if provided
Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b
* Lift LDPS up to app module
Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85
* Fix some navigation behavior
Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b
* Navigate to initial topic if provided
Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed
* Remove dependency in interests feature module
Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f
* Hide back arrow when the topics list is visible
Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8
* Update interests tests
Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd
* Highlight selected topic when displaying 2 panes
Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415
* update dependency baselines
Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00
* run spotless apply
Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8
* Convert isListPaneHidden to isListPaneVisible
Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657
* Set semantics for selected state
Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca
* Use scaffold roles when determining visibility
Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648
* Update multipleBackStackInterests test
Change-Id: I1e372f7989817151a6765205291b13b561187fa8
2 years ago
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
2 years ago
707117a4f2
Merge branch 'main' into kotlinify
2 years ago
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
2 years ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
2 years ago
b7a628ece5
Update feature/interests/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/interests/navigation/InterestsNavigation.kt
2 years ago
9d41ffa318
Merge branch 'main' into kotlinify
2 years ago
32e1ec0447
Remove violations: property-naming
2 years ago
f8f932705a
Remove violations: discouraged-comment-location
2 years ago
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
2 years ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
2 years ago
6247712064
Add convention plugins to version catalogs
2 years ago
Don Turner
Clara Fok
Simon Marquis
Alex Vanyo
saeedishayan76
Don Turner
Jonathan Koren
lihenggui
Melwin Magalhaes