af504d2331
More NavigationState refactoring. Fix compilation errors.
1 month ago
f6824858c4
Refactor NavigationState and make tests pass
1 month ago
386d1a0a16
WIP remove DI 2
1 month ago
c9bba49957
WIP remove DI
1 month ago
dc29a5eb62
run spotless
2 months ago
b91a965ae2
Refactored NiaNavigator
...
Made NiaNavigator a stateless class only responsibly for navigating and pop (modifying backStack).
Navigation state now lives in a new class called NiaNavigatorState.
The state of this class is saved and restored by ViewModel.
2 months ago
e373828f5f
Update feature ViewModels and tests
2 months ago
4a8eaba408
Refactor Interests to ListDetailScene
2 months ago
d30083005e
Refactor feature modules to navigation3
2 months ago
068d8cc93c
Split feature modules into api and impl modules
...
Source code is still left in api module. impl module is empty at this point.
2 months ago
17162dab60
graphUpdate
4 months ago
1c61be7b7b
Update color mapping
...
| Type | Plugin ID | Color |
|-------------|------------------------------------|------------------------|
| Application | `nowinandroid.android.application` | `#CAFFBF` PastelGreen |
| Feature | `nowinandroid.android.feature` | `#FFD6A5` PastelOrange |
| Library | `nowinandroid.android.library` | `#9BF6FF` PastelBlue |
| Test | `nowinandroid.android.test` | `#A0C4FF` PastelMauve |
| JVM | `nowinandroid.jvm.library` | `#BDB2FF` PastelPurple |
| Unknown | `?` | `#FFADAD` PastelRed |
4 months ago
e8dc43b58b
graphUpdate
4 months ago
e079e68815
Delete old graphs
4 months ago
5b99313ae5
fix typo
...
Change-Id: I65dcde81c68c24bfd58f0b66c6ed826e802aff67
1 year ago
8bb823ede7
use backgroundScope
...
Change-Id: I78d5e53d343dac7e7d27896c95714a53a9a7229a
1 year ago
94f86b7975
fix test name and typo, and user assertion instead of check method
...
Change-Id: I45e04df676fe9f5e5e893a1fc6e8f54e9e7d7a1a
1 year ago
d372d6ecec
improve BookmarksViewModelTest coverage
...
Change-Id: Ide13abd9a125a337ba9c9fff2136221e16ebd46e
1 year ago
bf54ccc760
feat: use androidx.lifecycle.compose.LocalLifecycleOwner
...
Change-Id: If0a414ee4d5aab277fb90343ba7d5aa6a9dbd2e8
1 year ago
26dd4424f6
remove blank lines for resolve spotless error
1 year ago
0356b873e9
change collectJob to backgroundScope coroutine
1 year ago
00efda54e8
Merge branch 'main' into dt/nav-safe-args
...
* main: (58 commits)
Instrumented tests for InterestsListDetailScreen (#1518 )
Remove Firebase AD_SERVICE_CONFIG property
updateProdReleaseBadging
Merge Android & JVM plugins into a single `HiltConventionPlugin`
Update dependency guard
🤖 Updates baselines for Dependency Guard
Update to Lifecycle 2.8.3
Add android.adservices.AD_SERVICES_CONFIG to badges
Apply suggestions from code review
Update app/src/main/AndroidManifest.xml
generateModuleGraphs
dependencyGuardBaseline
updateProdReleaseBadging
Fix spotless.
Change set to `=` operator
Cleanup unused reference in `libs.versions.toml`
Regenerate SVG graphs
Update comment wording
Use stdin to avoid repeating the output file name
Replace bash commands with proper svgo cli
...
Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5
1 year ago
da8f32a2ea
Rename Destinations to Routes
...
Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7
2 years ago
924391cd22
Fix spotless
...
Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428
2 years ago
89163b5ea1
Migrate remainder of app to type-safe navigation
...
Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b
2 years ago
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
2 years ago
78c77737c0
Merge pull request #1275 from Jaehwa-Noh/rename-function
...
Rename function to setNewsResourceBookmarked
2 years ago
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
2 years ago
ee4320723f
Fix typo.
...
Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f
2 years ago
ed91723e2f
Fix #1270
...
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
2 years ago
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
2 years ago
2ad48843f6
Fix formatting
...
Change-Id: I674d32bc0f1921c431717dbf0f41a74f632322b3
2 years ago
254b464259
Update Lifecycle to 2.7.0. Use new LifecycleEventEffect.
...
Change-Id: I71e7aa521f22499fd3f3e9f3ac7c81658f3abc3a
2 years ago
707117a4f2
Merge branch 'main' into kotlinify
2 years ago
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
2 years ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
2 years ago
6cd5958665
Update feature/bookmarks/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/bookmarks/navigation/BookmarksNavigation.kt
2 years ago
9d41ffa318
Merge branch 'main' into kotlinify
2 years ago
32e1ec0447
Remove violations: property-naming
2 years ago
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
2 years ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
2 years ago
9c89e98e5b
Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold"
...
This reverts commit 335a7ec68caa8ce0e1f6
2 years ago
816a7b60c1
Replace manual navigation component switching with new NavigationSuiteScaffold
...
Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723
2 years ago
0287af8d9a
Merge pull request #947 from android/tj/staggered-grid-feed
...
Use lazy vertical staggered grid in feed to maximize space utilization
2 years ago
6247712064
Add convention plugins to version catalogs
2 years ago
03d2455f41
Use lazy vertical staggered grid in feed to maximize space utilization
...
Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926
2 years ago
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
2 years ago
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
2 years ago
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
2 years ago
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
2 years ago
Don Turner
Clara Fok
Simon Marquis
hiroaki404
blue928sky
saeedishayan76
Alex Vanyo
Jaehwa Noh
Don Turner
lihenggui
Miłosz Moczkowski
Adetunji Dahunsi
Melwin Magalhaes
dahunsi
Simon Marquis