442 Commits (a77c01795db70366b91789fbcecf79e2589952b2)

Author	SHA1	Message	Date
Mercury Li	a77c01795d	Fix Robolectric tests for feature modules ... Add isIncludeAndroidResources to CmpFeatureConventionPlugin so Robolectric can discover the test manifest with ComponentActivity. Add missing compose UI test dependencies to feature:foryou.	3 weeks ago
Mercury Li	b60153218c	Fix CI build after KMP migration and Compose Multiplatform 1.7.3 upgrade ... - Remove demo/prod flavor references from CI workflow (flavors were removed during KMP migration) - Replace tasks.create with tasks.register in convention plugins to fix EagerGradleConfiguration lint error - Remove HiltTestApplication references from screenshot and UI tests (Hilt was replaced by Koin) - Add Compose plugins to core:screenshot-testing for inline method resolution - Add androidx.navigation.testing dependency to feature:topic and feature:interests for SavedStateHandle.toRoute - Fix ViewModel tests in commonTest by setting up Dispatchers.Main (bookmarks, settings) - Uncomment TopicRoute in TopicViewModelTest SavedStateHandle setup - Replace NavDestination.id with type-safe popUpTo<ForYouBaseRoute> in NiaAppState (id property removed in KMP navigation) - Rename badging golden file from prodRelease to release - Update dependency guard baselines - Update AGENTS.md with corrected task names	3 weeks ago
lihenggui	0c691b9676	Merge remote-tracking branch 'upstream/main'	1 year ago
Don Turner	47f93efa19	Merge pull request #1400 from hiroaki404/test/improve_bookmark_viewmodel_coverage ... improve BookmarksViewModelTest coverage	1 year ago
Don Turner	9a183d5fcc	Fix spotless	1 year ago
Don Turner	a6680e4bab	Update feature/settings/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/settings/SettingsDialog.kt	1 year ago
Abhinav Srivastava	20e568e98b	Update SettingsDialog.kt	1 year ago
Don Turner	4277366b7c	Merge pull request #1729 from takahirom/takahirom/update-sdk-35/2024-12-11 ... Update SDK 35 with Theme Fixing	1 year ago
Ben Weiss	d8b735f80e	Revert "Improve accessibility to ForYou topics (#1309)" (#1732) ... This reverts commit 48544194f4.	1 year ago
takahirom	5e73c76acd	🤖 Updates screenshots	1 year ago
Jaehwa Noh	48544194f4	Improve accessibility to ForYou topics (#1309) ... * Clear semantics. Change-Id: I69a48798f6be8433e877c38166bd73cd776d71ac * Merge the descendants semantics. Change-Id: Ifbe91bb694b393e6780f93732a7d38f5ee355680 * Add string for icon description. Change-Id: Ibf35c651aeacfbe317794ed898f0fb0e8bc1ec15 * Change icon description. Change-Id: I9359bf8c9272b247669ae58fd79e5f79466ec0a9 * Change state of icon check logic. Change-Id: I3e5e89fc1c469c3f3c4744d18f697f68d070996b * Merge only text. Change-Id: I36eefc6dd9f56f7a1f63003f0f95f6755ae16def * Add stateDescription. Change-Id: Id4d32e49374dbdb6e666048937e37060cbd4b454 * Add toggleableState. Change-Id: I9f836e2463bf800786d11f9e0997a7d570ff90b0 * Set clearAndSetSemantics at Row. Change-Id: Ic25b9ca11bbcc40c8ff24172669b07ea9b7642a9 * Set stateDescription "Following" and "Not Following". Change-Id: Ib82ac94b05a5d373ac10787aac5241fb4f03c7b2 * Find topic by onNodeWithContentDescription. Change-Id: I2423e3846c02169f6bf1fc30d9b4034b5f79efb3 * Find topic by onNodeWithContentDescription. Change-Id: Iefc97fd9e52227f51f7d40f8c10cb4878cde90c0	1 year ago
Don Turner	a258794dc6	Merge branch 'main' into introduce_screenshot_a11y_tests	1 year ago
Don Turner	e36b7ab454	Merge pull request #1711 from AdnanHabibMirza/adnan/typesafe_project_accessor ... Use typesafe project accessor	1 year ago
Don Turner	78b1a6748a	Merge pull request #1707 from yongsuk44/feature/type-safe ... Refactor: Use type safe SearchRoute	1 year ago
hiroaki404	5b99313ae5	fix typo ... Change-Id: I65dcde81c68c24bfd58f0b66c6ed826e802aff67	1 year ago
hiroaki404	8bb823ede7	use backgroundScope ... Change-Id: I78d5e53d343dac7e7d27896c95714a53a9a7229a	1 year ago
nosho.hiroaki	94f86b7975	fix test name and typo, and user assertion instead of check method ... Change-Id: I45e04df676fe9f5e5e893a1fc6e8f54e9e7d7a1a	1 year ago
nosho.hiroaki	d372d6ecec	improve BookmarksViewModelTest coverage ... Change-Id: Ide13abd9a125a337ba9c9fff2136221e16ebd46e	1 year ago
lihenggui	a87dcda7eb	Merge remote-tracking branch 'upstream/main'	1 year ago
Ben Weiss	729681b79a	Revert "Bump protobuf from 4.26.1 to 4.28.2 (#1630)" ... This reverts commit 82b6352da1.	1 year ago
Jaehwa Noh	dfc3355054	Empty search text is added in recent searches problem fix. (#1223) ... * Add if state to prevent blank query. * Create test emptySearchText_NotAddToRecentSearches - For empty query not add in recent query list. * Apply early return. * assertEquals to assertNull. Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Import org.junit.Assert.assertNull * Change org.junit.Assert.assertNull to kotlin.test.assertNull. Change-Id: I60083b0b9a1dcaed84d957b49c91e5163d5659d6 * Add 'or' to prevent search when query is blank. Change-Id: If498de05889d6d5946b1bbb1d1c10cb311bb9b52 * Create stateIsEmptyQuery_withThreeWhiteSpacesSearchQuery test. Change-Id: I6d6e8f9fe988ca83fae484e4f2338ad6fe58b676 * Add UI logic to prevent blank text search in SearchScreen. - Early return to do not call onSearchExplicitlyTriggered() Change-Id: I28db284eac9059fb6f48dd718721a1fc5fdb8f7a * Apply trim at query to remove whitespace. Change-Id: Id349af4bb1af3d0f1c3973e6fb9e6f3e7b924d9b * Create test stateIsEmptyQuery_withThreeWhiteSpacesAndOneLetterSearchQuery Change-Id: Iee59f6085e4045b2e3c532f78804926290b6c6c5 * Update feature/search/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModelTest.kt Change name to emptySearchText_isNotAddedTorecentSearches() Co-authored-by: Don Turner <dturner@users.noreply.github.com> * Change name to searchTextWithThreeSpaces_isEmptyQuery() Co-authored-by: Don Turner <dturner@users.noreply.github.com> * Change name to searchTextWithThreeWhiteSpacesAndOneCharacter_isEmptyQuery() Change-Id: I4c82b12e2c9bd4ff480e94061caf257a603e38da * Revert "Change name to searchTextWithThreeWhiteSpacesAndOneCharacter_isEmptyQuery()" This reverts commit e4c176598a. * Change name to searchTextWithThreeSpacesAndOneLetter_isEmptyQuery Co-authored-by: Don Turner <dturner@users.noreply.github.com> * Add end curly bracket. Change-Id: I7bd113e7b65d646f5321e34a7df2868f6e239cad --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr> Co-authored-by: Don Turner <dturner@users.noreply.github.com>	1 year ago
dependabot[bot]	82b6352da1	Bump protobuf from 4.26.1 to 4.28.2 (#1630) ... * Bump protobuf from 4.26.1 to 4.28.2 Bumps `protobuf` from 4.26.1 to 4.28.2. Updates `com.google.protobuf:protobuf-kotlin-lite` from 4.26.1 to 4.28.2 Updates `com.google.protobuf:protoc` from 4.26.1 to 4.28.2 - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl) - [Commits](https://github.com/protocolbuffers/protobuf/commits) --- updated-dependencies: - dependency-name: com.google.protobuf:protobuf-kotlin-lite dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: com.google.protobuf:protoc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * 🤖 Updates baselines for Dependency Guard * 🤖 Updates screenshots --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Weiss <keyboardsurfer@users.noreply.github.com>	1 year ago
Don Turner	afb6741554	Merge pull request #1682 from blue928sky/use-lifecycle-compose-LocalLifecycleOwner ... Use androidx.lifecycle.compose.LocalLifecycleOwner	1 year ago
Adnan Habib	83a8beee72	Use typesafe project accessor ... Change-Id: Ib9f0a68debaf75431fe45d5a81128e33e4885321	1 year ago
Yuri Schimke	2415239d45	suppress checks	1 year ago
Yuri Schimke	3e4f66b489	spotless	1 year ago
Yuri Schimke	4f27c18f20	Change order of exceptions	1 year ago
Yuri Schimke	0849597755	Suppress A11y exception for now	1 year ago
yongsuk44	ca87bfe6cf	Refactor: Use type safe SearchRoute	1 year ago
yschimke	2401e20dd4	🤖 Updates screenshots	1 year ago
Yuri Schimke	d7f1863920	remove sdk 21	1 year ago
Yuri Schimke	56fd308d65	revert screenshots	1 year ago
Yuri Schimke	0dd998765c	Update dependencies ... Update Compose BOM to 2024.11.00 and update other dependencies, such as Robolectric and Roborazzi. Also, update Screenshot Tests with sdk version 35 for better screenshot testing.	1 year ago
lihenggui	0758f8e5bf	Merge remote-tracking branch 'upstream/main'	1 year ago
blue928sky	a929f9ccc0	Merge remote-tracking branch 'origin/main' into use-lifecycle-compose-LocalLifecycleOwner ... Change-Id: I338708411967f018bc4a86b2cecebc1bcce71d32	1 year ago
blue928sky	bf54ccc760	feat: use androidx.lifecycle.compose.LocalLifecycleOwner ... Change-Id: If0a414ee4d5aab277fb90343ba7d5aa6a9dbd2e8	1 year ago
Don Turner	89795c98b5	Fix spotless	1 year ago
Don Turner	5994d8c6fd	Add TopicScreen as a sub destination in the ForYou section. Fixes #1463	1 year ago
lihenggui	7007fd4d21	Spotless	1 year ago
lihenggui	ee92faf87c	Move sync module to multiplatform	1 year ago
lihenggui	91d86ec2be	Merge remote-tracking branch 'upstream/main'	1 year ago
Don Turner	bd557fd604	Reduce icon sizes	1 year ago
lihenggui	ccd7d292d2	Spotless	1 year ago
lihenggui	528ee11110	Add material 3 adaptive dependencies and fix compilation errors	1 year ago
lihenggui	539d36fb0b	WIP: Move app to use compose multiplatform	1 year ago
lihenggui	7b0d1bea22	Migrate bookmarks module to multiplatform	1 year ago
lihenggui	6a48d80dec	Make foryou module to use koin	1 year ago
lihenggui	6e4a3e1ef7	Add kotlin serialization in the topic module	1 year ago
lihenggui	2657cb75c7	Migrate interest module to use koin	1 year ago
lihenggui	41b0cf19f7	Use koin in the search module	1 year ago