nosho.hiroaki
94f86b7975
fix test name and typo, and user assertion instead of check method
...
Change-Id: I45e04df676fe9f5e5e893a1fc6e8f54e9e7d7a1a
2 weeks ago
nosho.hiroaki
d372d6ecec
improve BookmarksViewModelTest coverage
...
Change-Id: Ide13abd9a125a337ba9c9fff2136221e16ebd46e
2 weeks ago
Ben Weiss
729681b79a
Revert "Bump protobuf from 4.26.1 to 4.28.2 ( #1630 )"
...
This reverts commit 82b6352da1
.
2 weeks ago
Jaehwa Noh
dfc3355054
Empty search text is added in recent searches problem fix. ( #1223 )
...
* Add if state to prevent blank query.
* Create test emptySearchText_NotAddToRecentSearches
- For empty query not add in recent query list.
* Apply early return.
* assertEquals to assertNull.
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
* Import org.junit.Assert.assertNull
* Change org.junit.Assert.assertNull to kotlin.test.assertNull.
Change-Id: I60083b0b9a1dcaed84d957b49c91e5163d5659d6
* Add 'or' to prevent search when query is blank.
Change-Id: If498de05889d6d5946b1bbb1d1c10cb311bb9b52
* Create stateIsEmptyQuery_withThreeWhiteSpacesSearchQuery test.
Change-Id: I6d6e8f9fe988ca83fae484e4f2338ad6fe58b676
* Add UI logic to prevent blank text search in SearchScreen.
- Early return to do not call onSearchExplicitlyTriggered()
Change-Id: I28db284eac9059fb6f48dd718721a1fc5fdb8f7a
* Apply trim at query to remove whitespace.
Change-Id: Id349af4bb1af3d0f1c3973e6fb9e6f3e7b924d9b
* Create test stateIsEmptyQuery_withThreeWhiteSpacesAndOneLetterSearchQuery
Change-Id: Iee59f6085e4045b2e3c532f78804926290b6c6c5
* Update feature/search/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModelTest.kt
Change name to emptySearchText_isNotAddedTorecentSearches()
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Change name to searchTextWithThreeSpaces_isEmptyQuery()
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Change name to searchTextWithThreeWhiteSpacesAndOneCharacter_isEmptyQuery()
Change-Id: I4c82b12e2c9bd4ff480e94061caf257a603e38da
* Revert "Change name to searchTextWithThreeWhiteSpacesAndOneCharacter_isEmptyQuery()"
This reverts commit e4c176598a
.
* Change name to searchTextWithThreeSpacesAndOneLetter_isEmptyQuery
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Add end curly bracket.
Change-Id: I7bd113e7b65d646f5321e34a7df2868f6e239cad
---------
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
2 weeks ago
dependabot[bot]
82b6352da1
Bump protobuf from 4.26.1 to 4.28.2 ( #1630 )
...
* Bump protobuf from 4.26.1 to 4.28.2
Bumps `protobuf` from 4.26.1 to 4.28.2.
Updates `com.google.protobuf:protobuf-kotlin-lite` from 4.26.1 to 4.28.2
Updates `com.google.protobuf:protoc` from 4.26.1 to 4.28.2
- [Release notes](https://github.com/protocolbuffers/protobuf/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl )
- [Commits](https://github.com/protocolbuffers/protobuf/commits )
---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-kotlin-lite
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.protobuf:protoc
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* 🤖 Updates baselines for Dependency Guard
* 🤖 Updates screenshots
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Weiss <keyboardsurfer@users.noreply.github.com>
2 weeks ago
Don Turner
afb6741554
Merge pull request #1682 from blue928sky/use-lifecycle-compose-LocalLifecycleOwner
...
Use androidx.lifecycle.compose.LocalLifecycleOwner
4 weeks ago
yschimke
2401e20dd4
🤖 Updates screenshots
1 month ago
Yuri Schimke
d7f1863920
remove sdk 21
1 month ago
Yuri Schimke
56fd308d65
revert screenshots
1 month ago
Yuri Schimke
0dd998765c
Update dependencies
...
Update Compose BOM to 2024.11.00 and update other dependencies, such as Robolectric and Roborazzi.
Also, update Screenshot Tests with sdk version 35 for better screenshot testing.
1 month ago
blue928sky
a929f9ccc0
Merge remote-tracking branch 'origin/main' into use-lifecycle-compose-LocalLifecycleOwner
...
Change-Id: I338708411967f018bc4a86b2cecebc1bcce71d32
2 months ago
blue928sky
bf54ccc760
feat: use androidx.lifecycle.compose.LocalLifecycleOwner
...
Change-Id: If0a414ee4d5aab277fb90343ba7d5aa6a9dbd2e8
2 months ago
Don Turner
89795c98b5
Fix spotless
2 months ago
Don Turner
5994d8c6fd
Add TopicScreen as a sub destination in the ForYou section. Fixes #1463
2 months ago
Don Turner
bd557fd604
Reduce icon sizes
2 months ago
Tomáš Mlynarič
37353e354a
Merge pull request #1594 from yongsuk44/trace-marker-default
...
Fix duplicate composition trace markers
3 months ago
Alex Vanyo
f42afb5aa7
Merge pull request #1585 from saeedishayan76/change-unitTest
...
change collectJob to backgroundScope coroutine
3 months ago
Don Turner
d1748eb2d3
Merge pull request #1616 from android/dt/fix-internal-build
...
Replace BoxWithConstraints with Box
3 months ago
Don Turner
115a68e72b
Replace BoxWithConstraints with Box
...
Change-Id: I63a54aa6c30c6a68beab66ffce77238e5156ee06
3 months ago
Alex Vanyo
79787caa60
Merge pull request #1601 from android/av/compose-2024-09-00
...
Update Compose to 2024.09.00
4 months ago
Alex Vanyo
e135b49736
Replace ClickableText with LinkAnnotation
...
Change-Id: I18ba20f07db5a392890f7e568c9faa7a90af1054
4 months ago
Alex Vanyo
940497f176
Merge pull request #1575 from junyong008/remove-duplicate-dependency
...
Remove duplicate dependency
4 months ago
saeedishayan76
987e87f4ed
Check topicViewModelTest for spotless
4 months ago
saeedishayan76
6f40606c54
InterstsViewModelTest fix spotless Issue
4 months ago
saeedishayan76
26dd4424f6
remove blank lines for resolve spotless error
4 months ago
saeedishayan76
0356b873e9
change collectJob to backgroundScope coroutine
4 months ago
yongsuk44
f0434e52a4
Spotless Apply
4 months ago
yongsuk44
46e15f21dc
Fix duplicate composition trace markers in composable
4 months ago
Don Turner
bee8c88681
Update feature/interests/src/test/kotlin/com/google/samples/apps/nowinandroid/interests/InterestsViewModelTest.kt
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
4 months ago
Don Turner
4ff5b1fa26
Fix failing InterestsListDetailScreenTest
...
Change-Id: Ib6e47d9a9cced4c967756f95a5c98587628bd2cb
4 months ago
Don Turner
8d57134663
Fix spotless
...
Change-Id: Ib093c206809a470b7f6135933bd2a72046865684
4 months ago
Don Turner
a8ffd1f2f1
Fix incorrect deep link key name in ForYouViewModelTest
...
Change-Id: I945632c419e11671eb73690999f9a234e577d16b
4 months ago
Don Turner
4b3f5370b9
Clean up deep link handling
...
Change-Id: I9d589cfe5c20a6b55708b99f5d79b10271af8ab4
4 months ago
Don Turner
00efda54e8
Merge branch 'main' into dt/nav-safe-args
...
* main: (58 commits)
Instrumented tests for InterestsListDetailScreen (#1518 )
Remove Firebase AD_SERVICE_CONFIG property
updateProdReleaseBadging
Merge Android & JVM plugins into a single `HiltConventionPlugin`
Update dependency guard
🤖 Updates baselines for Dependency Guard
Update to Lifecycle 2.8.3
Add android.adservices.AD_SERVICES_CONFIG to badges
Apply suggestions from code review
Update app/src/main/AndroidManifest.xml
generateModuleGraphs
dependencyGuardBaseline
updateProdReleaseBadging
Fix spotless.
Change set to `=` operator
Cleanup unused reference in `libs.versions.toml`
Regenerate SVG graphs
Update comment wording
Use stdin to avoid repeating the output file name
Replace bash commands with proper svgo cli
...
Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5
4 months ago
junyong
104f2591df
Remove duplicate dependency
4 months ago
Don Turner
fc58680c06
Remove string-based argument name from navigation code
...
Change-Id: I7c880cc73374e053ea0d41df00a4bda95ed4b551
5 months ago
Simon Marquis
1c5513283a
Merge remote-tracking branch 'origin/main' into fix/1161-2
6 months ago
Don Turner
ec71b2a07e
Add Robolectric to allow ViewModel tests to pass
...
Change-Id: I782fab167103edbdaa1d95839b4fbc6e659fef4e
6 months ago
Don Turner
95bdc0f533
Rename ForYouRoute composable to ForYouScreen
...
Change-Id: I47456f19f2b41cafe44ba7636cad6d1fea782a33
7 months ago
Don Turner
da8f32a2ea
Rename Destinations to Routes
...
Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7
7 months ago
Don Turner
8fc2e15e73
Update to navigation 2.8.0-beta01
...
Change-Id: I2f01dc19e37b9fe890ad861909f57198cc5262d4
7 months ago
Simon Marquis
61143ca98b
Merge remote-tracking branch 'origin/main' into fix/1161-2
8 months ago
Don Turner
be752e779d
Fix tests, fix spotless
...
Change-Id: I55e779abe4ee49dc93916d9e1184ed81e1b2bbd0
8 months ago
Don Turner
aba2b2c154
Remove different deeplink destination, add route for nested nav host
...
Change-Id: Idb9586752d815449243d6d529e9b655c45e395ad
8 months ago
Don Turner
4a84cf2bf4
Add specific type for deeplinks
...
Change-Id: I63c0abb16cbf540ef72dfb945518a48113bdbf75
8 months ago
Don Turner
f67f4d1a83
Update ForYou destination to match current deeplink pattern
...
Change-Id: Ia5ab36f2d75d8d061e63c0cac5262503bc93a638
8 months ago
Don Turner
7ec21d9d2f
Fix issue where selected topic in list was not showing as selected. Minor tidy ups.
...
Change-Id: Icfa79eac6f7327c365f79fd7d15dfa1f8c77184d
8 months ago
Alex Vanyo
3fb6df7c33
Add NavigationSuiteScaffold
...
Change-Id: I36710d880bff381ed86c61632f2ab91902727775
8 months ago
Alex Vanyo
1c0508a678
Recreate nested nav to work with AnimatedPane
...
Change-Id: I6b526331b7fc62b968ac39e91753a8a1e5343023
8 months ago
dturner
8cc0fc00e6
🤖 Updates screenshots
8 months ago