2297 Commits (917cfd2be2f2e70ef6564f2503acc3986bf2e9df)

 

All Branches   

Search

Author	SHA1	Message	Date
Don Turner	8faf3aa38a	Merge pull request #922 from SimonMarquis/SimonMarquis-patch-1-1 ... Update AGP to version 8.1.1	1 year ago
Adetunji Dahunsi	b248e4d0e8	Merge pull request #952 from SimonMarquis/patch-2 ... Fix wrong configuration name, leaking `work-testing` to runtime classpath	1 year ago
Simon Marquis	ebfe01affd	Enforce `resourcePrefix` on Android library modules ... ``` :ui-test-hilt-manifest -> ui_test_hilt_manifest_ :core:analytics -> core_analytics_ :core:common -> core_common_ :core:data -> core_data_ :core:data-test -> core_data_test_ :core:database -> core_database_ :core:datastore -> core_datastore_ :core:datastore-test -> core_datastore_test_ :core:designsystem -> core_designsystem_ :core:domain -> core_domain_ :core:network -> core_network_ :core:notifications -> core_notifications_ :core:testing -> core_testing_ :core:ui -> core_ui_ :feature:bookmarks -> feature_bookmarks_ :feature:foryou -> feature_foryou_ :feature:interests -> feature_interests_ :feature:search -> feature_search_ :feature:settings -> feature_settings_ :feature:topic -> feature_topic_ :sync:sync-test -> sync_test_ :sync:work -> sync_work_ ```	1 year ago
Simon Marquis	f798e28ef0	Update AGP to version 8.1.1 ... Removing the compileSdk 34 build warning: ``` We recommend using a newer Android Gradle plugin to use compileSdk = 34 This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = \"UpsideDownCakePrivacySandbox\"). You are strongly encouraged to update your project to use a newer Android Gradle plugin that has been tested with compileSdk = 34. If you are already using the latest version of the Android Gradle plugin, you may need to wait until a newer version with support for compileSdk = 34 is available. To suppress this warning, add/update android.suppressUnsupportedCompileSdk=34 to this project's gradle.properties. ```	1 year ago
Simon Marquis	a33dafccad	Migrate from `java` to `kotlin` sourceSet directory	1 year ago
Simon Marquis	49a2fb5272	Fix wrong configuration name, leaking `work-testing` to runtime classpath ... Typo introduced recently when Roborazzi was added to the project: 886158d3cb (diff-8cff73265af19c059547b76aca8882cbaa3209291406f52df1dafbbc78e80c46)	1 year ago
Simon Marquis	03ba943632	Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication` ... - Prevent logging multiple times (because of `onResume()` callback) - Remove unnecessary io dispatcher: `ListenableFuture<T>.await()` is already main-safe and prevent acquiring io slot. - Merge comments into a single javadoc comment on the `ProfileVerifierLogger` type. - Add proper javadoc format with markdown specific blocks. - Update logs & tag to be more uniform. Closes #945	1 year ago
Simon Marquis	81345ffecb	Update IDE copyright to match spotless configuration	1 year ago
Jose Alcérreca	151f877bbe	Adds screenshot tests to :core:designsystem (#931) ... * WIP: Adds screenshot tests to :core:designsystem Change-Id: I0672845feba4064652dd8d60f07047b87864e121 * 🤖 Updates screenshots * Creates tests for more components and cleans up Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22 * WIP: More cleanup and more combinations of themes Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523 * Added the rest of the screenshot tests for designsystem Change-Id: Ic427db5491910781c038882055524e3f3dbed194 * Some more cleanup Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180 * Spotless Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6 * 🤖 Updates screenshots * ScreenshotHelper cleanup Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0	1 year ago
Don Turner	d0909a9c8f	Merge pull request #925 from SimonMarquis/remove-dispatcher ... Remove unnecessary dispatcher switch in `DefaultRecentSearchRepository`	1 year ago
Alex Vanyo	000c21f065	Merge pull request #926 from SimonMarquis/patch-1 ... Fix typo in `AndroidCompose.kt`	1 year ago
James Rose	7945a2beba	Merge pull request #618 from materoy/main ... Renamed functions with signature toggle(isOn: Boolean)	1 year ago
lihenggui	9cc27bfacb	Update gradle-wrapper.jar	1 year ago
Simon Marquis	eadcbe6795	Fix typo in `AndroidCompose.kt`	1 year ago
Simon Marquis	0ddcf0b4ab	Remove unnecessary dispatcher switch in `DefaultRecentSearchRepository` ... As mentioned in the following discussion: https://github.com/android/nowinandroid/discussions/818 Room already takes care of switching dispatchers if the DAO method is correctly annotated with the `suspend` modifier.	1 year ago
Roy Matero	298f3ce4db	Merge branch 'android:main' into main	1 year ago
Adetunji Dahunsi	b989d3a243	Merge pull request #907 from SimonMarquis/replace-instant-serializer ... Replace identical `InstantSerializer` with KotlinX datetime default serializer	1 year ago
Simon Marquis	c98e6236d5	Replace identical `InstantSerializer` with KotlinX datetime default serializer	1 year ago
Jose Alcérreca	5b79869324	Adds dark screenshot tests and fixes background colors in ForYou (#918) ... * Adds dark screenshot tests and fixes background colors in ForYou * 🤖 Updates screenshots	1 year ago
Milosz Moczkowski	851ca6388e	Merge pull request #868 from SimonMarquis/patch-4 ... Handle topic clicks from all destinations	1 year ago
Roy Matero	4e6cda1965	Renamed toggle function signature with boolean parameters ... Change-Id: I0d6c0ed4d4c0ee4bd387e5645fc558970f5f202b	1 year ago
Milosz Moczkowski	ce7a303a2c	Merge pull request #792 from SimonMarquis/gmd ... Update GMD workflow	1 year ago
Milosz Moczkowski	c57fb78fa7	Merge pull request #759 from SimonMarquis/lint/sarif ... Android Lint improvements	1 year ago
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876) ... * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	1 year ago
Adetunji Dahunsi	4716c7f841	Merge pull request #913 from hoangchungk53qx1/main ... Refactor Search Feature	1 year ago
hoangchungk53qx1	66eafdc38b	format modification for screen search	1 year ago
Milosz Moczkowski	b6459d41ee	Merge pull request #834 from takahirom/takahirom/rename-topicBody/2023-07-13 ... Rename LazyListScope.TopicBody LazyListScope.topicBody	1 year ago
Milosz Moczkowski	374808c284	Merge pull request #847 from SilviaGarciaBouza/wrong_color_in_dark_mode ... Added TextStyle color for ClickableText	1 year ago
Milosz Moczkowski	d2d12b958b	Merge pull request #858 from SimonMarquis/patch-10 ... Add missing `allowNotifications()` in `BaselineProfileGenerator.kt`	1 year ago
hoangchungk53qx1	70498dd6e3	separate function logEvent for search triggered	1 year ago
hoangchungk53qx1	9cb20db93a	separate function logEvent for search triggered	1 year ago
hoangchungk53qx1	c52c4b88cd	replace object with data object in search feature, simple format code for the reader	1 year ago
hoangchungk53qx1	cd30ecf359	replace object with data object in search feature, simple format code for the reader	1 year ago
Adetunji Dahunsi	014d388e92	Merge pull request #897 from SimonMarquis/SimonMarquis-patch-1-2 ... Add syntax highlighting on Compose compiler metrics code block	1 year ago
lihenggui	fcc49d141d	Upgrade Gradle to v8.3	1 year ago
Milosz Moczkowski	12642c9110	Merge pull request #891 from SimonMarquis/update/protobuf ... Update protobuf 3.24.0 and protobuf plugin 0.9.4	1 year ago
Milosz Moczkowski	43d788be3c	Merge pull request #892 from SimonMarquis/update/ksp ... Update KSP 1.9.0-1.0.13	1 year ago
Milosz Moczkowski	24c094c756	Merge pull request #896 from SimonMarquis/SimonMarquis-patch-1-1 ... Update note rendering with new GitHub callouts	1 year ago
Milosz Moczkowski	434bbbd8d1	Merge pull request #898 from SimonMarquis/run-configuration ... Create `spotlessApply` permanent run configuration	1 year ago
Milosz Moczkowski	928833fe5d	Merge pull request #889 from RivanParmar/main ... Rename SearchResult.kt.kt to SearchResult.kt	1 year ago
Milosz Moczkowski	89a1294c63	Merge branch 'main' into takahirom/rename-topicBody/2023-07-13	1 year ago
Jose Alcérreca	6c0d6ad82e	Fixes icons size in onboarding and restores LocalInspection for images (#909) ... * Fixes icons size in onboarding and restores LocalInspection for images	1 year ago
Don Turner	6645ec9fce	Merge pull request #902 from SimonMarquis/resource-type-to-string ... Replace `NewsResourceType` enum with simpler String type	1 year ago
Simon Marquis	0ced769999	Widen `isNotEmpty` with `isNotBlank` to potentially catch blank values	1 year ago
Simon Marquis	4a5ec5bd82	Update `var` with fake default value to the more "correct" `lateinit var`	1 year ago
Simon Marquis	f1bc6f1226	Restore `Unknown` type as empty `String`	1 year ago
Simon Marquis	c831dc673c	Fix broken text	1 year ago
Simon Marquis	daa2228132	Restore original `type` labels	1 year ago
Simon Marquis	480d8e7d7c	Fix missing removal	1 year ago
Simon Marquis	553b01fcb6	spotlessApply	1 year ago