Simon Marquis
1c5513283a
Merge remote-tracking branch 'origin/main' into fix/1161-2
6 months ago
Simon Marquis
61143ca98b
Merge remote-tracking branch 'origin/main' into fix/1161-2
7 months ago
Alex Vanyo
3fb6df7c33
Add NavigationSuiteScaffold
...
Change-Id: I36710d880bff381ed86c61632f2ab91902727775
8 months ago
Alex Vanyo
1c0508a678
Recreate nested nav to work with AnimatedPane
...
Change-Id: I6b526331b7fc62b968ac39e91753a8a1e5343023
8 months ago
Don Turner
88c3eb0b90
Merge pull request #1284 from sanao1006/remove-GetSearchContentsCountUseCase
...
Directly call SearchContentsRepository interface in SearchViewModel
9 months ago
Simon Marquis
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
9 months ago
yongsuk44
e2a4706470
Remove unnecessary opt-in annotations
9 months ago
Jonathan Koren
dac1a9e446
Topic detail pane placeholder ( #1280 )
...
* Topic detail pane placeholder
Change-Id: I92b84493a5406240285c0759b30aa10d29871f09
* Add modifier parameter
Change-Id: Ie363be83b44f26291030c04c1513cecb851a6899
9 months ago
Don Turner
51d3903a4b
Merge branch 'main' into remove-GetSearchContentsCountUseCase
9 months ago
Don Turner
c7e9dd3803
Update method name. Fixes #1287
...
Change-Id: I9b603bd33f7be0f7562aab4a7b6f2307a3a1333a
9 months ago
Don Turner
0584f191bc
Merge pull request #1271 from android/dt/remove-feature-dep
...
Remove the search module's dependency on other feature modules
9 months ago
sanao1006
825a5e2f5f
[Refactor]: Directly call SearchContentsRepository interface in SearchViewModel
...
- Remove GetSearchContentsCountUseCase.
- Remove GetSearchContentsCountUseCase from SearchViewModel.
- Remove GetSearchContentsCountUseCase from SearchViewModelTest.
Fixes #1283
9 months ago
Alex Vanyo
78c77737c0
Merge pull request #1275 from Jaehwa-Noh/rename-function
...
Rename function to setNewsResourceBookmarked
9 months ago
Don Turner
b5bfe44bf3
Fix spotless
...
Change-Id: I5b08ce68522c59cdd7f7ec56a14a7ebc8b3868cd
9 months ago
Don Turner
ce9e82622d
Fix broken reference to string resources
...
Change-Id: Ide4cb90abc2ae7ca78488909a37df685c2e71ec6
9 months ago
Don Turner
5084fca4dd
Fix InterestScreenTest resources
...
Change-Id: Ib6aa372a1ab3b13b5c69c1d3feec2c31e5dca3ce
9 months ago
Don Turner
a4c52e6485
Remove the search module's dependency on other feature modules
...
Change-Id: I17df9948fed04ddc7ba507b437d39536b8b180bb
9 months ago
Don Turner
3e4aad3210
Merge pull request #1257 from android/dt/add-module-graphs
...
Update module dependency graphs and add script to create them
9 months ago
Don Turner
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
9 months ago
Jaehwa Noh
fc4f7930a6
Merge branch 'android:main' into rename-function
9 months ago
Jaehwa Noh
ee4320723f
Fix typo.
...
Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f
9 months ago
Jaehwa Noh
ed91723e2f
Fix #1270
...
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
9 months ago
Don Turner
547cb191d2
Merge pull request #1256 from lnbs97/main
...
Fix typo in TopicViewModel.kt
9 months ago
Tomáš Mlynarič
aa15e65a77
Fix search flickering
...
Change-Id: I6d17f5703186dbebcba4f931ab9692d4ab1e9f79
10 months ago
Jonathan Koren
19f6f9e09a
2 pane support in Interests screen ( #1234 )
...
* Add dependency on material3 adaptive
Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6
* Add InterestsListDetailScreen composable
Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971
* Store selectedTopicId in InterestsViewModel
Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce
* Pass detail pane composable down
Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293
* Navigate to initial topic if provided
Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b
* Lift LDPS up to app module
Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85
* Fix some navigation behavior
Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b
* Navigate to initial topic if provided
Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed
* Remove dependency in interests feature module
Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f
* Hide back arrow when the topics list is visible
Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8
* Update interests tests
Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd
* Highlight selected topic when displaying 2 panes
Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415
* update dependency baselines
Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00
* run spotless apply
Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8
* Convert isListPaneHidden to isListPaneVisible
Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657
* Set semantics for selected state
Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca
* Use scaffold roles when determining visibility
Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648
* Update multipleBackStackInterests test
Change-Id: I1e372f7989817151a6765205291b13b561187fa8
10 months ago
lnbs97
96d210dc35
fix typo in TopicViewModel.kt
10 months ago
Don Turner
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
10 months ago
Don Turner
171fa88ac0
Merge pull request #1248 from yongsuk44/main
...
Apply Composable Parameter Ordering Guidelines
10 months ago
kim-yongsuk
3fa75a037a
Apply Composable Parameter Ordering Guidelines
...
Change-Id: Id456e91b5ce8bd5807c40df67c3deac008c61670
10 months ago
Alex Vanyo
e3c7018124
Extract ScreenshotHelper to separate testing module
...
Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af
10 months ago
Don Turner
db5e2b649e
Remove unnecessary Boxes
...
Change-Id: Ia404cde7f6b555234bef4b27058fabd4471ea3c6
10 months ago
dturner
27fd4e544a
🤖 Updates screenshots
10 months ago
dturner
02d4fea615
🤖 Updates screenshots
10 months ago
dturner
81a5c0a3a7
🤖 Updates screenshots
10 months ago
Don Turner
76d59b3da8
Merge branch 'main' into update-compose-bom
10 months ago
Don Turner
1d2029aa2c
Merge pull request #1040 from SimonMarquis/fix-unit-test
...
Fix `emptyResultIsReturned_withNotMatchingQuery` unit test
10 months ago
dturner
9e645356f6
🤖 Updates screenshots
10 months ago
Don Turner
2271d01da5
Fix spotless
...
Change-Id: I8d19c437fc6e2e2198af5ac871c3f7813d280923
10 months ago
Don Turner
b1d867f827
Replace BoxWithConstraints with Box (fixes linter error)
...
Change-Id: Iea0401e28ae0e884511800652fde0f1896642aa0
10 months ago
dturner
6b2b01ed82
🤖 Updates screenshots
10 months ago
Don Turner
522efac8c0
Update Compose BOM to 2024.02.00. Fixes #1218
...
Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b
10 months ago
Don Turner
69f4287ab5
Merge branch 'main' into lifecycle2.7.0
...
* main:
Bump protobuf from 3.24.4 to 3.25.2 (#1214 )
Remove legacy benchmark build type (#1207 )
Use androidx.tracing everywhere
Revert fast initialization of Coil
Add comment for Retrofit async OkHttp
Optimize OkHttp initialization for Retrofit
Add braces
Inline initialization
Don't use runBlocking if async init completed
Launch loader directly without additional coroutine scope
Fix comment
Improve lazy loading for Coil + OkHttp
Restores screenshot tests in foryou (#1199 )
Fix name and message of dependency guard actions (#1196 )
Change-Id: Ifcbfcfba4b7d8c24599e207b4a05dfea6125fde7
10 months ago
Don Turner
2ad48843f6
Fix formatting
...
Change-Id: I674d32bc0f1921c431717dbf0f41a74f632322b3
10 months ago
Ben Weiss
f64f1c0aa2
Remove legacy benchmark build type ( #1207 )
...
* Remove legacy benchmark build type
Now that we have the baseline profile gradle plugin,
there is no need for a benchmark build type.
The plugin does the setup and configuration and runs against the
correct app flavor.
* Remove explicit benchmark build type from benchmark module
* Remove stale build task exclusions
* Fix tracing import location
FYI @mlykotom
10 months ago
Don Turner
254b464259
Update Lifecycle to 2.7.0. Use new LifecycleEventEffect.
...
Change-Id: I71e7aa521f22499fd3f3e9f3ac7c81658f3abc3a
10 months ago
Tomáš Mlynarič
d9aaec0699
Use androidx.tracing everywhere
...
Change-Id: I847827efc08f5cbc00f0c809ad992c267f826e50
10 months ago
Jose Alcérreca
3ff5d48f37
Restores screenshot tests in foryou ( #1199 )
11 months ago
Simon Marquis
5a1258232f
Fix `emptyResultIsReturned_withNotMatchingQuery` unit test
...
`searchResultUiState` transitively relied on `getSearchContentsCount` updates and on `userDataRepository` to emit something.
11 months ago
Don Turner
707117a4f2
Merge branch 'main' into kotlinify
1 year ago
Don Turner
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
1 year ago