2019 Commits (8b56fd31605d2ab38f3b598cb82002e6ca45f343)

 

All Branches   

Search

Author	SHA1	Message	Date
Adetunji Dahunsi	ec53d03854	Merge pull request #722 from android/tj/scrollbars ... Add scrollbars to app	1 year ago
dahunsi	03610d229a	Update feedItemsSize calculation ... Change-Id: I2bf6a2fa0e210cef1318707d948a49d2ef010452	1 year ago
Simon Marquis	e8449112b4	Replace StringDecoder injection with simpler API ... The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String. For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`). Unit tests would fail because Uri is not mocked (since we are not using Robolectric). Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc. FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded". The solution to this problem was to simply use regular Java APIs: - `URLDecoder.decode(urlEncodedTopicId, "UTF-8")` - `URLEncoder.encode(topicId, "UTF-8")`	1 year ago
Simon Marquis	4bdc9705af	Fix miscellaneous warnings ... - Remove unused namespace declaration - Collapse empty manifest tags - Remove redundant qualifier name - Remove redundant suppression	1 year ago
Simon Marquis	b7799f0475	Convert 'sealed' sub-object to 'data object'	1 year ago
Simon Marquis	72788223d2	Update README.md to mention `prodRelease` variant ... and remove the "in open beta" now that it has been published.	1 year ago
qamarelsafadi	5bbcc904e9	feat: make painter in one line	1 year ago
qamarelsafadi	3595d8dcb5	feat: move the placeholder default value to the method	1 year ago
Qamar A. Safadi	9f3103c212	Merge branch 'android:main' into loading-progress-for-image	1 year ago
Alex Vanyo	a3ee09ec3e	Merge pull request #817 from android/av/enable-edge-to-edge ... Switch to new Activity.enableEdgeToEdge	1 year ago
Don Turner	2693773fa2	Merge pull request #866 from nodmp/main-topic-typo ... Typo fix for topics	1 year ago
Don Turner	04eb632081	Merge pull request #862 from SimonMarquis/patch-1 ... Remove hardcoded topic names in `NavigationTest.kt`	1 year ago
Simon Marquis	d8a6d0de13	Replace NiaNetworkDataSource with TopicsRepository ... to be closer to the actual source of data used by the instrumented app.	1 year ago
Simon Marquis	57f3700980	Select last topic by name instead of a random one	1 year ago
Don Turner	8d3c2341ad	Merge pull request #864 from SimonMarquis/patch-2 ... Add missing full stop in `search_not_ready` string	1 year ago
Simon Marquis	64f81751b3	Handle topic clicks from all destinations ... Closes #865	1 year ago
prosixe	c779b4e8ca	Typo fix for topics ... tocpis -> topics	1 year ago
Alex Vanyo	2b218b97d9	Switch to new Activity.enableEdgeToEdge ... Change-Id: I9bbb7b2d116099524525619714ef18448e707c4f	1 year ago
Simon Marquis	995d7b643f	Add missing full stop in `search_not_ready` string	1 year ago
Simon Marquis	0a1f333fc6	Update NavigationTest.kt	1 year ago
Simon Marquis	bf5fdb4cf8	Update NavigationTest.kt	1 year ago
Simon Marquis	250850cf9b	Remove hardcoded topic names in `NavigationTest.kt`	1 year ago
qamarelsafadi	e276212574	feat: remove check if placeholder null and put a default placeholder if its not passed.	1 year ago
qamarelsafadi	f1a2993adc	feat: remove add placeholder todo	1 year ago
qamarelsafadi	427d65ecb2	Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image	1 year ago
Qamar A. Safadi	54723b5966	Merge branch 'android:main' into loading-progress-for-image	1 year ago
qamarelsafadi	9c1ec17a39	fix: modifier to Modifier	1 year ago
Don Turner	cd2fbb02b6	Merge pull request #855 from SimonMarquis/patch-6 ... Update desugar_jdk_libs to version 2.0.3	1 year ago
Don Turner	7c38944a71	Merge pull request #861 from android/fix-retrofit ... Fix for Retrofit R8 issue, bump version to 0.1.2	1 year ago
Don Turner	654944430d	Fix for Retrofit R8 issue, bump version to 0.1.2 ... Change-Id: Ia90d693731c95248211b12b1ce2e9dfab0ecf34c	1 year ago
Simon Marquis	83032cba6e	Add small delay before fling gesture	1 year ago
Don Turner	13019dc543	Merge branch 'main' into patch-6	1 year ago
Don Turner	6ab175c08c	Merge pull request #856 from SimonMarquis/patch-8 ... Update room to version 2.5.2	1 year ago
Don Turner	3756e3ea2d	Merge pull request #832 from SimonMarquis/patch-2 ... Align `targetSdk` to 34 in `AndroidTestConventionPlugin.kt`	1 year ago
qamarelsafadi	9fb3804156	Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image	1 year ago
Qamar A. Safadi	8209bd7ad2	Merge branch 'android:main' into loading-progress-for-image	1 year ago
qamarelsafadi	57025e7587	fix: review notes	1 year ago
Márton Braun	52c5b88950	Merge pull request #854 from SimonMarquis/patch-5 ... Update AGP 8.1.0	1 year ago
Simon Marquis	3b29e953bb	Update BaselineProfileGenerator.kt	1 year ago
Simon Marquis	03a15958ec	Add missing `allowNotifications()` in `BaselineProfileGenerator.kt` ... Closes #853	1 year ago
Simon Marquis	e257f2cbf4	Merge remote-tracking branch 'origin/main' into patch-2	1 year ago
Simon Marquis	97414a667a	Update room to version 2.5.2 ... Changelog: https://developer.android.com/jetpack/androidx/releases/room#2.5.2	1 year ago
Simon Marquis	fb2bd63d68	Update desugar_jdk_libs to version 2.0.3 ... Changelog: https://github.com/google/desugar_jdk_libs/blob/master/CHANGELOG.md	1 year ago
Simon Marquis	61f7eb8823	Update new `CommonExtension` signature	1 year ago
Simon Marquis	5467aad054	Remove AGP lint version override	1 year ago
Simon Marquis	abdb7b8bf6	Update AGP 8.1.0	1 year ago
qamarelsafadi	8a197800c5	feat: fix format issue	1 year ago
qamarelsafadi	f4859e0bcd	Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image	1 year ago
Qamar A. Safadi	06e91fd623	Merge branch 'android:main' into loading-progress-for-image	1 year ago
qamarelsafadi	a294adb6b9	feat: fix format issue	1 year ago