Tomáš Mlynarič
75a3295381
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt
10 months ago
dturner
08d8f1393a
🤖 Updates baselines for Dependency Guard
10 months ago
dependabot[bot]
6add4d68e3
Bump protobuf from 3.24.4 to 3.25.2 ( #1214 )
...
* Bump protobuf from 3.24.4 to 3.25.2
Bumps `protobuf` from 3.24.4 to 3.25.2.
Updates `com.google.protobuf:protobuf-kotlin-lite` from 3.24.4 to 3.25.2
Updates `com.google.protobuf:protoc` from 3.24.4 to 3.25.2
- [Release notes](https://github.com/protocolbuffers/protobuf/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl )
- [Commits](https://github.com/protocolbuffers/protobuf/compare/v3.24.4...v3.25.2 )
---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-kotlin-lite
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.protobuf:protoc
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* 🤖 Updates baselines for Dependency Guard
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
10 months ago
Ben Weiss
f64f1c0aa2
Remove legacy benchmark build type ( #1207 )
...
* Remove legacy benchmark build type
Now that we have the baseline profile gradle plugin,
there is no need for a benchmark build type.
The plugin does the setup and configuration and runs against the
correct app flavor.
* Remove explicit benchmark build type from benchmark module
* Remove stale build task exclusions
* Fix tracing import location
FYI @mlykotom
11 months ago
Tomáš Mlynarič
58483b6166
Revert fast initialization of Coil
...
As discussed in https://github.com/coil-kt/coil/issues/2097 the problem is caused by regitering system services, which will be fixed in 2.6.0
Change-Id: I9085309780508137f10b25ff82deed3c62e5d159
11 months ago
Tomáš Mlynarič
f3e89bad4a
Add braces
...
Change-Id: I859babab7278137a4a2e49e5a085c65632888dd0
11 months ago
Tomáš Mlynarič
d1211f15e7
Inline initialization
...
Change-Id: I0a77eb6457cac27c1a4d604c8efdcbbdce95bc48
11 months ago
Tomáš Mlynarič
e853748cf7
Don't use runBlocking if async init completed
...
Change-Id: I641187ce277f434c6fca49a11b3cfccd50ecf5da
11 months ago
Tomáš Mlynarič
7c33946ce1
Launch loader directly without additional coroutine scope
...
Change-Id: Icbbdbcbcac1a6275857ebe998509f1e09109db7a
11 months ago
Tomáš Mlynarič
8e3903e90c
Fix comment
...
Co-authored-by: Yuri Schimke <yuri@schimke.ee>
11 months ago
Tomáš Mlynarič
5f0612102d
Improve lazy loading for Coil + OkHttp
...
This way, we can load Coil's backend on a background thread and not block the MainThread with it.
Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames.
Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62
11 months ago
Tomáš Mlynarič
12a3a6edde
Use trySend multiple times
...
Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032
11 months ago
Tomáš Mlynarič
08bfc54832
Update dependency guard baseline
...
Change-Id: I2557753f1eb4c6845aca6473a6aba5b7e758ebbf
11 months ago
Tomáš Mlynarič
f8e797fd26
Rename currentTimezone variable
...
Change-Id: I92630f6851b0253294a8d3ec2e5b3cbe7db74b4d
11 months ago
Tomáš Mlynarič
98e9e80639
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Ie83fb57676934ca3bdda59a986eb1a01a7c97424
11 months ago
Tomáš Mlynarič
ea1573fcc1
Use kotlinx.datetime.Timezone instead of java ZoneId
...
Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628
11 months ago
Jonathan Koren
c1d6c88bb0
Run dependencyGuard task during CI ( #1064 )
...
* Run dependencyGuard task during CI
Run the `dependencyGuard` task during CI, which will fail if there are
detected changes.
Change-Id: If5f2b18a4c765bd38a3353df2adaaa91cf1739c3
* Add actions to update dependency guard baselines
* Update baselines
* Better glob for update baselines action
11 months ago
Tomáš Mlynarič
44ae059a2b
Rename LocalTimeZone -> LocalZoneId + collects with lifecycle
...
Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3
11 months ago
Tomáš Mlynarič
cb00d2c8cb
Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers
...
This way, we can save ~1ms per composed item on screen.
Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d
11 months ago
Tomáš Mlynarič
395b9853df
Add Composition Tracing
...
Change-Id: I3ad60930de2fab71a700a0c2df3f0a1f566cafd8
11 months ago
Don Turner
f5b3ae56dc
Merge pull request #951 from SimonMarquis/issue-945
...
Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`
1 year ago
Don Turner
691bf2aad6
Merge pull request #785 from SimonMarquis/optimize-avd
...
Optimize AVD to fix long vector paths Lint warning
1 year ago
SimonMarquis
afdfd8acc5
🤖 Updates screenshots
1 year ago
Simon Marquis
377d3bef0c
Optimize AVD to fix long vector paths Lint warning
...
... with SVGOM, but you'll have to check on Android Studio the AVD diff.
https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html
1 year ago
Don Turner
707117a4f2
Merge branch 'main' into kotlinify
1 year ago
Don Turner
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
1 year ago
Don Turner
046831df36
Update dependency guard classpaths
...
Change-Id: I5f729bce92ec1cc9f71e34e42cbe38765966fc31
1 year ago
Simon Marquis
0699efc592
Merge branch 'main' into issue-945
1 year ago
Simon Marquis
be9dc533e3
Replace `Enum.values()` with `Enum.entries`
...
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
1 year ago
Don Turner
a5c030f740
Merge pull request #956 from KDW03/add_saved_test
...
Add Test for Saved Top Level Destination
1 year ago
Don Turner
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
1 year ago
Don Turner
9d41ffa318
Merge branch 'main' into kotlinify
1 year ago
Don Turner
ad15f0137e
Merge pull request #1094 from lihenggui/main
...
Upgrade Spotless and Ktlint and remove code convention violations
1 year ago
Don Turner
8d5ef578c6
Merge pull request #1103 from android/add_icon_comment
...
Add comment explaining why the launcher icon colors differ per build
1 year ago
Simon Marquis
b6d82e24df
Merge branch 'main' into kotlinify
1 year ago
Don Turner
b801a7deea
Moving comments to _after_ first XML element
...
Change-Id: Id4271a67ffcfbd712a2dd1f363970fcd31ee5ac0
1 year ago
lihenggui
2a2d8ed88d
Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE
1 year ago
Don Turner
d018e57f52
Fix spotless
...
Change-Id: I5dea4fec5b391e8cb7794af13e99978fcb622fbb
1 year ago
Don Turner
e6b5560f07
Revert "Move app screenshot tests to match dependencies declaration"
1 year ago
Don Turner
28bb3f1b2f
Add comment explaining why the launcher icon colors differ per build variant
...
Change-Id: I30126402370162ccbe53e177652583e4472f2030
1 year ago
Simon Marquis
83764082ff
Move app screenshot tests to match dependencies declaration
...
Fixes #990
1 year ago
lihenggui
32e1ec0447
Remove violations: property-naming
1 year ago
lihenggui
fb5bd225be
Spotless
1 year ago
Simon Marquis
2b739c0ffe
Fix badging, which is not "stable" when it comes to ordering
1 year ago
Simon Marquis
65a8b0d3b5
dependencyGuardBaseline
1 year ago
Simon Marquis
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
1 year ago
Jonathan Koren
392eaa3e61
Add dependencyGuard to AndroidApplicationConventionPlugin
...
Change-Id: Ib695ca18512d0ccde4c67e101f09ebbff8897912
1 year ago
Jonathan Koren
d15a203c59
Only record prodReleaseRuntimeClasspath configuration
...
Change-Id: I129fc4839ac2b4d5624c91cd25b47efba8847f44
1 year ago
Jonathan Koren
d5d5e3561f
Add dependency guard plugin
1 year ago
Simon Marquis
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
1 year ago