nowinandroid

Commit Graph

Author	SHA1	Message	Date
Don Turner	8901e5932a	Merge pull request #872 from SimonMarquis/data-objects Convert 'sealed' sub-object to 'data object'	3 years ago
Don Turner	0e13207a40	Merge pull request #874 from SimonMarquis/string-decoder Replace StringDecoder injection with simpler API	3 years ago
Don Turner	4d0efef3b4	Merge pull request #879 from tatsuyafujisaki/rename-constants Rename constants	3 years ago
AlirezaJoon	a23ffab602	fix: add label to animations for fixing lint issue	3 years ago
Tatsuya Fujisaki	4eeb045287	Rename constants	3 years ago
Adetunji Dahunsi	ec53d03854	Merge pull request #722 from android/tj/scrollbars Add scrollbars to app	3 years ago
Simon Marquis	e8449112b4	Replace StringDecoder injection with simpler API The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String. For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`). Unit tests would fail because Uri is not mocked (since we are not using Robolectric). Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc. FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded". The solution to this problem was to simply use regular Java APIs: - `URLDecoder.decode(urlEncodedTopicId, "UTF-8")` - `URLEncoder.encode(topicId, "UTF-8")`	3 years ago
Simon Marquis	b7799f0475	Convert 'sealed' sub-object to 'data object'	3 years ago
prosixe	c779b4e8ca	Typo fix for topics tocpis -> topics	3 years ago
Adetunji Dahunsi	48041fcaa4	Merge pull request #835 from blackbracken/avoid_retrieving_unnecessary_entity Call getNewsResourceIds instead of getNewsResources	3 years ago
TJ Dahunsi	9babb50c58	Interact with scrollbar only if drag direction matches scrollbar orientation Change-Id: I8fb5a64098ea83458d25fd2b7363a6b5dd3fef2f	3 years ago
TJ Dahunsi	e13e84c155	Replace usages of 'displacement' to 'moved' in parameter names Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a	3 years ago
TJ Dahunsi	806726a7f0	PR feedback Change-Id: I6e9f4a2ba53e81d32d07e229eb848541801eca18	3 years ago
TJ Dahunsi	eeb4973265	PR feedback Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f	3 years ago
TJ Dahunsi	2dba522663	Check if first item size == 0 Change-Id: I41acffad84d9db1cf407f77b04530643933f98bf	3 years ago
TJ Dahunsi	cb1d50e65e	Even better names Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65	3 years ago
TJ Dahunsi	ce6eaa9d64	Fix spotless	3 years ago
TJ Dahunsi	4858167b24	Added clarifying comments to code and used better variable names	3 years ago
TJ Dahunsi	bda31e9d15	Default scrollbars to dormant	3 years ago
TJ Dahunsi	d6a265093d	Extract scrollbar values to constants	3 years ago
TJ Dahunsi	795c5e32a9	Add hoverable to scrollbar	3 years ago
TJ Dahunsi	31b4841cb2	Add scrollbars to app	3 years ago
Márton Braun	56389cb760	Merge pull request #752 from SimonMarquis/kotlin-1.9.0 Kotlin 1.9.0	3 years ago
Simon Marquis	f7ed38182d	Add protobuf generated sources to the sourceSets And update to version 3.23.4.	3 years ago
blackbracken	b570be2abb	reformat by spotless	3 years ago
blackbracken	e9a16e437d	add kdoc for getNewsResourceIds	3 years ago
blackbracken	805914dade	Call getNewsResourceIds instead of getNewsResources	3 years ago
Milosz Moczkowski	7b6c3a16ca	Merge pull request #823 from ahmed-madhoun1/allow_localised_date_format Allow localised date format	3 years ago
Don Turner	b2a74ba174	Merge pull request #812 from Askeri-Muhendis/main Kotlin Coding conventions	3 years ago
TJ Dahunsi	c4686cfa54	Track when deep link notifications are opened Change-Id: I223b1c8fbca36f9b7f2a35d9cb2fa901d6f5be91	3 years ago
ahmedmadhoun1	3114b2eeaa	Allow localised date format	3 years ago
İbrahim Ethem Şen	6271d1c4c0	Merge branch 'android:main' into main	3 years ago
İbrahim Ethem Şen	56f8a27132	Kotlin coding conventions places companion object at the bottom of the class	3 years ago
Tomáš Mlynarič	8e1e994bb1	Add named arguments Change-Id: Ic91ae4fc04bf8eb92c3e5845c7e984475526ec91	3 years ago
Tomáš Mlynarič	4a8a43551a	Add contentType to news feed Before ScrollForYouFeedBenchmark_scrollFeedCompilationFull frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5 frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1 Traces: Iteration 0 1 2 3 4 5 6 7 8 9 After ScrollForYouFeedBenchmark_scrollFeedCompilationFull frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2 frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7 Traces: Iteration 0 1 2 3 4 5 6 7 8 9 Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef	3 years ago
James Rose	7826b4f5f2	Merge pull request #748 from SimonMarquis/fix/permissions Grant `POST_NOTIFICATIONS` permission in more instrumented tests	3 years ago
Adetunji Dahunsi	890c0f5769	Merge pull request #776 from SimonMarquis/fix/714 Keep track of matching `Network`s inside `NetworkCallback`	3 years ago
Simon Marquis	27154ef38a	Apply changes from review comments	3 years ago
Miłosz Moczkowski	479a2f00b0	Refactor icons	3 years ago
Milosz Moczkowski	1345764649	Merge pull request #770 from android/refactor/remove_unused_statements Remove unused statements	3 years ago
Simon Marquis	fecab96e4c	Keep track of matching `Network`s inside `NetworkCallback` This will ensure the connectivity state remains synchronized with the `ConnectivityManager`. Fixes #714	3 years ago
Miłosz Moczkowski	99094199bc	Remove redundant suppressions Change-Id: Iae08b6f284cf7a387922fdec34c8a0aa0da809ef	3 years ago
Miłosz Moczkowski	5bf66739bd	Remove redundant statements Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89	3 years ago
Simon Marquis	9aba5cc0fe	Cleanup unused string resources	3 years ago
Adetunji Dahunsi	f914254414	Merge pull request #749 from android/tj/reactive-only-dao Ensure DAO exposes only reactive types	3 years ago
Don Turner	d319264ef0	Provide Default dispatcher for instrumented tests Change-Id: I488a9b9d9d3864ce9496614ab35332ec19d06bcc	3 years ago
Don Turner	b245334a18	Updating TestDataStoreModule to use ApplicationScope	3 years ago
TJ Dahunsi	dcc36b0228	Fix tests Change-Id: Ie6b62071d2023e3a7ffe1553ab606e3f6b386a5e	3 years ago
Don Turner	4cdb5963a0	Add top level application scope, use IO dispatcher for DataStore Change-Id: I1512b1665587c73abd5e8a78aa9abd3eed24ab79	3 years ago
TJ Dahunsi	cd6ad7d575	Ensure DAO exposes only reactive types Change-Id: I8992ccf6525cd4c5ea9503d532b500e4d310b7fb	3 years ago

1 2 3 4 5 ...

280 Commits (8901e5932a92a0fa8ee681d83b2f3473a764cfa0)