138 Commits (886158d3cb9c7271bdf46241addc4db694174473)

Author	SHA1	Message	Date
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876) ... * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	1 year ago
Simon Marquis	daa2228132	Restore original `type` labels	1 year ago
Simon Marquis	0377fd8712	Replace `NewsResourceType` enum with simpler String type ... See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901	1 year ago
Adetunji Dahunsi	153b34fd50	Merge pull request #850 from qamarelsafadi/loading-progress-for-image ... Fix #849: Loading progress for image	1 year ago
Don Turner	492697ce6b	Merge pull request #873 from SimonMarquis/misc-warnings ... Fix miscellaneous warnings	1 year ago
Qamar A. Safadi	2db3e0c804	Merge branch 'android:main' into loading-progress-for-image	1 year ago
Don Turner	8901e5932a	Merge pull request #872 from SimonMarquis/data-objects ... Convert 'sealed' sub-object to 'data object'	1 year ago
Qamar A. Safadi	8aa0457ca9	Merge branch 'android:main' into loading-progress-for-image	1 year ago
dahunsi	03610d229a	Update feedItemsSize calculation ... Change-Id: I2bf6a2fa0e210cef1318707d948a49d2ef010452	1 year ago
Simon Marquis	4bdc9705af	Fix miscellaneous warnings ... - Remove unused namespace declaration - Collapse empty manifest tags - Remove redundant qualifier name - Remove redundant suppression	1 year ago
Simon Marquis	b7799f0475	Convert 'sealed' sub-object to 'data object'	1 year ago
qamarelsafadi	f1a2993adc	feat: remove add placeholder todo	1 year ago
TJ Dahunsi	e13e84c155	Replace usages of 'displacement' to 'moved' in parameter names ... Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a	1 year ago
TJ Dahunsi	eeb4973265	PR feedback ... Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f	1 year ago
TJ Dahunsi	cb1d50e65e	Even better names ... Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65	1 year ago
TJ Dahunsi	3aec705048	Add padding to scrollbars	1 year ago
TJ Dahunsi	31b4841cb2	Add scrollbars to app	1 year ago
TJ Dahunsi	4af86580eb	Move analytics tracking of news deep link to an extension method ... Change-Id: Id3d1a30d86634b9176067696db5ecfd4d02854a5	1 year ago
TJ Dahunsi	c4686cfa54	Track when deep link notifications are opened ... Change-Id: I223b1c8fbca36f9b7f2a35d9cb2fa901d6f5be91	1 year ago
Tomáš Mlynarič	19ffb53150	Don't use lambda contentType for a single item ... Change-Id: I0588c031428d523707463c5f0f0b6c586ea5e2c3	1 year ago
Tomáš Mlynarič	4a8a43551a	Add contentType to news feed ... Before ScrollForYouFeedBenchmark_scrollFeedCompilationFull frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5 frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1 Traces: Iteration 0 1 2 3 4 5 6 7 8 9 After ScrollForYouFeedBenchmark_scrollFeedCompilationFull frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2 frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7 Traces: Iteration 0 1 2 3 4 5 6 7 8 9 Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef	1 year ago
James Rose	7826b4f5f2	Merge pull request #748 from SimonMarquis/fix/permissions ... Grant `POST_NOTIFICATIONS` permission in more instrumented tests	1 year ago
Amaury Medeiros	512930c239	Fix inline comment as suggested in PR	1 year ago
Amaury Medeiros	87c27f6b82	Apply suggested changes to inline comment	1 year ago
Amaury Medeiros	dd70bbd589	Fix ForYouScreen Compose Previews ... Permissions should only be called in an Activity context, which is a layoutlib limitation. We need to avoid launching the permission request when in LocalInspectionMode, otherwise we'll have render errors on the ForYouScreen previews.	1 year ago
Miłosz Moczkowski	5bf66739bd	Remove redundant statements ... Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89	2 years ago
Simon Marquis	9aba5cc0fe	Cleanup unused string resources	2 years ago
Simon Marquis	823c4db201	Grant `POST_NOTIFICATIONS` permission in more instrumented tests ... Continues the work initiated in #738. Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.	2 years ago
Simon Marquis	a93cce92f7	Update ForYouScreenTest.kt	2 years ago
Simon Marquis	69879ff874	Grant permission only if TIRAMISU or above	2 years ago
Simon Marquis	331e8cffac	Grant `POST_NOTIFICATIONS` permission in instrumented tests	2 years ago
TJ Dahunsi	5d51cdcd28	Fix navigation tests	2 years ago
TJ Dahunsi	ef97cb941c	Route notification deep link through for you screen	2 years ago
TJ Dahunsi	2499c0a0bd	Notify users when news are updated	2 years ago
Milosz Moczkowski	2c18740d62	Merge pull request #665 from AnirudhPudari/migrate-to-compose_flowlayouts ... [Bug]: Migrate away from accompanist/flowlayout	2 years ago
James Rose	050db2cb72	Merge branch 'main' into jr/track-viewed	2 years ago
AnirudhPudari	33a3e360a4	Deprecated FlowLayouts from accompanist	2 years ago
mlykotom	3b7e7e3c02	Use ReportDrawnWhen ... Change-Id: I77b4db63f72f43c6c826e66358f7672792ef137d	2 years ago
Adetunji Dahunsi	08956492c8	Backend triggered sync ... Change-Id: I53c43b136ebb755f6258b1e815301dddb3b536a3	2 years ago
Milosz Moczkowski	ba6a697844	Merge pull request #624 from SimonMarquis/gradle-sort ... Sort and group Gradle dependencies	2 years ago
Chris Sinco	93c01ad184	Fix trailing commas based on spotless check	2 years ago
Chris Sinco	049750dd51	Merge branch 'main' into ui-polish	2 years ago
Amaury Medeiros	6b605a779c	Fix ForYouScreenTopicSelection Compose Preview	2 years ago
James Rose	57c13d84bd	Incorporate code review changes: Move UserNewsResourceRepository to data ... module; move UserNewsResource to model module. Implement unread dot for bookmarked articles. Keep the flows cold in UserNewsResourceRepository.	2 years ago
Simon Marquis	8ec54d19d8	Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter	2 years ago
James Rose	ebfbb5bafd	Display unread state on the news feed and bottom nav bar ... When a news resource is unread, display a dot on its card in the news feed. When the For You section has unread resources, display a dot on its icon in the navigation bar. Update the read status when a resource is opened.	2 years ago
James Rose	bd450099fb	Replace GetUserNewsResourcesUseCase with UserNewsResourceRepository ... This moves the responsibility for joining the UserData and the NewsResources to UserNewsResourceRepository. This way, the work can be done once and shared with all consumers in a SharedFlow, rather than having each consumer perform the join itself by invoking the UseCase.	2 years ago
Adetunji Dahunsi	ae58d1e1b0	Merge pull request #592 from android/tj/news-resource-query ... Add NewsResourceQuery to better query encapsulation	2 years ago
Adetunji Dahunsi	09f5c3bc61	Add NewsResourceQuery to better query encapsulation ... Change-Id: I93f8c8ae2d1144975f6f9ff1ba93be9a4600768a	2 years ago
Alex Vanyo	874c2d1487	Merge pull request #561 from SimonMarquis/update/androidx-lifecycle ... Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05	2 years ago