794d84cf67
done required cleanup
2 years ago
079f92ea32
feat: added launchSingleTop in navigate
2 years ago
487a288191
fix: removed disableSplitMotionEvents
2 years ago
b3cdc172cd
Implement search feature ( #685 )
...
Implement search feature
- Add a feature module named "search"
- Add a SearchScreen that is navigated by tapping the search icon at the top left corner
- Add a data layer that takes care of populating the *Fts tables and querying them by a search query
- Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen
The SearchScreen has following features:
- The user is able to type the search query in the TextField
- The search result is displayed as the user types
- When the search result is clicked, it navigates to:
- The InterestsScreen when a topic is clicked
- Chrome custom tab with the URL of the clicked news resource
- When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches
- Latest recent searches are displayed in the SearchScreen
2 years ago
6c18b25d5d
Replace `if` condition with AnimatedVisibility component
2 years ago
bf747434cd
Add Undo snackbar on Bookmark removal
...
Change-Id: I1fefd6e72378e26ae35b66e032529a116cff9a79
2 years ago
2c18740d62
Merge pull request #665 from AnirudhPudari/migrate-to-compose_flowlayouts
...
[Bug]: Migrate away from accompanist/flowlayout
2 years ago
050db2cb72
Merge branch 'main' into jr/track-viewed
2 years ago
b49767a88c
Rename getUserNewsResources to observeAll
2 years ago
33a3e360a4
Deprecated FlowLayouts from accompanist
2 years ago
3b7e7e3c02
Use ReportDrawnWhen
...
Change-Id: I77b4db63f72f43c6c826e66358f7672792ef137d
2 years ago
08956492c8
Backend triggered sync
...
Change-Id: I53c43b136ebb755f6258b1e815301dddb3b536a3
2 years ago
ba6a697844
Merge pull request #624 from SimonMarquis/gradle-sort
...
Sort and group Gradle dependencies
2 years ago
93c01ad184
Fix trailing commas based on spotless check
2 years ago
049750dd51
Merge branch 'main' into ui-polish
2 years ago
6b605a779c
Fix ForYouScreenTopicSelection Compose Preview
2 years ago
57c13d84bd
Incorporate code review changes: Move UserNewsResourceRepository to data
...
module; move UserNewsResource to model module. Implement unread dot for
bookmarked articles. Keep the flows cold in UserNewsResourceRepository.
2 years ago
8ec54d19d8
Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
2 years ago
ebfbb5bafd
Display unread state on the news feed and bottom nav bar
...
When a news resource is unread, display a dot on its card in the news
feed. When the For You section has unread resources, display a dot on
its icon in the navigation bar.
Update the read status when a resource is opened.
2 years ago
bd450099fb
Replace GetUserNewsResourcesUseCase with UserNewsResourceRepository
...
This moves the responsibility for joining the UserData and the
NewsResources to UserNewsResourceRepository. This way, the work can be
done once and shared with all consumers in a SharedFlow, rather than
having each consumer perform the join itself by invoking the UseCase.
2 years ago
098649d02f
Remove unnecessary text description for buttons on Interest page
...
Change-Id: I33968bf3a42de795eaa55e72cb86c2898f936dd1
2 years ago
ae58d1e1b0
Merge pull request #592 from android/tj/news-resource-query
...
Add NewsResourceQuery to better query encapsulation
2 years ago
09f5c3bc61
Add NewsResourceQuery to better query encapsulation
...
Change-Id: I93f8c8ae2d1144975f6f9ff1ba93be9a4600768a
2 years ago
874c2d1487
Merge pull request #561 from SimonMarquis/update/androidx-lifecycle
...
Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05
2 years ago
17ffb5bf3e
Merge pull request #586 from takagimeow/fix/add-padding-for-loading-wheel
...
Add padding between the loading wheel and the top of the screen
2 years ago
cc3f7905e5
Resolved format violations error
2 years ago
4d4f7d4a15
Merge remote-tracking branch 'origin/main' into update/androidx-lifecycle
2 years ago
36eeb19da8
Merge remote-tracking branch 'goog/main' into feb13-merge
...
* goog/main:
Revert "Revert "Revert "Revert "New build trigger""""
Bump versionCode to 5
Remove AD_ID permission
Add Firebase analytics. See go/nia-firebase-services.
Simplify build script
Copy local.properties during build
Fix exit codes
Remove .prod from the applicationIdSuffix in preparation for Play launch
Build aab with play services enabled
Build release artifacts separately, using google-services
Enable use-google-services in release builds
Revert "Revert "Revert "New build trigger"""
Revert "Revert "New build trigger""
Revert "New build trigger"
New build trigger
Increment internal build trigger
Adding a file which can be modified to trigger an internal build
Add Firebase dependencies
Remove API 23 from list of APIs to test in Firebase Test Lab (it's flaky)
Copy google-services.json from prebuilts folder
Change-Id: Ibc76e1b89c6c7e7f58843edb56581e169c9ce14e
2 years ago
8b8401e3ec
Add padding between the loading wheel and the top of the screen
2 years ago
0d23e64848
Merge pull request #558 from android/av/gmd-convention-plugin
...
Switch GMD to use a convention plugin
2 years ago
4284e6912e
Merge remote-tracking branch 'github/main' into feb9automerger
...
* github/main:
Bump version to 4
Remove unused DropdownMenu component
Route topic chip tap events up to NiaNavHost
Apply suggestions from code review
Migrate custom room configuration into a convention plugin
Update docs/ArchitectureLearningJourney.md - User action follow topic
Update docs/ArchitectureLearningJourney.md - Writing data
Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea
2 years ago
322ff63dbc
Route topic chip tap events up to NiaNavHost
...
Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7
2 years ago
e3e33d8497
Merge "Add Firebase analytics. See go/nia-firebase-services." into main
2 years ago
2a4d0434a5
Add Firebase analytics. See go/nia-firebase-services.
...
Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689
2 years ago
a8d7d3b1a2
Increase settings touch target for radio button and text link
...
Change-Id: If80f1a94a82eb6fd7aef7b6ee8fff9640032d180
2 years ago
0695fbdc27
Merge remote-tracking branch 'origin/vishesh211/bug-534-interests-multiple-click' into vishesh211/bug-534-interests-multiple-click
...
# Conflicts:
# feature/interests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/TabContent.kt
2 years ago
f9a3533df3
Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05
...
> `Transformations` is now written in Kotlin. This is a *source incompatible change* for those classes written in Kotlin that were directly using syntax such as `Transformations.map`
> Kotlin code *must* now use the Kotlin extension method syntax that was previously only available when using `lifecycle-livedata-ktx`.
> The `collectAsStateWithLifecycle()` APIs of `lifecycle-runtime-compose` are no longer in experimental status. (I09d42, b/258835424)
Changelog: https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.0-alpha05
2 years ago
6146dd5576
Switch GMD to use a convention plugin
...
Change-Id: Ia4f94cd7533c9168752ee39e3f960108fe802ab4
2 years ago
5b8fef7c26
Merge pull request #528 from android/refactor/preview_parameters
...
Replace global variables with PreviewParameterProvider
2 years ago
a4eddf6fa3
bug: fixed bug #534 of multiple clicks on the interests screen
2 years ago
f9dcdb4390
More refactoring
2 years ago
e536c396f9
Move new UseCase and tests into separate files
...
Change-Id: I4c337473ca0a60a5fccbb8aa640735cf7d616e71
2 years ago
bcb4d7d592
Replace global variables with PreviewParameterProvider
2 years ago
5a29414b7a
Fix spotless
2 years ago
a9bf21aaf4
Add UseCase for getting followed news resources, refactor ForYouVM
2 years ago
20c29a6c09
Fix bookmarking scrolling to top of the page bug ( #548 )
2 years ago
1d081ce26f
Fix formatting for a trailing comma
...
Change-Id: I300ec889aa9cd726a3cc60294e0cf7707e3361a6
2 years ago
11fbf53f12
Merge pull request #543 from android/mb/trailing-commas
...
Enable trailing commas via .editorconfig
2 years ago
893ac390a6
Merge pull request #524 from andhiratobing/main
...
Set item keys for smart recomposition of topics
2 years ago
819dd494ad
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
2 years ago
cfbf782613
Merge pull request #542 from android/as/dynamic-color-option
...
Add dynamic color option in settings for API >=32
2 years ago
f28d7f0eef
change the bookmark image to SVG
...
Change-Id: I2a9ae27d338127ab2a7b2b90ecff5b565fe5bd1a
2 years ago
257d3e5c70
change the bookmark image to SVG
...
Change-Id: I995faf3ac437cf78c7c447801a969fab01dbc85d
2 years ago
6b48b355cc
Merge branch 'main' into tm/fix-benchmarks-no-people
...
Change-Id: I94ca19fad5527c11a2f0f28cc43a23ab22f419a7
2 years ago
46c1d510d4
Android-CI workflow -> GMD refactor ( #537 )
...
This PR is about updating the operating system to macOS-12 as the previous one was going to be deprecated, as well as updating the checkout to v3 to avoid the warnings in the panel; adding setup SDK action to accept the license which was missing from the beginning.
I also added imports instead of adding them directly with the codes.
As a reference, there was another PR with a similar topic, but it wasn't complete: #483
2 years ago
dbbe8ffecb
Small fix for naming and boolean logic
...
Change-Id: I3dd291bdd581494574c557329bf23f5ed07af0bb
2 years ago
19efc1b5e8
Fix Spotless issue manually
...
Change-Id: Icd560e6ceaaeee0a6f502fe49b3403ab07f926ef
2 years ago
aa6f338f38
Make empty bookmark icon dynamic to dynamic color settings
...
Change-Id: I6a69f0a82f91536d43d986cc5a382b65f4219816
2 years ago
6046f6e943
Add dynamic color option in settings for API >=32
...
Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6
2 years ago
4633609930
Introduce GMD + ATD ( #479 )
...
Introduce Gradle Managed Device definitions to modules that have instrumented tests.
At the moment, defining it as a convention plugin isn't possible due to the bug. That bug is now fixed and will be included in Android Studio Flamingo.
Once Flamingo becomes stable, convert the GMD definitions as a convention plugin (#523 )
Change-Id: I0866369e3d0bbe148ca5ec1f92bad59239a347b8
2 years ago
8eac9a4bdd
Set item keys for smart recomposition of topics
2 years ago
bad3ea60f5
Refactor Topics news feed, tidy a few other bits up
...
Change-Id: Id4c9d1bce484137b363ec4cd21a45ca9863a2e7f
2 years ago
cafac8eb09
fix spotless, tidy test data
...
Change-Id: I4ceb7b85e5a8dd4d4f20088b2594c6b4030299bb
2 years ago
dd81618f89
Fix UI tests
...
Change-Id: Ie42077d20523c28a61c75bccfdc11d8a34d8a8a9
2 years ago
24df51349d
Move mapping logic into secondary constructor
...
Change-Id: I032326f502d27f2d3bd9fb8273ae44df878d172c
2 years ago
355b0540aa
Move construction of UserNewsResource into separate function
...
Change-Id: I7c1f6427cd7d95c2016349fec301b88455b33cf2
2 years ago
32bc5c1590
Fix merge conflicts
2 years ago
2f454de21c
Spacing polish based on design spec
2 years ago
47bc4a7b88
Merge pull request #504 from android/dt/fix-build-warnings
...
Fix build warnings
2 years ago
4484743830
Merge pull request #453 from LinX64/no_bookmarks_state_test
...
[Saved screen] Added the test for empty state and refactor
2 years ago
1acee42167
Merge pull request #493 from andhiratobing/main
...
Set visibility modifier of composable preview to private
2 years ago
cf053ade5a
Fix build warnings
2 years ago
2534bdc5f8
CI error due to invalid file format resolved
2 years ago
5638e253ae
Fix unit and UI tests. Apply spotless.
...
Change-Id: Iab75852a27a44309d349f84e65226911ab59fcd5
2 years ago
ec4bceead3
Renamed SaveableNewsResource to UserNewsResource
2 years ago
6941e2082b
Renamed SaveableNewsResource to UserNewsResource
2 years ago
a9a8a18d16
remove the redundant "interests" prefix
2 years ago
cfe6e65311
Typo fix for search
2 years ago
1e493c0bbc
Set visibility modifier of composable preview to private
2 years ago
154f05e23f
Remove tab state from InterestsViewModel
...
Change-Id: I5c15015f27fa0aa7709d0c3959d761355c8d9722
2 years ago
8a051eaa5c
Fix spotless issues
2 years ago
c12fe1fbe5
Update :core-designsystem module based on Figma file
2 years ago
0018144827
LoadingWheel testTag for every loading wheel
...
Change-Id: I7728e1717925abdfb607e93f3d48226910d42c0d
2 years ago
ec6e902c0f
Waiting for topic selection
...
Change-Id: I44226a7c5e693ee92eed27070c09cd4e0751e674
2 years ago
4ba63c0de8
Remove author concept from app
...
Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793
2 years ago
9c22a7a4e7
Remove `Stream` suffixes
...
Change-Id: I45decae965d7e35289d3fa31fc58b8c463fbead1
2 years ago
9c22af19eb
Rename variables
...
Change-Id: Iccfc7cdd76c8ad1c866eeff8d621952c3e9c4db6
2 years ago
8f52fcdfe5
Add TODO with ReportDrawnWhen
2 years ago
2242b8a1dc
Fix waiting for content
2 years ago
9ddf45e12c
Merge pull request #358 from YuraLaguta/main
...
Fixes #341 Defines enter & exit animations for OverlayLoadingWheel on…
2 years ago
4ded548ba7
Spotless apply - new version
2 years ago
d865c6421e
Reverted the changes back for import
2 years ago
40838f8138
Spotless apply
2 years ago
932f80a281
Added the test for empty state and refactor
2 years ago
9dc969fe63
Fixes #341 Defines enter & exit animations for OverlayLoadingWheel on ForYouScreen
2 years ago
c19b8b9319
New empty bookmarks handling ( #443 )
...
* Added the png file for error state
This should be removed later - couldn't convert the design to vector from svg - there is a problem with the `<mask` tag.
* Added two new strings based on the Figma file
* Redesign and reimplementation for the empty BookmarksScreen along with two clarifying comments.
* Removed the png file and replaced it with vector
* Code refactor after code reviewing
Made contentDescription null, removed extra spaces and renaming for the Composable function as suggested.
* Moved the modifier after Text
* Added a space after the curly bracket to pass the Spotless check
* Spotless apply
* Simplify logic in Bookmarks screen
* Change order of composables in BookmarksScreen and add previews
* Refactor after code review
Removed the space before `if`, and changed the padding from 5 to 8dp.
Co-authored-by: Jolanda Verhoef <JolandaVerhoef@users.noreply.github.com>
2 years ago
aa4d930c20
Merge pull request #386 from android/jv/topic-colors
...
Tint topic icons to theme's primary color
2 years ago
c62673d035
Merge pull request #179 from Abhimanyu14/niaicons
...
Icons alignment to use NiaIcons
2 years ago
bbc5460b62
Merge pull request #427 from LinX64/bookmarks_empty_data
...
Handling empty bookmarks on Saved view
2 years ago
26a9dfe5d7
Merge pull request #434 from hoc081098/refactor_ForYouViewModel
...
ForYouViewModel: replace snapshotFlow with flowOf
2 years ago
51c7ea2fe4
ForYouViewModel: replace snapshotFlow with flowOf
2 years ago
e61d9156db
Added the check for empty list on Success
...
So basically here I am checking if the feed count is not empty, then show the data, otherwise, show a simple `Text()` to notify that the user hasn't bookmarked a feed yet!
2 years ago
45c229fe47
Added the string for the Text
...
It is just showing "No bookmarks yet!" to the user
2 years ago
d69a37af7c
Icons alignment to use NiaIcons
2 years ago
671a048e7c
Fix spotless issues
2 years ago
90dc300783
Migrate from JUnit assertions to Kotlin's test framework
...
Fixes #419
2 years ago
5b8c284c74
Rename hasDismissedOnboarding to shouldHideOnboarding
...
Change-Id: I8a6b35f7216f9944652d8da346e7458614311e08
2 years ago
6654403498
Refactor onboarding to save interests to user data
...
Change-Id: I97772a8b65e1e94a95187ebb7c514104af2d3a08
2 years ago
10447f2dfa
Merge pull request #390 from android/jv/author-item-improvements
...
[UX] Improve AuthorItem
2 years ago
8a816e2149
Add feedback link
2 years ago
58ffd8781a
Make author images fill their circle in onboarding
2 years ago
7e04447cff
Improve AuthorItem behavior
2 years ago
b49086fc4f
Tint topic icons to theme's primary color
2 years ago
3a501f4530
Allow InterestsItem to be skipped on recomposition
...
Add a benchmark for topics state change
2 years ago
9a06a7a93b
Add link to brand guidelines, remove redundant R
2 years ago
f3ea2853fd
Update licenses URL
2 years ago
b9156f6812
Fix UI tests
2 years ago
756e45eb82
Add note about b/221643630
2 years ago
501d29be59
Add back spacer for navigation bar
2 years ago
dbff140b64
Fix minor issues
2 years ago
e5183e21e0
Resolve conflict with navigation changes from main
2 years ago
76daa393b1
Address review feedback from Manu
2 years ago
828242dbad
Remove Scaffold from top level screens
2 years ago
3a106534e7
Remove Scaffold from BookmarksScreen
2 years ago
c3f7870412
Fix spotless issues
2 years ago
56c0645816
Add tests
2 years ago
d42881e5d4
Add UI architecture for Settings dialog
2 years ago
8c30ab9f80
Add settings module, refactor top bar
2 years ago
b6cae161c2
Add basic UI for theme switcher
2 years ago
a0b22d8ed2
Updates Navigation approach with new guidance ( #347 )
2 years ago
9435c1cd79
Merge branch 'github/main'
2 years ago
7e6cb46436
Merge pull request #328 from android/bw/moreJankstats
...
Add more jank tracking
2 years ago
ee2e3db928
Add more jank tracking
2 years ago
f3debd0af1
Merge "Add domain layer. See go/nia-domain-layer for details." into main
2 years ago
4a4de7d6a4
Add domain layer. See go/nia-domain-layer for details.
...
Change-Id: I3f4684005e81fb9c4163bf59c7026dcff6e88dc4
2 years ago
dcc23829d4
Migrate packages to namespaces in build files
...
Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5
2 years ago
6351a89545
Merge pull request #310 from android/documentation/dep_graphs
...
Add dependency graphs to every module
2 years ago
c4debb74e7
Give feedback when syncing on ForYouScreen
...
Change-Id: I10a646e8a17f81d96351e69d36f0cb6ccf28e05c
2 years ago
06e60063b5
Add dependency graphs to every module
...
Change-Id: I629fef818f7521c13bb3069a3ff9ed9bc42e57f3
2 years ago
14ae167b69
Merge pull request #242 from android/av/built-in-insets
...
Update material3 with built-in insets support
2 years ago
9be6e846d9
Apply spotless
...
Change-Id: I49eeb1984cb3e978a9cee5c1e4d53e856a10bb4e
2 years ago
738210166a
Refine backgrounds and navigation colors
...
Change-Id: I9fd863cc608f21078ab78c39c2c3d227aedbac7c
2 years ago
4a1fb58c34
Merge pull request #301 from android/caren/topics_bookmarks
...
Enable bookmarks on topics page
2 years ago
8c11769622
Update to material3 1.0.0-beta03 wih built-in insets support
...
Change-Id: I4d07f89d4faa6e3417468ad78acf3fbb161f0797
2 years ago
f914d6a412
Merge pull request #299 from android/refactor/remove_episodes
...
Remove episodes related code
2 years ago
cf9cf1d781
Fix test
2 years ago
33e77ce6bc
Fix tests
2 years ago
4e11b7342b
Run spotless
2 years ago
e0e664846d
Rename topicState -> topicUiState
2 years ago
ccf60dca6c
Fix indents
2 years ago
vishesh211
Takeshi Hagikura
Maximillian Leonov
Neelansh Sahai
Milosz Moczkowski
James Rose
AnirudhPudari
mlykotom
Adetunji Dahunsi
Chris Sinco
Amaury Medeiros
Simon Marquis
Caren
Adetunji Dahunsi
Alex Vanyo
Caren
Keisuke Takagi
Don Turner
Márton Braun
Angie Sasmita
Manuel Vivo
Mohsen Rzna
ratobing
Don Turner
Muhammad Anas Shamsi
magicalmeghan
Nick Rout
Jolanda Verhoef
Yura Laguta
hoc081098
Abhimanyu14
Ben Trengrove
Automerger
Ben Weiss
Ben Weiss
Wojtek Kaliciński