dturner
02d4fea615
🤖 Updates screenshots
2 years ago
Don Turner
8494b74646
Fix spotless (really should enable the commit hook to do this)
...
Change-Id: I68cb9bd989a809e5db1bca3157c2c978ad8c8906
2 years ago
Don Turner
68c15a891c
Fix text styles and spacing now that includeFontPadding is false
...
Change-Id: I6894836a7cd3a6139511a5d1ac0a96702a265186
2 years ago
dturner
81a5c0a3a7
🤖 Updates screenshots
2 years ago
Don Turner
092daacced
Revert fontSize change
...
Change-Id: I4011205f8a07c418653ee463d7355fe1e4ff6f44
2 years ago
Don Turner
1de15f0fab
Fix spotless (again)
...
Change-Id: If6b292af514df435d7bd233bd634657904c67d6b
2 years ago
Don Turner
76d59b3da8
Merge branch 'main' into update-compose-bom
2 years ago
Don Turner
1d2029aa2c
Merge pull request #1040 from SimonMarquis/fix-unit-test
...
Fix `emptyResultIsReturned_withNotMatchingQuery` unit test
2 years ago
Don Turner
adddea6fc7
Remove includeFontPadding, default behaviour is fine
...
Change-Id: I334c5a488c1e2a2b49670a97b16385a7df1791c8
2 years ago
dturner
9e645356f6
🤖 Updates screenshots
2 years ago
Don Turner
3868371ec8
Switch default padding to true since this was actually false by default since Compose 1.6.0-alpha01
...
Change-Id: Ifd291b247f848cea43e084cc0fb99917e47e26eb
2 years ago
Don Turner
c773fd7d0a
Switch off default font padding to avoid changing UI
...
Change-Id: Ida974df8fd4b1aba6f9525ef5335a6cbe02ddb18
2 years ago
Don Turner
3b1ee87194
Fix ShortText icon
...
Change-Id: I8b243ef88c1cc8be83f5fbeaee6a2576c453a062
2 years ago
dturner
6b2b01ed82
🤖 Updates screenshots
2 years ago
Don Turner
522efac8c0
Update Compose BOM to 2024.02.00. Fixes #1218
...
Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b
2 years ago
Tomáš Mlynarič
4cdc2ad345
Add comment for Retrofit async OkHttp
...
Change-Id: Ic7a6887b76caf26f00b58b0753271d426b67e75b
2 years ago
Tomáš Mlynarič
d110d92b87
Optimize OkHttp initialization for Retrofit
...
Change-Id: I347f1080ab5adf774a0cdd3c659cbf25c4820f9a
2 years ago
Tomáš Mlynarič
5f0612102d
Improve lazy loading for Coil + OkHttp
...
This way, we can load Coil's backend on a background thread and not block the MainThread with it.
Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames.
Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62
2 years ago
Simon Marquis
b687328567
Replace comments with proper `@TestOnly` annotations
2 years ago
Simon Marquis
a83f6691c4
Fix addNewsResources issue
2 years ago
Simon Marquis
5a1258232f
Fix `emptyResultIsReturned_withNotMatchingQuery` unit test
...
`searchResultUiState` transitively relied on `getSearchContentsCount` updates and on `userDataRepository` to emit something.
2 years ago
Don Turner
691bf2aad6
Merge pull request #785 from SimonMarquis/optimize-avd
...
Optimize AVD to fix long vector paths Lint warning
2 years ago
Simon Marquis
377d3bef0c
Optimize AVD to fix long vector paths Lint warning
...
... with SVGOM, but you'll have to check on Android Studio the AVD diff.
https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html
2 years ago
Don Turner
707117a4f2
Merge branch 'main' into kotlinify
2 years ago
Don Turner
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
2 years ago
Simon Marquis
be9dc533e3
Replace `Enum.values()` with `Enum.entries`
...
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
2 years ago
Don Turner
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
2 years ago
Simon Marquis
bdb10a6870
Update core/designsystem/src/main/kotlin/com/google/samples/apps/nowinandroid/core/designsystem/component/scrollbar/ScrollbarExt.kt
...
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
2 years ago
Don Turner
9d41ffa318
Merge branch 'main' into kotlinify
2 years ago
Simon Marquis
b6d82e24df
Merge branch 'main' into kotlinify
2 years ago
lihenggui
56fbe13b5a
Ignore function naming check when annotated with @Test
2 years ago
lihenggui
485440b550
Suppress ktlint:standard:function-naming in ResultKtTest
2 years ago
lihenggui
d671126f9e
Move @Suppress("ktlint:standard:max-line-length") to function scope
2 years ago
lihenggui
32e1ec0447
Remove violations: property-naming
2 years ago
lihenggui
f8f932705a
Remove violations: discouraged-comment-location
2 years ago
lihenggui
fb5bd225be
Spotless
2 years ago
Simon Marquis
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
2 years ago
Yuya
e8f4537e7c
Update thumbTrackSizePercent calculation for readability
...
Change-Id: I7ef067a950b4b5911b8c2e6a8c1f72c3e95d938d
2 years ago
Yuya
07d9877331
Update thumb movement range by thumb size, in app scrollbars
...
Change-Id: I4438debd5037965a837758e0c78b110ab8197da5
2 years ago
Ben Trengrove
e62d70bf5a
Merge pull request #1067 from android/ben/itemstate
...
Remove redundant mutable state in NewsFeed
2 years ago
dahunsi
e334a727c3
Fix typo in app scrollbars
...
Change-Id: Ie72f1410fa8e5a68a520321c34d4fad251016486
2 years ago
Ben Trengrove
3142ecb495
Remove redundant mutable state
2 years ago
Ben Trengrove
22df321b9e
Apply spotless
2 years ago
Ben Trengrove
72da8e2e56
Use custom Modifier.Node instead of background
2 years ago
Ben Trengrove
d8880e98f0
Move state into a state holder and remove redundant Box
2 years ago
Ben Trengrove
01928d7df5
Move scrollbar changes out of composition
2 years ago
Simon Marquis
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
2 years ago
Simon Marquis
988002e692
Update Robolectric 4.11.1
...
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1
> Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below.
Removing explicit API 33 Robolectric configuration.
2 years ago
Daniel Santiago
c908f989c8
Update to Hilt 2.48.1 and use the KSP version
...
* Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin.
* `@Binds` function cannot be an extension function.
* Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.
2 years ago
Mario Manhique
b2c1c11218
Update MainDispatcherRule.kt
...
Updated MainDispatcherRule parameter accessibility to private because its only needs to be accessible inside that class.
2 years ago