74 Commits (77bd5428653f9c9038c0dc39093ec42ccdf62133)

Author	SHA1	Message	Date
Don Turner	492697ce6b	Merge pull request #873 from SimonMarquis/misc-warnings ... Fix miscellaneous warnings	1 year ago
Don Turner	0e13207a40	Merge pull request #874 from SimonMarquis/string-decoder ... Replace StringDecoder injection with simpler API	1 year ago
Simon Marquis	0418997f5a	Extract `UTF-8` character encoding	1 year ago
Simon Marquis	e8449112b4	Replace StringDecoder injection with simpler API ... The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String. For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`). Unit tests would fail because Uri is not mocked (since we are not using Robolectric). Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc. FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded". The solution to this problem was to simply use regular Java APIs: - `URLDecoder.decode(urlEncodedTopicId, "UTF-8")` - `URLEncoder.encode(topicId, "UTF-8")`	1 year ago
Simon Marquis	4bdc9705af	Fix miscellaneous warnings ... - Remove unused namespace declaration - Collapse empty manifest tags - Remove redundant qualifier name - Remove redundant suppression	1 year ago
TJ Dahunsi	e13e84c155	Replace usages of 'displacement' to 'moved' in parameter names ... Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a	1 year ago
TJ Dahunsi	eeb4973265	PR feedback ... Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f	1 year ago
TJ Dahunsi	cb1d50e65e	Even better names ... Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65	1 year ago
TJ Dahunsi	31b4841cb2	Add scrollbars to app	1 year ago
Miłosz Moczkowski	5bf66739bd	Remove redundant statements ... Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89	2 years ago
Simon Marquis	9aba5cc0fe	Cleanup unused string resources	2 years ago
Milosz Moczkowski	5f49c6ae25	Merge pull request #568 from vishesh211/vishesh211/bug-534-interests-multiple-click ... Interests multiple click	2 years ago
vishesh211	079f92ea32	feat: added launchSingleTop in navigate	2 years ago
James Rose	b49767a88c	Rename getUserNewsResources to observeAll	2 years ago
James Rose	57c13d84bd	Incorporate code review changes: Move UserNewsResourceRepository to data ... module; move UserNewsResource to model module. Implement unread dot for bookmarked articles. Keep the flows cold in UserNewsResourceRepository.	2 years ago
James Rose	ebfbb5bafd	Display unread state on the news feed and bottom nav bar ... When a news resource is unread, display a dot on its card in the news feed. When the For You section has unread resources, display a dot on its icon in the navigation bar. Update the read status when a resource is opened.	2 years ago
James Rose	bd450099fb	Replace GetUserNewsResourcesUseCase with UserNewsResourceRepository ... This moves the responsibility for joining the UserData and the NewsResources to UserNewsResourceRepository. This way, the work can be done once and shared with all consumers in a SharedFlow, rather than having each consumer perform the join itself by invoking the UseCase.	2 years ago
Adetunji Dahunsi	ae58d1e1b0	Merge pull request #592 from android/tj/news-resource-query ... Add NewsResourceQuery to better query encapsulation	2 years ago
Adetunji Dahunsi	09f5c3bc61	Add NewsResourceQuery to better query encapsulation ... Change-Id: I93f8c8ae2d1144975f6f9ff1ba93be9a4600768a	2 years ago
Alex Vanyo	874c2d1487	Merge pull request #561 from SimonMarquis/update/androidx-lifecycle ... Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05	2 years ago
Simon Marquis	4d4f7d4a15	Merge remote-tracking branch 'origin/main' into update/androidx-lifecycle	2 years ago
Don Turner	36eeb19da8	Merge remote-tracking branch 'goog/main' into feb13-merge ... * goog/main: Revert "Revert "Revert "Revert "New build trigger"""" Bump versionCode to 5 Remove AD_ID permission Add Firebase analytics. See go/nia-firebase-services. Simplify build script Copy local.properties during build Fix exit codes Remove .prod from the applicationIdSuffix in preparation for Play launch Build aab with play services enabled Build release artifacts separately, using google-services Enable use-google-services in release builds Revert "Revert "Revert "New build trigger""" Revert "Revert "New build trigger"" Revert "New build trigger" New build trigger Increment internal build trigger Adding a file which can be modified to trigger an internal build Add Firebase dependencies Remove API 23 from list of APIs to test in Firebase Test Lab (it's flaky) Copy google-services.json from prebuilts folder Change-Id: Ibc76e1b89c6c7e7f58843edb56581e169c9ce14e	2 years ago
Alex Vanyo	0d23e64848	Merge pull request #558 from android/av/gmd-convention-plugin ... Switch GMD to use a convention plugin	2 years ago
Don Turner	4284e6912e	Merge remote-tracking branch 'github/main' into feb9automerger ... * github/main: Bump version to 4 Remove unused DropdownMenu component Route topic chip tap events up to NiaNavHost Apply suggestions from code review Migrate custom room configuration into a convention plugin Update docs/ArchitectureLearningJourney.md - User action follow topic Update docs/ArchitectureLearningJourney.md - Writing data Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea	2 years ago
Márton Braun	322ff63dbc	Route topic chip tap events up to NiaNavHost ... Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7	2 years ago
Don Turner	2a4d0434a5	Add Firebase analytics. See go/nia-firebase-services. ... Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689	2 years ago
Simon Marquis	f9a3533df3	Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05 ... > `Transformations` is now written in Kotlin. This is a *source incompatible change* for those classes written in Kotlin that were directly using syntax such as `Transformations.map` > Kotlin code *must* now use the Kotlin extension method syntax that was previously only available when using `lifecycle-livedata-ktx`. > The `collectAsStateWithLifecycle()` APIs of `lifecycle-runtime-compose` are no longer in experimental status. (I09d42, b/258835424) Changelog: https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.0-alpha05	2 years ago
Alex Vanyo	6146dd5576	Switch GMD to use a convention plugin ... Change-Id: Ia4f94cd7533c9168752ee39e3f960108fe802ab4	2 years ago
Miłosz Moczkowski	bcb4d7d592	Replace global variables with PreviewParameterProvider	2 years ago
Márton Braun	819dd494ad	Run Spotless to add trailing commas (and apply other rule updates) ... Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209	2 years ago
Angie Sasmita	cfbf782613	Merge pull request #542 from android/as/dynamic-color-option ... Add dynamic color option in settings for API >=32	2 years ago
Mohsen Rzna	46c1d510d4	Android-CI workflow -> GMD refactor (#537) ... This PR is about updating the operating system to macOS-12 as the previous one was going to be deprecated, as well as updating the checkout to v3 to avoid the warnings in the panel; adding setup SDK action to accept the license which was missing from the beginning. I also added imports instead of adding them directly with the codes. As a reference, there was another PR with a similar topic, but it wasn't complete: #483	2 years ago
Angie Sasmita	6046f6e943	Add dynamic color option in settings for API >=32 ... Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6	2 years ago
Takeshi Hagikura	4633609930	Introduce GMD + ATD (#479) ... Introduce Gradle Managed Device definitions to modules that have instrumented tests. At the moment, defining it as a convention plugin isn't possible due to the bug. That bug is now fixed and will be included in Android Studio Flamingo. Once Flamingo becomes stable, convert the GMD definitions as a convention plugin (#523) Change-Id: I0866369e3d0bbe148ca5ec1f92bad59239a347b8	2 years ago
Don Turner	bad3ea60f5	Refactor Topics news feed, tidy a few other bits up ... Change-Id: Id4c9d1bce484137b363ec4cd21a45ca9863a2e7f	2 years ago
Don Turner	cafac8eb09	fix spotless, tidy test data ... Change-Id: I4ceb7b85e5a8dd4d4f20088b2594c6b4030299bb	2 years ago
Don Turner	dd81618f89	Fix UI tests ... Change-Id: Ie42077d20523c28a61c75bccfdc11d8a34d8a8a9	2 years ago
Don Turner	355b0540aa	Move construction of UserNewsResource into separate function ... Change-Id: I7c1f6427cd7d95c2016349fec301b88455b33cf2	2 years ago
Don Turner	32bc5c1590	Fix merge conflicts	2 years ago
Don Turner	cf053ade5a	Fix build warnings	2 years ago
Don Turner	5638e253ae	Fix unit and UI tests. Apply spotless. ... Change-Id: Iab75852a27a44309d349f84e65226911ab59fcd5	2 years ago
magicalmeghan	ec4bceead3	Renamed SaveableNewsResource to UserNewsResource	2 years ago
magicalmeghan	6941e2082b	Renamed SaveableNewsResource to UserNewsResource	2 years ago
Jolanda Verhoef	4ba63c0de8	Remove author concept from app ... Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793	2 years ago
Márton Braun	9c22a7a4e7	Remove `Stream` suffixes ... Change-Id: I45decae965d7e35289d3fa31fc58b8c463fbead1	2 years ago
Milosz Moczkowski	aa4d930c20	Merge pull request #386 from android/jv/topic-colors ... Tint topic icons to theme's primary color	2 years ago
Milosz Moczkowski	c62673d035	Merge pull request #179 from Abhimanyu14/niaicons ... Icons alignment to use NiaIcons	2 years ago
Abhimanyu14	d69a37af7c	Icons alignment to use NiaIcons	2 years ago
Simon Marquis	671a048e7c	Fix spotless issues	2 years ago
Simon Marquis	90dc300783	Migrate from JUnit assertions to Kotlin's test framework ... Fixes #419	2 years ago