nowinandroid

Commit Graph

Author	SHA1	Message	Date
Simon Marquis	8ca16d85a7	Merge remote-tracking branch 'origin/main' into in-memory-datastore	2 months ago
Simon Marquis	dc14461490	Update retrofit from 2.9.0 to 2.11.0 - Replace Jake Wharton's Kotlinx Serialization converter with new retrofit's `converter-kotlinx-serialization`. - Remove custom Proguard rules that are now part of the dependency: https://github.com/square/retrofit/tree/trunk/retrofit-response-type-keeper#readme Changelog: https://github.com/square/retrofit/blob/trunk/CHANGELOG.md	2 months ago
Ben Weiss	c01a129e4a	Nightly builds with baseline profiles (#1173 ) * Overall build * Enable nightly builds * Enable Startup Profile generation for release builds * Skip BP generation for regular Builds * Test baseline profiles for all variants * Cleanup * Remove stale baseline-prof.txt * Add generated profiles to .gitignore * GMD * Setup GMD in separate step * Add GMD setup to all workflows * Lower GMD specs * Update GMD and Android SDK setup * Add options test options for GMD startup * Ensure only one device is used for bp / benchmark * Apply guidance from issuetracker b/287312019 * Add new metrics for baseline profile measurement Added custom metrics to better understand how effective a baseline profile is. These TraceSectionMetrics keep track of JIT compilations as well as class initializations which should go down when a BP is properly applied to the app.	2 months ago
Jonathan Koren	447cd7eba3	Convert InterestsListDetailScreenTest to unit test (#1560 ) * Convert InterestsListDetailScreenTest to Robolectric Change-Id: I751f6ccc8bf16465fb6a9effb8a5d738a184d778 * Fix import alias Change-Id: I3726858384bfe842eb717bae72c309284c524f06 * Add waitForIdle Change-Id: I702fbca6ba79e3705e3226b0f3088923c89fc2cb	2 months ago
Don Turner	00efda54e8	Merge branch 'main' into dt/nav-safe-args * main: (58 commits) Instrumented tests for InterestsListDetailScreen (#1518) Remove Firebase AD_SERVICE_CONFIG property updateProdReleaseBadging Merge Android & JVM plugins into a single `HiltConventionPlugin` Update dependency guard 🤖 Updates baselines for Dependency Guard Update to Lifecycle 2.8.3 Add android.adservices.AD_SERVICES_CONFIG to badges Apply suggestions from code review Update app/src/main/AndroidManifest.xml generateModuleGraphs dependencyGuardBaseline updateProdReleaseBadging Fix spotless. Change set to `=` operator Cleanup unused reference in `libs.versions.toml` Regenerate SVG graphs Update comment wording Use stdin to avoid repeating the output file name Replace bash commands with proper svgo cli ... Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5	3 months ago
Simon Marquis	dc09a1428c	Add missing dependency in `:app` module	5 months ago
Simon Marquis	d56e06e676	Merge Android & JVM plugins into a single `HiltConventionPlugin`	5 months ago
Don Turner	041e46eacf	Merge branch 'main' into dt/nav-safe-args * main: Remove the printModulePaths task and read modules direct from settings Update pull_request_template.md Made pull request instructions clearer Update gradle wrapper Upgrade AGP to 8.4.0, Android Build Tools to 31.4.0, and Gradle to 8.7. Regenerate SVG graphs and cleanup/reformat files Update build.gradle.kts Remove duplicated AndroidX Work testing dependency Bump gradle/wrapper-validation-action from 2 to 3 🤖 Updates baselines for Dependency Guard Bump com.dropbox.dependency-guard from 0.4.3 to 0.5.0 Bump protobuf from 3.25.2 to 4.26.0 Bump app.cash.turbine:turbine from 1.0.0 to 1.1.0 Bump androidxMacroBenchmark from 1.2.2 to 1.2.3 🤖 Updates baselines for Dependency Guard Unnecessary safe call on a non-null receiver Bump androidx.activity:activity-compose from 1.8.0 to 1.8.2 Apply suggestions from code review Move Android instrumented test `ThemeTest` to unit test Change-Id: Id3283279ca5a9d90c2bbc4740d6c583ba8dded41	6 months ago
Simon Marquis	61143ca98b	Merge remote-tracking branch 'origin/main' into fix/1161-2	6 months ago
Don Turner	93a48a221a	Use version catalog reference to serialization plugin Change-Id: Ia197b2403e8250720387123d8c5d5d9ad809a036	7 months ago
Don Turner	2d45b84031	Merge branch 'main' into dt/nav-safe-args	7 months ago
Don Turner	d96bcf8ffe	Migrate Interests nested NavHost to safe args Change-Id: I4f3c310be693ecbcbc8b99c4e573d7fc6e9a2f74	7 months ago
Simon Marquis	3e1f545869	Update build.gradle.kts	7 months ago
Jose Alcérreca	ead3f49f7b	Fixes flakiness in app's screenshot tests (#1395 ) * Disables WM init in app's screenshot tests Change-Id: Ib0994e744f49b53f58c0eebd52f80c0eba67bbed * Spotless Change-Id: Ic0212889354481433ce45ec4292ae7be9bd24b2e * [CI] Uploads roborazzi reports if they fail Change-Id: I5a25a7e156d3fcb72a396d3b503e62068a20b417 * Uses unused test module and enables LocalInspection Change-Id: Iac36347dc3d702248d7515a74823e0bc0cbf2a2b * Fixes timezone in snackbar screenshot tests Change-Id: Ic517e8822218abeaddd3f8d2740b03e651d72d31 * Fixes conflict Change-Id: Ia42fb78781d2469a608183594fc25c7c69f7e76c * 🤖 Updates screenshots	7 months ago
Jose Alcérreca	1da560f582	Revert "Configure baseline profiles in the baselineProfile lambda" (#1398 ) This reverts commit `7980c1d0df`.	7 months ago
Ben Weiss	7980c1d0df	Configure baseline profiles in the baselineProfile lambda (#1060 ) * Configure baseline profiles in the baselineProfile lambda * This is the correct and easiest way to set up baseline profiles correctly. * See b/313428246 for more context. * Handle empty topics during baseline profile generation * Revert to API 33 GMD and fail empty screen tests * Rename withChildren to noChildren for better legibility * Remove unused log tags * Update benchmark and metrics versions * 🤖 Updates baselines for Dependency Guard --------- Co-authored-by: Tomáš Mlynarič <mlykotom@google.com> Co-authored-by: Jaehwa Noh <shwoghk14@gmail.com>	7 months ago
Don Turner	61cce4bf19	Merge branch 'main' into replace-testharness	7 months ago
Alex Vanyo	0be0bc191f	Update usage of material3 adaptive to be edge-to-edge Change-Id: I481c79db77bbdd657182f5355200f63e2355f40d	8 months ago
Don Turner	fc2146c970	Merge branch 'main' into replace-testharness	8 months ago
Jaehwa Noh	a22b724a66	Change getByName to named - reference by [APIs to avoid](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#apis_to_avoid) Change-Id: Idf1ce9cf372b8f5da2f0da95fcf53454ffb3388f	8 months ago
Jose Alcérreca	78e3725f9f	Sets up jacoco coverage with a combined report and a GHA (#1303 ) * Uses jacoco coverage reporting in AGP	8 months ago
Simon Marquis	930e061611	Cleanup dependencies This is a followup cleanup of #1163 that was partially addressed by #1140. - Remove unused `projects.core.testing` dependencies (or replace with direct dependencies). - Introduce `androidx.compose.ui.test` bundle. - Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.	8 months ago
Alex Vanyo	cc02c30b8e	Update material3-adaptive to 1.0.0-alpha08 Change-Id: Ic218c6b061b5cea4e56b544073541421862bc1d0	9 months ago
Jonathan Koren	19f6f9e09a	2 pane support in Interests screen (#1234 ) * Add dependency on material3 adaptive Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6 * Add InterestsListDetailScreen composable Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971 * Store selectedTopicId in InterestsViewModel Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce * Pass detail pane composable down Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293 * Navigate to initial topic if provided Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b * Lift LDPS up to app module Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85 * Fix some navigation behavior Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b * Navigate to initial topic if provided Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed * Remove dependency in interests feature module Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f * Hide back arrow when the topics list is visible Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8 * Update interests tests Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd * Highlight selected topic when displaying 2 panes Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415 * update dependency baselines Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00 * run spotless apply Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8 * Convert isListPaneHidden to isListPaneVisible Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657 * Set semantics for selected state Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca * Use scaffold roles when determining visibility Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648 * Update multipleBackStackInterests test Change-Id: I1e372f7989817151a6765205291b13b561187fa8	9 months ago
Don Turner	2d610b0775	Merge branch 'main' into replace-testharness * main: (37 commits) Disable animations of instrumented tests (#1167) Bump gradle/wrapper-validation-action from 1 to 2 Remove unused release variable. Fixes #1231 Apply Composable Parameter Ordering Guidelines Remove kotlinx-coroutines-guava dependency from :sync:work Add explicit guava-android dependency for :sync:work Extract ScreenshotHelper to separate testing module Update AGP to 8.3.0 Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert. 🤖 Updates baselines for Dependency Guard Bump the kotlin-ksp-compose group with 6 updates 🤖 Updates baselines for Dependency Guard Bump hilt from 2.50 to 2.51 Bump com.google.truth:truth from 1.1.5 to 1.4.2 Move java to kotlin folder. Remove disk usage testing Figuring out what is using 66Gb in the runner Dpm Improve converting to kotlin timezone Use trySend multiple times ... Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a	9 months ago
Don Turner	747c9275bc	Merge pull request #1249 from android/dt/fix-1231 Remove unused release variable. Fixes #1231	9 months ago
Don Turner	77cbdb62a4	Remove unused release variable. Fixes #1231 Change-Id: I8c03d3d2e1aee85a22d1a03b97e3bec4069e0fcb	9 months ago
Alex Vanyo	e3c7018124	Extract ScreenshotHelper to separate testing module Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af	9 months ago
Don Turner	d6357be8c4	Replace Accompanist TestHarness with DeviceConfigurationOverride Change-Id: I6742d5e221f86a019f44d3e623609bf76d2a3a2a	9 months ago
Tomáš Mlynarič	75a3295381	Merge branch 'main' into mlykotom/tz-perf-improvement Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c # Conflicts: # app/dependencies/prodReleaseRuntimeClasspath.txt # build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt	9 months ago
Ben Weiss	f64f1c0aa2	Remove legacy benchmark build type (#1207 ) * Remove legacy benchmark build type Now that we have the baseline profile gradle plugin, there is no need for a benchmark build type. The plugin does the setup and configuration and runs against the correct app flavor. * Remove explicit benchmark build type from benchmark module * Remove stale build task exclusions * Fix tracing import location FYI @mlykotom	10 months ago
Tomáš Mlynarič	395b9853df	Add Composition Tracing Change-Id: I3ad60930de2fab71a700a0c2df3f0a1f566cafd8	10 months ago
Simon Marquis	f27a2e176e	Reduce overall build complexity - Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`	12 months ago
Jonathan Koren	392eaa3e61	Add dependencyGuard to AndroidApplicationConventionPlugin Change-Id: Ib695ca18512d0ccde4c67e101f09ebbff8897912	1 year ago
Jonathan Koren	d15a203c59	Only record prodReleaseRuntimeClasspath configuration Change-Id: I129fc4839ac2b4d5624c91cd25b47efba8847f44	1 year ago
Jonathan Koren	d5d5e3561f	Add dependency guard plugin	1 year ago
Miłosz Moczkowski	9c89e98e5b	Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold" This reverts commit `335a7ec68c`, reversing changes made to `aa8ce0e1f6`.	1 year ago
Miłosz Moczkowski	816a7b60c1	Replace manual navigation component switching with new NavigationSuiteScaffold Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723	1 year ago
Ben Weiss	aa8ce0e1f6	Add automated baseline profile generation (#880 ) Baseline profile generation is disabled for the PR level Build task. Release tasks require a fresh baseline profile. A new profile is generated using the baseline profile Gradle plugin. * Prepare for usage of dex layout optimizations which can be actively used once NiA switches to AGP 8.2+. * Add GMD config to release build * Switch to macos-latest * Update names for StartupBenchmark tests to better reflect states * Stable release and recent GMD device * Reduce flakiness by adding wait to benchmark * More convenient waiting for objects * Rename junit dependency to androidx-junit * Only run baseline profile benchmarks during GH workflow * Enable automatic BP generation for only release builds * Disable BP generation from Build workflow * Specify modules and skip benchmarking Build workflow Bug: b/299334172	1 year ago
Daniel Santiago	c908f989c8	Update to Hilt 2.48.1 and use the KSP version * Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin. * `@Binds` function cannot be an extension function. * Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.	1 year ago
Don Turner	a381d13199	Merge pull request #958 from McGalanes/main Use typesafe project accessors	1 year ago
Melwin Magalhaes	6247712064	Add convention plugins to version catalogs	1 year ago
Melwin Magalhaes	b1266dc05a	Use typesafe project accessors for project modules	1 year ago
Simon Marquis	49a2fb5272	Fix wrong configuration name, leaking `work-testing` to runtime classpath Typo introduced recently when Roborazzi was added to the project: `886158d3cb (diff-8cff73265af19c059547b76aca8882cbaa3209291406f52df1dafbbc78e80c46)`	1 year ago
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876 ) * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	1 year ago
Don Turner	e96e54f7de	Merge pull request #806 from SimonMarquis/objenesis Remove forced resolution strategy	1 year ago
Alex Vanyo	2b218b97d9	Switch to new Activity.enableEdgeToEdge Change-Id: I9bbb7b2d116099524525619714ef18448e707c4f	1 year ago
Don Turner	654944430d	Fix for Retrofit R8 issue, bump version to 0.1.2 Change-Id: Ia90d693731c95248211b12b1ce2e9dfab0ecf34c	1 year ago
Don Turner	7f62b725a6	Bump version to code=7, name=0.1.1 Change-Id: I2d8fa940dc5e4c14e3c9df650bc1f1432a330f02	1 year ago
Automerger	44c3c6d947	Merge branch 'github/main'	1 year ago

1 2 3

114 Commits (76f49bdbd6f2588440dd30831626549be4a72461)