Qamar A. Safadi
5abc69fb49
Merge branch 'android:main' into loading-progress-for-image
1 year ago
AlirezaJoon
a23ffab602
fix: add label to animations for fixing lint issue
1 year ago
Qamar A. Safadi
8aa0457ca9
Merge branch 'android:main' into loading-progress-for-image
1 year ago
Simon Marquis
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
1 year ago
qamarelsafadi
3595d8dcb5
feat: move the placeholder default value to the method
1 year ago
qamarelsafadi
e276212574
feat: remove check if placeholder null and put a default placeholder if its not passed.
1 year ago
qamarelsafadi
9c1ec17a39
fix: modifier to Modifier
1 year ago
qamarelsafadi
a294adb6b9
feat: fix format issue
1 year ago
qamarelsafadi
7a05f7db96
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
1 year ago
qamarelsafadi
3284eb68a3
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
1 year ago
Qamar Safadi
ee8b70003d
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
1 year ago
TJ Dahunsi
9babb50c58
Interact with scrollbar only if drag direction matches scrollbar orientation
...
Change-Id: I8fb5a64098ea83458d25fd2b7363a6b5dd3fef2f
1 year ago
TJ Dahunsi
e13e84c155
Replace usages of 'displacement' to 'moved' in parameter names
...
Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a
1 year ago
TJ Dahunsi
806726a7f0
PR feedback
...
Change-Id: I6e9f4a2ba53e81d32d07e229eb848541801eca18
1 year ago
TJ Dahunsi
eeb4973265
PR feedback
...
Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f
1 year ago
TJ Dahunsi
2dba522663
Check if first item size == 0
...
Change-Id: I41acffad84d9db1cf407f77b04530643933f98bf
1 year ago
TJ Dahunsi
cb1d50e65e
Even better names
...
Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65
1 year ago
TJ Dahunsi
ce6eaa9d64
Fix spotless
1 year ago
TJ Dahunsi
4858167b24
Added clarifying comments to code and used better variable names
1 year ago
TJ Dahunsi
bda31e9d15
Default scrollbars to dormant
1 year ago
TJ Dahunsi
d6a265093d
Extract scrollbar values to constants
1 year ago
TJ Dahunsi
795c5e32a9
Add hoverable to scrollbar
1 year ago
TJ Dahunsi
31b4841cb2
Add scrollbars to app
1 year ago
Simon Marquis
8e708cca05
Merge branch 'main' into lint/sarif
2 years ago
Miłosz Moczkowski
479a2f00b0
Refactor icons
2 years ago
Miłosz Moczkowski
5bf66739bd
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
2 years ago
Simon Marquis
8ea9a8fa51
Android Lint improvements
...
- Create `LintConventionPlugin` to configure Lint on all compatible modules: Android applications, Android libraries and JVM modules.
- Run `lintProdRelease` in CI instead of the default `lintDemoDebug` which is less important compared to production code.
- Rearrange CI steps to make it more clear that Lint should is an additional step after build (build -> test -> lint).
- Enable SARIF support and upload results to GitHub's CodeQL to get inline feedback on PRs.
If we really need better perfs, we could restore `lint.checkDependencies = true` on the `:app` module and only execute `:app:lintProdRelease`.
But in practice, this does not change the total build time on this project.
2 years ago
Simon Marquis
8ec54d19d8
Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
2 years ago
Márton Braun
237375f52a
Remove unused DropdownMenu component
...
Change-Id: I7ee7e8f1995667c7e54459f4333594c4605cc5a9
2 years ago
Márton Braun
322ff63dbc
Route topic chip tap events up to NiaNavHost
...
Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7
2 years ago
Márton Braun
819dd494ad
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
2 years ago
Angie Sasmita
cfbf782613
Merge pull request #542 from android/as/dynamic-color-option
...
Add dynamic color option in settings for API >=32
2 years ago
mlykotom
6b48b355cc
Merge branch 'main' into tm/fix-benchmarks-no-people
...
Change-Id: I94ca19fad5527c11a2f0f28cc43a23ab22f419a7
2 years ago
Angie Sasmita
dbbe8ffecb
Small fix for naming and boolean logic
...
Change-Id: I3dd291bdd581494574c557329bf23f5ed07af0bb
2 years ago
Angie Sasmita
19efc1b5e8
Fix Spotless issue manually
...
Change-Id: Icd560e6ceaaeee0a6f502fe49b3403ab07f926ef
2 years ago
Angie Sasmita
6046f6e943
Add dynamic color option in settings for API >=32
...
Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6
2 years ago
Alex Vanyo
ba11e6bf38
Merge pull request #491 from android/av/fix-background-composable
...
Updated background composable for gradient
2 years ago
Don Turner
0917cdebec
Refactor NiaGradientBackground to accept GradientColors
...
Change-Id: I55840b22e123490097710570bf11554554df90f9
2 years ago
Don Turner
1acee42167
Merge pull request #493 from andhiratobing/main
...
Set visibility modifier of composable preview to private
2 years ago
ratobing
1e493c0bbc
Set visibility modifier of composable preview to private
2 years ago
Nick Rout
c742aa3eca
Fix issues with NiaTheme gradients and backgrounds
2 years ago
Nick Rout
9fd47261c9
Address design system PR feedback
2 years ago
Nick Rout
cac02c418d
Fix ThemeTest
2 years ago
Nick Rout
61bbd406c5
Fix ThemeTest
2 years ago
Nick Rout
a34bc2d7c2
Fix spotless issues
2 years ago
Nick Rout
be4ad40441
Fix spotless issues
2 years ago
Nick Rout
c12fe1fbe5
Update :core-designsystem module based on Figma file
2 years ago
mlykotom
90674c0c07
Add niaTopAppBar testTag
...
Change-Id: I02a207675e106137fe005140965c96f1b50f98ce
2 years ago
mlykotom
0018144827
LoadingWheel testTag for every loading wheel
...
Change-Id: I7728e1717925abdfb607e93f3d48226910d42c0d
2 years ago
Mohsen Rzna
c19b8b9319
New empty bookmarks handling ( #443 )
...
* Added the png file for error state
This should be removed later - couldn't convert the design to vector from svg - there is a problem with the `<mask` tag.
* Added two new strings based on the Figma file
* Redesign and reimplementation for the empty BookmarksScreen along with two clarifying comments.
* Removed the png file and replaced it with vector
* Code refactor after code reviewing
Made contentDescription null, removed extra spaces and renaming for the Composable function as suggested.
* Moved the modifier after Text
* Added a space after the curly bracket to pass the Spotless check
* Spotless apply
* Simplify logic in Bookmarks screen
* Change order of composables in BookmarksScreen and add previews
* Refactor after code review
Removed the space before `if`, and changed the padding from 5 to 8dp.
Co-authored-by: Jolanda Verhoef <JolandaVerhoef@users.noreply.github.com>
2 years ago
Milosz Moczkowski
c62673d035
Merge pull request #179 from Abhimanyu14/niaicons
...
Icons alignment to use NiaIcons
2 years ago
Abhimanyu14
d69a37af7c
Icons alignment to use NiaIcons
2 years ago
Simon Marquis
90dc300783
Migrate from JUnit assertions to Kotlin's test framework
...
Fixes #419
2 years ago
Milosz Moczkowski
398c399c1c
Merge pull request #297 from android/av/remove-dolphin-preview-todos
...
Remove Preview TODOs for Dolphin
2 years ago
Don Turner
76daa393b1
Address review feedback from Manu
2 years ago
Don Turner
8c30ab9f80
Add settings module, refactor top bar
2 years ago
Alex Vanyo
7e3faad699
Add data logic for theme switcher
...
Change-Id: Ifffadb897de4f6e08f7115103f99c156a7098b70
2 years ago
Don Turner
7ca17f68ed
Merge branch 'main' into av/remove-dolphin-preview-todos
2 years ago
Wojtek Kaliciński
dcc23829d4
Migrate packages to namespaces in build files
...
Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5
2 years ago
Don Turner
6351a89545
Merge pull request #310 from android/documentation/dep_graphs
...
Add dependency graphs to every module
2 years ago
Adetunji Dahunsi
c4debb74e7
Give feedback when syncing on ForYouScreen
...
Change-Id: I10a646e8a17f81d96351e69d36f0cb6ccf28e05c
2 years ago
Milosz Moczkowski
06e60063b5
Add dependency graphs to every module
...
Change-Id: I629fef818f7521c13bb3069a3ff9ed9bc42e57f3
2 years ago
Alex Vanyo
738210166a
Refine backgrounds and navigation colors
...
Change-Id: I9fd863cc608f21078ab78c39c2c3d227aedbac7c
2 years ago
Alex Vanyo
8c11769622
Update to material3 1.0.0-beta03 wih built-in insets support
...
Change-Id: I4d07f89d4faa6e3417468ad78acf3fbb161f0797
2 years ago
Automerger
3083c5e2ce
Merge branch 'github/main'
2 years ago
Caren
d89812ee90
Merge pull request #288 from android/caren/remove_search
...
Remove Search from top app bar
2 years ago
Automerger
2531f1be9f
Merge branch 'github/main'
2 years ago
Caren
f16e9d011e
Merge pull request #272 from android/caren/fix_toggle_buttons
...
Fix toggle buttons interaction when using TalkBack
2 years ago
Automerger
6765d79065
Merge branch 'github/main'
2 years ago
Alex Vanyo
bfedf75665
Remove Preview TODOs for Dolphin
...
Change-Id: I35219c7dd6a902c43cd310dcaf8d0e2c2dbdec45
2 years ago
Takeshi Hagikura
74737cad49
Introduce Multipreview annotation to simplify the preview configurations
...
- Bump the AGP version to 7.3.0
- Introduce Multipreview annotation class that represents device
previews and theme previews
Fixes #282
2 years ago
Caren Chang
f76984539b
Fix toggle buttons interaction when using TalkBack
2 years ago
Caren Chang
b74767921c
Remove Search from top app bar
2 years ago
Wojtek Kaliciński
4683918cc7
Move spotless to init script
...
Also adds automatic git hooks installation
Change-Id: I18debbee43af27db7b95a4202f824fa87e186713
2 years ago
madroid
3bd81154b5
Move 'core-' module to core subfolder
2 years ago