da8f32a2ea
Rename Destinations to Routes
...
Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7
7 months ago
924391cd22
Fix spotless
...
Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428
8 months ago
89163b5ea1
Migrate remainder of app to type-safe navigation
...
Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b
8 months ago
ee4320723f
Fix typo.
...
Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f
10 months ago
ed91723e2f
Fix #1270
...
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
10 months ago
2ad48843f6
Fix formatting
...
Change-Id: I674d32bc0f1921c431717dbf0f41a74f632322b3
10 months ago
254b464259
Update Lifecycle to 2.7.0. Use new LifecycleEventEffect.
...
Change-Id: I71e7aa521f22499fd3f3e9f3ac7c81658f3abc3a
11 months ago
707117a4f2
Merge branch 'main' into kotlinify
1 year ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
1 year ago
6cd5958665
Update feature/bookmarks/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/bookmarks/navigation/BookmarksNavigation.kt
1 year ago
9d41ffa318
Merge branch 'main' into kotlinify
1 year ago
32e1ec0447
Remove violations: property-naming
1 year ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
1 year ago
03d2455f41
Use lazy vertical staggered grid in feed to maximize space utilization
...
Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926
1 year ago
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
1 year ago
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
1 year ago
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
1 year ago
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
1 year ago
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
1 year ago
e13e84c155
Replace usages of 'displacement' to 'moved' in parameter names
...
Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a
1 year ago
eeb4973265
PR feedback
...
Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f
1 year ago
bdf3ee3cb0
PR feedback
...
Change-Id: Ie22aa3c7fdf4c8ca8d8118837cfd279de8c6d80b
1 year ago
cb1d50e65e
Even better names
...
Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65
1 year ago
3aec705048
Add padding to scrollbars
1 year ago
31b4841cb2
Add scrollbars to app
1 year ago
7b30720b25
Remove nested scaffold from the bookmarks screen
...
Change-Id: Ie8b6f160d341156a6f9c02c0ca7f530095fb2950
2 years ago
9aba5cc0fe
Cleanup unused string resources
2 years ago
d6ba65c77f
Update `BookmarksGrid` horizontal spacing to fix #732
2 years ago
bf747434cd
Add Undo snackbar on Bookmark removal
...
Change-Id: I1fefd6e72378e26ae35b66e032529a116cff9a79
2 years ago
050db2cb72
Merge branch 'main' into jr/track-viewed
2 years ago
b49767a88c
Rename getUserNewsResources to observeAll
2 years ago
049750dd51
Merge branch 'main' into ui-polish
2 years ago
57c13d84bd
Incorporate code review changes: Move UserNewsResourceRepository to data
...
module; move UserNewsResource to model module. Implement unread dot for
bookmarked articles. Keep the flows cold in UserNewsResourceRepository.
2 years ago
ebfbb5bafd
Display unread state on the news feed and bottom nav bar
...
When a news resource is unread, display a dot on its card in the news
feed. When the For You section has unread resources, display a dot on
its icon in the navigation bar.
Update the read status when a resource is opened.
2 years ago
bd450099fb
Replace GetUserNewsResourcesUseCase with UserNewsResourceRepository
...
This moves the responsibility for joining the UserData and the
NewsResources to UserNewsResourceRepository. This way, the work can be
done once and shared with all consumers in a SharedFlow, rather than
having each consumer perform the join itself by invoking the UseCase.
2 years ago
874c2d1487
Merge pull request #561 from SimonMarquis/update/androidx-lifecycle
...
Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05
2 years ago
4d4f7d4a15
Merge remote-tracking branch 'origin/main' into update/androidx-lifecycle
2 years ago
4284e6912e
Merge remote-tracking branch 'github/main' into feb9automerger
...
* github/main:
Bump version to 4
Remove unused DropdownMenu component
Route topic chip tap events up to NiaNavHost
Apply suggestions from code review
Migrate custom room configuration into a convention plugin
Update docs/ArchitectureLearningJourney.md - User action follow topic
Update docs/ArchitectureLearningJourney.md - Writing data
Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea
2 years ago
322ff63dbc
Route topic chip tap events up to NiaNavHost
...
Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7
2 years ago
2a4d0434a5
Add Firebase analytics. See go/nia-firebase-services.
...
Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689
2 years ago
f9a3533df3
Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05
...
> `Transformations` is now written in Kotlin. This is a *source incompatible change* for those classes written in Kotlin that were directly using syntax such as `Transformations.map`
> Kotlin code *must* now use the Kotlin extension method syntax that was previously only available when using `lifecycle-livedata-ktx`.
> The `collectAsStateWithLifecycle()` APIs of `lifecycle-runtime-compose` are no longer in experimental status. (I09d42, b/258835424)
Changelog: https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.0-alpha05
2 years ago
bcb4d7d592
Replace global variables with PreviewParameterProvider
2 years ago
819dd494ad
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
2 years ago
f28d7f0eef
change the bookmark image to SVG
...
Change-Id: I2a9ae27d338127ab2a7b2b90ecff5b565fe5bd1a
2 years ago
257d3e5c70
change the bookmark image to SVG
...
Change-Id: I995faf3ac437cf78c7c447801a969fab01dbc85d
2 years ago
19efc1b5e8
Fix Spotless issue manually
...
Change-Id: Icd560e6ceaaeee0a6f502fe49b3403ab07f926ef
2 years ago
aa6f338f38
Make empty bookmark icon dynamic to dynamic color settings
...
Change-Id: I6a69f0a82f91536d43d986cc5a382b65f4219816
2 years ago
32bc5c1590
Fix merge conflicts
2 years ago
2f454de21c
Spacing polish based on design spec
2 years ago
4484743830
Merge pull request #453 from LinX64/no_bookmarks_state_test
...
[Saved screen] Added the test for empty state and refactor
2 years ago
Don Turner
Jaehwa Noh
Don Turner
Simon Marquis
lihenggui
dahunsi
Simon Marquis
TJ Dahunsi
Miłosz Moczkowski
Neelansh Sahai
James Rose
Chris Sinco
Alex Vanyo
Márton Braun
Angie Sasmita