120 Commits (643b62ed688afe4b568b9ec60730cb905bf7f68a)

Author	SHA1	Message	Date
Don Turner	5994d8c6fd	Add TopicScreen as a sub destination in the ForYou section. Fixes #1463	3 weeks ago
Don Turner	bd557fd604	Reduce icon sizes	1 month ago
saeedishayan76	987e87f4ed	Check topicViewModelTest for spotless	3 months ago
saeedishayan76	26dd4424f6	remove blank lines for resolve spotless error	3 months ago
saeedishayan76	0356b873e9	change collectJob to backgroundScope coroutine	3 months ago
Don Turner	00efda54e8	Merge branch 'main' into dt/nav-safe-args ... * main: (58 commits) Instrumented tests for InterestsListDetailScreen (#1518) Remove Firebase AD_SERVICE_CONFIG property updateProdReleaseBadging Merge Android & JVM plugins into a single `HiltConventionPlugin` Update dependency guard 🤖 Updates baselines for Dependency Guard Update to Lifecycle 2.8.3 Add android.adservices.AD_SERVICES_CONFIG to badges Apply suggestions from code review Update app/src/main/AndroidManifest.xml generateModuleGraphs dependencyGuardBaseline updateProdReleaseBadging Fix spotless. Change set to `=` operator Cleanup unused reference in `libs.versions.toml` Regenerate SVG graphs Update comment wording Use stdin to avoid repeating the output file name Replace bash commands with proper svgo cli ... Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5	3 months ago
Don Turner	ec71b2a07e	Add Robolectric to allow ViewModel tests to pass ... Change-Id: I782fab167103edbdaa1d95839b4fbc6e659fef4e	5 months ago
Don Turner	da8f32a2ea	Rename Destinations to Routes ... Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7	6 months ago
Simon Marquis	61143ca98b	Merge remote-tracking branch 'origin/main' into fix/1161-2	6 months ago
Don Turner	7ec21d9d2f	Fix issue where selected topic in list was not showing as selected. Minor tidy ups. ... Change-Id: Icfa79eac6f7327c365f79fd7d15dfa1f8c77184d	7 months ago
Alex Vanyo	1c0508a678	Recreate nested nav to work with AnimatedPane ... Change-Id: I6b526331b7fc62b968ac39e91753a8a1e5343023	7 months ago
Don Turner	924391cd22	Fix spotless ... Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428	7 months ago
Don Turner	89163b5ea1	Migrate remainder of app to type-safe navigation ... Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b	7 months ago
Don Turner	490997281a	Update to alpha08, use toRoute to obtain destination inside VM ... Change-Id: I72f617c594b5e0ae272cf94d2d7288446153420a	7 months ago
Don Turner	d96bcf8ffe	Migrate Interests nested NavHost to safe args ... Change-Id: I4f3c310be693ecbcbc8b99c4e573d7fc6e9a2f74	7 months ago
Don Turner	6dc59e7016	Use SafeArgs navigation for Topic feature ... Change-Id: Idf4386f10c780d3edc1f8aa11b428cb146e982c3	7 months ago
Simon Marquis	930e061611	Cleanup dependencies ... This is a followup cleanup of #1163 that was partially addressed by #1140. - Remove unused `projects.core.testing` dependencies (or replace with direct dependencies). - Introduce `androidx.compose.ui.test` bundle. - Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.	8 months ago
Jonathan Koren	dac1a9e446	Topic detail pane placeholder (#1280) ... * Topic detail pane placeholder Change-Id: I92b84493a5406240285c0759b30aa10d29871f09 * Add modifier parameter Change-Id: Ie363be83b44f26291030c04c1513cecb851a6899	8 months ago
Alex Vanyo	78c77737c0	Merge pull request #1275 from Jaehwa-Noh/rename-function ... Rename function to setNewsResourceBookmarked	8 months ago
Don Turner	3e4aad3210	Merge pull request #1257 from android/dt/add-module-graphs ... Update module dependency graphs and add script to create them	8 months ago
Don Turner	a5025390af	Add title to READMEs to describe the dependency graph ... Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528	8 months ago
Jaehwa Noh	fc4f7930a6	Merge branch 'android:main' into rename-function	8 months ago
Jaehwa Noh	ee4320723f	Fix typo. ... Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f	9 months ago
Jaehwa Noh	ed91723e2f	Fix #1270 ... Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c	9 months ago
Don Turner	547cb191d2	Merge pull request #1256 from lnbs97/main ... Fix typo in TopicViewModel.kt	9 months ago
Jonathan Koren	19f6f9e09a	2 pane support in Interests screen (#1234) ... * Add dependency on material3 adaptive Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6 * Add InterestsListDetailScreen composable Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971 * Store selectedTopicId in InterestsViewModel Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce * Pass detail pane composable down Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293 * Navigate to initial topic if provided Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b * Lift LDPS up to app module Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85 * Fix some navigation behavior Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b * Navigate to initial topic if provided Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed * Remove dependency in interests feature module Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f * Hide back arrow when the topics list is visible Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8 * Update interests tests Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd * Highlight selected topic when displaying 2 panes Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415 * update dependency baselines Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00 * run spotless apply Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8 * Convert isListPaneHidden to isListPaneVisible Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657 * Set semantics for selected state Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca * Use scaffold roles when determining visibility Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648 * Update multipleBackStackInterests test Change-Id: I1e372f7989817151a6765205291b13b561187fa8	9 months ago
lnbs97	96d210dc35	fix typo in TopicViewModel.kt	9 months ago
Don Turner	80a82de945	Update module dependency graphs and add script to create them ... Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31	9 months ago
Don Turner	707117a4f2	Merge branch 'main' into kotlinify	11 months ago
Don Turner	0f0511748e	Merge pull request #1088 from SimonMarquis/cleanup-dependencies ... Reduce overall build complexity	11 months ago
Don Turner	89d39a7242	Merge pull request #767 from SimonMarquis/resource-prefix ... Enforce `resourcePrefix` on Android library modules	11 months ago
Don Turner	9d41ffa318	Merge branch 'main' into kotlinify	11 months ago
lihenggui	32e1ec0447	Remove violations: property-naming	11 months ago
Simon Marquis	f27a2e176e	Reduce overall build complexity ... - Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`	12 months ago
Simon Marquis	caa482bc71	Kotlinify codebase ... - Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)	1 year ago
kimdowoo	129099e219	refactor/Convert object to data object in sealed interface	1 year ago
Melwin Magalhaes	6247712064	Add convention plugins to version catalogs	1 year ago
Simon Marquis	b2cd980170	Merge remote-tracking branch 'origin/main' into resource-prefix	1 year ago
Simon Marquis	ebfe01affd	Enforce `resourcePrefix` on Android library modules ... ``` :ui-test-hilt-manifest -> ui_test_hilt_manifest_ :core:analytics -> core_analytics_ :core:common -> core_common_ :core:data -> core_data_ :core:data-test -> core_data_test_ :core:database -> core_database_ :core:datastore -> core_datastore_ :core:datastore-test -> core_datastore_test_ :core:designsystem -> core_designsystem_ :core:domain -> core_domain_ :core:network -> core_network_ :core:notifications -> core_notifications_ :core:testing -> core_testing_ :core:ui -> core_ui_ :feature:bookmarks -> feature_bookmarks_ :feature:foryou -> feature_foryou_ :feature:interests -> feature_interests_ :feature:search -> feature_search_ :feature:settings -> feature_settings_ :feature:topic -> feature_topic_ :sync:sync-test -> sync_test_ :sync:work -> sync_work_ ```	1 year ago
Simon Marquis	a33dafccad	Migrate from `java` to `kotlin` sourceSet directory	1 year ago
Roy Matero	298f3ce4db	Merge branch 'android:main' into main	1 year ago
Roy Matero	4e6cda1965	Renamed toggle function signature with boolean parameters ... Change-Id: I0d6c0ed4d4c0ee4bd387e5645fc558970f5f202b	1 year ago
Milosz Moczkowski	89a1294c63	Merge branch 'main' into takahirom/rename-topicBody/2023-07-13	1 year ago
Simon Marquis	daa2228132	Restore original `type` labels	1 year ago
Simon Marquis	0377fd8712	Replace `NewsResourceType` enum with simpler String type ... See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901	1 year ago
Don Turner	492697ce6b	Merge pull request #873 from SimonMarquis/misc-warnings ... Fix miscellaneous warnings	1 year ago
Don Turner	0e13207a40	Merge pull request #874 from SimonMarquis/string-decoder ... Replace StringDecoder injection with simpler API	1 year ago
Simon Marquis	0418997f5a	Extract `UTF-8` character encoding	1 year ago
Simon Marquis	e8449112b4	Replace StringDecoder injection with simpler API ... The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String. For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`). Unit tests would fail because Uri is not mocked (since we are not using Robolectric). Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc. FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded". The solution to this problem was to simply use regular Java APIs: - `URLDecoder.decode(urlEncodedTopicId, "UTF-8")` - `URLEncoder.encode(topicId, "UTF-8")`	1 year ago
Simon Marquis	4bdc9705af	Fix miscellaneous warnings ... - Remove unused namespace declaration - Collapse empty manifest tags - Remove redundant qualifier name - Remove redundant suppression	1 year ago