268 Commits (6297b741e91296bdc4425d84de55a6aea3954545)

Author	SHA1	Message	Date
Simon Marquis	988002e692	Update Robolectric 4.11.1 ... - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11 - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1 > Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below. Removing explicit API 33 Robolectric configuration.	8 months ago
Miłosz Moczkowski	9c89e98e5b	Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold" ... This reverts commit 335a7ec68c, reversing changes made to aa8ce0e1f6.	8 months ago
Miłosz Moczkowski	816a7b60c1	Replace manual navigation component switching with new NavigationSuiteScaffold ... Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723	8 months ago
kimdowoo	129099e219	refactor/Convert object to data object in sealed interface	9 months ago
Adetunji Dahunsi	0287af8d9a	Merge pull request #947 from android/tj/staggered-grid-feed ... Use lazy vertical staggered grid in feed to maximize space utilization	9 months ago
Don Turner	a381d13199	Merge pull request #958 from McGalanes/main ... Use typesafe project accessors	10 months ago
Melwin Magalhaes	6247712064	Add convention plugins to version catalogs	10 months ago
Melwin Magalhaes	b1266dc05a	Use typesafe project accessors for project modules	10 months ago
tunjid	b2498c763f	🤖 Updates screenshots	10 months ago
dahunsi	03d2455f41	Use lazy vertical staggered grid in feed to maximize space utilization ... Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926	10 months ago
Simon Marquis	a33dafccad	Migrate from `java` to `kotlin` sourceSet directory	10 months ago
Roy Matero	298f3ce4db	Merge branch 'android:main' into main	11 months ago
Jose Alcérreca	5b79869324	Adds dark screenshot tests and fixes background colors in ForYou (#918) ... * Adds dark screenshot tests and fixes background colors in ForYou * 🤖 Updates screenshots	11 months ago
Roy Matero	4e6cda1965	Renamed toggle function signature with boolean parameters ... Change-Id: I0d6c0ed4d4c0ee4bd387e5645fc558970f5f202b	11 months ago
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876) ... * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	11 months ago
Adetunji Dahunsi	4716c7f841	Merge pull request #913 from hoangchungk53qx1/main ... Refactor Search Feature	11 months ago
hoangchungk53qx1	66eafdc38b	format modification for screen search	11 months ago
Milosz Moczkowski	b6459d41ee	Merge pull request #834 from takahirom/takahirom/rename-topicBody/2023-07-13 ... Rename LazyListScope.TopicBody LazyListScope.topicBody	11 months ago
Milosz Moczkowski	374808c284	Merge pull request #847 from SilviaGarciaBouza/wrong_color_in_dark_mode ... Added TextStyle color for ClickableText	11 months ago
hoangchungk53qx1	70498dd6e3	separate function logEvent for search triggered	11 months ago
hoangchungk53qx1	9cb20db93a	separate function logEvent for search triggered	11 months ago
hoangchungk53qx1	c52c4b88cd	replace object with data object in search feature, simple format code for the reader	11 months ago
hoangchungk53qx1	cd30ecf359	replace object with data object in search feature, simple format code for the reader	11 months ago
Milosz Moczkowski	89a1294c63	Merge branch 'main' into takahirom/rename-topicBody/2023-07-13	11 months ago
Simon Marquis	daa2228132	Restore original `type` labels	11 months ago
Simon Marquis	0377fd8712	Replace `NewsResourceType` enum with simpler String type ... See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901	11 months ago
Adetunji Dahunsi	153b34fd50	Merge pull request #850 from qamarelsafadi/loading-progress-for-image ... Fix #849: Loading progress for image	11 months ago
Don Turner	492697ce6b	Merge pull request #873 from SimonMarquis/misc-warnings ... Fix miscellaneous warnings	11 months ago
Qamar A. Safadi	2db3e0c804	Merge branch 'android:main' into loading-progress-for-image	11 months ago
Don Turner	8901e5932a	Merge pull request #872 from SimonMarquis/data-objects ... Convert 'sealed' sub-object to 'data object'	11 months ago
Don Turner	0e13207a40	Merge pull request #874 from SimonMarquis/string-decoder ... Replace StringDecoder injection with simpler API	11 months ago
Qamar A. Safadi	5abc69fb49	Merge branch 'android:main' into loading-progress-for-image	11 months ago
Simon Marquis	0418997f5a	Extract `UTF-8` character encoding	11 months ago
Don Turner	4d0efef3b4	Merge pull request #879 from tatsuyafujisaki/rename-constants ... Rename constants	11 months ago
Qamar A. Safadi	8aa0457ca9	Merge branch 'android:main' into loading-progress-for-image	12 months ago
Adetunji Dahunsi	0a20cb729b	Merge pull request #877 from android/tj/scrollbars ... Update feedItemsSize calculation	12 months ago
Tatsuya Fujisaki	4eeb045287	Rename constants	12 months ago
Adetunji Dahunsi	ec53d03854	Merge pull request #722 from android/tj/scrollbars ... Add scrollbars to app	12 months ago
dahunsi	03610d229a	Update feedItemsSize calculation ... Change-Id: I2bf6a2fa0e210cef1318707d948a49d2ef010452	12 months ago
Simon Marquis	e8449112b4	Replace StringDecoder injection with simpler API ... The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String. For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`). Unit tests would fail because Uri is not mocked (since we are not using Robolectric). Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc. FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded". The solution to this problem was to simply use regular Java APIs: - `URLDecoder.decode(urlEncodedTopicId, "UTF-8")` - `URLEncoder.encode(topicId, "UTF-8")`	12 months ago
Simon Marquis	4bdc9705af	Fix miscellaneous warnings ... - Remove unused namespace declaration - Collapse empty manifest tags - Remove redundant qualifier name - Remove redundant suppression	12 months ago
Simon Marquis	b7799f0475	Convert 'sealed' sub-object to 'data object'	12 months ago
Qamar A. Safadi	9f3103c212	Merge branch 'android:main' into loading-progress-for-image	12 months ago
Simon Marquis	995d7b643f	Add missing full stop in `search_not_ready` string	12 months ago
qamarelsafadi	f1a2993adc	feat: remove add placeholder todo	12 months ago
TJ Dahunsi	e13e84c155	Replace usages of 'displacement' to 'moved' in parameter names ... Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a	1 year ago
TJ Dahunsi	eeb4973265	PR feedback ... Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f	1 year ago
TJ Dahunsi	bdf3ee3cb0	PR feedback ... Change-Id: Ie22aa3c7fdf4c8ca8d8118837cfd279de8c6d80b	1 year ago
TJ Dahunsi	cb1d50e65e	Even better names ... Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65	1 year ago
TJ Dahunsi	3aec705048	Add padding to scrollbars	1 year ago