Simon Marquis
3e1f545869
Update build.gradle.kts
8 months ago
Jose Alcérreca
ead3f49f7b
Fixes flakiness in app's screenshot tests ( #1395 )
...
* Disables WM init in app's screenshot tests
Change-Id: Ib0994e744f49b53f58c0eebd52f80c0eba67bbed
* Spotless
Change-Id: Ic0212889354481433ce45ec4292ae7be9bd24b2e
* [CI] Uploads roborazzi reports if they fail
Change-Id: I5a25a7e156d3fcb72a396d3b503e62068a20b417
* Uses unused test module and enables LocalInspection
Change-Id: Iac36347dc3d702248d7515a74823e0bc0cbf2a2b
* Fixes timezone in snackbar screenshot tests
Change-Id: Ic517e8822218abeaddd3f8d2740b03e651d72d31
* Fixes conflict
Change-Id: Ia42fb78781d2469a608183594fc25c7c69f7e76c
* 🤖 Updates screenshots
8 months ago
Jose Alcérreca
1da560f582
Revert "Configure baseline profiles in the baselineProfile lambda" ( #1398 )
...
This reverts commit 7980c1d0df
.
8 months ago
Ben Weiss
7980c1d0df
Configure baseline profiles in the baselineProfile lambda ( #1060 )
...
* Configure baseline profiles in the baselineProfile lambda
* This is the correct and easiest way to set up baseline profiles correctly.
* See b/313428246 for more context.
* Handle empty topics during baseline profile generation
* Revert to API 33 GMD and fail empty screen tests
* Rename withChildren to noChildren for better legibility
* Remove unused log tags
* Update benchmark and metrics versions
* 🤖 Updates baselines for Dependency Guard
---------
Co-authored-by: Tomáš Mlynarič <mlykotom@google.com>
Co-authored-by: Jaehwa Noh <shwoghk14@gmail.com>
8 months ago
Alex Vanyo
91215c5c89
Update to navigation 2.7.7
...
Change-Id: Iaceea1fc216c899f7fac58e7f5eeaea4e1c10dbb
8 months ago
Don Turner
c7d5cb4012
Replace TestHarness with DeviceConfigurationOverride after merging main
...
Change-Id: Ie49b67981929fd3932ce3da68571a6305cf67aef
8 months ago
Don Turner
61cce4bf19
Merge branch 'main' into replace-testharness
8 months ago
Sergey Pinkevich
2ade8c8f1c
Merge branch 'dependabot/gradle/androidx.activity-activity-compose-1.8.2' of https://github.com/android/nowinandroid into dependabot/gradle/androidx.activity-activity-compose-1.8.2
8 months ago
Alex Vanyo
d452f22a68
Update badging
...
Change-Id: If6b1327554bc855baa86fd47519ca56e015b9d14
8 months ago
Alex Vanyo
9b4c22cb2d
Update to material3-adaptive alpha10
...
Change-Id: I810c36323a35c445c22dd3876c52df0360a5cb48
8 months ago
Alex Vanyo
0be0bc191f
Update usage of material3 adaptive to be edge-to-edge
...
Change-Id: I481c79db77bbdd657182f5355200f63e2355f40d
8 months ago
Jose Alcérreca
16f45c0b1a
Adds screenshot tests for snackbar ( #1343 )
...
* Adds screenshot tests for snackbar
Change-Id: I81566e3301fb17e3f31cbc408e6cc3325eab5a12
* Small tweaks, RFR
Change-Id: Ia16db6e6f5bec2714081b5ceaeeba36b2ee26105
* 🤖 Updates screenshots
* Update NiaApp.kt
Adds modifier to NiaApp
9 months ago
Don Turner
739dc00987
Fix spotless
...
Change-Id: I98a9b9fa1de5cc0bb3a3caa7d795053fd784b238
9 months ago
Don Turner
fc2146c970
Merge branch 'main' into replace-testharness
9 months ago
Don Turner
655aebccdc
Remove workaround for https://issuetracker.google.com/327149166
...
Change-Id: I335f9f5da1ff3f2574acca8e3fcb27b949a07c7a
9 months ago
Jaehwa Noh
a22b724a66
Change getByName to named
...
- reference by [APIs to avoid](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#apis_to_avoid )
Change-Id: Idf1ce9cf372b8f5da2f0da95fcf53454ffb3388f
9 months ago
Jose Alcérreca
78e3725f9f
Sets up jacoco coverage with a combined report and a GHA ( #1303 )
...
* Uses jacoco coverage reporting in AGP
9 months ago
Simon Marquis
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
9 months ago
Don Turner
bd89507f10
Merge pull request #1306 from yongsuk44/feat/weak-warning
...
Cleaned up unnecessary '@opt-in' annotations and removed empty constructors
9 months ago
yongsuk44
e2a4706470
Remove unnecessary opt-in annotations
9 months ago
dependabot[bot]
c4b669a138
🤖 Updates baselines for Dependency Guard
9 months ago
dependabot[bot]
7d2026f180
🤖 Updates baselines for Dependency Guard
9 months ago
Jonathan Koren
dac1a9e446
Topic detail pane placeholder ( #1280 )
...
* Topic detail pane placeholder
Change-Id: I92b84493a5406240285c0759b30aa10d29871f09
* Add modifier parameter
Change-Id: Ie363be83b44f26291030c04c1513cecb851a6899
9 months ago
Don Turner
70dcd5119d
Make path to module graph image dynamic. Fixes #1286
...
Change-Id: I595a841ef7b06cccc959ca96d18824f4fad4c261
9 months ago
Don Turner
3e4aad3210
Merge pull request #1257 from android/dt/add-module-graphs
...
Update module dependency graphs and add script to create them
9 months ago
Don Turner
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
9 months ago
SergeyPinkevich
06f08a58dd
🤖 Updates baselines for Dependency Guard
9 months ago
alexvanyo
a6f223301e
🤖 Updates baselines for Dependency Guard
9 months ago
Alex Vanyo
cc02c30b8e
Update material3-adaptive to 1.0.0-alpha08
...
Change-Id: Ic218c6b061b5cea4e56b544073541421862bc1d0
9 months ago
Don Turner
0c9f0dd48c
Merge pull request #1217 from android/dependabot/gradle/org.jetbrains.kotlinx-kotlinx-serialization-json-1.6.3
...
Bump org.jetbrains.kotlinx:kotlinx-serialization-json from 1.6.0 to 1.6.3
10 months ago
Don Turner
e9565a567e
Merge pull request #1258 from Jaehwa-Noh/rename-test-function
...
Rename test function, and delete explicit type argument
10 months ago
Don Turner
74d1d91c28
Merge pull request #1263 from android/dependabot/gradle/kotlinxCoroutines-1.8.0
...
Bump kotlinxCoroutines from 1.7.3 to 1.8.0
10 months ago
Don Turner
91af060e77
Merge pull request #1264 from android/dependabot/gradle/androidx.hilt-hilt-navigation-compose-1.2.0
...
Bump androidx.hilt:hilt-navigation-compose from 1.0.0 to 1.2.0
10 months ago
Don Turner
1fde4f5753
Merge pull request #1266 from android/dependabot/gradle/androidx.browser-browser-1.8.0
...
Bump androidx.browser:browser from 1.6.0 to 1.8.0
10 months ago
mlykotom
a7a7736426
🤖 Updates baselines for Dependency Guard
10 months ago
dependabot[bot]
5448786c4d
🤖 Updates baselines for Dependency Guard
10 months ago
dependabot[bot]
72f968ff2c
🤖 Updates baselines for Dependency Guard
10 months ago
dependabot[bot]
6e5548a837
🤖 Updates baselines for Dependency Guard
10 months ago
Jaehwa Noh
d67b1a2504
Merge branch 'android:main' into rename-test-function
10 months ago
Jaehwa Noh
e017b84a12
Remove explicit type argument.
...
Change-Id: Id02756d780309af6638698de856b563d9e775cc3
10 months ago
Jaehwa Noh
8cfd42453c
Rename test function name
...
- Given-when-then format.
Change-Id: I3305c5a7cc5a0f41be31292534a086034f642404
10 months ago
Jonathan Koren
19f6f9e09a
2 pane support in Interests screen ( #1234 )
...
* Add dependency on material3 adaptive
Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6
* Add InterestsListDetailScreen composable
Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971
* Store selectedTopicId in InterestsViewModel
Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce
* Pass detail pane composable down
Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293
* Navigate to initial topic if provided
Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b
* Lift LDPS up to app module
Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85
* Fix some navigation behavior
Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b
* Navigate to initial topic if provided
Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed
* Remove dependency in interests feature module
Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f
* Hide back arrow when the topics list is visible
Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8
* Update interests tests
Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd
* Highlight selected topic when displaying 2 panes
Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415
* update dependency baselines
Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00
* run spotless apply
Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8
* Convert isListPaneHidden to isListPaneVisible
Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657
* Set semantics for selected state
Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca
* Use scaffold roles when determining visibility
Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648
* Update multipleBackStackInterests test
Change-Id: I1e372f7989817151a6765205291b13b561187fa8
10 months ago
Don Turner
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
10 months ago
Don Turner
2d610b0775
Merge branch 'main' into replace-testharness
...
* main: (37 commits)
Disable animations of instrumented tests (#1167 )
Bump gradle/wrapper-validation-action from 1 to 2
Remove unused release variable. Fixes #1231
Apply Composable Parameter Ordering Guidelines
Remove kotlinx-coroutines-guava dependency from :sync:work
Add explicit guava-android dependency for :sync:work
Extract ScreenshotHelper to separate testing module
Update AGP to 8.3.0
Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert.
🤖 Updates baselines for Dependency Guard
Bump the kotlin-ksp-compose group with 6 updates
🤖 Updates baselines for Dependency Guard
Bump hilt from 2.50 to 2.51
Bump com.google.truth:truth from 1.1.5 to 1.4.2
Move java to kotlin folder.
Remove disk usage testing
Figuring out what is using 66Gb in the runner
Dpm
Improve converting to kotlin timezone
Use trySend multiple times
...
Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a
10 months ago
Don Turner
7737368c0e
Update app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
10 months ago
Don Turner
14b60b3a59
Merge branch 'main' into dependabot/gradle/org.jetbrains.kotlinx-kotlinx-serialization-json-1.6.3
10 months ago
Don Turner
8a3c34994d
Merge pull request #1239 from Jaehwa-Noh/java-to-kotlin
...
Move java to kotlin folder.
10 months ago
Don Turner
747c9275bc
Merge pull request #1249 from android/dt/fix-1231
...
Remove unused release variable. Fixes #1231
10 months ago
Don Turner
77cbdb62a4
Remove unused release variable. Fixes #1231
...
Change-Id: I8c03d3d2e1aee85a22d1a03b97e3bec4069e0fcb
10 months ago
Alex Vanyo
e3c7018124
Extract ScreenshotHelper to separate testing module
...
Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af
10 months ago
Don Turner
d768c796d4
Merge pull request #1244 from android/dependabot/gradle/hilt-2.51
...
Bump hilt from 2.50 to 2.51
10 months ago
Jaehwa Noh
1ca0085423
Merge branch 'android:main' into java-to-kotlin
10 months ago
Tomáš Mlynarič
f31fdb3ec2
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Id49a580012629163ec4a3663d95ab71b98910220
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
# gradle/libs.versions.toml
10 months ago
dependabot[bot]
b2b9f12915
🤖 Updates baselines for Dependency Guard
10 months ago
Jaehwa Noh
9b488bf70a
Move java to kotlin folder.
...
Change-Id: Iaf4723dea6169fbf3f9a8d3bf8779179ac56ab86
10 months ago
dturner
43b2240bdd
🤖 Updates screenshots
10 months ago
Don Turner
73d0b70f21
Workaround for new ForcedSize behaviour, bump ui-test version
...
Change-Id: Ibf93c1b65250e6527e34bc90602c1b1001b2df46
10 months ago
Don Turner
fa811ab85f
Bump to ui-test:1.7.0-alpha03, add parameter name
...
Change-Id: Ib1bbe4ad0d823c632d387587aa55c5eeb39e4b8d
10 months ago
dturner
50d5583fe1
🤖 Updates screenshots
10 months ago
Don Turner
d6357be8c4
Replace Accompanist TestHarness with DeviceConfigurationOverride
...
Change-Id: I6742d5e221f86a019f44d3e623609bf76d2a3a2a
10 months ago
dturner
27fd4e544a
🤖 Updates screenshots
10 months ago
dturner
02d4fea615
🤖 Updates screenshots
10 months ago
Don Turner
a507ff6d8e
Wrap NiaApp with NiaTheme for app screenshot tests
...
Change-Id: I8e298da139b19721b90ae778e7ab184f600d0bd7
10 months ago
Tomáš Mlynarič
75a3295381
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt
10 months ago
dturner
6b2b01ed82
🤖 Updates screenshots
10 months ago
dturner
076a2af757
🤖 Updates baselines for Dependency Guard
10 months ago
dturner
08d8f1393a
🤖 Updates baselines for Dependency Guard
10 months ago
dependabot[bot]
0c0adddf42
🤖 Updates baselines for Dependency Guard
10 months ago
dependabot[bot]
6add4d68e3
Bump protobuf from 3.24.4 to 3.25.2 ( #1214 )
...
* Bump protobuf from 3.24.4 to 3.25.2
Bumps `protobuf` from 3.24.4 to 3.25.2.
Updates `com.google.protobuf:protobuf-kotlin-lite` from 3.24.4 to 3.25.2
Updates `com.google.protobuf:protoc` from 3.24.4 to 3.25.2
- [Release notes](https://github.com/protocolbuffers/protobuf/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl )
- [Commits](https://github.com/protocolbuffers/protobuf/compare/v3.24.4...v3.25.2 )
---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-kotlin-lite
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.protobuf:protoc
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* 🤖 Updates baselines for Dependency Guard
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
10 months ago
Ben Weiss
f64f1c0aa2
Remove legacy benchmark build type ( #1207 )
...
* Remove legacy benchmark build type
Now that we have the baseline profile gradle plugin,
there is no need for a benchmark build type.
The plugin does the setup and configuration and runs against the
correct app flavor.
* Remove explicit benchmark build type from benchmark module
* Remove stale build task exclusions
* Fix tracing import location
FYI @mlykotom
10 months ago
Tomáš Mlynarič
58483b6166
Revert fast initialization of Coil
...
As discussed in https://github.com/coil-kt/coil/issues/2097 the problem is caused by regitering system services, which will be fixed in 2.6.0
Change-Id: I9085309780508137f10b25ff82deed3c62e5d159
11 months ago
Tomáš Mlynarič
f3e89bad4a
Add braces
...
Change-Id: I859babab7278137a4a2e49e5a085c65632888dd0
11 months ago
Tomáš Mlynarič
d1211f15e7
Inline initialization
...
Change-Id: I0a77eb6457cac27c1a4d604c8efdcbbdce95bc48
11 months ago
Tomáš Mlynarič
e853748cf7
Don't use runBlocking if async init completed
...
Change-Id: I641187ce277f434c6fca49a11b3cfccd50ecf5da
11 months ago
Tomáš Mlynarič
7c33946ce1
Launch loader directly without additional coroutine scope
...
Change-Id: Icbbdbcbcac1a6275857ebe998509f1e09109db7a
11 months ago
Tomáš Mlynarič
8e3903e90c
Fix comment
...
Co-authored-by: Yuri Schimke <yuri@schimke.ee>
11 months ago
Tomáš Mlynarič
5f0612102d
Improve lazy loading for Coil + OkHttp
...
This way, we can load Coil's backend on a background thread and not block the MainThread with it.
Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames.
Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62
11 months ago
Tomáš Mlynarič
12a3a6edde
Use trySend multiple times
...
Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032
11 months ago
Tomáš Mlynarič
08bfc54832
Update dependency guard baseline
...
Change-Id: I2557753f1eb4c6845aca6473a6aba5b7e758ebbf
11 months ago
Tomáš Mlynarič
f8e797fd26
Rename currentTimezone variable
...
Change-Id: I92630f6851b0253294a8d3ec2e5b3cbe7db74b4d
11 months ago
Tomáš Mlynarič
98e9e80639
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Ie83fb57676934ca3bdda59a986eb1a01a7c97424
11 months ago
Tomáš Mlynarič
ea1573fcc1
Use kotlinx.datetime.Timezone instead of java ZoneId
...
Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628
11 months ago
Jonathan Koren
c1d6c88bb0
Run dependencyGuard task during CI ( #1064 )
...
* Run dependencyGuard task during CI
Run the `dependencyGuard` task during CI, which will fail if there are
detected changes.
Change-Id: If5f2b18a4c765bd38a3353df2adaaa91cf1739c3
* Add actions to update dependency guard baselines
* Update baselines
* Better glob for update baselines action
11 months ago
Tomáš Mlynarič
44ae059a2b
Rename LocalTimeZone -> LocalZoneId + collects with lifecycle
...
Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3
11 months ago
Tomáš Mlynarič
cb00d2c8cb
Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers
...
This way, we can save ~1ms per composed item on screen.
Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d
11 months ago
Tomáš Mlynarič
395b9853df
Add Composition Tracing
...
Change-Id: I3ad60930de2fab71a700a0c2df3f0a1f566cafd8
11 months ago
Don Turner
f5b3ae56dc
Merge pull request #951 from SimonMarquis/issue-945
...
Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`
1 year ago
Don Turner
691bf2aad6
Merge pull request #785 from SimonMarquis/optimize-avd
...
Optimize AVD to fix long vector paths Lint warning
1 year ago
Simon Marquis
48fde2c3bf
Fix badging after merge
1 year ago
Simon Marquis
d9d9153eda
Merge branch 'main' into firebase-ktx
1 year ago
SimonMarquis
afdfd8acc5
🤖 Updates screenshots
1 year ago
Simon Marquis
377d3bef0c
Optimize AVD to fix long vector paths Lint warning
...
... with SVGOM, but you'll have to check on Android Studio the AVD diff.
https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html
1 year ago
Don Turner
707117a4f2
Merge branch 'main' into kotlinify
1 year ago
Don Turner
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
1 year ago
Don Turner
046831df36
Update dependency guard classpaths
...
Change-Id: I5f729bce92ec1cc9f71e34e42cbe38765966fc31
1 year ago
Simon Marquis
0699efc592
Merge branch 'main' into issue-945
1 year ago
Simon Marquis
be9dc533e3
Replace `Enum.values()` with `Enum.entries`
...
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
1 year ago
Don Turner
a5c030f740
Merge pull request #956 from KDW03/add_saved_test
...
Add Test for Saved Top Level Destination
1 year ago
Don Turner
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
1 year ago
Don Turner
9d41ffa318
Merge branch 'main' into kotlinify
1 year ago
Don Turner
ad15f0137e
Merge pull request #1094 from lihenggui/main
...
Upgrade Spotless and Ktlint and remove code convention violations
1 year ago
Don Turner
8d5ef578c6
Merge pull request #1103 from android/add_icon_comment
...
Add comment explaining why the launcher icon colors differ per build
1 year ago
Simon Marquis
b6d82e24df
Merge branch 'main' into kotlinify
1 year ago
Don Turner
b801a7deea
Moving comments to _after_ first XML element
...
Change-Id: Id4271a67ffcfbd712a2dd1f363970fcd31ee5ac0
1 year ago
lihenggui
2a2d8ed88d
Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE
1 year ago
Don Turner
d018e57f52
Fix spotless
...
Change-Id: I5dea4fec5b391e8cb7794af13e99978fcb622fbb
1 year ago
Don Turner
e6b5560f07
Revert "Move app screenshot tests to match dependencies declaration"
1 year ago
Don Turner
28bb3f1b2f
Add comment explaining why the launcher icon colors differ per build variant
...
Change-Id: I30126402370162ccbe53e177652583e4472f2030
1 year ago
Simon Marquis
83764082ff
Move app screenshot tests to match dependencies declaration
...
Fixes #990
1 year ago
lihenggui
32e1ec0447
Remove violations: property-naming
1 year ago
lihenggui
fb5bd225be
Spotless
1 year ago
Simon Marquis
2b739c0ffe
Fix badging, which is not "stable" when it comes to ordering
1 year ago
Simon Marquis
65a8b0d3b5
dependencyGuardBaseline
1 year ago
Simon Marquis
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
1 year ago
Simon Marquis
768738350b
Merge branch 'main' into firebase-ktx
1 year ago
Simon Marquis
32c3c3754d
updateProdReleaseBadging
...
See https://github.com/android/nowinandroid/pull/1006 for these new permissions and "Ad Services" property.
1 year ago
Jonathan Koren
392eaa3e61
Add dependencyGuard to AndroidApplicationConventionPlugin
...
Change-Id: Ib695ca18512d0ccde4c67e101f09ebbff8897912
1 year ago
Jonathan Koren
d15a203c59
Only record prodReleaseRuntimeClasspath configuration
...
Change-Id: I129fc4839ac2b4d5624c91cd25b47efba8847f44
1 year ago
Jonathan Koren
d5d5e3561f
Add dependency guard plugin
1 year ago
Simon Marquis
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
1 year ago
Simon Marquis
988002e692
Update Robolectric 4.11.1
...
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1
> Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below.
Removing explicit API 33 Robolectric configuration.
1 year ago
Miłosz Moczkowski
9c89e98e5b
Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold"
...
This reverts commit 335a7ec68c
, reversing
changes made to aa8ce0e1f6
.
1 year ago
mmoczkowski
f365e8b782
🤖 Updates screenshots
1 year ago
Miłosz Moczkowski
816a7b60c1
Replace manual navigation component switching with new NavigationSuiteScaffold
...
Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723
1 year ago
Ben Weiss
aa8ce0e1f6
Add automated baseline profile generation ( #880 )
...
Baseline profile generation is disabled for the PR level Build task. Release tasks require a fresh baseline profile. A new profile is generated using the baseline profile Gradle plugin.
* Prepare for usage of dex layout optimizations which can be actively used once NiA switches to AGP 8.2+.
* Add GMD config to release build
* Switch to macos-latest
* Update names for StartupBenchmark tests to better reflect states
* Stable release and recent GMD device
* Reduce flakiness by adding wait to benchmark
* More convenient waiting for objects
* Rename junit dependency to androidx-junit
* Only run baseline profile benchmarks during GH workflow
* Enable automatic BP generation for only release builds
* Disable BP generation from Build workflow
* Specify modules and skip benchmarking Build workflow
Bug: b/299334172
1 year ago
Don Turner
f3b2655e2f
Merge pull request #933 from danysantiago/main
...
Update to Hilt 2.48 and use the KSP version
1 year ago
Daniel Santiago
c908f989c8
Update to Hilt 2.48.1 and use the KSP version
...
* Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin.
* `@Binds` function cannot be an extension function.
* Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.
1 year ago
Jose Alcérreca
3f22248cb7
[CI] Better caching and fewer jobs run
...
* [CI] Runs build in macos to generate a cache for androidTest runs
* Build projects before running emulator
* Fixes flaky coroutines test
* Moves spotless up in local tests job
* Enables config cache by setting problems to warn. Fixes #1022
1 year ago
rosariopf
221b615690
remove ACCESS_ADSERVICES permissions
1 year ago
Don Turner
09304e2477
Add updated badging for prodRelease variant
...
Change-Id: Ibe71c285708ffec85520a0c7852600f361ed1646
1 year ago
Alex Vanyo
360b33eb82
Add automatic checks for badging
...
Change-Id: Ic8fca86d7aa84675fa91fb1aa99abcc6e19d663e
1 year ago
TM
d3d5b02428
Inline color values for app icons
1 year ago
TM
9b83237bfd
Removed Comments
1 year ago
TM
afb427b9c5
Use colors from design palette in build variant icons
1 year ago
TM
38d0c15d33
Create different icons for each build variant
...
Added color values for DEBUG and BENCHMARK build variants.
1 year ago
Jose Alcérreca
431069ab77
NiaAppScreenSizesScreenshotTests.kt: Fixes screenshot test showing wrong width ( #986 )
...
* FIxes screenshot test
* 🤖 Updates screenshots
1 year ago
Adetunji Dahunsi
0287af8d9a
Merge pull request #947 from android/tj/staggered-grid-feed
...
Use lazy vertical staggered grid in feed to maximize space utilization
1 year ago
Don Turner
a381d13199
Merge pull request #958 from McGalanes/main
...
Use typesafe project accessors
1 year ago
Melwin Magalhaes
6247712064
Add convention plugins to version catalogs
1 year ago
Melwin Magalhaes
b1266dc05a
Use typesafe project accessors for project modules
1 year ago
tunjid
b2498c763f
🤖 Updates screenshots
1 year ago
Simon Marquis
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
1 year ago
Simon Marquis
faf42aa133
Merge remote-tracking branch 'origin/main' into issue-945
1 year ago
kimdowoo
bc56ba79bc
Add Test for Saved Top Level Destination
1 year ago
Don Turner
e40fb7925d
Merge pull request #779 from SimonMarquis/java-to-kotlin-sourceset
...
Migrate from `java` to `kotlin` sourceSet directory
1 year ago
Simon Marquis
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
1 year ago
Simon Marquis
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
1 year ago
Simon Marquis
49a2fb5272
Fix wrong configuration name, leaking `work-testing` to runtime classpath
...
Typo introduced recently when Roborazzi was added to the project:
886158d3cb (diff-8cff73265af19c059547b76aca8882cbaa3209291406f52df1dafbbc78e80c46)
1 year ago
Simon Marquis
03ba943632
Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`
...
- Prevent logging multiple times (because of `onResume()` callback)
- Remove unnecessary io dispatcher: `ListenableFuture<T>.await()` is already main-safe and prevent acquiring io slot.
- Merge comments into a single javadoc comment on the `ProfileVerifierLogger` type.
- Add proper javadoc format with markdown specific blocks.
- Update logs & tag to be more uniform.
Closes #945
1 year ago
Jose Alcérreca
151f877bbe
Adds screenshot tests to :core:designsystem ( #931 )
...
* WIP: Adds screenshot tests to :core:designsystem
Change-Id: I0672845feba4064652dd8d60f07047b87864e121
* 🤖 Updates screenshots
* Creates tests for more components and cleans up
Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22
* WIP: More cleanup and more combinations of themes
Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523
* Added the rest of the screenshot tests for designsystem
Change-Id: Ic427db5491910781c038882055524e3f3dbed194
* Some more cleanup
Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180
* Spotless
Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6
* 🤖 Updates screenshots
* ScreenshotHelper cleanup
Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0
1 year ago