Aurimas
5ba16edde9
Apply spotless by default ( #2055 )
...
* Apply spotless by default
- Upgrades to spotless 8.2.1
- Moves spotless setup from an init.gradle.kts to build-logic
- Narrows down the scope of `target` in spotless configuration to
be more precise to workaround https://github.com/diffplug/spotless/issues/2717
- Updates all references to init.gradle.kts
Ran gradle-profiler ./gradlew build --dry-run to validate performance
impact.
Before PR:
Mean 10,527.96 ms with 289.01 ms std dev
After PR:
Mean 11,251.78 ms with 530.29 ms std dev
Regression is there, but quite minor.
Test: ./gradlew spotlessCheck
* Address comments from AI overlords
* Fix usage of rootProject
* Enable spotless for build-logic via root project
1 week ago
Jaehwa Noh
379956cb30
Merge pull request #2045 from Jaehwa-Noh/rename-package
...
Rename package properly
2 weeks ago
hoangchungk53qx1
3c5026065d
Refactor: Replace list initialization with emptyList() for clarity
7 months ago
Don Turner
b77f6f8da7
Refactor change to make it clearer when the deserialization workaround is required.
1 year ago
Jaehwa Noh
696bd7de62
Create `getDemoDataFromJson` method and use it.
...
Change-Id: I19336b061e74a378cc70470fbd6af8ee4c7533e0
1 year ago
Jaehwa Noh
5084e5c3d6
Revert exposed `readText` method.
...
Change-Id: I8076fabed4b4f2f460c74b43ad1c3e38a5268005
1 year ago
Jaehwa Noh
80172dcf82
Replace manual string converter to readText method.
...
Change-Id: If8cc6c27bd399fcdf8446ec411626f13d39e707c
1 year ago
Jaehwa Noh
301f7f5ad6
Pass new DemoAssetManager with open and readText methods.
...
Change-Id: I4b58c250e76f6d41e794087ff3b467fc61c88eca
1 year ago
Jaehwa Noh
9320d592b4
Override readText.
...
Change-Id: Ibf7fca9de5461e7285ed6d68092e36d70408f3bd
1 year ago
Jaehwa Noh
008b989397
Create readText method.
...
Change-Id: I15df6f18343bcf36d2d583a19cd47d6344942201
1 year ago
Jaehwa Noh
868bfad12d
Merge branch 'android-remote-main' into api-21
...
Change-Id: Iecf9c37a262bf6ae59953ac50bca2523bcab8843
# Conflicts:
# .github/workflows/Build.yaml
1 year ago
Don Turner
b478ceae54
Fix failing UI test, add unit test and refactor
1 year ago
Don Turner
ecfb5157dd
Improve test data and add UI test for topic chip
1 year ago
Simon Marquis
dc14461490
Update retrofit from 2.9.0 to 2.11.0
...
- Replace Jake Wharton's Kotlinx Serialization converter with new retrofit's `converter-kotlinx-serialization`.
- Remove custom Proguard rules that are now part of the dependency: https://github.com/square/retrofit/tree/trunk/retrofit-response-type-keeper#readme
Changelog: https://github.com/square/retrofit/blob/trunk/CHANGELOG.md
1 year ago
Jaehwa Noh
622ae698db
Remove `okio.use` and redundant length init.
...
Change-Id: Ibac659c7aff6d8be99f52d012d603f8251bbd23d
2 years ago
Jaehwa Noh
6a205b14a7
Add KDoC for convertStreamToString.
...
Change-Id: Idb7fc085e889f8012234d14ad7bc0a4713073d6e
2 years ago
Jaehwa Noh
29e514f359
Take capability below API 24, and add comment.
...
Change-Id: I86d99fa9e74a8475c0b2bad202cfb4697ab1016b
2 years ago
Jaehwa Noh
a928bf1c51
Create convertStreamToString.
...
Change-Id: I07dbb58813bc891f407773fddab7f1487f1ed24f
2 years ago
Jaehwa Noh
a888c87c5f
Below than api24,use decodeFromString
...
Change-Id: Icf428ebfe7e153e132e112c2dc6926bd40ab3951
2 years ago
Jaehwa Noh
3c70183ce6
Change name Fake to Demo.
...
Change-Id: Ife321dd95238227bfdfc1f13f6832472bd699b6f
2 years ago
Jaehwa Noh
2739168e33
Revert "Move main to demo."
...
This reverts commit a5be299e3d .
2 years ago
Jaehwa Noh
a5be299e3d
Move main to demo.
...
Change-Id: I48bb3c26ef02d6302cb7caabcaa17d5b4659031a
2 years ago
Jaehwa Noh
5d99f381e9
Remove VisibleForTesting.
...
Change-Id: Icd7005ec38495a1a4bc6f1594f70a2c1228538ab
2 years ago
Jaehwa Noh
27ca860745
Rename fake to demo.
...
Change-Id: I5b1d7963e623832a766900aa74ef1085aac0cacc
2 years ago
Tomáš Mlynarič
4cdc2ad345
Add comment for Retrofit async OkHttp
...
Change-Id: Ic7a6887b76caf26f00b58b0753271d426b67e75b
2 years ago
Tomáš Mlynarič
d110d92b87
Optimize OkHttp initialization for Retrofit
...
Change-Id: I347f1080ab5adf774a0cdd3c659cbf25c4820f9a
2 years ago
Tomáš Mlynarič
5f0612102d
Improve lazy loading for Coil + OkHttp
...
This way, we can load Coil's backend on a background thread and not block the MainThread with it.
Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames.
Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62
2 years ago
Don Turner
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
2 years ago
lihenggui
d671126f9e
Move @Suppress("ktlint:standard:max-line-length") to function scope
2 years ago
lihenggui
fb5bd225be
Spotless
2 years ago
Simon Marquis
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
2 years ago
Jonathan Koren
5482d81fdc
fixed for PR 985
2 years ago
Simon Marquis
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
2 years ago
Simon Marquis
c98e6236d5
Replace identical `InstantSerializer` with KotlinX datetime default serializer
2 years ago
Simon Marquis
0377fd8712
Replace `NewsResourceType` enum with simpler String type
...
See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901
3 years ago
Tatsuya Fujisaki
4eeb045287
Rename constants
3 years ago
İbrahim Ethem Şen
56f8a27132
Kotlin coding conventions places companion object at the bottom of the class
3 years ago
Simon Marquis
9499e559e7
Delete no longer used `AUTHORS_ASSET` reference
3 years ago
Márton Braun
bea2eecd90
Update Kotlin, Compose compiler, serialization versions
...
Change-Id: I2aa0d07769e79e6f85824a391418566aef6b721e
3 years ago
Yuri Schimke
4fa730098d
Fixes
...
Change-Id: Iedcafbf0ad7b853544b7b5b3f37685a0a868c2e6
3 years ago
Yuri Schimke
9e399b69ea
Improve network pooling and avoid startup image fetches.
...
Change-Id: If747fb0833d31ce7c9bedffd400160e979bc945e
3 years ago
Márton Braun
819dd494ad
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
3 years ago
Jolanda Verhoef
4ba63c0de8
Remove author concept from app
...
Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793
3 years ago
Miłosz Moczkowski
e653b738d2
Remove FakeDataSource
...
Change-Id: I5e1486feeade67f0f7276458187694e684310ad3
3 years ago
Simon Marquis
ee8eac34b8
Refactor `:core:network` DI
...
- Delete unused `NetworkModule` from benchmark sourceSet (contains unknowns references)
- Extract common bindings into a single `NetworkModule`
- Expose "flavored" bindings through `FlavoredNetworkModule`s
3 years ago
Simon Marquis
7e0bfb43fa
Add missing binding in NetworkModule
3 years ago
Simon Marquis
b5d342468e
Merge remote-tracking branch 'fork/main' into patch/assets-as-json-files
3 years ago
Simon Marquis
321b1602e1
Remove duplicated link
3 years ago
Simon Marquis
67dea1c136
Fix spotless issues
3 years ago
Simon Marquis
fbaa8eaff5
Migrate hard-coded JSON data into JSON assets files
...
JSON minification is no longer necessary since assets files are already gzipped during APK/AAB packaging.
Fixes #391
3 years ago