Simon Marquis
8ea9a8fa51
Android Lint improvements
...
- Create `LintConventionPlugin` to configure Lint on all compatible modules: Android applications, Android libraries and JVM modules.
- Run `lintProdRelease` in CI instead of the default `lintDemoDebug` which is less important compared to production code.
- Rearrange CI steps to make it more clear that Lint should is an additional step after build (build -> test -> lint).
- Enable SARIF support and upload results to GitHub's CodeQL to get inline feedback on PRs.
If we really need better perfs, we could restore `lint.checkDependencies = true` on the `:app` module and only execute `:app:lintProdRelease`.
But in practice, this does not change the total build time on this project.
2 years ago
Simon Marquis
502f9ed110
Remove `ExperimentalCoroutinesApi` and `FlowPreview` opt-in
...
```
> Task :core:model:compileKotlin
w: Opt-in requirement marker kotlinx.coroutines.ExperimentalCoroutinesApi is unresolved. Please make sure it's present in the module dependencies
w: Opt-in requirement marker kotlinx.coroutines.FlowPreview is unresolved. Please make sure it's present in the module dependencies
```
2 years ago
Tomáš Mlynarič
f577fb06cc
Add project path subfolder
...
Change-Id: I1b680a37ecbd80b894b0d1b649633936cbe41328
2 years ago
Tomáš Mlynarič
d549ca6c7a
Apply suggestions from code review
...
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
2 years ago
Tomáš Mlynarič
9f6a94dee2
Change folder for compose-reports
...
Change-Id: I7757f13c36c60991586224707f91f8ac8c0beae8
2 years ago
Neelansh Sahai
02bf1ac230
Merge pull request #725 from tsumuchan/main
...
Clarify dependencies of the included build-logic
2 years ago
Alex Vanyo
76b0b08121
Adjust JDK setup to remove toolchain
...
Change-Id: Ie0f43cb8f0fe504ed3e98ef35703949959688699
2 years ago
tsumuchan
e1025d8363
Update gradle plugin naming
2 years ago
Milosz Moczkowski
88b9e023d0
Merge pull request #692 from android/av/fix-jvm-target-comment
...
Fix JVM target comment
2 years ago
Simon Marquis
ddabba8e4a
Merge branch 'main' into jvmToolchain
2 years ago
Simon Marquis
4550743fac
Create and use CI specific group of GMD devices
...
This should reduce the total CI time of `AndroidCIWithGmd` workflow.
Using the matrix strategy at the GitHub Actions level forces us to run the tests sequentially and download/rebuild everything from scratch at each iteration.
2 years ago
Don Turner
2fd1b716f6
Merge pull request #667 from SimonMarquis/cleanup/warnings
...
Cleanup warnings and replace deprecated methods
2 years ago
Simon Marquis
57d1bed2cc
Disable unnecessary Android instrumented tests
2 years ago
Simon Marquis
f19dd06200
Remove deprecated `kotlin.Experimental` opt-in
...
This would produce the following warning messages:
```
w: Opt-in requirement marker kotlin.Experimental is unresolved. Please make sure it's present in the module dependencies
```
2 years ago
Simon Marquis
1921c6544d
Replace deprecated methods
2 years ago
Alex Vanyo
1998fc1a20
Fix JVM target comment
...
Change-Id: I9e62b796ed096f6cf586b51dc3a8e81f79c62e50
2 years ago
Takeshi Hagikura
e1bb03b33d
Set the source/target compatibility to 11
...
This is because up to Java 11 features are supported without requiring
minimum API level nor AGP versions at the moment as in
https://developer.android.com/studio/write/java11-minimal-support-table
2 years ago
Don Turner
e1ae12129a
Merge pull request #662 from android/av/agp-8.0
...
Update to AGP 8.0
2 years ago
Simon Marquis
80b8ae7a98
Don't rely on `finalizeDsl` API to configure Crashlytics
2 years ago
Alex Vanyo
4cdfaa93b2
Fix comment referring to 11
...
Change-Id: Ibef7bf42f60dd132535e70a7619958b242b7afe9
2 years ago
Alex Vanyo
e323c2155f
Remove unused imports in build-config
...
Change-Id: I9fa6da0490fd9dc43cf5ed21aaa770c76b461a55
2 years ago
Alex Vanyo
38260e5a86
Update to VERSION_17 everywhere
...
Change-Id: I3e75e8a833f45365657a24c4af652c2449af804c
2 years ago
Alex Vanyo
086dc957c0
Update to AGP 8.0
...
Change-Id: I27eb106e484e2003d732782a39612dc72c845282
2 years ago
Milosz Moczkowski
37908ec05c
Merge pull request #630 from drawers/david/delete-unnecessary-gradle-wrapper
...
Remove unnecessary copy of Gradle wrapper
2 years ago
David Rawson
973eb04d81
Remove unnecessary Gradle wrapper
2 years ago
Simon Marquis
8ec54d19d8
Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
2 years ago
Don Turner
36eeb19da8
Merge remote-tracking branch 'goog/main' into feb13-merge
...
* goog/main:
Revert "Revert "Revert "Revert "New build trigger""""
Bump versionCode to 5
Remove AD_ID permission
Add Firebase analytics. See go/nia-firebase-services.
Simplify build script
Copy local.properties during build
Fix exit codes
Remove .prod from the applicationIdSuffix in preparation for Play launch
Build aab with play services enabled
Build release artifacts separately, using google-services
Enable use-google-services in release builds
Revert "Revert "Revert "New build trigger"""
Revert "Revert "New build trigger""
Revert "New build trigger"
New build trigger
Increment internal build trigger
Adding a file which can be modified to trigger an internal build
Add Firebase dependencies
Remove API 23 from list of APIs to test in Firebase Test Lab (it's flaky)
Copy google-services.json from prebuilts folder
Change-Id: Ibc76e1b89c6c7e7f58843edb56581e169c9ce14e
2 years ago
Simon Marquis
ea7bcf33c5
Configure jvmToolchain for Android projects
2 years ago
Alex Vanyo
ded79e617e
Add Pixel C API 30 emulator to CI
...
Change-Id: If386c899496433d4e179111c0230905b36db7c50
2 years ago
Alex Vanyo
0d23e64848
Merge pull request #558 from android/av/gmd-convention-plugin
...
Switch GMD to use a convention plugin
2 years ago
Don Turner
4284e6912e
Merge remote-tracking branch 'github/main' into feb9automerger
...
* github/main:
Bump version to 4
Remove unused DropdownMenu component
Route topic chip tap events up to NiaNavHost
Apply suggestions from code review
Migrate custom room configuration into a convention plugin
Update docs/ArchitectureLearningJourney.md - User action follow topic
Update docs/ArchitectureLearningJourney.md - Writing data
Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea
2 years ago
Don Turner
e3e33d8497
Merge "Add Firebase analytics. See go/nia-firebase-services." into main
2 years ago
Don Turner
2a4d0434a5
Add Firebase analytics. See go/nia-firebase-services.
...
Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689
2 years ago
Automerger
8c3fcefad6
Merge branch 'github/main'
2 years ago
Don Turner
e997459f29
Merge pull request #562 from SimonMarquis/room/convention-plugin
...
Migrate custom room configuration into a convention plugin
2 years ago
Simon Marquis
0cf2f25edd
Upgrade JVM source/target compatibility to 11
2 years ago
Simon Marquis
3409f937ed
Migrate custom room configuration into a convention plugin
...
And use `CommandLineArgumentProvider` to avoid breaking cacheability: https://issuetracker.google.com/issues/132245929
2 years ago
Alex Vanyo
6146dd5576
Switch GMD to use a convention plugin
...
Change-Id: Ia4f94cd7533c9168752ee39e3f960108fe802ab4
2 years ago
Don Turner
19684abc5f
Remove .prod from the applicationIdSuffix in preparation for Play launch
...
Change-Id: I30f7120bf6ce3f101ca9fc1ad28d3cecf2048f9a
2 years ago
Automerger
beccdfe8f5
Merge branch 'github/main'
2 years ago
Alex Vanyo
1cce9aaae2
Update AGP to 7.4.0
...
Change-Id: I3bede0226f89e78c65b74968effc738796e10218
2 years ago
Ben Weiss
f316be1d69
Add Firebase dependencies
...
This sets up the project for using Firebase Crashlytics and
Performance Monitoring.
Change-Id: I8d14cfd2e5c2ba1911f2c3175adc20d6714addb6
2 years ago
Don Turner
cf053ade5a
Fix build warnings
2 years ago
mlykotom
7db33aa041
Refactor naming according to convention
...
Change-Id: Id74e2495d5909e4978247e0d7edfb5621b2064ff
2 years ago
mlykotom
b9c89952f1
Revert capitalization + add suppress
2 years ago
mlykotom
a1d7a90766
Rename Flavor -> NiaFlavor
2 years ago
mlykotom
6c1f8394d9
Fix flavors change
2 years ago
Simon Marquis
90dc300783
Migrate from JUnit assertions to Kotlin's test framework
...
Fixes #419
2 years ago
Don Turner
2dd2f83026
Remove applicationIdSuffix from demo variant, add it to prod instead
...
Change-Id: I890beefbd79de04a9f5fa1153eb8b1ab3ee6eaf4
2 years ago
Milosz Moczkowski
398c399c1c
Merge pull request #297 from android/av/remove-dolphin-preview-todos
...
Remove Preview TODOs for Dolphin
2 years ago
Don Turner
7a223f5d8e
Merge pull request #356 from android/jv/compose-bom
...
Update to new Compose release
2 years ago
Jolanda Verhoef
e7b2ed623e
Update to new Compose release
2 years ago
Manuel Vivo
a0b22d8ed2
Updates Navigation approach with new guidance ( #347 )
2 years ago
Don Turner
7ca17f68ed
Merge branch 'main' into av/remove-dolphin-preview-todos
2 years ago
Don Turner
4a4de7d6a4
Add domain layer. See go/nia-domain-layer for details.
...
Change-Id: I3f4684005e81fb9c4163bf59c7026dcff6e88dc4
2 years ago
Maximillian Leonov
f84471f0f9
Remove type-safe project accessors feature preview
2 years ago
Márton Braun
5fd5d17caf
Opt in to experimental kotlinx.serialization API locally
...
Change-Id: Ibc88151f5a8b7a3a82e2c0043839c1cb9e016bcf
2 years ago
Wojtek Kaliciński
4c64a05897
Update to AGP 7.3.0 stable
...
Enables Gradle configuration cache.
Fix "no name set for build-config" warning.
Fix printing of test APKs due to AGP 7.3 changes
Change-Id: I65ec0cb9eba3d047417fc512ffeb66d378ba0c75
2 years ago
Alex Vanyo
bfedf75665
Remove Preview TODOs for Dolphin
...
Change-Id: I35219c7dd6a902c43cd310dcaf8d0e2c2dbdec45
2 years ago
Wojtek Kaliciński
4683918cc7
Move spotless to init script
...
Also adds automatic git hooks installation
Change-Id: I18debbee43af27db7b95a4202f824fa87e186713
2 years ago
Wojtek Kaliciński
d0cff2b11c
Build cleanup
...
* Move Hilt setup to convention plugin
* Disable Hilt on modules where it's not needed
* Enable non-transitive R classes
* Fix `configuration` blocks called in wrong scope
* Move imperative Flavors code from build.gradle
* Disable unnecessary build features globally
* Disable configure-on-demand as it's not encouraged
* Don't use internal AGP packages in plugins
Change-Id: I1bee3e3fd0103054637b979a350f9fd2312ae8ba
2 years ago
Wojtek Kaliciński
d81aa055ee
Merge "Fix FTL test APKs resolution" into main
2 years ago
Wojtek Kaliciński
17afcf4302
Fix FTL test APKs resolution
...
Change-Id: I390cdf45df6d8fce5bf388a4fd495205ed407a0c
2 years ago
Alex Vanyo
2e0ebd84b4
Update compileSdk and targetSdk to API 33
...
Change-Id: I2e73265ab2b8a570712b3806913eaff1e17236ec
2 years ago
Alex Vanyo
d6555cbaa5
Merge pull request #269 from android/av/compose-tracing
...
Update Kotlin, Compose and add in the new runtime-tracing artifact
2 years ago
Alex Vanyo
ab15fa4445
Merge pull request #195 from android/renovate/gradle-7.x
...
Update dependency gradle to v7.5.1
2 years ago
Alex Vanyo
a60687ae73
Update Kotlin, Compose and add runtime-tracing
...
Change-Id: I1697541a70a47281424fa51dfe5cab78bf89a1f6
2 years ago
madroid
3bd81154b5
Move 'core-' module to core subfolder
2 years ago
renovate[bot]
76fc0ed6e5
Update dependency gradle to v7.5.1
2 years ago
Jolanda Verhoef
8ae2ce2e94
Merge pull request #236 from android/jv/fix-warnings-as-errors
...
Use GradleLocalProperties for reading warningsAsErrors
2 years ago
Jolanda Verhoef
eefe378347
Remove unused imports
2 years ago
Jolanda Verhoef
ac1471476a
Only use gradle.properties to read warningsAsErrors
2 years ago
Jolanda Verhoef
ce5875cef8
Read gradle property as string instead of boolean, gradle sync fails otherwise.
2 years ago
Jolanda Verhoef
87affa5593
Read warningsAsErrors from local.properties or gradle.properties, and default to false
2 years ago
Jolanda Verhoef
31b093e6de
Use GradleLocalProperties for reading warningsAsErrors from local.properties
2 years ago
Wojtek Kaliciński
aa5d254435
Use [plugins] block in version catalog
...
Change-Id: Ib2aa30405dfe8e5f5017f2f1b45e972d8e19ddca
2 years ago
Jolanda Verhoef
68dbf8c6e1
Merge pull request #177 from oheyadam/aa/included-build-gradle-properties
...
Add a gradle.properties file to the build-logic build
2 years ago
Manuel Vivo
88054edf90
Use collectAsStateWithLifecycle to safely collect uiState ( #166 )
2 years ago
Jolanda Verhoef
c35e530d92
Merge pull request #182 from android/compose-kotlin-version-updates
...
Update Compose compiler to 1.2.0, Kotlin to 1.7.0
2 years ago
Ben Weiss
ffd0ba9138
Merge pull request #145 from android/bw/initialMetrics
...
Add tracing and JankStats
2 years ago
Márton Braun
6df6f03c95
Update Compose compiler to 1.2.0, Kotlin to 1.7.0
2 years ago
Adam Ahmed
674364315f
Add a gradle.properties file to the build-logic project
2 years ago
Alex Vanyo
f48fa174d4
Merge pull request #135 from android/av/included-build-gradle-wrapper
...
Add duplicate Gradle wrapper to included build
2 years ago
Ben Weiss
9f929944d0
Address review comments
...
* Introduce gradle plugin for firebase perf
* Create TrackScrollJank composable to mask tracking code
2 years ago
Jolanda Verhoef
a81d2620bd
Merge pull request #125 from takahirom/add-compiler-metrics-option
...
Add compose compiler metrics option
3 years ago
Nick Rout
d05b573f52
Improve design system usage and add lint checks
...
Change-Id: I05f9400a9410e31bdf1534e458d560fe793b809f
3 years ago
takahirom
5290c0c188
Add last blank line
3 years ago
takahirom
d3ffb1f806
Move compose metrics parameters to Android Compose script
3 years ago
Alex Vanyo
2b8bda8677
Add duplicate Gradle wrapper to included build
...
Change-Id: Id76b61a4b486fcd19f1d3ca4c4ad4f29367fa5b9
3 years ago
takahirom
5c73cdd973
Add compose compiler metrics option
3 years ago
Jose Alcérreca
9dcc43c12c
Merge remote-tracking branch 'github/main'
...
Change-Id: Ib23a555860e276e62a369b90c087d434d38a44cb
3 years ago
Satyan Jacquens
7c761c5595
Keep targetSdk 31
3 years ago
Don Turner
eb1973052d
Add demo and prod product flavors. Remove staging variant.
...
Change-Id: I7d251d477ef1ee770096b9971099e0bf59cfa6ea
3 years ago
sjcqs
8878265f96
Apply used plugins in conventions
3 years ago
sjcqs
bb672151fd
Add copyrights
3 years ago
Satyan Jacquens
b7475311d5
Remove extra space
...
Co-authored-by: Alex Vanyo <vanyoalex@gmail.com>
3 years ago
satyan
35e6a5fd41
Make build-logic extension internal
...
Those extensions *will* be accessible in build.gradle.kts if not made internal.
They are used to configure the conventions plugins internally.
They should not be accessible by the consumer Gradle modules.
3 years ago
satyan
39a97cc5e9
Update build-logic README.md
3 years ago
satyan
555c4b4855
Replace gradle script with explicit convention plugins
3 years ago
kbuilder
6a211f194d
Merge branch 'github/main'
3 years ago