293 Commits (56b9871fae8428cd40a941af8561403362b82df5)

Author	SHA1	Message	Date
Tomáš Mlynarič	f8e797fd26	Rename currentTimezone variable ... Change-Id: I92630f6851b0253294a8d3ec2e5b3cbe7db74b4d	9 months ago
Tomáš Mlynarič	ea1573fcc1	Use kotlinx.datetime.Timezone instead of java ZoneId ... Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628	9 months ago
Tomáš Mlynarič	44ae059a2b	Rename LocalTimeZone -> LocalZoneId + collects with lifecycle ... Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3	9 months ago
Tomáš Mlynarič	cb00d2c8cb	Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers ... This way, we can save ~1ms per composed item on screen. Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d	9 months ago
Don Turner	f5b3ae56dc	Merge pull request #951 from SimonMarquis/issue-945 ... Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`	11 months ago
Don Turner	691bf2aad6	Merge pull request #785 from SimonMarquis/optimize-avd ... Optimize AVD to fix long vector paths Lint warning	11 months ago
SimonMarquis	afdfd8acc5	🤖 Updates screenshots	11 months ago
Simon Marquis	377d3bef0c	Optimize AVD to fix long vector paths Lint warning ... ... with SVGOM, but you'll have to check on Android Studio the AVD diff. https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html	11 months ago
Don Turner	707117a4f2	Merge branch 'main' into kotlinify	11 months ago
Simon Marquis	0699efc592	Merge branch 'main' into issue-945	11 months ago
Simon Marquis	be9dc533e3	Replace `Enum.values()` with `Enum.entries` ... 'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9	11 months ago
Don Turner	a5c030f740	Merge pull request #956 from KDW03/add_saved_test ... Add Test for Saved Top Level Destination	11 months ago
Don Turner	89d39a7242	Merge pull request #767 from SimonMarquis/resource-prefix ... Enforce `resourcePrefix` on Android library modules	11 months ago
Don Turner	9d41ffa318	Merge branch 'main' into kotlinify	11 months ago
Don Turner	ad15f0137e	Merge pull request #1094 from lihenggui/main ... Upgrade Spotless and Ktlint and remove code convention violations	11 months ago
Don Turner	8d5ef578c6	Merge pull request #1103 from android/add_icon_comment ... Add comment explaining why the launcher icon colors differ per build	11 months ago
Simon Marquis	b6d82e24df	Merge branch 'main' into kotlinify	11 months ago
Don Turner	b801a7deea	Moving comments to _after_ first XML element ... Change-Id: Id4271a67ffcfbd712a2dd1f363970fcd31ee5ac0	11 months ago
lihenggui	2a2d8ed88d	Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE	11 months ago
Don Turner	d018e57f52	Fix spotless ... Change-Id: I5dea4fec5b391e8cb7794af13e99978fcb622fbb	11 months ago
Don Turner	e6b5560f07	Revert "Move app screenshot tests to match dependencies declaration"	11 months ago
Don Turner	28bb3f1b2f	Add comment explaining why the launcher icon colors differ per build variant ... Change-Id: I30126402370162ccbe53e177652583e4472f2030	11 months ago
Simon Marquis	83764082ff	Move app screenshot tests to match dependencies declaration ... Fixes #990	11 months ago
lihenggui	32e1ec0447	Remove violations: property-naming	11 months ago
lihenggui	fb5bd225be	Spotless	11 months ago
Simon Marquis	caa482bc71	Kotlinify codebase ... - Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)	12 months ago
Simon Marquis	988002e692	Update Robolectric 4.11.1 ... - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11 - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1 > Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below. Removing explicit API 33 Robolectric configuration.	12 months ago
Miłosz Moczkowski	9c89e98e5b	Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold" ... This reverts commit 335a7ec68c, reversing changes made to aa8ce0e1f6.	12 months ago
mmoczkowski	f365e8b782	🤖 Updates screenshots	12 months ago
Miłosz Moczkowski	816a7b60c1	Replace manual navigation component switching with new NavigationSuiteScaffold ... Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723	12 months ago
Jose Alcérreca	3f22248cb7	[CI] Better caching and fewer jobs run ... * [CI] Runs build in macos to generate a cache for androidTest runs * Build projects before running emulator * Fixes flaky coroutines test * Moves spotless up in local tests job * Enables config cache by setting problems to warn. Fixes #1022	1 year ago
TM	d3d5b02428	Inline color values for app icons	1 year ago
TM	9b83237bfd	Removed Comments	1 year ago
TM	afb427b9c5	Use colors from design palette in build variant icons	1 year ago
TM	38d0c15d33	Create different icons for each build variant ... Added color values for DEBUG and BENCHMARK build variants.	1 year ago
Jose Alcérreca	431069ab77	NiaAppScreenSizesScreenshotTests.kt: Fixes screenshot test showing wrong width (#986) ... * FIxes screenshot test * 🤖 Updates screenshots	1 year ago
tunjid	b2498c763f	🤖 Updates screenshots	1 year ago
Simon Marquis	b2cd980170	Merge remote-tracking branch 'origin/main' into resource-prefix	1 year ago
Simon Marquis	faf42aa133	Merge remote-tracking branch 'origin/main' into issue-945	1 year ago
kimdowoo	bc56ba79bc	Add Test for Saved Top Level Destination	1 year ago
Simon Marquis	ebfe01affd	Enforce `resourcePrefix` on Android library modules ... ``` :ui-test-hilt-manifest -> ui_test_hilt_manifest_ :core:analytics -> core_analytics_ :core:common -> core_common_ :core:data -> core_data_ :core:data-test -> core_data_test_ :core:database -> core_database_ :core:datastore -> core_datastore_ :core:datastore-test -> core_datastore_test_ :core:designsystem -> core_designsystem_ :core:domain -> core_domain_ :core:network -> core_network_ :core:notifications -> core_notifications_ :core:testing -> core_testing_ :core:ui -> core_ui_ :feature:bookmarks -> feature_bookmarks_ :feature:foryou -> feature_foryou_ :feature:interests -> feature_interests_ :feature:search -> feature_search_ :feature:settings -> feature_settings_ :feature:topic -> feature_topic_ :sync:sync-test -> sync_test_ :sync:work -> sync_work_ ```	1 year ago
Simon Marquis	a33dafccad	Migrate from `java` to `kotlin` sourceSet directory	1 year ago
Simon Marquis	03ba943632	Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication` ... - Prevent logging multiple times (because of `onResume()` callback) - Remove unnecessary io dispatcher: `ListenableFuture<T>.await()` is already main-safe and prevent acquiring io slot. - Merge comments into a single javadoc comment on the `ProfileVerifierLogger` type. - Add proper javadoc format with markdown specific blocks. - Update logs & tag to be more uniform. Closes #945	1 year ago
Jose Alcérreca	151f877bbe	Adds screenshot tests to :core:designsystem (#931) ... * WIP: Adds screenshot tests to :core:designsystem Change-Id: I0672845feba4064652dd8d60f07047b87864e121 * 🤖 Updates screenshots * Creates tests for more components and cleans up Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22 * WIP: More cleanup and more combinations of themes Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523 * Added the rest of the screenshot tests for designsystem Change-Id: Ic427db5491910781c038882055524e3f3dbed194 * Some more cleanup Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180 * Spotless Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6 * 🤖 Updates screenshots * ScreenshotHelper cleanup Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0	1 year ago
Milosz Moczkowski	851ca6388e	Merge pull request #868 from SimonMarquis/patch-4 ... Handle topic clicks from all destinations	1 year ago
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876) ... * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	1 year ago
Simon Marquis	b7799f0475	Convert 'sealed' sub-object to 'data object'	1 year ago
Alex Vanyo	a3ee09ec3e	Merge pull request #817 from android/av/enable-edge-to-edge ... Switch to new Activity.enableEdgeToEdge	1 year ago
Simon Marquis	d8a6d0de13	Replace NiaNetworkDataSource with TopicsRepository ... to be closer to the actual source of data used by the instrumented app.	1 year ago
Simon Marquis	57f3700980	Select last topic by name instead of a random one	1 year ago
Simon Marquis	64f81751b3	Handle topic clicks from all destinations ... Closes #865	1 year ago
Alex Vanyo	2b218b97d9	Switch to new Activity.enableEdgeToEdge ... Change-Id: I9bbb7b2d116099524525619714ef18448e707c4f	1 year ago
Simon Marquis	0a1f333fc6	Update NavigationTest.kt	1 year ago
Simon Marquis	bf5fdb4cf8	Update NavigationTest.kt	1 year ago
Simon Marquis	250850cf9b	Remove hardcoded topic names in `NavigationTest.kt`	1 year ago
Simon Marquis	ba82b06cc3	Fix Lint `RememberReturnType` issue with explicit type	1 year ago
Milosz Moczkowski	04d3da39b9	Merge pull request #809 from SimonMarquis/launcher-icon-dark-theme ... Extract launcher icon tints and provide `-night` alternatives	1 year ago
Murat Yener	e96dac39b2	changed from ListenableFuture.get() to ListenableFuture.await()	1 year ago
Murat Yener	78ed9adca2	spotless fix	1 year ago
Murat Yener	7b5c0f2be8	Adds ProfileViewer to log the app's Baseline Profile Compilation Status	1 year ago
Simon Marquis	cf64e25ad5	Extract launcher icon tints and provide `-night` alternatives ... Implements #805	1 year ago
James Rose	7826b4f5f2	Merge pull request #748 from SimonMarquis/fix/permissions ... Grant `POST_NOTIFICATIONS` permission in more instrumented tests	1 year ago
Miłosz Moczkowski	7b30720b25	Remove nested scaffold from the bookmarks screen ... Change-Id: Ie8b6f160d341156a6f9c02c0ca7f530095fb2950	1 year ago
Miłosz Moczkowski	479a2f00b0	Refactor icons	1 year ago
Miłosz Moczkowski	ded8b109b9	Refactor custom notificationDot modifier ... Change-Id: Ife24492a495b111f111a8bd16f21b7ebd469e5aa	1 year ago
Simon Marquis	823c4db201	Grant `POST_NOTIFICATIONS` permission in more instrumented tests ... Continues the work initiated in #738. Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.	1 year ago
James Rose	a68eedebfa	Merge pull request #713 from android/jr/settings-dialog-state ... Save the showSettingsDialog flag in instance state	2 years ago
James Rose	62a77321d3	Save the showSettingsDialog flag in instance state ... This prevents the settings dialog from being dismissed when the device is rotated.	2 years ago
TJ Dahunsi	ef97cb941c	Route notification deep link through for you screen	2 years ago
Milosz Moczkowski	553f55f978	Merge pull request #679 from SimonMarquis/patch-3 ... Simplify String resource loading in `NavigationTest.kt`	2 years ago
Takeshi Hagikura	b3cdc172cd	Implement search feature (#685) ... Implement search feature - Add a feature module named "search" - Add a SearchScreen that is navigated by tapping the search icon at the top left corner - Add a data layer that takes care of populating the *Fts tables and querying them by a search query - Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen The SearchScreen has following features: - The user is able to type the search query in the TextField - The search result is displayed as the user types - When the search result is clicked, it navigates to: - The InterestsScreen when a topic is clicked - Chrome custom tab with the URL of the clicked news resource - When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches - Latest recent searches are displayed in the SearchScreen	2 years ago
Simon Marquis	3a810f015b	Remove unused variables	2 years ago
Simon Marquis	091abad348	Simplify String resource loading in NavigationTest.kt	2 years ago
James Rose	b49767a88c	Rename getUserNewsResources to observeAll	2 years ago
James Rose	57c13d84bd	Incorporate code review changes: Move UserNewsResourceRepository to data ... module; move UserNewsResource to model module. Implement unread dot for bookmarked articles. Keep the flows cold in UserNewsResourceRepository.	2 years ago
James Rose	ebfbb5bafd	Display unread state on the news feed and bottom nav bar ... When a news resource is unread, display a dot on its card in the news feed. When the For You section has unread resources, display a dot on its icon in the navigation bar. Update the read status when a resource is opened.	2 years ago
Alex Vanyo	01b5f34eb3	Update to Compose Material 3 1.1.0-alpha06 ... Change-Id: I6399358ad85254243b5aff547e31e3abe92fb6ed	2 years ago
Alex Vanyo	874c2d1487	Merge pull request #561 from SimonMarquis/update/androidx-lifecycle ... Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05	2 years ago
Caren	6a5feb767e	Merge pull request #582 from yschimke/loaders ... Improve network pooling and avoid startup image fetches.	2 years ago
Simon Marquis	4d4f7d4a15	Merge remote-tracking branch 'origin/main' into update/androidx-lifecycle	2 years ago
Yuri Schimke	9e399b69ea	Improve network pooling and avoid startup image fetches. ... Change-Id: If747fb0833d31ce7c9bedffd400160e979bc945e	2 years ago
Don Turner	79da80756e	Merge "Remove AD_ID permission" into main	2 years ago
Don Turner	11a4bbaa48	Remove AD_ID permission ... Change-Id: Iaf691c8ff1e8fbbbcd39b068d8bfdc29c8f6a58c	2 years ago
Don Turner	4284e6912e	Merge remote-tracking branch 'github/main' into feb9automerger ... * github/main: Bump version to 4 Remove unused DropdownMenu component Route topic chip tap events up to NiaNavHost Apply suggestions from code review Migrate custom room configuration into a convention plugin Update docs/ArchitectureLearningJourney.md - User action follow topic Update docs/ArchitectureLearningJourney.md - Writing data Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea	2 years ago
Márton Braun	322ff63dbc	Route topic chip tap events up to NiaNavHost ... Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7	2 years ago
Don Turner	e3e33d8497	Merge "Add Firebase analytics. See go/nia-firebase-services." into main	2 years ago
Don Turner	2a4d0434a5	Add Firebase analytics. See go/nia-firebase-services. ... Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689	2 years ago
Simon Marquis	f9a3533df3	Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05 ... > `Transformations` is now written in Kotlin. This is a *source incompatible change* for those classes written in Kotlin that were directly using syntax such as `Transformations.map` > Kotlin code *must* now use the Kotlin extension method syntax that was previously only available when using `lifecycle-livedata-ktx`. > The `collectAsStateWithLifecycle()` APIs of `lifecycle-runtime-compose` are no longer in experimental status. (I09d42, b/258835424) Changelog: https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.0-alpha05	2 years ago
Alex Vanyo	b72d0fe1af	Fix settings dialog dismissed test on non-portrait phones ... Change-Id: I15ed475915fdef198029db2713b6f619da374cc7	2 years ago
Alex Vanyo	9b6695d8dd	Remove unused import ... Change-Id: I426995db727995c7af6d34082593b078756a3f9d	2 years ago
Alex Vanyo	b4de09d0b2	Use only width to determine navigation UI ... Change-Id: Icad00b9a3eecac9762f6c6b7c3790e8cf1c161d6	2 years ago
Márton Braun	819dd494ad	Run Spotless to add trailing commas (and apply other rule updates) ... Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209	2 years ago
Angie Sasmita	cfbf782613	Merge pull request #542 from android/as/dynamic-color-option ... Add dynamic color option in settings for API >=32	2 years ago
mlykotom	6b48b355cc	Merge branch 'main' into tm/fix-benchmarks-no-people ... Change-Id: I94ca19fad5527c11a2f0f28cc43a23ab22f419a7	2 years ago
Angie Sasmita	6046f6e943	Add dynamic color option in settings for API >=32 ... Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6	2 years ago
Harshit Pandey	c96ff9e3c8	Coil refrence url fixed	2 years ago
Muhammad Anas Shamsi	43bb4359f5	Revert "Add link of source code in app" ... This reverts commit 197f4a5157.	2 years ago
Muhammad Anas Shamsi	197f4a5157	Add link of source code in app	2 years ago
Muhammad Anas Shamsi	f3f01c3d2f	Typo fix for compact	2 years ago
Don Turner	0917cdebec	Refactor NiaGradientBackground to accept GradientColors ... Change-Id: I55840b22e123490097710570bf11554554df90f9	2 years ago