4fb667ffd1
Revert "Move internal modifier to the object to work around build errors"
...
This reverts commit fd939d5a48
3 days ago
269f445848
Merge remote-tracking branch 'origin/main' into agp-9
1 month ago
8f269ff57a
Fix module graph generation.
1 month ago
06fe6698f3
Remove VisibleForTesting
2 months ago
fd939d5a48
Move internal modifier to the object to work around build errors
...
`error: cannot find symbol` on:
- `DataStoreModule.INSTANCE.providesUserPreferencesDataStore$datastore_demoDebug`
- `SyncModule.Companion.provideFirebaseMessaging$work_prodDebug()`
3 months ago
17162dab60
graphUpdate
4 months ago
1c61be7b7b
Update color mapping
...
| Type | Plugin ID | Color |
|-------------|------------------------------------|------------------------|
| Application | `nowinandroid.android.application` | `#CAFFBF` PastelGreen |
| Feature | `nowinandroid.android.feature` | `#FFD6A5` PastelOrange |
| Library | `nowinandroid.android.library` | `#9BF6FF` PastelBlue |
| Test | `nowinandroid.android.test` | `#A0C4FF` PastelMauve |
| JVM | `nowinandroid.jvm.library` | `#BDB2FF` PastelPurple |
| Unknown | `?` | `#FFADAD` PastelRed |
4 months ago
e8dc43b58b
graphUpdate
4 months ago
e079e68815
Delete old graphs
4 months ago
5820b0e86c
Add safe call to WorkInfo (again)
1 year ago
238461d428
Add safe call to WorkInfo
1 year ago
d56e06e676
Merge Android & JVM plugins into a single `HiltConventionPlugin`
2 years ago
e71ce1fc00
Merge remote-tracking branch 'origin/main' into jvm-alt
2 years ago
837dac809c
Merge branch 'main' into rpf-update-firebase-ktx
2 years ago
3dbca86a37
Merge remote-tracking branch 'origin/main' into jvm-alt
2 years ago
4496627c65
Upgrade AGP to 8.4.0, Android Build Tools to 31.4.0, and Gradle to 8.7.
2 years ago
ead3f49f7b
Fixes flakiness in app's screenshot tests ( #1395 )
...
* Disables WM init in app's screenshot tests
Change-Id: Ib0994e744f49b53f58c0eebd52f80c0eba67bbed
* Spotless
Change-Id: Ic0212889354481433ce45ec4292ae7be9bd24b2e
* [CI] Uploads roborazzi reports if they fail
Change-Id: I5a25a7e156d3fcb72a396d3b503e62068a20b417
* Uses unused test module and enables LocalInspection
Change-Id: Iac36347dc3d702248d7515a74823e0bc0cbf2a2b
* Fixes timezone in snackbar screenshot tests
Change-Id: Ic517e8822218abeaddd3f8d2740b03e651d72d31
* Fixes conflict
Change-Id: Ia42fb78781d2469a608183594fc25c7c69f7e76c
* 🤖 Updates screenshots
2 years ago
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
2 years ago
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
2 years ago
1d91231f49
Remove kotlinx-coroutines-guava dependency from :sync:work
...
Change-Id: Ic5abbd36436a7d8c6382cb02b4ebd7538f8ae1f6
2 years ago
06104076b2
Add explicit guava-android dependency for :sync:work
...
Change-Id: I3c2c201eb0669165e3594bedfea83bff29c28ce2
2 years ago
61c7d71870
Migrate `:core:common` to pure JVM module
...
The notification icons are now stored in `:core:notifications`.
This forces `:sync:work` to depend on it.
Another solution could be to provide the resource id through Hilt, but it would require more changes.
2 years ago
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
2 years ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
2 years ago
32e1ec0447
Remove violations: property-naming
2 years ago
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
2 years ago
c908f989c8
Update to Hilt 2.48.1 and use the KSP version
...
* Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin.
* `@Binds` function cannot be an extension function.
* Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.
2 years ago
9f26813697
upgrade to Firebase BoM 32.5.0 and drop Firebase KTX
2 years ago
12b56b81a0
Merge pull request #953 from SimonMarquis/fix/warnings-SyncNotificationsService
...
Declare `SyncNotificationsService` only in `prod` sourceSet
2 years ago
a381d13199
Merge pull request #958 from McGalanes/main
...
Use typesafe project accessors
2 years ago
6247712064
Add convention plugins to version catalogs
2 years ago
b1266dc05a
Use typesafe project accessors for project modules
2 years ago
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
2 years ago
3eb835ae08
Declare `SyncNotificationsService` only in `prod` sourceSet
...
And move Firebase Messaging dependency to the appropriate configuration.
Relates to #360
```
nowinandroid/app/src/main/AndroidManifest.xml Warning:
meta-data#com.google.samples.apps.nowinandroid.sync.initializers.SyncInitializer was tagged at AndroidManifest.xml:0 to remove other declarations but no other declaration present
```
2 years ago
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
2 years ago
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
2 years ago
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
2 years ago
4eeb045287
Rename constants
2 years ago
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
2 years ago
3c5e83ce25
PR feedback
...
Change-Id: I894e1b5ebb150740bc88e4e255955a049f3db053
3 years ago
ac56e742a4
Consume Flows from WorkManager for work status
...
Change-Id: Ia8002a7b74405de51a37921d3aaec91fc92d3773
3 years ago
c364dfc84e
Update message sender in SyncNotificationsService
3 years ago
b3cdc172cd
Implement search feature ( #685 )
...
Implement search feature
- Add a feature module named "search"
- Add a SearchScreen that is navigated by tapping the search icon at the top left corner
- Add a data layer that takes care of populating the *Fts tables and querying them by a search query
- Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen
The SearchScreen has following features:
- The user is able to type the search query in the TextField
- The search result is displayed as the user types
- When the search result is clicked, it navigates to:
- The InterestsScreen when a topic is clicked
- Chrome custom tab with the URL of the clicked news resource
- When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches
- Latest recent searches are displayed in the SearchScreen
3 years ago
73a38720d8
Merge pull request #649 from android/tj/backend-requested-sync
...
Wire up backend requested sync
3 years ago
05be2855d8
Wire up backend requested sync
...
Change-Id: I1d4485b589c7e94527a2a02f371cd3f030231622
3 years ago
489502ba13
Initialize sync manually
...
Change-Id: Ia26b1179270a87d3b87a915185b8d5fc7532c464
3 years ago
08956492c8
Backend triggered sync
...
Change-Id: I53c43b136ebb755f6258b1e815301dddb3b536a3
3 years ago
8ec54d19d8
Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
3 years ago
874c2d1487
Merge pull request #561 from SimonMarquis/update/androidx-lifecycle
...
Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05
3 years ago
2a4d0434a5
Add Firebase analytics. See go/nia-firebase-services.
...
Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689
3 years ago
Simon Marquis
Don Turner
Don Turner
lihenggui
Jose Alcérreca
Alex Vanyo
Daniel Santiago
rosariopf
Melwin Magalhaes
Simon Marquis
Tatsuya Fujisaki
TJ Dahunsi
Adetunji Dahunsi
Takeshi Hagikura