Milosz Moczkowski
24c094c756
Merge pull request #896 from SimonMarquis/SimonMarquis-patch-1-1
...
Update note rendering with new GitHub callouts
1 year ago
Milosz Moczkowski
434bbbd8d1
Merge pull request #898 from SimonMarquis/run-configuration
...
Create `spotlessApply` permanent run configuration
1 year ago
Milosz Moczkowski
928833fe5d
Merge pull request #889 from RivanParmar/main
...
Rename SearchResult.kt.kt to SearchResult.kt
1 year ago
Milosz Moczkowski
89a1294c63
Merge branch 'main' into takahirom/rename-topicBody/2023-07-13
1 year ago
Jose Alcérreca
6c0d6ad82e
Fixes icons size in onboarding and restores LocalInspection for images ( #909 )
...
* Fixes icons size in onboarding and restores LocalInspection for images
1 year ago
Don Turner
6645ec9fce
Merge pull request #902 from SimonMarquis/resource-type-to-string
...
Replace `NewsResourceType` enum with simpler String type
1 year ago
Simon Marquis
0ced769999
Widen `isNotEmpty` with `isNotBlank` to potentially catch blank values
1 year ago
Simon Marquis
4a5ec5bd82
Update `var` with fake default value to the more "correct" `lateinit var`
1 year ago
Simon Marquis
f1bc6f1226
Restore `Unknown` type as empty `String`
1 year ago
Simon Marquis
c831dc673c
Fix broken text
1 year ago
Simon Marquis
daa2228132
Restore original `type` labels
1 year ago
Simon Marquis
480d8e7d7c
Fix missing removal
1 year ago
Simon Marquis
553b01fcb6
spotlessApply
1 year ago
Simon Marquis
0377fd8712
Replace `NewsResourceType` enum with simpler String type
...
See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901
1 year ago
Simon Marquis
77bd542865
Create `spotlessApply` permanent run configuration
...
This will help devs run the right command, and it's easier to find.
1 year ago
Simon Marquis
a1a6fb81cf
Add syntax highlighting on Compose compiler metrics code block
1 year ago
Simon Marquis
1462a1e658
Update note rendering with new GitHub callouts
...
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts
1 year ago
Adetunji Dahunsi
153b34fd50
Merge pull request #850 from qamarelsafadi/loading-progress-for-image
...
Fix #849 : Loading progress for image
1 year ago
Simon Marquis
24ee5f539f
Update KSP 1.9.0-1.0.13
...
Changelog: https://github.com/google/ksp/releases/tag/1.9.0-1.0.13
1 year ago
Simon Marquis
fce6659ca6
Update protobuf 3.24.0 and protobuf plugin 0.9.4
...
- https://github.com/protocolbuffers/protobuf/releases/tag/v24.0
- https://github.com/google/protobuf-gradle-plugin/releases/tag/v0.9.4
- Avoid eagerly resolving input files in ProtobufExtract. This bug would cause a lot of invalidations of configuration cache when upgrading to Gradle 8.1. (#719 )
- Fix plugin compatibility with Kotlin Gradle Plugin 1.9.0 release. (#721 )
1 year ago
Simon Marquis
22ff97b3ae
recheck
1 year ago
RivanParmar
9e1d46e28c
Rename SearchResult.kt.kt to SearchResult.kt
1 year ago
Don Turner
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
1 year ago
Don Turner
246200f163
Merge pull request #754 from android/tm/metrics-one-folder
...
Compose compiler metrics saved into one folder
1 year ago
qamarelsafadi
308f51f87d
Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
1 year ago
Qamar A. Safadi
2db3e0c804
Merge branch 'android:main' into loading-progress-for-image
1 year ago
qamarelsafadi
5d7e33d905
fix formatting
1 year ago
Don Turner
e96e54f7de
Merge pull request #806 from SimonMarquis/objenesis
...
Remove forced resolution strategy
1 year ago
Don Turner
8901e5932a
Merge pull request #872 from SimonMarquis/data-objects
...
Convert 'sealed' sub-object to 'data object'
1 year ago
Don Turner
0e13207a40
Merge pull request #874 from SimonMarquis/string-decoder
...
Replace StringDecoder injection with simpler API
1 year ago
qamarelsafadi
f203e9a218
feat: replacing SubcomposeAsyncImage as its not recommended to use with lazyLayout
1 year ago
Qamar A. Safadi
5abc69fb49
Merge branch 'android:main' into loading-progress-for-image
1 year ago
Simon Marquis
0418997f5a
Extract `UTF-8` character encoding
1 year ago
Don Turner
e03294bad5
Merge pull request #871 from SimonMarquis/patch-1
...
Update README.md to mention `prodRelease` variant
1 year ago
Don Turner
4d0efef3b4
Merge pull request #879 from tatsuyafujisaki/rename-constants
...
Rename constants
1 year ago
Tatsuya Fujisaki
f6d62f999c
1 year ago
Adetunji Dahunsi
d685f46309
Merge pull request #884 from alizera/fix_animation_label
...
fix: add label to animations for fixing lint issue
1 year ago
AlirezaJoon
a23ffab602
fix: add label to animations for fixing lint issue
1 year ago
Qamar A. Safadi
8aa0457ca9
Merge branch 'android:main' into loading-progress-for-image
1 year ago
Adetunji Dahunsi
0a20cb729b
Merge pull request #877 from android/tj/scrollbars
...
Update feedItemsSize calculation
1 year ago
Tatsuya Fujisaki
4eeb045287
Rename constants
1 year ago
Adetunji Dahunsi
ec53d03854
Merge pull request #722 from android/tj/scrollbars
...
Add scrollbars to app
1 year ago
dahunsi
03610d229a
Update feedItemsSize calculation
...
Change-Id: I2bf6a2fa0e210cef1318707d948a49d2ef010452
1 year ago
Simon Marquis
e8449112b4
Replace StringDecoder injection with simpler API
...
The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String.
For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`).
Unit tests would fail because Uri is not mocked (since we are not using Robolectric).
Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc.
FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded".
The solution to this problem was to simply use regular Java APIs:
- `URLDecoder.decode(urlEncodedTopicId, "UTF-8")`
- `URLEncoder.encode(topicId, "UTF-8")`
1 year ago
Simon Marquis
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
1 year ago
Simon Marquis
b7799f0475
Convert 'sealed' sub-object to 'data object'
1 year ago
Simon Marquis
72788223d2
Update README.md to mention `prodRelease` variant
...
and remove the "in open beta" now that it has been published.
1 year ago
qamarelsafadi
5bbcc904e9
feat: make painter in one line
1 year ago
qamarelsafadi
3595d8dcb5
feat: move the placeholder default value to the method
1 year ago
Qamar A. Safadi
9f3103c212
Merge branch 'android:main' into loading-progress-for-image
1 year ago