5b99313ae5
fix typo
...
Change-Id: I65dcde81c68c24bfd58f0b66c6ed826e802aff67
2 weeks ago
8bb823ede7
use backgroundScope
...
Change-Id: I78d5e53d343dac7e7d27896c95714a53a9a7229a
2 weeks ago
94f86b7975
fix test name and typo, and user assertion instead of check method
...
Change-Id: I45e04df676fe9f5e5e893a1fc6e8f54e9e7d7a1a
2 weeks ago
d372d6ecec
improve BookmarksViewModelTest coverage
...
Change-Id: Ide13abd9a125a337ba9c9fff2136221e16ebd46e
2 weeks ago
bf54ccc760
feat: use androidx.lifecycle.compose.LocalLifecycleOwner
...
Change-Id: If0a414ee4d5aab277fb90343ba7d5aa6a9dbd2e8
2 months ago
26dd4424f6
remove blank lines for resolve spotless error
4 months ago
0356b873e9
change collectJob to backgroundScope coroutine
4 months ago
00efda54e8
Merge branch 'main' into dt/nav-safe-args
...
* main: (58 commits)
Instrumented tests for InterestsListDetailScreen (#1518 )
Remove Firebase AD_SERVICE_CONFIG property
updateProdReleaseBadging
Merge Android & JVM plugins into a single `HiltConventionPlugin`
Update dependency guard
🤖 Updates baselines for Dependency Guard
Update to Lifecycle 2.8.3
Add android.adservices.AD_SERVICES_CONFIG to badges
Apply suggestions from code review
Update app/src/main/AndroidManifest.xml
generateModuleGraphs
dependencyGuardBaseline
updateProdReleaseBadging
Fix spotless.
Change set to `=` operator
Cleanup unused reference in `libs.versions.toml`
Regenerate SVG graphs
Update comment wording
Use stdin to avoid repeating the output file name
Replace bash commands with proper svgo cli
...
Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5
4 months ago
da8f32a2ea
Rename Destinations to Routes
...
Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7
7 months ago
924391cd22
Fix spotless
...
Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428
8 months ago
89163b5ea1
Migrate remainder of app to type-safe navigation
...
Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b
8 months ago
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
9 months ago
78c77737c0
Merge pull request #1275 from Jaehwa-Noh/rename-function
...
Rename function to setNewsResourceBookmarked
10 months ago
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
10 months ago
ee4320723f
Fix typo.
...
Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f
10 months ago
ed91723e2f
Fix #1270
...
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
10 months ago
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
10 months ago
2ad48843f6
Fix formatting
...
Change-Id: I674d32bc0f1921c431717dbf0f41a74f632322b3
10 months ago
254b464259
Update Lifecycle to 2.7.0. Use new LifecycleEventEffect.
...
Change-Id: I71e7aa521f22499fd3f3e9f3ac7c81658f3abc3a
11 months ago
707117a4f2
Merge branch 'main' into kotlinify
1 year ago
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
1 year ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
1 year ago
6cd5958665
Update feature/bookmarks/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/bookmarks/navigation/BookmarksNavigation.kt
1 year ago
9d41ffa318
Merge branch 'main' into kotlinify
1 year ago
32e1ec0447
Remove violations: property-naming
1 year ago
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
1 year ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
1 year ago
9c89e98e5b
Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold"
...
This reverts commit 335a7ec68caa8ce0e1f6
1 year ago
816a7b60c1
Replace manual navigation component switching with new NavigationSuiteScaffold
...
Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723
1 year ago
0287af8d9a
Merge pull request #947 from android/tj/staggered-grid-feed
...
Use lazy vertical staggered grid in feed to maximize space utilization
1 year ago
6247712064
Add convention plugins to version catalogs
1 year ago
03d2455f41
Use lazy vertical staggered grid in feed to maximize space utilization
...
Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926
1 year ago
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
1 year ago
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
1 year ago
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
1 year ago
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
1 year ago
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
1 year ago
e13e84c155
Replace usages of 'displacement' to 'moved' in parameter names
...
Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a
1 year ago
eeb4973265
PR feedback
...
Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f
1 year ago
bdf3ee3cb0
PR feedback
...
Change-Id: Ie22aa3c7fdf4c8ca8d8118837cfd279de8c6d80b
1 year ago
cb1d50e65e
Even better names
...
Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65
1 year ago
3aec705048
Add padding to scrollbars
1 year ago
31b4841cb2
Add scrollbars to app
1 year ago
7b30720b25
Remove nested scaffold from the bookmarks screen
...
Change-Id: Ie8b6f160d341156a6f9c02c0ca7f530095fb2950
2 years ago
9aba5cc0fe
Cleanup unused string resources
2 years ago
d6ba65c77f
Update `BookmarksGrid` horizontal spacing to fix #732
2 years ago
bf747434cd
Add Undo snackbar on Bookmark removal
...
Change-Id: I1fefd6e72378e26ae35b66e032529a116cff9a79
2 years ago
050db2cb72
Merge branch 'main' into jr/track-viewed
2 years ago
b49767a88c
Rename getUserNewsResources to observeAll
2 years ago
049750dd51
Merge branch 'main' into ui-polish
2 years ago
hiroaki404
blue928sky
saeedishayan76
Don Turner
Simon Marquis
Alex Vanyo
Jaehwa Noh
Don Turner
lihenggui
Miłosz Moczkowski
Adetunji Dahunsi
Melwin Magalhaes
dahunsi
Simon Marquis
TJ Dahunsi
Neelansh Sahai
James Rose
Chris Sinco