392 Commits (2ade8c8f1c94b3352864b63327382b1d9c9253f8)

Author	SHA1	Message	Date
Ben Weiss	f64f1c0aa2	Remove legacy benchmark build type (#1207) ... * Remove legacy benchmark build type Now that we have the baseline profile gradle plugin, there is no need for a benchmark build type. The plugin does the setup and configuration and runs against the correct app flavor. * Remove explicit benchmark build type from benchmark module * Remove stale build task exclusions * Fix tracing import location FYI @mlykotom	6 months ago
Tomáš Mlynarič	58483b6166	Revert fast initialization of Coil ... As discussed in https://github.com/coil-kt/coil/issues/2097 the problem is caused by regitering system services, which will be fixed in 2.6.0 Change-Id: I9085309780508137f10b25ff82deed3c62e5d159	7 months ago
Tomáš Mlynarič	f3e89bad4a	Add braces ... Change-Id: I859babab7278137a4a2e49e5a085c65632888dd0	7 months ago
Tomáš Mlynarič	d1211f15e7	Inline initialization ... Change-Id: I0a77eb6457cac27c1a4d604c8efdcbbdce95bc48	7 months ago
Tomáš Mlynarič	e853748cf7	Don't use runBlocking if async init completed ... Change-Id: I641187ce277f434c6fca49a11b3cfccd50ecf5da	7 months ago
Tomáš Mlynarič	7c33946ce1	Launch loader directly without additional coroutine scope ... Change-Id: Icbbdbcbcac1a6275857ebe998509f1e09109db7a	7 months ago
Tomáš Mlynarič	8e3903e90c	Fix comment ... Co-authored-by: Yuri Schimke <yuri@schimke.ee>	7 months ago
Tomáš Mlynarič	5f0612102d	Improve lazy loading for Coil + OkHttp ... This way, we can load Coil's backend on a background thread and not block the MainThread with it. Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames. Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62	7 months ago
Tomáš Mlynarič	12a3a6edde	Use trySend multiple times ... Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032	7 months ago
Tomáš Mlynarič	08bfc54832	Update dependency guard baseline ... Change-Id: I2557753f1eb4c6845aca6473a6aba5b7e758ebbf	7 months ago
Tomáš Mlynarič	f8e797fd26	Rename currentTimezone variable ... Change-Id: I92630f6851b0253294a8d3ec2e5b3cbe7db74b4d	7 months ago
Tomáš Mlynarič	98e9e80639	Merge branch 'main' into mlykotom/tz-perf-improvement ... Change-Id: Ie83fb57676934ca3bdda59a986eb1a01a7c97424	7 months ago
Tomáš Mlynarič	ea1573fcc1	Use kotlinx.datetime.Timezone instead of java ZoneId ... Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628	7 months ago
Jonathan Koren	c1d6c88bb0	Run dependencyGuard task during CI (#1064) ... * Run dependencyGuard task during CI Run the `dependencyGuard` task during CI, which will fail if there are detected changes. Change-Id: If5f2b18a4c765bd38a3353df2adaaa91cf1739c3 * Add actions to update dependency guard baselines * Update baselines * Better glob for update baselines action	7 months ago
Tomáš Mlynarič	44ae059a2b	Rename LocalTimeZone -> LocalZoneId + collects with lifecycle ... Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3	7 months ago
Tomáš Mlynarič	cb00d2c8cb	Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers ... This way, we can save ~1ms per composed item on screen. Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d	7 months ago
Tomáš Mlynarič	395b9853df	Add Composition Tracing ... Change-Id: I3ad60930de2fab71a700a0c2df3f0a1f566cafd8	7 months ago
Don Turner	f5b3ae56dc	Merge pull request #951 from SimonMarquis/issue-945 ... Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`	8 months ago
Don Turner	691bf2aad6	Merge pull request #785 from SimonMarquis/optimize-avd ... Optimize AVD to fix long vector paths Lint warning	8 months ago
SimonMarquis	afdfd8acc5	🤖 Updates screenshots	8 months ago
Simon Marquis	377d3bef0c	Optimize AVD to fix long vector paths Lint warning ... ... with SVGOM, but you'll have to check on Android Studio the AVD diff. https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html	8 months ago
Don Turner	707117a4f2	Merge branch 'main' into kotlinify	8 months ago
Don Turner	0f0511748e	Merge pull request #1088 from SimonMarquis/cleanup-dependencies ... Reduce overall build complexity	8 months ago
Don Turner	046831df36	Update dependency guard classpaths ... Change-Id: I5f729bce92ec1cc9f71e34e42cbe38765966fc31	8 months ago
Simon Marquis	0699efc592	Merge branch 'main' into issue-945	8 months ago
Simon Marquis	be9dc533e3	Replace `Enum.values()` with `Enum.entries` ... 'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9	8 months ago
Don Turner	a5c030f740	Merge pull request #956 from KDW03/add_saved_test ... Add Test for Saved Top Level Destination	8 months ago
Don Turner	89d39a7242	Merge pull request #767 from SimonMarquis/resource-prefix ... Enforce `resourcePrefix` on Android library modules	8 months ago
Don Turner	9d41ffa318	Merge branch 'main' into kotlinify	8 months ago
Don Turner	ad15f0137e	Merge pull request #1094 from lihenggui/main ... Upgrade Spotless and Ktlint and remove code convention violations	8 months ago
Don Turner	8d5ef578c6	Merge pull request #1103 from android/add_icon_comment ... Add comment explaining why the launcher icon colors differ per build	8 months ago
Simon Marquis	b6d82e24df	Merge branch 'main' into kotlinify	8 months ago
Don Turner	b801a7deea	Moving comments to _after_ first XML element ... Change-Id: Id4271a67ffcfbd712a2dd1f363970fcd31ee5ac0	8 months ago
lihenggui	2a2d8ed88d	Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE	8 months ago
Don Turner	d018e57f52	Fix spotless ... Change-Id: I5dea4fec5b391e8cb7794af13e99978fcb622fbb	8 months ago
Don Turner	e6b5560f07	Revert "Move app screenshot tests to match dependencies declaration"	8 months ago
Don Turner	28bb3f1b2f	Add comment explaining why the launcher icon colors differ per build variant ... Change-Id: I30126402370162ccbe53e177652583e4472f2030	8 months ago
Simon Marquis	83764082ff	Move app screenshot tests to match dependencies declaration ... Fixes #990	8 months ago
lihenggui	32e1ec0447	Remove violations: property-naming	8 months ago
lihenggui	fb5bd225be	Spotless	8 months ago
Simon Marquis	2b739c0ffe	Fix badging, which is not "stable" when it comes to ordering	9 months ago
Simon Marquis	65a8b0d3b5	dependencyGuardBaseline	9 months ago
Simon Marquis	f27a2e176e	Reduce overall build complexity ... - Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`	9 months ago
Jonathan Koren	392eaa3e61	Add dependencyGuard to AndroidApplicationConventionPlugin ... Change-Id: Ib695ca18512d0ccde4c67e101f09ebbff8897912	9 months ago
Jonathan Koren	d15a203c59	Only record prodReleaseRuntimeClasspath configuration ... Change-Id: I129fc4839ac2b4d5624c91cd25b47efba8847f44	9 months ago
Jonathan Koren	d5d5e3561f	Add dependency guard plugin	9 months ago
Simon Marquis	caa482bc71	Kotlinify codebase ... - Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)	9 months ago
Simon Marquis	988002e692	Update Robolectric 4.11.1 ... - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11 - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1 > Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below. Removing explicit API 33 Robolectric configuration.	9 months ago
Miłosz Moczkowski	9c89e98e5b	Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold" ... This reverts commit 335a7ec68c, reversing changes made to aa8ce0e1f6.	9 months ago
mmoczkowski	f365e8b782	🤖 Updates screenshots	9 months ago
Miłosz Moczkowski	816a7b60c1	Replace manual navigation component switching with new NavigationSuiteScaffold ... Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723	9 months ago
Ben Weiss	aa8ce0e1f6	Add automated baseline profile generation (#880) ... Baseline profile generation is disabled for the PR level Build task. Release tasks require a fresh baseline profile. A new profile is generated using the baseline profile Gradle plugin. * Prepare for usage of dex layout optimizations which can be actively used once NiA switches to AGP 8.2+. * Add GMD config to release build * Switch to macos-latest * Update names for StartupBenchmark tests to better reflect states * Stable release and recent GMD device * Reduce flakiness by adding wait to benchmark * More convenient waiting for objects * Rename junit dependency to androidx-junit * Only run baseline profile benchmarks during GH workflow * Enable automatic BP generation for only release builds * Disable BP generation from Build workflow * Specify modules and skip benchmarking Build workflow Bug: b/299334172	9 months ago
Don Turner	f3b2655e2f	Merge pull request #933 from danysantiago/main ... Update to Hilt 2.48 and use the KSP version	10 months ago
Daniel Santiago	c908f989c8	Update to Hilt 2.48.1 and use the KSP version ... * Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin. * `@Binds` function cannot be an extension function. * Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.	10 months ago
Jose Alcérreca	3f22248cb7	[CI] Better caching and fewer jobs run ... * [CI] Runs build in macos to generate a cache for androidTest runs * Build projects before running emulator * Fixes flaky coroutines test * Moves spotless up in local tests job * Enables config cache by setting problems to warn. Fixes #1022	10 months ago
Alex Vanyo	360b33eb82	Add automatic checks for badging ... Change-Id: Ic8fca86d7aa84675fa91fb1aa99abcc6e19d663e	10 months ago
TM	d3d5b02428	Inline color values for app icons	10 months ago
TM	9b83237bfd	Removed Comments	10 months ago
TM	afb427b9c5	Use colors from design palette in build variant icons	10 months ago
TM	38d0c15d33	Create different icons for each build variant ... Added color values for DEBUG and BENCHMARK build variants.	10 months ago
Jose Alcérreca	431069ab77	NiaAppScreenSizesScreenshotTests.kt: Fixes screenshot test showing wrong width (#986) ... * FIxes screenshot test * 🤖 Updates screenshots	11 months ago
Adetunji Dahunsi	0287af8d9a	Merge pull request #947 from android/tj/staggered-grid-feed ... Use lazy vertical staggered grid in feed to maximize space utilization	11 months ago
Don Turner	a381d13199	Merge pull request #958 from McGalanes/main ... Use typesafe project accessors	11 months ago
Melwin Magalhaes	6247712064	Add convention plugins to version catalogs	11 months ago
Melwin Magalhaes	b1266dc05a	Use typesafe project accessors for project modules	11 months ago
tunjid	b2498c763f	🤖 Updates screenshots	11 months ago
Simon Marquis	b2cd980170	Merge remote-tracking branch 'origin/main' into resource-prefix	11 months ago
Simon Marquis	faf42aa133	Merge remote-tracking branch 'origin/main' into issue-945	11 months ago
kimdowoo	bc56ba79bc	Add Test for Saved Top Level Destination	11 months ago
Don Turner	e40fb7925d	Merge pull request #779 from SimonMarquis/java-to-kotlin-sourceset ... Migrate from `java` to `kotlin` sourceSet directory	11 months ago
Simon Marquis	ebfe01affd	Enforce `resourcePrefix` on Android library modules ... ``` :ui-test-hilt-manifest -> ui_test_hilt_manifest_ :core:analytics -> core_analytics_ :core:common -> core_common_ :core:data -> core_data_ :core:data-test -> core_data_test_ :core:database -> core_database_ :core:datastore -> core_datastore_ :core:datastore-test -> core_datastore_test_ :core:designsystem -> core_designsystem_ :core:domain -> core_domain_ :core:network -> core_network_ :core:notifications -> core_notifications_ :core:testing -> core_testing_ :core:ui -> core_ui_ :feature:bookmarks -> feature_bookmarks_ :feature:foryou -> feature_foryou_ :feature:interests -> feature_interests_ :feature:search -> feature_search_ :feature:settings -> feature_settings_ :feature:topic -> feature_topic_ :sync:sync-test -> sync_test_ :sync:work -> sync_work_ ```	11 months ago
Simon Marquis	a33dafccad	Migrate from `java` to `kotlin` sourceSet directory	11 months ago
Simon Marquis	49a2fb5272	Fix wrong configuration name, leaking `work-testing` to runtime classpath ... Typo introduced recently when Roborazzi was added to the project: 886158d3cb (diff-8cff73265af19c059547b76aca8882cbaa3209291406f52df1dafbbc78e80c46)	11 months ago
Simon Marquis	03ba943632	Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication` ... - Prevent logging multiple times (because of `onResume()` callback) - Remove unnecessary io dispatcher: `ListenableFuture<T>.await()` is already main-safe and prevent acquiring io slot. - Merge comments into a single javadoc comment on the `ProfileVerifierLogger` type. - Add proper javadoc format with markdown specific blocks. - Update logs & tag to be more uniform. Closes #945	11 months ago
Jose Alcérreca	151f877bbe	Adds screenshot tests to :core:designsystem (#931) ... * WIP: Adds screenshot tests to :core:designsystem Change-Id: I0672845feba4064652dd8d60f07047b87864e121 * 🤖 Updates screenshots * Creates tests for more components and cleans up Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22 * WIP: More cleanup and more combinations of themes Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523 * Added the rest of the screenshot tests for designsystem Change-Id: Ic427db5491910781c038882055524e3f3dbed194 * Some more cleanup Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180 * Spotless Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6 * 🤖 Updates screenshots * ScreenshotHelper cleanup Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0	12 months ago
Milosz Moczkowski	851ca6388e	Merge pull request #868 from SimonMarquis/patch-4 ... Handle topic clicks from all destinations	1 year ago
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876) ... * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	1 year ago
Don Turner	e96e54f7de	Merge pull request #806 from SimonMarquis/objenesis ... Remove forced resolution strategy	1 year ago
Simon Marquis	b7799f0475	Convert 'sealed' sub-object to 'data object'	1 year ago
Alex Vanyo	a3ee09ec3e	Merge pull request #817 from android/av/enable-edge-to-edge ... Switch to new Activity.enableEdgeToEdge	1 year ago
Simon Marquis	d8a6d0de13	Replace NiaNetworkDataSource with TopicsRepository ... to be closer to the actual source of data used by the instrumented app.	1 year ago
Simon Marquis	57f3700980	Select last topic by name instead of a random one	1 year ago
Simon Marquis	64f81751b3	Handle topic clicks from all destinations ... Closes #865	1 year ago
Alex Vanyo	2b218b97d9	Switch to new Activity.enableEdgeToEdge ... Change-Id: I9bbb7b2d116099524525619714ef18448e707c4f	1 year ago
Simon Marquis	0a1f333fc6	Update NavigationTest.kt	1 year ago
Simon Marquis	bf5fdb4cf8	Update NavigationTest.kt	1 year ago
Simon Marquis	250850cf9b	Remove hardcoded topic names in `NavigationTest.kt`	1 year ago
Don Turner	654944430d	Fix for Retrofit R8 issue, bump version to 0.1.2 ... Change-Id: Ia90d693731c95248211b12b1ce2e9dfab0ecf34c	1 year ago
Márton Braun	56389cb760	Merge pull request #752 from SimonMarquis/kotlin-1.9.0 ... Kotlin 1.9.0	1 year ago
Simon Marquis	ba82b06cc3	Fix Lint `RememberReturnType` issue with explicit type	1 year ago
Don Turner	7f62b725a6	Bump version to code=7, name=0.1.1 ... Change-Id: I2d8fa940dc5e4c14e3c9df650bc1f1432a330f02	1 year ago
Automerger	49a3f47fd8	Merge branch 'github/main'	1 year ago
Automerger	44c3c6d947	Merge branch 'github/main'	1 year ago
Milosz Moczkowski	04d3da39b9	Merge pull request #809 from SimonMarquis/launcher-icon-dark-theme ... Extract launcher icon tints and provide `-night` alternatives	1 year ago
Murat Yener	e96dac39b2	changed from ListenableFuture.get() to ListenableFuture.await()	1 year ago
Murat Yener	78ed9adca2	spotless fix	1 year ago
Murat Yener	7b5c0f2be8	Adds ProfileViewer to log the app's Baseline Profile Compilation Status	1 year ago
Simon Marquis	cf64e25ad5	Extract launcher icon tints and provide `-night` alternatives ... Implements #805	1 year ago
Simon Marquis	0a3069a0d8	Remove forced junit resolution strategy ... By looking at the Gradle scan's dependency tab, junit 4.12 is already replaced by 4.13.2. There is no need to manually force this at the configuration level.	1 year ago
Simon Marquis	d332f7b70d	Remove forced objenesis resolution strategy ... The linked issue is marked as resolved, and not able to reproduce the mentioned compilation error.	1 year ago