88c3eb0b90
Merge pull request #1284 from sanao1006/remove-GetSearchContentsCountUseCase
...
Directly call SearchContentsRepository interface in SearchViewModel
12 months ago
e2a4706470
Remove unnecessary opt-in annotations
1 year ago
51d3903a4b
Merge branch 'main' into remove-GetSearchContentsCountUseCase
1 year ago
c7e9dd3803
Update method name. Fixes #1287
...
Change-Id: I9b603bd33f7be0f7562aab4a7b6f2307a3a1333a
1 year ago
825a5e2f5f
[Refactor]: Directly call SearchContentsRepository interface in SearchViewModel
...
- Remove GetSearchContentsCountUseCase.
- Remove GetSearchContentsCountUseCase from SearchViewModel.
- Remove GetSearchContentsCountUseCase from SearchViewModelTest.
Fixes #1283
1 year ago
b5bfe44bf3
Fix spotless
...
Change-Id: I5b08ce68522c59cdd7f7ec56a14a7ebc8b3868cd
1 year ago
ce9e82622d
Fix broken reference to string resources
...
Change-Id: Ide4cb90abc2ae7ca78488909a37df685c2e71ec6
1 year ago
a4c52e6485
Remove the search module's dependency on other feature modules
...
Change-Id: I17df9948fed04ddc7ba507b437d39536b8b180bb
1 year ago
3e4aad3210
Merge pull request #1257 from android/dt/add-module-graphs
...
Update module dependency graphs and add script to create them
1 year ago
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
1 year ago
aa15e65a77
Fix search flickering
...
Change-Id: I6d17f5703186dbebcba4f931ab9692d4ab1e9f79
1 year ago
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
1 year ago
3fa75a037a
Apply Composable Parameter Ordering Guidelines
...
Change-Id: Id456e91b5ce8bd5807c40df67c3deac008c61670
1 year ago
5a1258232f
Fix `emptyResultIsReturned_withNotMatchingQuery` unit test
...
`searchResultUiState` transitively relied on `getSearchContentsCount` updates and on `userDataRepository` to emit something.
1 year ago
707117a4f2
Merge branch 'main' into kotlinify
1 year ago
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
1 year ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
1 year ago
cd62fd5e01
Update feature/search/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/search/navigation/SearchNavigation.kt
1 year ago
9d41ffa318
Merge branch 'main' into kotlinify
1 year ago
32e1ec0447
Remove violations: property-naming
1 year ago
f8f932705a
Remove violations: discouraged-comment-location
1 year ago
fb5bd225be
Spotless
1 year ago
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
1 year ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
1 year ago
0287af8d9a
Merge pull request #947 from android/tj/staggered-grid-feed
...
Use lazy vertical staggered grid in feed to maximize space utilization
1 year ago
a381d13199
Merge pull request #958 from McGalanes/main
...
Use typesafe project accessors
1 year ago
6247712064
Add convention plugins to version catalogs
1 year ago
b1266dc05a
Use typesafe project accessors for project modules
1 year ago
03d2455f41
Use lazy vertical staggered grid in feed to maximize space utilization
...
Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926
1 year ago
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
2 years ago
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
2 years ago
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
2 years ago
4716c7f841
Merge pull request #913 from hoangchungk53qx1/main
...
Refactor Search Feature
2 years ago
66eafdc38b
format modification for screen search
2 years ago
374808c284
Merge pull request #847 from SilviaGarciaBouza/wrong_color_in_dark_mode
...
Added TextStyle color for ClickableText
2 years ago
70498dd6e3
separate function logEvent for search triggered
2 years ago
9cb20db93a
separate function logEvent for search triggered
2 years ago
c52c4b88cd
replace object with data object in search feature, simple format code for the reader
2 years ago
cd30ecf359
replace object with data object in search feature, simple format code for the reader
2 years ago
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
2 years ago
ec53d03854
Merge pull request #722 from android/tj/scrollbars
...
Add scrollbars to app
2 years ago
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
2 years ago
995d7b643f
Add missing full stop in `search_not_ready` string
2 years ago
e13e84c155
Replace usages of 'displacement' to 'moved' in parameter names
...
Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a
2 years ago
eeb4973265
PR feedback
...
Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f
2 years ago
bdf3ee3cb0
PR feedback
...
Change-Id: Ie22aa3c7fdf4c8ca8d8118837cfd279de8c6d80b
2 years ago
cb1d50e65e
Even better names
...
Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65
2 years ago
0016b10037
Added TextStyle color for ClickableText
2 years ago
9197b332c4
Merge pull request #825 from android/refactor/interest_item
...
Refactor InterestsItem to a Material3 ListItem
2 years ago
445c18a803
Refactor InterestsItem to Material3 ListItem
...
Change-Id: I12adc8820964aecd97ea0b4e22ae13e95e1428ab
2 years ago
Don Turner
yongsuk44
Don Turner
sanao1006
Tomáš Mlynarič
kim-yongsuk
Simon Marquis
lihenggui
Adetunji Dahunsi
Melwin Magalhaes
dahunsi
Simon Marquis
hoangchungk53qx1
Milosz Moczkowski
TJ Dahunsi
Silvia García Bouza