Don Turner
4277366b7c
Merge pull request #1729 from takahirom/takahirom/update-sdk-35/2024-12-11
...
Update SDK 35 with Theme Fixing
9 months ago
Ben Weiss
d8b735f80e
Revert "Improve accessibility to ForYou topics ( #1309 )" ( #1732 )
...
This reverts commit 48544194f4
.
9 months ago
takahirom
5e73c76acd
🤖 Updates screenshots
9 months ago
Jaehwa Noh
48544194f4
Improve accessibility to ForYou topics ( #1309 )
...
* Clear semantics.
Change-Id: I69a48798f6be8433e877c38166bd73cd776d71ac
* Merge the descendants semantics.
Change-Id: Ifbe91bb694b393e6780f93732a7d38f5ee355680
* Add string for icon description.
Change-Id: Ibf35c651aeacfbe317794ed898f0fb0e8bc1ec15
* Change icon description.
Change-Id: I9359bf8c9272b247669ae58fd79e5f79466ec0a9
* Change state of icon check logic.
Change-Id: I3e5e89fc1c469c3f3c4744d18f697f68d070996b
* Merge only text.
Change-Id: I36eefc6dd9f56f7a1f63003f0f95f6755ae16def
* Add stateDescription.
Change-Id: Id4d32e49374dbdb6e666048937e37060cbd4b454
* Add toggleableState.
Change-Id: I9f836e2463bf800786d11f9e0997a7d570ff90b0
* Set clearAndSetSemantics at Row.
Change-Id: Ic25b9ca11bbcc40c8ff24172669b07ea9b7642a9
* Set stateDescription "Following" and "Not Following".
Change-Id: Ib82ac94b05a5d373ac10787aac5241fb4f03c7b2
* Find topic by onNodeWithContentDescription.
Change-Id: I2423e3846c02169f6bf1fc30d9b4034b5f79efb3
* Find topic by onNodeWithContentDescription.
Change-Id: Iefc97fd9e52227f51f7d40f8c10cb4878cde90c0
9 months ago
Don Turner
a258794dc6
Merge branch 'main' into introduce_screenshot_a11y_tests
9 months ago
Don Turner
e36b7ab454
Merge pull request #1711 from AdnanHabibMirza/adnan/typesafe_project_accessor
...
Use typesafe project accessor
9 months ago
Don Turner
78b1a6748a
Merge pull request #1707 from yongsuk44/feature/type-safe
...
Refactor: Use type safe SearchRoute
9 months ago
Ben Weiss
729681b79a
Revert "Bump protobuf from 4.26.1 to 4.28.2 ( #1630 )"
...
This reverts commit 82b6352da1
.
9 months ago
Jaehwa Noh
dfc3355054
Empty search text is added in recent searches problem fix. ( #1223 )
...
* Add if state to prevent blank query.
* Create test emptySearchText_NotAddToRecentSearches
- For empty query not add in recent query list.
* Apply early return.
* assertEquals to assertNull.
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
* Import org.junit.Assert.assertNull
* Change org.junit.Assert.assertNull to kotlin.test.assertNull.
Change-Id: I60083b0b9a1dcaed84d957b49c91e5163d5659d6
* Add 'or' to prevent search when query is blank.
Change-Id: If498de05889d6d5946b1bbb1d1c10cb311bb9b52
* Create stateIsEmptyQuery_withThreeWhiteSpacesSearchQuery test.
Change-Id: I6d6e8f9fe988ca83fae484e4f2338ad6fe58b676
* Add UI logic to prevent blank text search in SearchScreen.
- Early return to do not call onSearchExplicitlyTriggered()
Change-Id: I28db284eac9059fb6f48dd718721a1fc5fdb8f7a
* Apply trim at query to remove whitespace.
Change-Id: Id349af4bb1af3d0f1c3973e6fb9e6f3e7b924d9b
* Create test stateIsEmptyQuery_withThreeWhiteSpacesAndOneLetterSearchQuery
Change-Id: Iee59f6085e4045b2e3c532f78804926290b6c6c5
* Update feature/search/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModelTest.kt
Change name to emptySearchText_isNotAddedTorecentSearches()
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Change name to searchTextWithThreeSpaces_isEmptyQuery()
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Change name to searchTextWithThreeWhiteSpacesAndOneCharacter_isEmptyQuery()
Change-Id: I4c82b12e2c9bd4ff480e94061caf257a603e38da
* Revert "Change name to searchTextWithThreeWhiteSpacesAndOneCharacter_isEmptyQuery()"
This reverts commit e4c176598a
.
* Change name to searchTextWithThreeSpacesAndOneLetter_isEmptyQuery
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Add end curly bracket.
Change-Id: I7bd113e7b65d646f5321e34a7df2868f6e239cad
---------
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
9 months ago
dependabot[bot]
82b6352da1
Bump protobuf from 4.26.1 to 4.28.2 ( #1630 )
...
* Bump protobuf from 4.26.1 to 4.28.2
Bumps `protobuf` from 4.26.1 to 4.28.2.
Updates `com.google.protobuf:protobuf-kotlin-lite` from 4.26.1 to 4.28.2
Updates `com.google.protobuf:protoc` from 4.26.1 to 4.28.2
- [Release notes](https://github.com/protocolbuffers/protobuf/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl )
- [Commits](https://github.com/protocolbuffers/protobuf/commits )
---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-kotlin-lite
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.protobuf:protoc
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* 🤖 Updates baselines for Dependency Guard
* 🤖 Updates screenshots
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Weiss <keyboardsurfer@users.noreply.github.com>
9 months ago
Don Turner
afb6741554
Merge pull request #1682 from blue928sky/use-lifecycle-compose-LocalLifecycleOwner
...
Use androidx.lifecycle.compose.LocalLifecycleOwner
9 months ago
Adnan Habib
83a8beee72
Use typesafe project accessor
...
Change-Id: Ib9f0a68debaf75431fe45d5a81128e33e4885321
9 months ago
Yuri Schimke
2415239d45
suppress checks
10 months ago
Yuri Schimke
3e4f66b489
spotless
10 months ago
Yuri Schimke
4f27c18f20
Change order of exceptions
10 months ago
Yuri Schimke
0849597755
Suppress A11y exception for now
10 months ago
yongsuk44
ca87bfe6cf
Refactor: Use type safe SearchRoute
10 months ago
yschimke
2401e20dd4
🤖 Updates screenshots
10 months ago
Yuri Schimke
d7f1863920
remove sdk 21
10 months ago
Yuri Schimke
56fd308d65
revert screenshots
10 months ago
Yuri Schimke
0dd998765c
Update dependencies
...
Update Compose BOM to 2024.11.00 and update other dependencies, such as Robolectric and Roborazzi.
Also, update Screenshot Tests with sdk version 35 for better screenshot testing.
10 months ago
blue928sky
a929f9ccc0
Merge remote-tracking branch 'origin/main' into use-lifecycle-compose-LocalLifecycleOwner
...
Change-Id: I338708411967f018bc4a86b2cecebc1bcce71d32
10 months ago
blue928sky
bf54ccc760
feat: use androidx.lifecycle.compose.LocalLifecycleOwner
...
Change-Id: If0a414ee4d5aab277fb90343ba7d5aa6a9dbd2e8
10 months ago
Don Turner
89795c98b5
Fix spotless
10 months ago
Don Turner
5994d8c6fd
Add TopicScreen as a sub destination in the ForYou section. Fixes #1463
10 months ago
Don Turner
bd557fd604
Reduce icon sizes
11 months ago
Tomáš Mlynarič
37353e354a
Merge pull request #1594 from yongsuk44/trace-marker-default
...
Fix duplicate composition trace markers
12 months ago
Alex Vanyo
f42afb5aa7
Merge pull request #1585 from saeedishayan76/change-unitTest
...
change collectJob to backgroundScope coroutine
12 months ago
Don Turner
d1748eb2d3
Merge pull request #1616 from android/dt/fix-internal-build
...
Replace BoxWithConstraints with Box
12 months ago
Don Turner
115a68e72b
Replace BoxWithConstraints with Box
...
Change-Id: I63a54aa6c30c6a68beab66ffce77238e5156ee06
12 months ago
Alex Vanyo
79787caa60
Merge pull request #1601 from android/av/compose-2024-09-00
...
Update Compose to 2024.09.00
1 year ago
Alex Vanyo
e135b49736
Replace ClickableText with LinkAnnotation
...
Change-Id: I18ba20f07db5a392890f7e568c9faa7a90af1054
1 year ago
Alex Vanyo
940497f176
Merge pull request #1575 from junyong008/remove-duplicate-dependency
...
Remove duplicate dependency
1 year ago
saeedishayan76
987e87f4ed
Check topicViewModelTest for spotless
1 year ago
saeedishayan76
6f40606c54
InterstsViewModelTest fix spotless Issue
1 year ago
saeedishayan76
26dd4424f6
remove blank lines for resolve spotless error
1 year ago
saeedishayan76
0356b873e9
change collectJob to backgroundScope coroutine
1 year ago
yongsuk44
f0434e52a4
Spotless Apply
1 year ago
yongsuk44
46e15f21dc
Fix duplicate composition trace markers in composable
1 year ago
Don Turner
bee8c88681
Update feature/interests/src/test/kotlin/com/google/samples/apps/nowinandroid/interests/InterestsViewModelTest.kt
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
1 year ago
Don Turner
4ff5b1fa26
Fix failing InterestsListDetailScreenTest
...
Change-Id: Ib6e47d9a9cced4c967756f95a5c98587628bd2cb
1 year ago
Don Turner
8d57134663
Fix spotless
...
Change-Id: Ib093c206809a470b7f6135933bd2a72046865684
1 year ago
Don Turner
a8ffd1f2f1
Fix incorrect deep link key name in ForYouViewModelTest
...
Change-Id: I945632c419e11671eb73690999f9a234e577d16b
1 year ago
Don Turner
4b3f5370b9
Clean up deep link handling
...
Change-Id: I9d589cfe5c20a6b55708b99f5d79b10271af8ab4
1 year ago
Don Turner
00efda54e8
Merge branch 'main' into dt/nav-safe-args
...
* main: (58 commits)
Instrumented tests for InterestsListDetailScreen (#1518 )
Remove Firebase AD_SERVICE_CONFIG property
updateProdReleaseBadging
Merge Android & JVM plugins into a single `HiltConventionPlugin`
Update dependency guard
🤖 Updates baselines for Dependency Guard
Update to Lifecycle 2.8.3
Add android.adservices.AD_SERVICES_CONFIG to badges
Apply suggestions from code review
Update app/src/main/AndroidManifest.xml
generateModuleGraphs
dependencyGuardBaseline
updateProdReleaseBadging
Fix spotless.
Change set to `=` operator
Cleanup unused reference in `libs.versions.toml`
Regenerate SVG graphs
Update comment wording
Use stdin to avoid repeating the output file name
Replace bash commands with proper svgo cli
...
Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5
1 year ago
junyong
104f2591df
Remove duplicate dependency
1 year ago
Don Turner
fc58680c06
Remove string-based argument name from navigation code
...
Change-Id: I7c880cc73374e053ea0d41df00a4bda95ed4b551
1 year ago
Simon Marquis
1c5513283a
Merge remote-tracking branch 'origin/main' into fix/1161-2
1 year ago
Don Turner
ec71b2a07e
Add Robolectric to allow ViewModel tests to pass
...
Change-Id: I782fab167103edbdaa1d95839b4fbc6e659fef4e
1 year ago
Don Turner
95bdc0f533
Rename ForYouRoute composable to ForYouScreen
...
Change-Id: I47456f19f2b41cafe44ba7636cad6d1fea782a33
1 year ago