Don Turner
490997281a
Update to alpha08, use toRoute to obtain destination inside VM
...
Change-Id: I72f617c594b5e0ae272cf94d2d7288446153420a
1 year ago
Don Turner
d96bcf8ffe
Migrate Interests nested NavHost to safe args
...
Change-Id: I4f3c310be693ecbcbc8b99c4e573d7fc6e9a2f74
1 year ago
Don Turner
afad1b9ac7
Merge pull request #1383 from android/av/navigation-2.7.7
...
Update to navigation 2.7.7
1 year ago
Alex Vanyo
068cee0278
Add workaround for state loss bug
...
Change-Id: I7ac4495c8e3ada419358688c61214c33c0d4040e
1 year ago
Simon Marquis
3e1f545869
Update build.gradle.kts
1 year ago
Jose Alcérreca
ead3f49f7b
Fixes flakiness in app's screenshot tests ( #1395 )
...
* Disables WM init in app's screenshot tests
Change-Id: Ib0994e744f49b53f58c0eebd52f80c0eba67bbed
* Spotless
Change-Id: Ic0212889354481433ce45ec4292ae7be9bd24b2e
* [CI] Uploads roborazzi reports if they fail
Change-Id: I5a25a7e156d3fcb72a396d3b503e62068a20b417
* Uses unused test module and enables LocalInspection
Change-Id: Iac36347dc3d702248d7515a74823e0bc0cbf2a2b
* Fixes timezone in snackbar screenshot tests
Change-Id: Ic517e8822218abeaddd3f8d2740b03e651d72d31
* Fixes conflict
Change-Id: Ia42fb78781d2469a608183594fc25c7c69f7e76c
* 🤖 Updates screenshots
1 year ago
Jose Alcérreca
1da560f582
Revert "Configure baseline profiles in the baselineProfile lambda" ( #1398 )
...
This reverts commit 7980c1d0df
.
1 year ago
Ben Weiss
7980c1d0df
Configure baseline profiles in the baselineProfile lambda ( #1060 )
...
* Configure baseline profiles in the baselineProfile lambda
* This is the correct and easiest way to set up baseline profiles correctly.
* See b/313428246 for more context.
* Handle empty topics during baseline profile generation
* Revert to API 33 GMD and fail empty screen tests
* Rename withChildren to noChildren for better legibility
* Remove unused log tags
* Update benchmark and metrics versions
* 🤖 Updates baselines for Dependency Guard
---------
Co-authored-by: Tomáš Mlynarič <mlykotom@google.com>
Co-authored-by: Jaehwa Noh <shwoghk14@gmail.com>
1 year ago
Alex Vanyo
91215c5c89
Update to navigation 2.7.7
...
Change-Id: Iaceea1fc216c899f7fac58e7f5eeaea4e1c10dbb
1 year ago
Don Turner
c7d5cb4012
Replace TestHarness with DeviceConfigurationOverride after merging main
...
Change-Id: Ie49b67981929fd3932ce3da68571a6305cf67aef
1 year ago
Don Turner
61cce4bf19
Merge branch 'main' into replace-testharness
1 year ago
Sergey Pinkevich
2ade8c8f1c
Merge branch 'dependabot/gradle/androidx.activity-activity-compose-1.8.2' of https://github.com/android/nowinandroid into dependabot/gradle/androidx.activity-activity-compose-1.8.2
1 year ago
Alex Vanyo
d452f22a68
Update badging
...
Change-Id: If6b1327554bc855baa86fd47519ca56e015b9d14
1 year ago
Alex Vanyo
9b4c22cb2d
Update to material3-adaptive alpha10
...
Change-Id: I810c36323a35c445c22dd3876c52df0360a5cb48
1 year ago
Alex Vanyo
0be0bc191f
Update usage of material3 adaptive to be edge-to-edge
...
Change-Id: I481c79db77bbdd657182f5355200f63e2355f40d
1 year ago
Jose Alcérreca
16f45c0b1a
Adds screenshot tests for snackbar ( #1343 )
...
* Adds screenshot tests for snackbar
Change-Id: I81566e3301fb17e3f31cbc408e6cc3325eab5a12
* Small tweaks, RFR
Change-Id: Ia16db6e6f5bec2714081b5ceaeeba36b2ee26105
* 🤖 Updates screenshots
* Update NiaApp.kt
Adds modifier to NiaApp
1 year ago
Don Turner
739dc00987
Fix spotless
...
Change-Id: I98a9b9fa1de5cc0bb3a3caa7d795053fd784b238
1 year ago
Don Turner
fc2146c970
Merge branch 'main' into replace-testharness
1 year ago
Don Turner
655aebccdc
Remove workaround for https://issuetracker.google.com/327149166
...
Change-Id: I335f9f5da1ff3f2574acca8e3fcb27b949a07c7a
1 year ago
Jaehwa Noh
a22b724a66
Change getByName to named
...
- reference by [APIs to avoid](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#apis_to_avoid )
Change-Id: Idf1ce9cf372b8f5da2f0da95fcf53454ffb3388f
1 year ago
Jose Alcérreca
78e3725f9f
Sets up jacoco coverage with a combined report and a GHA ( #1303 )
...
* Uses jacoco coverage reporting in AGP
1 year ago
Simon Marquis
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
1 year ago
Don Turner
bd89507f10
Merge pull request #1306 from yongsuk44/feat/weak-warning
...
Cleaned up unnecessary '@opt-in' annotations and removed empty constructors
1 year ago
yongsuk44
e2a4706470
Remove unnecessary opt-in annotations
1 year ago
dependabot[bot]
c4b669a138
🤖 Updates baselines for Dependency Guard
1 year ago
dependabot[bot]
7d2026f180
🤖 Updates baselines for Dependency Guard
1 year ago
Jonathan Koren
dac1a9e446
Topic detail pane placeholder ( #1280 )
...
* Topic detail pane placeholder
Change-Id: I92b84493a5406240285c0759b30aa10d29871f09
* Add modifier parameter
Change-Id: Ie363be83b44f26291030c04c1513cecb851a6899
2 years ago
Don Turner
70dcd5119d
Make path to module graph image dynamic. Fixes #1286
...
Change-Id: I595a841ef7b06cccc959ca96d18824f4fad4c261
2 years ago
Don Turner
3e4aad3210
Merge pull request #1257 from android/dt/add-module-graphs
...
Update module dependency graphs and add script to create them
2 years ago
Don Turner
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
2 years ago
SergeyPinkevich
06f08a58dd
🤖 Updates baselines for Dependency Guard
2 years ago
alexvanyo
a6f223301e
🤖 Updates baselines for Dependency Guard
2 years ago
Alex Vanyo
cc02c30b8e
Update material3-adaptive to 1.0.0-alpha08
...
Change-Id: Ic218c6b061b5cea4e56b544073541421862bc1d0
2 years ago
Don Turner
0c9f0dd48c
Merge pull request #1217 from android/dependabot/gradle/org.jetbrains.kotlinx-kotlinx-serialization-json-1.6.3
...
Bump org.jetbrains.kotlinx:kotlinx-serialization-json from 1.6.0 to 1.6.3
2 years ago
Don Turner
e9565a567e
Merge pull request #1258 from Jaehwa-Noh/rename-test-function
...
Rename test function, and delete explicit type argument
2 years ago
Don Turner
74d1d91c28
Merge pull request #1263 from android/dependabot/gradle/kotlinxCoroutines-1.8.0
...
Bump kotlinxCoroutines from 1.7.3 to 1.8.0
2 years ago
Don Turner
91af060e77
Merge pull request #1264 from android/dependabot/gradle/androidx.hilt-hilt-navigation-compose-1.2.0
...
Bump androidx.hilt:hilt-navigation-compose from 1.0.0 to 1.2.0
2 years ago
Don Turner
1fde4f5753
Merge pull request #1266 from android/dependabot/gradle/androidx.browser-browser-1.8.0
...
Bump androidx.browser:browser from 1.6.0 to 1.8.0
2 years ago
mlykotom
a7a7736426
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
5448786c4d
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
72f968ff2c
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
6e5548a837
🤖 Updates baselines for Dependency Guard
2 years ago
Jaehwa Noh
d67b1a2504
Merge branch 'android:main' into rename-test-function
2 years ago
Jaehwa Noh
e017b84a12
Remove explicit type argument.
...
Change-Id: Id02756d780309af6638698de856b563d9e775cc3
2 years ago
Jaehwa Noh
8cfd42453c
Rename test function name
...
- Given-when-then format.
Change-Id: I3305c5a7cc5a0f41be31292534a086034f642404
2 years ago
Jonathan Koren
19f6f9e09a
2 pane support in Interests screen ( #1234 )
...
* Add dependency on material3 adaptive
Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6
* Add InterestsListDetailScreen composable
Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971
* Store selectedTopicId in InterestsViewModel
Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce
* Pass detail pane composable down
Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293
* Navigate to initial topic if provided
Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b
* Lift LDPS up to app module
Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85
* Fix some navigation behavior
Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b
* Navigate to initial topic if provided
Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed
* Remove dependency in interests feature module
Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f
* Hide back arrow when the topics list is visible
Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8
* Update interests tests
Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd
* Highlight selected topic when displaying 2 panes
Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415
* update dependency baselines
Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00
* run spotless apply
Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8
* Convert isListPaneHidden to isListPaneVisible
Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657
* Set semantics for selected state
Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca
* Use scaffold roles when determining visibility
Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648
* Update multipleBackStackInterests test
Change-Id: I1e372f7989817151a6765205291b13b561187fa8
2 years ago
Don Turner
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
2 years ago
Don Turner
2d610b0775
Merge branch 'main' into replace-testharness
...
* main: (37 commits)
Disable animations of instrumented tests (#1167 )
Bump gradle/wrapper-validation-action from 1 to 2
Remove unused release variable. Fixes #1231
Apply Composable Parameter Ordering Guidelines
Remove kotlinx-coroutines-guava dependency from :sync:work
Add explicit guava-android dependency for :sync:work
Extract ScreenshotHelper to separate testing module
Update AGP to 8.3.0
Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert.
🤖 Updates baselines for Dependency Guard
Bump the kotlin-ksp-compose group with 6 updates
🤖 Updates baselines for Dependency Guard
Bump hilt from 2.50 to 2.51
Bump com.google.truth:truth from 1.1.5 to 1.4.2
Move java to kotlin folder.
Remove disk usage testing
Figuring out what is using 66Gb in the runner
Dpm
Improve converting to kotlin timezone
Use trySend multiple times
...
Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a
2 years ago
Don Turner
7737368c0e
Update app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
2 years ago
Don Turner
14b60b3a59
Merge branch 'main' into dependabot/gradle/org.jetbrains.kotlinx-kotlinx-serialization-json-1.6.3
2 years ago
Don Turner
8a3c34994d
Merge pull request #1239 from Jaehwa-Noh/java-to-kotlin
...
Move java to kotlin folder.
2 years ago
Don Turner
747c9275bc
Merge pull request #1249 from android/dt/fix-1231
...
Remove unused release variable. Fixes #1231
2 years ago
Don Turner
77cbdb62a4
Remove unused release variable. Fixes #1231
...
Change-Id: I8c03d3d2e1aee85a22d1a03b97e3bec4069e0fcb
2 years ago
Alex Vanyo
e3c7018124
Extract ScreenshotHelper to separate testing module
...
Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af
2 years ago
Don Turner
d768c796d4
Merge pull request #1244 from android/dependabot/gradle/hilt-2.51
...
Bump hilt from 2.50 to 2.51
2 years ago
Jaehwa Noh
1ca0085423
Merge branch 'android:main' into java-to-kotlin
2 years ago
Tomáš Mlynarič
f31fdb3ec2
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Id49a580012629163ec4a3663d95ab71b98910220
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
# gradle/libs.versions.toml
2 years ago
dependabot[bot]
b2b9f12915
🤖 Updates baselines for Dependency Guard
2 years ago
Jaehwa Noh
9b488bf70a
Move java to kotlin folder.
...
Change-Id: Iaf4723dea6169fbf3f9a8d3bf8779179ac56ab86
2 years ago
dturner
43b2240bdd
🤖 Updates screenshots
2 years ago
Don Turner
73d0b70f21
Workaround for new ForcedSize behaviour, bump ui-test version
...
Change-Id: Ibf93c1b65250e6527e34bc90602c1b1001b2df46
2 years ago
Don Turner
fa811ab85f
Bump to ui-test:1.7.0-alpha03, add parameter name
...
Change-Id: Ib1bbe4ad0d823c632d387587aa55c5eeb39e4b8d
2 years ago
dturner
50d5583fe1
🤖 Updates screenshots
2 years ago
Don Turner
d6357be8c4
Replace Accompanist TestHarness with DeviceConfigurationOverride
...
Change-Id: I6742d5e221f86a019f44d3e623609bf76d2a3a2a
2 years ago
dturner
27fd4e544a
🤖 Updates screenshots
2 years ago
dturner
02d4fea615
🤖 Updates screenshots
2 years ago
Don Turner
a507ff6d8e
Wrap NiaApp with NiaTheme for app screenshot tests
...
Change-Id: I8e298da139b19721b90ae778e7ab184f600d0bd7
2 years ago
Tomáš Mlynarič
75a3295381
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt
2 years ago
dturner
6b2b01ed82
🤖 Updates screenshots
2 years ago
dturner
076a2af757
🤖 Updates baselines for Dependency Guard
2 years ago
dturner
08d8f1393a
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
0c0adddf42
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
6add4d68e3
Bump protobuf from 3.24.4 to 3.25.2 ( #1214 )
...
* Bump protobuf from 3.24.4 to 3.25.2
Bumps `protobuf` from 3.24.4 to 3.25.2.
Updates `com.google.protobuf:protobuf-kotlin-lite` from 3.24.4 to 3.25.2
Updates `com.google.protobuf:protoc` from 3.24.4 to 3.25.2
- [Release notes](https://github.com/protocolbuffers/protobuf/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl )
- [Commits](https://github.com/protocolbuffers/protobuf/compare/v3.24.4...v3.25.2 )
---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-kotlin-lite
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.protobuf:protoc
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* 🤖 Updates baselines for Dependency Guard
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
2 years ago
Ben Weiss
f64f1c0aa2
Remove legacy benchmark build type ( #1207 )
...
* Remove legacy benchmark build type
Now that we have the baseline profile gradle plugin,
there is no need for a benchmark build type.
The plugin does the setup and configuration and runs against the
correct app flavor.
* Remove explicit benchmark build type from benchmark module
* Remove stale build task exclusions
* Fix tracing import location
FYI @mlykotom
2 years ago
Tomáš Mlynarič
58483b6166
Revert fast initialization of Coil
...
As discussed in https://github.com/coil-kt/coil/issues/2097 the problem is caused by regitering system services, which will be fixed in 2.6.0
Change-Id: I9085309780508137f10b25ff82deed3c62e5d159
2 years ago
Tomáš Mlynarič
f3e89bad4a
Add braces
...
Change-Id: I859babab7278137a4a2e49e5a085c65632888dd0
2 years ago
Tomáš Mlynarič
d1211f15e7
Inline initialization
...
Change-Id: I0a77eb6457cac27c1a4d604c8efdcbbdce95bc48
2 years ago
Tomáš Mlynarič
e853748cf7
Don't use runBlocking if async init completed
...
Change-Id: I641187ce277f434c6fca49a11b3cfccd50ecf5da
2 years ago
Tomáš Mlynarič
7c33946ce1
Launch loader directly without additional coroutine scope
...
Change-Id: Icbbdbcbcac1a6275857ebe998509f1e09109db7a
2 years ago
Tomáš Mlynarič
8e3903e90c
Fix comment
...
Co-authored-by: Yuri Schimke <yuri@schimke.ee>
2 years ago
Tomáš Mlynarič
5f0612102d
Improve lazy loading for Coil + OkHttp
...
This way, we can load Coil's backend on a background thread and not block the MainThread with it.
Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames.
Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62
2 years ago
Tomáš Mlynarič
12a3a6edde
Use trySend multiple times
...
Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032
2 years ago
Tomáš Mlynarič
08bfc54832
Update dependency guard baseline
...
Change-Id: I2557753f1eb4c6845aca6473a6aba5b7e758ebbf
2 years ago
Tomáš Mlynarič
f8e797fd26
Rename currentTimezone variable
...
Change-Id: I92630f6851b0253294a8d3ec2e5b3cbe7db74b4d
2 years ago
Tomáš Mlynarič
98e9e80639
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Ie83fb57676934ca3bdda59a986eb1a01a7c97424
2 years ago
Tomáš Mlynarič
ea1573fcc1
Use kotlinx.datetime.Timezone instead of java ZoneId
...
Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628
2 years ago
Jonathan Koren
c1d6c88bb0
Run dependencyGuard task during CI ( #1064 )
...
* Run dependencyGuard task during CI
Run the `dependencyGuard` task during CI, which will fail if there are
detected changes.
Change-Id: If5f2b18a4c765bd38a3353df2adaaa91cf1739c3
* Add actions to update dependency guard baselines
* Update baselines
* Better glob for update baselines action
2 years ago
Tomáš Mlynarič
44ae059a2b
Rename LocalTimeZone -> LocalZoneId + collects with lifecycle
...
Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3
2 years ago
Tomáš Mlynarič
cb00d2c8cb
Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers
...
This way, we can save ~1ms per composed item on screen.
Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d
2 years ago
Tomáš Mlynarič
395b9853df
Add Composition Tracing
...
Change-Id: I3ad60930de2fab71a700a0c2df3f0a1f566cafd8
2 years ago
Don Turner
f5b3ae56dc
Merge pull request #951 from SimonMarquis/issue-945
...
Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`
2 years ago
Don Turner
691bf2aad6
Merge pull request #785 from SimonMarquis/optimize-avd
...
Optimize AVD to fix long vector paths Lint warning
2 years ago
Simon Marquis
48fde2c3bf
Fix badging after merge
2 years ago
Simon Marquis
d9d9153eda
Merge branch 'main' into firebase-ktx
2 years ago
SimonMarquis
afdfd8acc5
🤖 Updates screenshots
2 years ago
Simon Marquis
377d3bef0c
Optimize AVD to fix long vector paths Lint warning
...
... with SVGOM, but you'll have to check on Android Studio the AVD diff.
https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html
2 years ago
Don Turner
707117a4f2
Merge branch 'main' into kotlinify
2 years ago
Don Turner
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
2 years ago
Don Turner
046831df36
Update dependency guard classpaths
...
Change-Id: I5f729bce92ec1cc9f71e34e42cbe38765966fc31
2 years ago
Simon Marquis
0699efc592
Merge branch 'main' into issue-945
2 years ago
Simon Marquis
be9dc533e3
Replace `Enum.values()` with `Enum.entries`
...
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
2 years ago
Don Turner
a5c030f740
Merge pull request #956 from KDW03/add_saved_test
...
Add Test for Saved Top Level Destination
2 years ago
Don Turner
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
2 years ago
Don Turner
9d41ffa318
Merge branch 'main' into kotlinify
2 years ago
Don Turner
ad15f0137e
Merge pull request #1094 from lihenggui/main
...
Upgrade Spotless and Ktlint and remove code convention violations
2 years ago
Don Turner
8d5ef578c6
Merge pull request #1103 from android/add_icon_comment
...
Add comment explaining why the launcher icon colors differ per build
2 years ago
Simon Marquis
b6d82e24df
Merge branch 'main' into kotlinify
2 years ago
Don Turner
b801a7deea
Moving comments to _after_ first XML element
...
Change-Id: Id4271a67ffcfbd712a2dd1f363970fcd31ee5ac0
2 years ago
lihenggui
2a2d8ed88d
Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE
2 years ago
Don Turner
d018e57f52
Fix spotless
...
Change-Id: I5dea4fec5b391e8cb7794af13e99978fcb622fbb
2 years ago
Don Turner
e6b5560f07
Revert "Move app screenshot tests to match dependencies declaration"
2 years ago
Don Turner
28bb3f1b2f
Add comment explaining why the launcher icon colors differ per build variant
...
Change-Id: I30126402370162ccbe53e177652583e4472f2030
2 years ago
Simon Marquis
83764082ff
Move app screenshot tests to match dependencies declaration
...
Fixes #990
2 years ago
lihenggui
32e1ec0447
Remove violations: property-naming
2 years ago
lihenggui
fb5bd225be
Spotless
2 years ago
Simon Marquis
2b739c0ffe
Fix badging, which is not "stable" when it comes to ordering
2 years ago
Simon Marquis
65a8b0d3b5
dependencyGuardBaseline
2 years ago
Simon Marquis
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
2 years ago
Simon Marquis
768738350b
Merge branch 'main' into firebase-ktx
2 years ago
Simon Marquis
32c3c3754d
updateProdReleaseBadging
...
See https://github.com/android/nowinandroid/pull/1006 for these new permissions and "Ad Services" property.
2 years ago
Jonathan Koren
392eaa3e61
Add dependencyGuard to AndroidApplicationConventionPlugin
...
Change-Id: Ib695ca18512d0ccde4c67e101f09ebbff8897912
2 years ago
Jonathan Koren
d15a203c59
Only record prodReleaseRuntimeClasspath configuration
...
Change-Id: I129fc4839ac2b4d5624c91cd25b47efba8847f44
2 years ago
Jonathan Koren
d5d5e3561f
Add dependency guard plugin
2 years ago
Simon Marquis
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
2 years ago
Simon Marquis
988002e692
Update Robolectric 4.11.1
...
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1
> Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below.
Removing explicit API 33 Robolectric configuration.
2 years ago
Miłosz Moczkowski
9c89e98e5b
Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold"
...
This reverts commit 335a7ec68c
, reversing
changes made to aa8ce0e1f6
.
2 years ago
mmoczkowski
f365e8b782
🤖 Updates screenshots
2 years ago
Miłosz Moczkowski
816a7b60c1
Replace manual navigation component switching with new NavigationSuiteScaffold
...
Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723
2 years ago
Ben Weiss
aa8ce0e1f6
Add automated baseline profile generation ( #880 )
...
Baseline profile generation is disabled for the PR level Build task. Release tasks require a fresh baseline profile. A new profile is generated using the baseline profile Gradle plugin.
* Prepare for usage of dex layout optimizations which can be actively used once NiA switches to AGP 8.2+.
* Add GMD config to release build
* Switch to macos-latest
* Update names for StartupBenchmark tests to better reflect states
* Stable release and recent GMD device
* Reduce flakiness by adding wait to benchmark
* More convenient waiting for objects
* Rename junit dependency to androidx-junit
* Only run baseline profile benchmarks during GH workflow
* Enable automatic BP generation for only release builds
* Disable BP generation from Build workflow
* Specify modules and skip benchmarking Build workflow
Bug: b/299334172
2 years ago
Don Turner
f3b2655e2f
Merge pull request #933 from danysantiago/main
...
Update to Hilt 2.48 and use the KSP version
2 years ago
Daniel Santiago
c908f989c8
Update to Hilt 2.48.1 and use the KSP version
...
* Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin.
* `@Binds` function cannot be an extension function.
* Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.
2 years ago
Jose Alcérreca
3f22248cb7
[CI] Better caching and fewer jobs run
...
* [CI] Runs build in macos to generate a cache for androidTest runs
* Build projects before running emulator
* Fixes flaky coroutines test
* Moves spotless up in local tests job
* Enables config cache by setting problems to warn. Fixes #1022
2 years ago
rosariopf
221b615690
remove ACCESS_ADSERVICES permissions
2 years ago
Don Turner
09304e2477
Add updated badging for prodRelease variant
...
Change-Id: Ibe71c285708ffec85520a0c7852600f361ed1646
2 years ago
Alex Vanyo
360b33eb82
Add automatic checks for badging
...
Change-Id: Ic8fca86d7aa84675fa91fb1aa99abcc6e19d663e
2 years ago
TM
d3d5b02428
Inline color values for app icons
2 years ago
TM
9b83237bfd
Removed Comments
2 years ago
TM
afb427b9c5
Use colors from design palette in build variant icons
2 years ago
TM
38d0c15d33
Create different icons for each build variant
...
Added color values for DEBUG and BENCHMARK build variants.
2 years ago
Jose Alcérreca
431069ab77
NiaAppScreenSizesScreenshotTests.kt: Fixes screenshot test showing wrong width ( #986 )
...
* FIxes screenshot test
* 🤖 Updates screenshots
2 years ago
Adetunji Dahunsi
0287af8d9a
Merge pull request #947 from android/tj/staggered-grid-feed
...
Use lazy vertical staggered grid in feed to maximize space utilization
2 years ago
Don Turner
a381d13199
Merge pull request #958 from McGalanes/main
...
Use typesafe project accessors
2 years ago
Melwin Magalhaes
6247712064
Add convention plugins to version catalogs
2 years ago
Melwin Magalhaes
b1266dc05a
Use typesafe project accessors for project modules
2 years ago
tunjid
b2498c763f
🤖 Updates screenshots
2 years ago
Simon Marquis
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
2 years ago
Simon Marquis
faf42aa133
Merge remote-tracking branch 'origin/main' into issue-945
2 years ago
kimdowoo
bc56ba79bc
Add Test for Saved Top Level Destination
2 years ago
Don Turner
e40fb7925d
Merge pull request #779 from SimonMarquis/java-to-kotlin-sourceset
...
Migrate from `java` to `kotlin` sourceSet directory
2 years ago
Simon Marquis
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
2 years ago
Simon Marquis
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
2 years ago
Simon Marquis
49a2fb5272
Fix wrong configuration name, leaking `work-testing` to runtime classpath
...
Typo introduced recently when Roborazzi was added to the project:
886158d3cb (diff-8cff73265af19c059547b76aca8882cbaa3209291406f52df1dafbbc78e80c46)
2 years ago
Simon Marquis
03ba943632
Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`
...
- Prevent logging multiple times (because of `onResume()` callback)
- Remove unnecessary io dispatcher: `ListenableFuture<T>.await()` is already main-safe and prevent acquiring io slot.
- Merge comments into a single javadoc comment on the `ProfileVerifierLogger` type.
- Add proper javadoc format with markdown specific blocks.
- Update logs & tag to be more uniform.
Closes #945
2 years ago
Jose Alcérreca
151f877bbe
Adds screenshot tests to :core:designsystem ( #931 )
...
* WIP: Adds screenshot tests to :core:designsystem
Change-Id: I0672845feba4064652dd8d60f07047b87864e121
* 🤖 Updates screenshots
* Creates tests for more components and cleans up
Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22
* WIP: More cleanup and more combinations of themes
Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523
* Added the rest of the screenshot tests for designsystem
Change-Id: Ic427db5491910781c038882055524e3f3dbed194
* Some more cleanup
Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180
* Spotless
Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6
* 🤖 Updates screenshots
* ScreenshotHelper cleanup
Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0
2 years ago
Milosz Moczkowski
851ca6388e
Merge pull request #868 from SimonMarquis/patch-4
...
Handle topic clicks from all destinations
2 years ago
Jose Alcérreca
886158d3cb
Adds Screenshot testing with Roborazzi ( #876 )
...
* Adds screenshot tests using Roborazzi (Robolectric Native Graphics)
- Adds Roborazzi to convention plugins
- Adds Screenshot helper in :core-testing
- Creates screenshot suites for :app and :feature-foryou
* CI and spotless
* Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier
* CI: Moves local tests to their own step
* CI: Adds --rerun to screenshot task
* CI: Moves screenshots before local tests
* CI: Fixes wrong if statement in workflow
* CI WIP: trying to trigger the push step
* CI: Re-enables roborazzi verification
* Fixes flaky screenshot tests by setting LocalInspectionMode on
* CI: screenshot commits now use the original author intead of bot account
* CI: Disables globbing because file_pattern didn't work
* CI: Trying new file pattern for png files
* CI: Adds a check for forks
* 🤖 Updates screenshots
* Code review: toml cleanup, comments
* Use new github.event.pull_request.head.repo.fork
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
* Uses Robolectric qualifiers to set the dpi, adds section to README
* Spotless
* Delegates creation of repository to Hilt in test
* Revert "Use new github.event.pull_request.head.repo.fork"
* 🤖 Updates screenshots
* Empty commit to trigger GHA on main branch
* Makes time zones deterministic in screenshot tests
* Increases GMD timeout to 90m, but it has to be reduced
---------
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
2 years ago
Don Turner
e96e54f7de
Merge pull request #806 from SimonMarquis/objenesis
...
Remove forced resolution strategy
2 years ago
Simon Marquis
b7799f0475
Convert 'sealed' sub-object to 'data object'
2 years ago
Alex Vanyo
a3ee09ec3e
Merge pull request #817 from android/av/enable-edge-to-edge
...
Switch to new Activity.enableEdgeToEdge
2 years ago
Simon Marquis
d8a6d0de13
Replace NiaNetworkDataSource with TopicsRepository
...
to be closer to the actual source of data used by the instrumented app.
2 years ago
Simon Marquis
57f3700980
Select last topic by name instead of a random one
2 years ago
Simon Marquis
64f81751b3
Handle topic clicks from all destinations
...
Closes #865
2 years ago
Alex Vanyo
2b218b97d9
Switch to new Activity.enableEdgeToEdge
...
Change-Id: I9bbb7b2d116099524525619714ef18448e707c4f
2 years ago
Simon Marquis
0a1f333fc6
Update NavigationTest.kt
2 years ago
Simon Marquis
bf5fdb4cf8
Update NavigationTest.kt
2 years ago
Simon Marquis
250850cf9b
Remove hardcoded topic names in `NavigationTest.kt`
2 years ago
Don Turner
654944430d
Fix for Retrofit R8 issue, bump version to 0.1.2
...
Change-Id: Ia90d693731c95248211b12b1ce2e9dfab0ecf34c
2 years ago
Márton Braun
56389cb760
Merge pull request #752 from SimonMarquis/kotlin-1.9.0
...
Kotlin 1.9.0
2 years ago
Simon Marquis
ba82b06cc3
Fix Lint `RememberReturnType` issue with explicit type
2 years ago
Don Turner
7f62b725a6
Bump version to code=7, name=0.1.1
...
Change-Id: I2d8fa940dc5e4c14e3c9df650bc1f1432a330f02
2 years ago
Automerger
49a3f47fd8
Merge branch 'github/main'
2 years ago
Automerger
44c3c6d947
Merge branch 'github/main'
2 years ago
Milosz Moczkowski
04d3da39b9
Merge pull request #809 from SimonMarquis/launcher-icon-dark-theme
...
Extract launcher icon tints and provide `-night` alternatives
2 years ago
Murat Yener
e96dac39b2
changed from ListenableFuture.get() to ListenableFuture.await()
2 years ago
Murat Yener
78ed9adca2
spotless fix
2 years ago
Murat Yener
7b5c0f2be8
Adds ProfileViewer to log the app's Baseline Profile Compilation Status
2 years ago
Simon Marquis
cf64e25ad5
Extract launcher icon tints and provide `-night` alternatives
...
Implements #805
2 years ago
Simon Marquis
0a3069a0d8
Remove forced junit resolution strategy
...
By looking at the Gradle scan's dependency tab, junit 4.12 is already replaced by 4.13.2.
There is no need to manually force this at the configuration level.
2 years ago
Simon Marquis
d332f7b70d
Remove forced objenesis resolution strategy
...
The linked issue is marked as resolved, and not able to reproduce the mentioned compilation error.
2 years ago
Automerger
8b024f0911
Merge branch 'github/main'
2 years ago
Simon Marquis
cb84082ae7
Merge branch 'main' into patch/proguard
2 years ago
Automerger
b434112bf2
Merge branch 'github/main'
2 years ago
James Rose
7826b4f5f2
Merge pull request #748 from SimonMarquis/fix/permissions
...
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
2 years ago
Automerger
1c2a833e6c
Merge branch 'github/main'
2 years ago
Miłosz Moczkowski
7b30720b25
Remove nested scaffold from the bookmarks screen
...
Change-Id: Ie8b6f160d341156a6f9c02c0ca7f530095fb2950
2 years ago
Automerger
a91ba16a9c
Merge branch 'github/main'
2 years ago
Miłosz Moczkowski
479a2f00b0
Refactor icons
2 years ago
Automerger
9241b06e9f
Merge branch 'github/main'
2 years ago
Miłosz Moczkowski
ded8b109b9
Refactor custom notificationDot modifier
...
Change-Id: Ife24492a495b111f111a8bd16f21b7ebd469e5aa
2 years ago
Simon Marquis
8f41a6b3ab
Cleanup proguard configuration
...
- Remove custom KotlinX Serialization config as it's already provided, see https://github.com/Kotlin/kotlinx.serialization#android .
- Delete empty config files.
2 years ago
Simon Marquis
823c4db201
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
...
Continues the work initiated in #738 .
Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.
2 years ago
Automerger
0c2e01bf4e
Merge branch 'github/main'
2 years ago
Miłosz Moczkowski
fc3d0ced20
Replace hardcoded license file with OSS licenses plugin
...
Change-Id: I4427fd5d7b7abd8a2912a41f61ffedfac4af9d6a
2 years ago
Automerger
4eaad4c0a6
Merge branch 'github/main'
2 years ago
James Rose
a68eedebfa
Merge pull request #713 from android/jr/settings-dialog-state
...
Save the showSettingsDialog flag in instance state
2 years ago
James Rose
62a77321d3
Save the showSettingsDialog flag in instance state
...
This prevents the settings dialog from being dismissed when the device
is rotated.
2 years ago
Don Turner
0829cb73f7
Bump version name to 0.1.0 (versionCode 6)
...
Change-Id: I880683a37b4324f91499eeb47b418ab5e2d1242b
2 years ago
TJ Dahunsi
ef97cb941c
Route notification deep link through for you screen
2 years ago
Milosz Moczkowski
553f55f978
Merge pull request #679 from SimonMarquis/patch-3
...
Simplify String resource loading in `NavigationTest.kt`
2 years ago
Simon Marquis
1341f7c2c5
Replace unused variable with simpler method calls
2 years ago